NERS file.
Reported-by: Joe Perches
Signed-off-by: Marek Szyprowski
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 29c08106bd22..4455fe05d3a3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15720,7 +15720,7 @@ M:
-mfc 1100.codec: Direct firmware load for s5p-mfc-v6-v2.fw failed with
error -2
s5p-mfc 1100.codec: Direct firmware load for s5p-mfc-v6.fw failed with
error -2
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 2 +-
struct clk_bulk_data *clks)
+{
+}
+
static inline struct clk *clk_get(struct device *dev, const char *id)
{
return NULL;
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
.co.jp>
Reviewed-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
Chanegs in v2:
- Fix to pass size + offset instead of changing address.
---
drivers/media/v4l2-core/videobuf2-vmalloc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-
;vaddr = vm_map_ram(frame_vector_pages(vec), n_pages, -1,
PAGE_KERNEL);
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Hi Hans,
On 2017-12-15 16:57, Hans Verkuil wrote:
On 14/12/17 15:11, Marek Szyprowski wrote:
I would like to get your opinion on this patch. Do you think it makes sense to:
1. add limited support for USERPTR and DMA-buf import? (limited means driver
will accept setting buffer pointer/fd only
userspace to discover if device support
queue buffer reconfiguration on-fly or not?
Here is the discussion: https://patchwork.linuxtv.org/patch/45305/
Best regards
Marek Szyprowski, PhD
Samsung R Institute Poland
On 2017-11-06 20:21, Nicolas Dufresne wrote:
Le lundi 06 novembre 2017 à 10:28 +0100
-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/v4l2-core/videobuf2-core.c | 56
drivers/media/v4l2-core/videobuf2-v4l2.c | 10 +++---
2 files changed, 33 insertions(+),
Hi Nicolas,
On 2017-11-03 14:45, Nicolas Dufresne wrote:
Le vendredi 03 novembre 2017 à 09:11 +0100, Marek Szyprowski a écrit :
MFC driver supports only MMAP operation mode mainly due to the hardware
restrictions of the addresses of the DMA buffers (MFC v5 hardware can
access buffers only
com>
[mszyprow: adapted to v4.14 code base, rewrote and extended commit message,
added checks for changing buffer addresses, added bidirectional queue
flags and comments]
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
v2:
- fixed copy/paste bug, which broke encoding sup
MMU fault can be mitigated by
enabling
bidirectional flag on OUTPUT queue. This is a bit strange, but that's
how the
hardware behaves. From my research it looks that it happens only in case
of MFCv5,
higher versions don't modify source stream.
Best regards
--
Marek Szyprowski, PhD
Samsung R Instit
ps for now
to match other mem2mem drivers.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/exynos4-is/fimc-m2m.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/media/platform/exynos4-is/fimc-m2m.c
b/drivers/media/
ps for now
to match other mem2mem drivers.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c
b/drivers/media/platform/exyn
t;
[mszyprow: adapted to v4.14 code base and updated commit message]
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 14 --
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 73
drivers/media/platform/s5p-mfc/
GSC updates (almost up to date
with 4.14 I think) there was no "Wrong buffer/video queue type (1)"
message either
I will check it and let you know if this is something we should worry about.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
to add the information about the reference commit to
each
commit message and also point to commit
e752577ed7bf55c81e10343fced8b378cda2b63b,
as it is exactly the same case here. Anyway:
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
I wonder if makes sense to send those patches also
.
Suggested-by: Marek Szyprowski <m.szyprow...@samsung.com>
Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org>
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 6 --
drivers/media/v4l2-core/videobuf
Support for Exynos4212 SoCs has been removed by commit bca9085e0ae9 ("ARM:
dts: exynos: remove Exynos4212 support (dead code)"), so there is no need
to keep remaining dead code related to this SoC version.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
driver
che...@s-opensource.com>
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
include/media/videobuf2-core.h | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-
(and probably other drivers
in the future) which wants to map output type of buffers as
read/write.
Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org>
Thanks for the patch.
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
While touching this, I would love to unify set_pag
struct vb2_buffer *bufs[VB2_MAX_FRAME];
unsigned intnum_buffers;
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Hi Christoph,
On 2017-07-05 19:33, Christoph Hellwig wrote:
On Mon, Jul 03, 2017 at 11:27:32AM +0200, Marek Szyprowski wrote:
The main question here if we want to merge incomplete solution or not. As
for now, there is no support in ARM/ARM64 for NON_CONSISTENT attribute.
Also none of the v4l2
-by: Arvind Yadav <arvind.yadav...@gmail.com>
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/v4l2-core/videobuf2-dma-sg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c
b/drivers/media/v4l2-core/videob
-by: Arvind Yadav <arvind.yadav...@gmail.com>
Thanks!
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c
b/driver
-by: Arvind Yadav <arvind.yadav...@gmail.com>
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/v4l2-core/videobuf2-vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-vmalloc.c
b/drivers/media/v4l2-co
):
[media] videobuf2-dc: Move vb2_dc_get_base_sgt() above mmap callbacks
drivers/media/v4l2-core/videobuf2-dma-contig.c | 60 --
1 file changed, 38 insertions(+), 22 deletions(-)
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
too and add DT bindings file pattern match. Also change the mailing
list from ARM generic to Samsung SoC specific to get more attention and
easier review in the future.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Acked-by: Krzysztof Kozlowski <k...@kernel.org>
---
v2
too. Also change the mailing list from ARM generic to Samsung SoC
specific to get more attention and easier review in the future.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAI
Hi All,
I'm sorry for the late reply, I just got back from holidays.
On 2017-06-02 23:43, Jacek Anaszewski wrote:
Cc Marek Szyprowski.
Marek, could you share your opinion about this patch?
On 06/02/2017 06:02 PM, Thierry Escande wrote:
From: Tony K Nadackal <tony...@samsung.com>
This
Hi Krzysztof,
On 2017-05-31 21:55, Krzysztof Kozlowski wrote:
On Wed, May 31, 2017 at 01:00:17PM +0200, Marek Szyprowski wrote:
Exynos5250 and Exynos542x SoCs have the same CEC hardware module as
Exynos4 SoC series, so enable support for it using the same compatible
string.
Tested on Odroid
--
drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++---
drivers/media/v4l2-core/v4l2-subdev.c | 7 ---
drivers/media/v4l2-core/videobuf2-dma-sg.c | 8
For vb2:
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
There are also a few vmalloc calls in old videobuf (v1
Hi Hans,
On 2017-05-31 13:17, Hans Verkuil wrote:
On 05/31/17 13:00, Marek Szyprowski wrote:
Exynos5250 and Exynos542x SoCs have the same CEC hardware module as
Exynos4 SoC series, so enable support for it using the same compatible
string.
Tested on Odroid XU3 (Exynos5422) and Google Snow
os4.
I've just posted a patch enabling CEC module on Exynos5250 (Google Snow)
and Exynos5422 (Odroid XU3).
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Exynos5250 and Exynos542x SoCs have the same CEC hardware module as
Exynos4 SoC series, so enable support for it using the same compatible
string.
Tested on Odroid XU3 (Exynos5422) and Google Snow (Exynos5250) boards.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
arch/ar
us 이(가) 쓴 글:
Hi Marek,
On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote:
Hi Laurent,
On 2017-04-20 12:25, Laurent Pinchart wrote:
Hi Marek,
(CC'ing Sakari Ailus)
Thank you for the patches.
On Thursday 20 Apr 2017 11:13:36 Marek Szyprowski wrote:
Dear all,
This is an u
Hi Tobias and Nicolas,
On 2017-04-26 17:16, Tobias Jakobi wrote:
Nicolas Dufresne wrote:
Le mercredi 26 avril 2017 à 01:21 +0300, Sakari Ailus a écrit :
Hi Marek,
On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote:
Hi Laurent,
On 2017-04-20 12:25, Laurent Pinchart wrote:
Hi
Hi Sakari,
On 2017-04-26 00:21, Sakari Ailus wrote:
Hi Marek,
On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote:
Hi Laurent,
On 2017-04-20 12:25, Laurent Pinchart wrote:
Hi Marek,
(CC'ing Sakari Ailus)
Thank you for the patches.
On Thursday 20 Apr 2017 11:13:36 Marek
Can we have an ack for the v4l side for that pls?
For the V4L2/videobuf2:
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
Thanks, Daniel
---
Changes since v1:
- Added the missing tegra driver (noticed by kbuild robot)
- Rebased off of drm-intel-next to get the i915 selftest
Hi Shuah,
On 2017-04-11 00:50, Shuah Khan wrote:
On 04/06/2017 06:01 AM, Marek Szyprowski wrote:
On 2017-04-05 18:02, Shuah Khan wrote:
When coherent DMA memory without struct page is shared, importer
fails to find the page and runs into kernel page fault when it
tries to dmabuf_ops_attach
+
5 files changed, 69 insertions(+), 5 deletions(-)
> [...]
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
- driver will use generic allocator for them instead of the
pre-allocated buffer for firmware and contexts.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
This patch should solve failure of h264 encoding due to insufficient memory
for codec temporary buffers. Please consider it a
patchset) fixes the
issue.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
From: Marek Szyprowski <m.szyprow...@samsung.com>
Date: Wed, 22 Mar 2017 10:59:26 +0100
Subject: [PATCH] media: s5p-mfc: Don't allocate codec buffers from
pre-allocated region
Further investig
target. Could you provide
more details of your setup:
- which kernel and patches,
- which hw,
- which test app.
Regards
Andrzej
Thanks,
Marian
Either I've been missing something or nothing has been going on. (K. E. Gordon)
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Clock should be turned off after calling s5p_mfc_init_hw() from the
watchdog worker, like it is already done in the s5p_mfc_open() which also
calls this function.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Fixes: af93574678108 ("[media] MFC: Add MFC 5.1 V4L2 drive
Internal MFC driver device structure contains two pointers to devices used
for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the
mem_dev[] array and use defines for accessing particular banks. This will
help to simplify code in the next patches.
Signed-off-by: Marek Szyprowski
Remove unused structures, definitions and functions that are no longer
called from the driver code.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Martinez Canillas <jav...@osg.sam
code provides and if the DMA base address equals zero, skip
first 128 KiB to keep required alignment. This patch also make the driver
operational on ARM64 architecture, because it no longer depends on ARM
specific DMA-mapping and IOMMU glue code functions.
Signed-off-by: Marek Szyprowski <m.szyp
did a bit of cleanup while touching the driver.
Best regards
Marek Szyprowski
Samsung R Institute Poland
Changelog:
v3:
- collected tags
- added a patch, which renames BANK1/2 to BANK_L/R to match documentation
- rebased onto v4.11-rc3
v2:
- fixed issues pointed by Javier Martinez Canillas: code co
Change parameters for s5p_mfc_alloc_priv_buf() and s5p_mfc_release_priv_buf()
functions. Instead of DMA device pointer and a base, provide common MFC
device structure and memory bank context identifier.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Ma
Use s5p_mfc_priv_buf structure for keeping the firmware image. This will
help handling of firmware buffer allocation in the next patches.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Marti
Once firmware buffer has been converted to use s5p_mfc_priv_buf structure,
it is possible to allocate it with existing s5p_mfc_alloc_priv_buf()
function. This change will help to reduce code variants in the next
patches.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Re
() to
keep DMA memory related operations in a single place. This way
s5p_mfc_alloc_firmware() is simplified and does what it name says. The
other consequence of this change is moving s5p_mfc_alloc_firmware() call
from the s5p_mfc_probe() function to the s5p_mfc_configure_dma_memory().
Signed-off-by: Marek
Firmware for MFC v6+ variants is not larger than 400 KiB, so there is no
need to allocate a full 1 MiB buffer for it. Reduce it to 512 KiB to keep
proper alignment of allocated buffer.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canilla
Internal MFC driver device structure contains two entries for keeping
addresses of the DMA memory banks. Replace them with the dma_base[] array
and use defines for accessing particular banks. This will help to simplify
code in the next patches.
Signed-off-by: Marek Szyprowski <m.szyp
Setting DMA max segment size to 32 bit mask is a part of DMA memory
configuration, so move those calls to s5p_mfc_configure_dma_memory()
function.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Jav
functional even without the reserved memory blocks for all
v6+ variants. This patch removes those reserved memory nodes from all
boards having MFC v6+ hardware block.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.co
Replace custom code with generic helper to retrieve driver data.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Acked-by: Andrzej Hajda &l
decoders or encoders (other codecs have smaller memory requirements).
If one needs more for particular use case, one can use "mem" module
parameter to force larger (or smaller) buffer (for example by adding
"s5p_mfc.mem=16M" to kernel command line).
Signed-off-by: Marek S
Move code for DMA memory configuration with IOMMU into separate function
to make it easier to compare what is being done in each case.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Martinez C
Documentation for MFC hardware still uses 'left' and 'right' names for
the memory channel/banks, so replace BANK1/2 defines with more appropriate
BANK_L/R names.
Suggested-by: Shuah Khan <shuahk...@gmail.com>
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/me
Memory Allocator) is enabled is 4MiB.
This patch also removes the requirement to provide two reserved memory
regions for MFC v6+ devices in device tree. Now the driver is fully
functional without them.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canilla
Hi Shuah,
On 2017-02-24 15:23, Shuah Khan wrote:
On Thu, Feb 23, 2017 at 11:26 PM, Marek Szyprowski
<m.szyprow...@samsung.com> wrote:
On 2017-02-23 22:43, Shuah Khan wrote:
On Tue, Feb 14, 2017 at 12:52 AM, Marek Szyprowski
<m.szyprow...@samsung.com> wrote:
It turned out that
Hi Shuah
On 2017-02-23 22:43, Shuah Khan wrote:
On Tue, Feb 14, 2017 at 12:52 AM, Marek Szyprowski
<m.szyprow...@samsung.com> wrote:
It turned out that all versions of MFC v6+ hardware doesn't have a strict
requirement for ALL buffers to be allocated on higher addresses than the
firmwar
[] (ret_from_fork+0x14/0x3c)
---[ end trace 1ead49a7bb83f0d8 ]---
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Fixes: af93574678108 ("[media] MFC: Add MFC 5.1 V4L2 driver")
CC: sta...@vger.kernel.org # v4.5+
---
This issue was there from the beggining of the driver, but th
Hi Shuah,
On 2017-02-22 19:07, Shuah Khan wrote:
On Mon, Feb 20, 2017 at 6:38 AM, Marek Szyprowski
<m.szyprow...@samsung.com> wrote:
To complete DMA memory configuration for MFC device, allocation of the
firmware buffer is needed, because some parameters are dependant on its base
a
Dear All,
On 2017-02-21 15:37, Marek Szyprowski wrote:
Hi Christian,
On 2017-02-21 14:59, Christian König wrote:
Am 21.02.2017 um 14:21 schrieb Marek Szyprowski:
Add compat ioctl support to dma-buf. This lets one to use
DMA_BUF_IOCTL_SYNC
ioctl from 32bit application on 64bit kernel. Data
Hi Christian,
On 2017-02-21 14:59, Christian König wrote:
Am 21.02.2017 um 14:21 schrieb Marek Szyprowski:
Add compat ioctl support to dma-buf. This lets one to use
DMA_BUF_IOCTL_SYNC
ioctl from 32bit application on 64bit kernel. Data structures for
both 32
and 64bit modes are same, so
Add compat ioctl support to dma-buf. This lets one to use DMA_BUF_IOCTL_SYNC
ioctl from 32bit application on 64bit kernel. Data structures for both 32
and 64bit modes are same, so there is no need for additional translation
layer.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.
Setting DMA max segment size to 32 bit mask is a part of DMA memory
configuration, so move those calls to s5p_mfc_configure_dma_memory()
function.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Jav
Internal MFC driver device structure contains two pointers to devices used
for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the
mem_dev[] array and use defines for accessing particular banks. This will
help to simplify code in the next patches.
Signed-off-by: Marek Szyprowski
Replace custom code with generic helper to retrieve driver data.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform
Firmware for MFC v6+ variants is not larger than 400 KiB, so there is no
need to allocate a full 1 MiB buffer for it. Reduce it to 512 KiB to keep
proper alignment of allocated buffer.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canilla
Use s5p_mfc_priv_buf structure for keeping the firmware image. This will
help handling of firmware buffer allocation in the next patches.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Marti
code provides and if the DMA base address equals zero, skip
first 128 KiB to keep required alignment. This patch also make the driver
operational on ARM64 architecture, because it no longer depends on ARM
specific DMA-mapping and IOMMU glue code functions.
Signed-off-by: Marek Szyprowski <m.szyp
Move code for DMA memory configuration with IOMMU into separate function
to make it easier to compare what is being done in each case.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Martinez C
() to
keep DMA memory related operations in a single place. This way
s5p_mfc_alloc_firmware() is simplified and does what it name says. The
other consequence of this change is moving s5p_mfc_alloc_firmware() call
from the s5p_mfc_probe() function to the s5p_mfc_configure_dma_memory().
Signed-off-by: Marek
Memory Allocator) is enabled is 4MiB.
This patch also removes the requirement to provide two reserved memory
regions for MFC v6+ devices in device tree. Now the driver is fully
functional without them.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canilla
decoders or encoders (other codecs have smaller memory requirements).
If one needs more for particular use case, one can use "mem" module
parameter to force larger (or smaller) buffer (for example by adding
"s5p_mfc.mem=16M" to kernel command line).
Signed-off-by: Marek S
functional even without the reserved memory blocks for all
v6+ variants. This patch removes those reserved memory nodes from all
boards having MFC v6+ hardware block.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.co
Internal MFC driver device structure contains two entries for keeping
addresses of the DMA memory banks. Replace them with the dma_base[] array
and use defines for accessing particular banks. This will help to simplify
code in the next patches.
Signed-off-by: Marek Szyprowski <m.szyp
Change parameters for s5p_mfc_alloc_priv_buf() and s5p_mfc_release_priv_buf()
functions. Instead of DMA device pointer and a base, provide common MFC
device structure and memory bank context identifier.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Ma
Once firmware buffer has been converted to use s5p_mfc_priv_buf structure,
it is possible to allocate it with existing s5p_mfc_alloc_priv_buf()
function. This change will help to reduce code variants in the next
patches.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Re
198/
I've tried to split changes into small pieces to make it easier to review
the code. I've also did a bit of cleanup while touching the driver.
Best regards
Marek Szyprowski
Samsung R Institute Poland
Changelog:
v2:
- fixed issues pointed by Javier Martinez Canillas: code compiles now
afte
Remove unused structures, definitions and functions that are no longer
called from the driver code.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Martinez Canillas <jav...@osg.samsung.co
Hi Javier,
On 2017-02-17 22:13, Javier Martinez Canillas wrote:
On 02/14/2017 04:52 AM, Marek Szyprowski wrote:
It turned out that all versions of MFC v6+ hardware doesn't have a strict
requirement for ALL buffers to be allocated on higher addresses than the
firmware base like
functional even without the reserved memory blocks for all
v6+ variants. This patch removes those reserved memory nodes from all
boards having MFC v6+ hardware block.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
arch/arm/boot/dts/exynos5250-arndale.dts | 1 -
arch/ar
() to
keep DMA memory related operations in a single place. This way
s5p_mfc_alloc_firmware() is simplified and does what it name says. The
other consequence of this change is moving s5p_mfc_alloc_firmware() call
from the s5p_mfc_probe() function to the s5p_mfc_configure_dma_memory().
Signed-off-by: Marek
Change parameters for s5p_mfc_alloc_priv_buf() and s5p_mfc_release_priv_buf()
functions. Instead of DMA device pointer and a base, provide common MFC
device structure and memory bank context identifier.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/s
Memory Allocator) is enabled is 4MiB.
This patch also removes the requirement to provide two reserved memory
regions for MFC v6+ devices in device tree. Now the driver is fully
functional without them.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
Documentation/devicetree/bi
Use s5p_mfc_priv_buf structure for keeping the firmware image. This will
help handling of firmware buffer allocation in the next patches.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_cmd_v5.c | 2 +-
drivers/media/platform/s
Setting DMA max segment size to 32 bit mask is a part of DMA memory
configuration, so move those calls to s5p_mfc_configure_dma_memory()
function.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 21 +
1 file c
Replace custom code with generic helper to retrieve driver data.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c| 17 ++---
drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 4 ++--
2 files changed, 4 insertions(
decoders or encoders (other codecs have smaller memory requirements).
If one needs more for particular use case, one can use "mem" module
parameter to force larger (or smaller) buffer (for example by adding
"s5p_mfc.mem=16M" to kernel command line).
Signed-off-by: Marek S
Internal MFC driver device structure contains two entries for keeping
addresses of the DMA memory banks. Replace them with the dma_base[] array
and use defines for accessing particular banks. This will help to simplify
code in the next patches.
Signed-off-by: Marek Szyprowski <m.szyp
Once firmware buffer has been converted to use s5p_mfc_priv_buf structure,
it is possible to allocate it with existing s5p_mfc_alloc_priv_buf()
function. This change will help to reduce code variants in the next
patches.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
d
code provides and if the DMA base address equals zero, skip
first 128 KiB to keep required alignment. This patch also make the driver
operational on ARM64 architecture, because it no longer depends on ARM
specific DMA-mapping and IOMMU glue code functions.
Signed-off-by: Marek Szyprowski <m.szyp
Remove unused structures, definitions and functions that are no longer
called from the driver code.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c| 21 -
drivers/media/platform/s5p-mfc/s5p_mfc_common.
Move code for DMA memory configuration with IOMMU into separate function
to make it easier to compare what is being done in each case.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 102 ++-
1 file chang
Firmware for MFC v6+ variants is not larger than 400 KiB, so there is no
need to allocate a full 1 MiB buffer for it. Reduce it to 512 KiB to keep
proper alignment of allocated buffer.
Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
---
drivers/media/platform/s5p-mfc/regs-mfc-v6
Internal MFC driver device structure contains two pointers to devices used
for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the
mem_dev[] array and use defines for accessing particular banks. This will
help to simplify code in the next patches.
Signed-off-by: Marek Szyprowski
1 - 100 of 930 matches
Mail list logo
