Re: [PATCH v2 2/3] media: dvb: represent min/max/step/tolerance freqs in Hz

Am 06.07.2018 um 00:59 schrieb Mauro Carvalho Chehab: Hi Mauro, I have one comment below. > Right now, satellite frontend drivers specify frequencies in kHz, > while terrestrial/cable ones specify in Hz. That's confusing > for developers. > > However, the main problem is that universal

Re: [PATCH] cx231xx: Increase USB bridge bandwidth

Am 02.04.2018 um 21:59 schrieb Brad Love: > The cx231xx USB bridge has issue streaming QAM256 DVB-C channels. > QAM64 channels were fine, but QAM256 channels produced corrupted > transport streams. > > cx231xx alt mode 4 does not provide enough bandwidth to acommodate > QAM256 DVB-C channels,

Re: [PATCH 2/9] cx231xx: Use board profile values for addresses

Am 17.04.2018 um 18:39 schrieb Brad Love: > Replace all usage of hard coded values with > the proper field from the board profile. > Hi Brad, will there be any interference with the usage to configure the analog tuner via the fields tuner_addr and tuner_type? Regards Matthias > Signed-off-by:

Re: [PATCH 5/9] cx231xx: Switch to using new dvb i2c helpers

Am 17.04.2018 um 18:39 schrieb Brad Love: > Mostly very straight forward replace of blocks with equivalent code. > > Cleanup added at end of dvb_init in case of failure. > Hi Brad, I have some suggestions. See below. Matthias > Signed-off-by: Brad Love > --- >

Re: [PATCH 1/3] media: si2165: Remove owner assignment from i2c_driver

y scripts/coccinelle/api/platform_no_drv_owner.cocci. > > Cc: Matthias Schwarzott <z...@gentoo.org> > Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> > --- > drivers/media/dvb-frontends/si2165.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/dvb-

Re: [PATCH 01/16] omap: omap-iommu.h: allow building drivers with COMPILE_TEST

Am 05.04.2018 um 19:54 schrieb Mauro Carvalho Chehab: > Drivers that depend on omap-iommu.h (currently, just omap3isp) > need a stub implementation in order to be built with COMPILE_TEST. > > Signed-off-by: Mauro Carvalho Chehab > --- > include/linux/omap-iommu.h | 5

Re: [PATCH 7/9] lgdt3306a: Set fe ops.release to NULL if probed

Am 05.01.2018 um 01:19 schrieb Michael Ira Krufky: > On Thu, Jan 4, 2018 at 7:04 PM, Brad Love wrote: >> If release is part of frontend ops then it is called in the >> course of dvb_frontend_detach. The process also decrements >> the module usage count. The problem is if

Re: [PATCH 2/2] lgdt3306a: Fix a double kfree on i2c device remove

Am 05.01.2018 um 15:57 schrieb Brad Love: > Both lgdt33606a_release and lgdt3306a_remove kfree state, but _release is > called first, then _remove operates on states members before kfree'ing it. > This can lead to random oops/GPF/etc on USB disconnect. > lgdt3306a_release does nothing but the

Re: usb/media/em28xx: use-after-free in dvb_unregister_frontend

Am 21.11.2017 um 14:51 schrieb Andrey Konovalov: > Hi! > Hi Andrey, > I've got the following report while fuzzing the kernel with syzkaller. > > On commit e1d1ea549b57790a3d8cf6300e6ef86118d692a3 (4.15-rc1). > > em28xx 1-1:9.0: Disconnecting > tc90522 1-0015: Toshiba TC90522 attached. >

Re: [PATCH] dvb_frontend: don't use-after-free the frontend struct

Am 07.11.2017 um 14:44 schrieb Mauro Carvalho Chehab: > diff --git a/drivers/media/dvb-core/dvb_frontend.c > b/drivers/media/dvb-core/dvb_frontend.c > index d485d5f6cc88..3ad83359098b 100644 > --- a/drivers/media/dvb-core/dvb_frontend.c > +++ b/drivers/media/dvb-core/dvb_frontend.c > @@ -150,11

[PATCH 15/15] media: MAINTAINERS: add si2165 driver

Silicon Labs Si2165 DVB-C/T demod driver Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index adbf69306e9e..b3dc695bcfa4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12193,6 +12

[PATCH 14/15] si2165: Add DVBv3 wrapper for ber statistics

Add read_ber function that reads from property cache to support DVBv3. The implementation is inspired by the cx24120 driver. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 26 ++ 1 file changed, 26 insertions(+) diff

[PATCH 06/15] si2165: improve read_status

Use check_signal register for DVB-T additionally. For DVB-C use ps_lock additionally. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 41 ++- drivers/media/dvb-frontends/si2165_priv.h | 2 ++ 2 files chang

[PATCH 10/15] cx23885: Use semicolon after assignment instead of comma

End assignments by semicolon instead of comma. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/pci/cx23885/cx23885-dvb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/c

[PATCH 12/15] si2165: add DVBv5 BER statistics

Add support for BER statistics. Configure a measurement period of 3 packets. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 57 +-- drivers/media/dvb-frontends/si2165_priv.h | 11 ++ 2 files chang

[PATCH 13/15] si2165: add DVBv3 wrapper for C/N statistics

Add read_snr function that reads from property cache to support DVBv3. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/med

[PATCH 11/15] si2165: add DVBv5 C/N statistics for DVB-C

Add C/N statistics in dB to read_status (DVBv5). Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 43 +-- drivers/media/dvb-frontends/si2165_priv.h | 1 + 2 files changed, 42 insertions(+), 2 deletions(-)

[PATCH 03/15] si2165: Make checkpatch happy

Fix almost all of checkpatch --strict warnings. The remaining warnings are about: * macro REG16 (should be enclosed in parentheses) * macro REG16 (Macro argument reuse) Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c

[PATCH 08/15] si2165: Use constellation from property cache instead of hardcoded QAM256

Use constellation from property cache instead of always setting it to QAM256. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/med

[PATCH 04/15] si2165: define register macros

Convert register numbers to macros. Correctness verified by comparing the disassembly before and after. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 206 +++--- drivers/media/dvb-frontends/si2165_priv.h

[PATCH 05/15] si2165: move ts parallel mode setting to the ts init code

The TS parallel mode setting should be where all other TS settings are written. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/d

[PATCH 02/15] si2165: Convert debug printk to dev_dbg

Removed module parameter debug and the conditions based on it. Now it can be configured via dynamic debug. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 79 +++- 1 file changed, 15 insertions(+), 64 del

[PATCH 09/15] cx231xx: Use semicolon after assignment instead of comma

End assignments by semicolon instead of comma. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-dvb.c b/drivers/media/usb/cx231xx/c

[PATCH 07/15] si2165: Write const value for lock timeout

The lock timeout should not depend on the bandwidth. It should be either constant or depend on xtal frequency. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/med

[PATCH 01/15] si2165: Remove redundant KBUILD_MODNAME from dev_* logging

Remove redundant repeated module name from messages. Before: si2165 8-0064: si2165: fw load finished After: si2165 8-0064: fw load finished Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 69

[PATCH] build: add fwnode_property_get_reference_args if not defined

Add function dummy that returns -ENODATA. Copied struct fwnode_reference_args from include/linux/fwnode.h. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- v4l/compat.h | 19 +++ v4l/scripts/make_config_compat.pl | 1 + 2 files changed, 20 inse

[PATCH] build: Add support for timer_setup

Literally copied the implementation from kernel commit 686fef928bba6be13 (timer: Prepare to change timer callback argument type) Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- v4l/compat.h | 17 + v4l/scripts/make_config_compat.pl | 1 + 2

[PATCH] em28xx: Fix use-after-free when disconnecting

4] CR2: 01f8 [ 6058.875880] ---[ end trace 717eecf7193b3fc6 ]--- Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/usb/em28xx/em28xx-dvb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/e

[PATCH] __dvb_frontend_free: Clear frontend_priv earlier

novalov <andreyk...@google.com> Signed-off-by: Matthias Schwarzott <z...@gentoo.org> Tested-by: Andrey Konovalov <andreyk...@google.com> --- drivers/media/dvb-core/dvb_frontend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c

Re: usb/media/dtt200u: use-after-free in __dvb_frontend_free

Am 23.10.2017 um 16:41 schrieb Andrey Konovalov: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. > > On commit 3e0cc09a3a2c40ec1ffb6b4e12da86e98feccb11 (4.14-rc5+). > > dvb-usb: found a 'WideView WT-220U PenType Receiver (based on ZL353)' > in warm state. >

Re: [PATCH] Simplify major/minor non-dynamic logic

Am 11.10.2017 um 21:36 schrieb Mauro Carvalho Chehab: > changeset 6bbf7a855d20 ("media: dvbdev: convert DVB device types into an > enum") > added a new warning on gcc 6: > >>> drivers/media/dvb-core/dvbdev.c:86:1: warning: control reaches end of >>> non-void function [-Wreturn-type] > > That's

[PATCH] cx23885: Explicitly list Hauppauge model numbers of HVR-4400 and HVR-5500

it supports DVB-S/S2 and DVB-T, but my hardware also supports DVB-C. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/pci/cx23885/cx23885-cards.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/pci/cx23885/cx23885-cards.c b/drivers/media/pci/c

Fwd: Aw: Fwd: [PATCH 1/2] cx23885: Fix use-after-free when unregistering the i2c_client for the dvb demod

lt;xpert-reac...@gmx.de> An: Matthias Schwarzott <z...@gentoo.org> Tested-by: Sven Müller <xpert-reac...@gmx.de> > Gesendet: Sonntag, 27. August 2017 um 12:12 Uhr > Von: "Matthias Schwarzott" <z...@gentoo.org> > An: "Sven Müller" <xpert-reac...@gm

Re: [PATCH 1/2] cx23885: Fix use-after-free when unregistering the i2c_client for the dvb demod

Am 02.08.2017 um 18:45 schrieb Matthias Schwarzott: > diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c > b/drivers/media/pci/cx23885/cx23885-dvb.c > index 979b66627f60..e795ddeb7fe2 100644 > --- a/drivers/media/pci/cx23885/cx23885-dvb.c > +++ b/drivers/media/pci/cx2388

Re: analog support for WinTV-HVR-900H/930C-HD

Am 19.08.2017 um 21:46 schrieb Sven Verdoolaege: > Hi, > Hi! > I hope this is the right place for asking about support > for analog TV on Hauppauge cards. > > I recently bought what I thought is a Hauppauge WinTV-HVR-900H > (that's what it says on the stick itself) because according > to

[PATCH 2/2] cx231xx: fix use-after-free when unregistering the i2c_client for the dvb demod

+0xdb/0x160 [cx231xx_dvb] cx231xx_unregister_extension+0x3d/0xb0 [cx231xx] cx231xx_dvb_unregister+0x10/0x809 [cx231xx_dvb] SyS_delete_module+0x18a/0x240 ? exit_to_usermode_loop+0x7b/0x80 entry_SYSCALL_64_fastpath+0x17/0x98 Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- d

[PATCH 0/2] Fix use-after-free errors when unregistering the i2c_client for the dvb demod

Hi! There seem to be a general error in a lot of dvb bride drivers about the order of i2c_unregister_device and the calls to dvb_unregister_frontend and dvb_frontend_detach. As soon as the i2c_client for a demod driver is unregistered the memory for the frontend is kfreed. But the calls to

[PATCH 1/2] cx23885: Fix use-after-free when unregistering the i2c_client for the dvb demod

: 0884 R11: 0206 R12: 7ffdf6cda010 kernel: R13: R14: 015001f0 R15: 014ff010 kernel: ---[ end trace c3a4659b89086061 ]--- Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/pci/cx23885/cx23885-dvb.c | 10 +--

[PATCH] Add compat code for skb_put_data

Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- v4l/compat.h | 12 v4l/scripts/make_config_compat.pl | 1 + 2 files changed, 13 insertions(+) diff --git a/v4l/compat.h b/v4l/compat.h index 47e2694..e565292 100644 --- a/v4l/compat.h +++ b/v4l/co

Re: Unknown symbol put_vaddr_frames when using media_build

Am 07.06.2017 um 20:23 schrieb Mauro Carvalho Chehab: > Em Tue, 9 May 2017 06:56:25 +0200 > Matthias Schwarzott <z...@gentoo.org> escreveu: > >> Hi! >> >> Whenever I compile the media drivers using media_build against a recent >> kernel, I get this message

Unknown symbol put_vaddr_frames when using media_build

Hi! Whenever I compile the media drivers using media_build against a recent kernel, I get this message when loading them: [5.848537] media: Linux media interface: v0.10 [5.881440] Linux video capture interface: v2.00 [5.881441] WARNING: You are using an experimental version of the

Re: [PATCH v2 01/12] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional

Am 26.03.2017 um 12:34 schrieb Daniel Scheller: > Am Sun, 26 Mar 2017 10:03:33 +0200 > schrieb Matthias Schwarzott <z...@gentoo.org>: > >> Am 24.03.2017 um 19:23 schrieb Daniel Scheller: >>> From: Daniel Scheller <d.schel...@gmx.net> >>> >>&g

Re: [PATCH v2 01/12] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional

Am 24.03.2017 um 19:23 schrieb Daniel Scheller: > From: Daniel Scheller > > Some hardware and bridges (namely ddbridge) require that tuner access is > limited to one concurrent access and wrap i2c gate control with a > mutex_lock when attaching frontends. According to vendor

media_build handles FRAME_VECTOR incorrect

Hi! Compiling the media drivers out of tree with media_build does not handle FRAME_VECTOR correctly. My kernel sources have FRAME_VECTOR but it is not enabled. So all modules depending on it (e.g. VIDEOBUF2_MEMOPS) will fail to load because the relevant functions cannot be found. I see two

[PATCH 3/7] cx231xx: Prepare for attaching new style i2c_client DVB demod drivers

cx231xx does not yet support attaching new-style i2c_client DVB demod drivers. Add necessary code base on tuner support for i2c_client. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 9 - 1 file changed, 8 insertions(+), 1 de

[PATCH 7/7] si2165: switch to regmap

This avoids some low-level operations. It has the benefit that now register values van be read from /sys/kernel/debug/regmap The maximum register value is just a guess - all higher addresses read as zero. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-fro

[PATCH 4/7] cx231xx: attach si2165 driver via i2c_client

Use new style attach. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 73 ++--- 1 file changed, 48 insertions(+), 25 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-dvb.c b/drivers/media/usb/c

[PATCH 2/7] cx23885: attach si2165 driver via i2c_client

Use new style attach. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/pci/cx23885/cx23885-dvb.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/c

[PATCH 6/7] si2165: use i2c_client->dev instead of i2c_adapter->dev for logging

Now that there is a i2c_client, use the more specific dev for logging. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/med

[PATCH 5/7] si2165: Remove legacy attach

Now that all users of legacy attach are converted it can be removed. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 117 -- drivers/media/dvb-frontends/si2165.h | 31 drivers/media/dvb-fro

[PATCH 1/7] si2165: support i2c_client attach

Afterwards it is possible to convert attaching in card drivers. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 149 +++ drivers/media/dvb-frontends/si2165.h | 22 ++ 2 files changed, 171 insertions(+)

[PATCH] si2165: avoid division by zero

HVR-4400 PCIe-card after suspend-to-disk. Do suspend-to-disk without accessing the DVB device before. After wakeup try to tune. si2165_init fails at checking the chip_mode and aborts. Then si2165_set_if_freq_shift will fail with div-by-zero. Signed-off-by: Matthias Schwarzott <z...@gentoo.

[REGRESSION/bisected] kernel oops in vb2_core_qbuf when tuning to DVB on the HVR-4400 caused by videobuf2: Refactor vb2_fileio_data and vb2_thread

Hi! When tuning the HVR-4400 to a DVB-C channel I get this kernel oops: Jan 3 21:59:39 gauss kernel: BUG: unable to handle kernel NULL pointer dereference at 01a0 Jan 3 21:59:39 gauss kernel: IP: [] vb2_core_qbuf+0x18/0x200 [videobuf2_core] Jan 3 21:59:39 gauss kernel: PGD

Re: [PATCH] [media] si2165: Refactoring for si2165_writereg_mask8()

ction >without using an extra assignment for the variable "ret" at the end. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> The patch looks fine. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> Regards Matthias PS: I am going to switch to re

[PATCH] si2165: Reject DVB-T bandwidth auto mode

The si2165 does not support bandwidth auto-detection. Reject the request. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/media/dvb-frontends/si216

Re: [PATCH 07/10] si2165: Fix DVB-T bandwidth default

Am 03.12.2015 um 15:15 schrieb Mauro Carvalho Chehab: > Em Thu, 19 Nov 2015 21:03:59 +0100 > Matthias Schwarzott <z...@gentoo.org> escreveu: > > > Please, add a description to your patches. > > That's said, this patch should be called, instead: > > si2165:

[PATCH] tda10071: Fix dependency to REGMAP_I2C

Without I get this error for by dvb-card: tda10071: Unknown symbol devm_regmap_init_i2c (err 0) cx23885_dvb_register() dvb_register failed err = -22 cx23885_dev_setup() Failed to register dvb adapters on VID_B Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/med

media_build using regmap-i2c

Hi! I noticed for a media_build installation, that tda10071 was not loadable because regmap-i2c did not exist. The only way I saw to get regmap-i2c compiled, is to enable any other kernel module that has a "select REGMAP_I2C" in Kconfig. I choose "CONFIG_SENSORS_ADS7828=m". Maybe the kernel

Re: [PATCH 4/4] si2165: Add DVB-C support for HVR-4400/HVR-5500

Am 19.11.2015 um 14:28 schrieb Mauro Carvalho Chehab: > Em Fri, 13 Nov 2015 23:54:58 +0100 > Matthias Schwarzott <z...@gentoo.org> escreveu: > >> It works only for HVR-4400/HVR-5500. >> For WinTV-HVR-930C-HD it fails with bad/no reception >> for unknown reaso

si2165: Add simple DVB-C support

This series adds simple DVB-C support to the si2165 demod driver. It works only for HVR-4400/HVR-5500. For WinTV-HVR-930C-HD it fails with bad/no reception for unknown reasons. Regards Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

[PATCH 09/10] si2165: Prepare si2165_set_frontend for splitting

Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 51 ++-- 1 file changed, 37 insertions(+), 14 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index 0

[PATCH 02/10] si2165: rename si2165_set_parameters to si2165_set_frontend

Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index d36b36c..a0e4600 100644 --- a/drivers/med

[PATCH 07/10] si2165: Fix DVB-T bandwidth default

Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index 807a3c9..e97b0e6 100644 --- a/d

[PATCH 06/10] si2165: Simplify si2165_set_if_freq_shift usage

Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index 0c1f4c4..807a3c9

[PATCH 04/10] si2165: only write agc registers after reset before start_syncro

Datasheet says they must be rewritten after reset. But it only makes sense to write them when trying to tune afterwards. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 32 +++- 1 file changed, 15 insertions(

[PATCH 10/10] si2165: Add DVB-C support for HVR-4400/HVR-5500

It works only for HVR-4400/HVR-5500. For WinTV-HVR-930C-HD it fails with bad/no reception for unknown reasons. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 86 +--- 1 file changed, 81 insertions(+), 5 del

[PATCH 08/10] si2165: set list of DVB-T registers together

Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 73 +--- 1 file changed, 26 insertions(+), 47 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index e

[PATCH 03/10] si2165: create function si2165_write_reg_list for writing register lists

Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index a0e4600..222d775 100644 --- a/drivers

[PATCH 05/10] si2165: move setting ts config to init

The TS config is fixed, so no need to write it for each tune. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/media/dvb-frontends/si216

[PATCH 01/10] si2165: rename frontend -> fe

Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index c5d7c0d..d36b36c

[PATCH 4/4] si2165: Add DVB-C support for HVR-4400/HVR-5500

It works only for HVR-4400/HVR-5500. For WinTV-HVR-930C-HD it fails with bad/no reception for unknown reasons. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 132 +++ 1 file changed, 120 insertions(+), 12 del

[PATCH 3/4] si2165: cleanup logic

Make si2165_set_if_freq_shift query IF frequency itself. create function to write a set of registers Always write adc registers after reset. Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 173 ++- 1 file chang

[PATCH 2/4] si2165: fix checkpatch issues

Signed-off-by: Matthias Schwarzott <z...@gentoo.org> --- drivers/media/dvb-frontends/si2165.c | 69 1 file changed, 39 insertions(+), 30 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c index 7

Re: [PATCH] [media] si2165: Fix possible leak in si2165_upload_firmware()

= si2165_writereg8(state, 0x0379, 0x01); if (ret) - return ret; + goto error; ret = si2165_upload_firmware_block(state, data, len, offset, block_count); Good catch. Signed-off-by: Matthias Schwarzott z...@gentoo.org

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

On 22.12.2014 13:59, Steven Toth wrote: On Sun, Dec 21, 2014 at 2:59 PM, Matthias Schwarzott z...@gentoo.org wrote: Unconditionally attaching Si2161/Si2165 demod driver breaks Hauppauge WinTV Starburst. So create own card entry for this. Add card name comments to the subsystem ids. Signed

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

On 22.12.2014 14:25, Mauro Carvalho Chehab wrote: Em Sun, 21 Dec 2014 21:07:02 +0100 Matthias Schwarzott z...@gentoo.org escreveu: Hi! Should the commit message directly point to the breaking commit 36efec48e2e6016e05364906720a0ec350a5d768? Yes, if this fixes an issue that happened

[PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

for HVR-5500) Signed-off-by: Matthias Schwarzott z...@gentoo.org Tested-by: Antti Palosaari cr...@iki.fi --- Only the commit message has been changed since last posting. The stable patches will be sent seperately against v3.17 and v3.18. drivers/media/pci/cx23885/cx23885-cards.c | 23

Re: cx23885: Add si2165 support for HVR-5500

On 20.12.2014 16:31, Antti Palosaari wrote: Matthias and Mauro, Hi Antti, meanwhile HVR-4400 has been tested by multiple people. And it works rather good for DVB-T. so you decided to add that patch, which makes rather big changes for existing HVR-4400 models, without any testing. I plugged

[PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

Unconditionally attaching Si2161/Si2165 demod driver breaks Hauppauge WinTV Starburst. So create own card entry for this. Add card name comments to the subsystem ids. Signed-off-by: Matthias Schwarzott z...@gentoo.org --- drivers/media/pci/cx23885/cx23885-cards.c | 23

Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

Hi! Should the commit message directly point to the breaking commit 36efec48e2e6016e05364906720a0ec350a5d768? This commit hopefully reverts the problematic attach for the Starburst card. I kept the GPIO-part in common, but I can split this also if necessary. Regards Matthias -- To unsubscribe

Re: [PATCH 6/7] [media] cx231xx-i2c: fix i2c_scan modprobe parameter

On 01.11.2014 14:38, Mauro Carvalho Chehab wrote: This device doesn't properly implement read with a zero bytes len. So, use 1 byte for I2C scan. Yes, the idea sounds good, but we should fix this in the code in cx231xx_i2c_check_for_device. Signed-off-by: Mauro Carvalho Chehab

[PATCH] cx231xx: use 1 byte read for i2c scan

Now cx231xx_i2c_check_for_device works like i2c_check_for_device of em28xx driver. For me this fixes scanning of all ports but port 2. Signed-off-by: Matthias Schwarzott z...@gentoo.org --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[PATCH] tveeprom: Update list of chips and extend serial number to 32bits

The update was supplied directly by PCTV. Add tuner ids 182-188. Add audproc ids 45-52. Add decoder chip ids 43-53. Use 32bits for the serial number. Signed-off-by: Matthias Schwarzott z...@gentoo.org --- drivers/media/common/tveeprom.c | 36 +--- 1 file changed

Re: [PATCH] cx231xx: remove direct register PWR_CTL_EN modification that switches port3

On 31.10.2014 11:32, Mauro Carvalho Chehab wrote: Em Thu, 30 Oct 2014 23:43:55 +0100 Matthias Schwarzott z...@gentoo.org escreveu: The only remaining place that modifies the relevant bit is in function cx231xx_set_Colibri_For_LowIF Signed-off-by: Matthias Schwarzott z...@gentoo.org

[PATCH v4 00/14] cx231xx: Use muxed i2c adapters instead of custom switching

Hi! This time the series got only small updates from Antti's review. Additionally I added a patch to no longer directly modify the content of the port3 switch bit in PWR_CTL_EN (from function cx231xx_set_power_mode). Now there are two places where I wonder what happens: 1.

[PATCH v4 02/14] cx231xx: use own i2c_client for eeprom access

This is a preparation for deleting the otherwise useless i2c_clients that are allocated for all the i2c master adapters. Signed-off-by: Matthias Schwarzott z...@gentoo.org Reviewed-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/cx231xx/cx231xx-cards.c | 24 +--- 1

[PATCH v4 03/14] cx231xx: delete i2c_client per bus

For each i2c master there is a i2c_client allocated that could be deleted now that its only two users have been changed to use their own i2c_client. Signed-off-by: Matthias Schwarzott z...@gentoo.org Reviewed-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 7

[PATCH v4 12/14] cx231xx: remove direct register PWR_CTL_EN modification that switches port3

The only remaining place that modifies the relevant bit is in function cx231xx_set_Colibri_For_LowIF Signed-off-by: Matthias Schwarzott z...@gentoo.org --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/cx231xx

[PATCH v4 13/14] cx231xx: drop unconditional port3 switching

All switching should be done by i2c mux adapters. Drop explicit dont_use_port_3 flag. Drop info message about switch. Only the removed code in start_streaming is questionable: It did switch the port_3 flag without accessing i2c in between. Signed-off-by: Matthias Schwarzott z...@gentoo.org

[PATCH v4 07/14] cx231xx: add wrapper to get the i2c_adapter pointer

This is a preparation for mapping I2C_1_MUX_1 and I2C_1_MUX_3 later to the seperate muxed i2c adapters. Map mux adapters to I2C_1 for now. Add local variables for i2c_adapters in dvb_init to get line lengths shorter. Signed-off-by: Matthias Schwarzott z...@gentoo.org Reviewed-by: Antti

[PATCH v4 04/14] cx231xx: give each master i2c bus a seperate name

V2: Use snprintf to construct the complete name V3: Remove unneeded variable. Signed-off-by: Matthias Schwarzott z...@gentoo.org Reviewed-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media

[PATCH v4 11/14] cx231xx: register i2c mux adapters for master1 and use as I2C_1_MUX_1 and I2C_1_MUX_3

Signed-off-by: Matthias Schwarzott z...@gentoo.org Reviewed-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/cx231xx/Kconfig| 1 + drivers/media/usb/cx231xx/cx231xx-core.c | 5 drivers/media/usb/cx231xx/cx231xx-i2c.c | 44 +++- drivers/media/usb

[PATCH v4 14/14] cx231xx: scan all four existing i2c busses instead of the 3 masters

The scanning itself just fails (as before this series) but now the correct busses are scanned. V2: Changed to symbolic names where muxed adapters can be seen directly. V3: Comment about scanning busses ordered by physical port numbers. Signed-off-by: Matthias Schwarzott z...@gentoo.org Reviewed

[PATCH v4 08/14] cx231xx: remember status of i2c port_3 switch

This is used later for is_tuner function that switches i2c behaviour for some tuners. V2: Add comments about possible improvements for port_3 switch function. V3: Fix coding style. Signed-off-by: Matthias Schwarzott z...@gentoo.org --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 12

[PATCH v4 09/14] cx231xx: let is_tuner check the real i2c port and not the i2c master number

Get used i2c port from bus_nr and status of port_3 switch. Signed-off-by: Matthias Schwarzott z...@gentoo.org --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb

[PATCH v4 01/14] cx231xx: let i2c bus scanning use its own i2c_client

This is a preparation for deleting the otherwise useless i2c_clients that are allocated for all the i2c master adapters. Signed-off-by: Matthias Schwarzott z...@gentoo.org Reviewed-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 17 +++-- drivers/media

[PATCH v4 05/14] cx231xx: Modifiy the symbolic constants for i2c ports and describe

Change to I2C_0 ... I2C_2 for the master ports and add I2C_1_MUX_1 and I2C_1_MUX_3 for the muxed ones. V2: Renamed mux adapters to seperate them from master adapters. Signed-off-by: Matthias Schwarzott z...@gentoo.org Reviewed-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/cx231xx

[PATCH v4 06/14] cx231xx: Use symbolic constants for i2c ports instead of numbers

Replace numbers by the constants of same value and same meaning. Signed-off-by: Matthias Schwarzott z...@gentoo.org Reviewed-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/cx231xx/cx231xx-cards.c | 62 +++ 1 file changed, 31 insertions(+), 31 deletions

[PATCH v4 10/14] cx231xx: change usage of I2C_1 to the real i2c port

change almost all instances of I2C_1 to I2C_1_MUX_3 Only these cases are changed to I2C_1_MUX_1: * All that have dont_use_port_3 set. * CX231XX_BOARD_HAUPPAUGE_EXETER, old code did explicitly not switch to port3. * eeprom access for 930C Signed-off-by: Matthias Schwarzott z...@gentoo.org

[PATCH] cx231xx: remove direct register PWR_CTL_EN modification that switches port3

The only remaining place that modifies the relevant bit is in function cx231xx_set_Colibri_For_LowIF Signed-off-by: Matthias Schwarzott z...@gentoo.org --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/cx231xx

  1   2   3   >