Re: [PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-24 Thread Matwey V. Kornilov
t; Ezequiel García, VanguardiaSur > www.vanguardiasur.com.ar -- With best regards, Matwey V. Kornilov

Re: [PATCH v6 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-12 Thread Matwey V. Kornilov
Matwey, does v6 address the comments made in v5? Hi, v6 addresses the comments made by Laurent Pinchart on Oct, 31: https://www.spinics.net/lists/linux-media/msg142216.html namely, dma_sync_single_for_device() is introduced in the proper place > > -- Steve -- With best regards, Matwey V. Kornilov

Re: [PATCH v6 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-12 Thread Matwey V. Kornilov
пт, 30 нояб. 2018 г. в 15:20, Matwey V. Kornilov : > > ср, 21 нояб. 2018 г. в 21:15, Matwey V. Kornilov : > > > > пт, 9 нояб. 2018 г. в 22:03, Matwey V. Kornilov : > > > > > > DMA cocherency slows the transfer down on systems without hardware > > > co

Re: [PATCH v6 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-11-30 Thread Matwey V. Kornilov
ср, 21 нояб. 2018 г. в 21:15, Matwey V. Kornilov : > > пт, 9 нояб. 2018 г. в 22:03, Matwey V. Kornilov : > > > > DMA cocherency slows the transfer down on systems without hardware > > coherent DMA. > > Instead we use noncocherent DMA memory and explicit sy

Re: [PATCH v6 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-11-21 Thread Matwey V. Kornilov
пт, 9 нояб. 2018 г. в 22:03, Matwey V. Kornilov : > > DMA cocherency slows the transfer down on systems without hardware > coherent DMA. > Instead we use noncocherent DMA memory and explicit sync at data receive > handler. > > Based on previous commit the following performance

[PATCH v6 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-11-09 Thread Matwey V. Kornilov
ot be successfully received at AM335x platforms with MUSB based USB host controller due to performance issues [1]. [1] https://www.spinics.net/lists/linux-usb/msg165735.html Signed-off-by: Matwey V. Kornilov --- drivers/media/usb/pwc/pwc-if.c | 62 +- 1

[PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-11-09 Thread Matwey V. Kornilov
* remeasured performance Changes since v1: * trace_pwc_handler_exit() call moved to proper place * detailed description added for commit 1 * additional output added to trace to track separate frames Matwey V. Kornilov (2): media: usb: pwc: Introduce TRACE_EVENTs for pwc_isoc_handler() media

[PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-11-09 Thread Matwey V. Kornilov
* remeasured performance Changes since v1: * trace_pwc_handler_exit() call moved to proper place * detailed description added for commit 1 * additional output added to trace to track separate frames Matwey V. Kornilov (2): media: usb: pwc: Introduce TRACE_EVENTs for pwc_isoc_handler() media

[PATCH v6 1/2] media: usb: pwc: Introduce TRACE_EVENTs for pwc_isoc_handler()

2018-11-09 Thread Matwey V. Kornilov
able to measure performance of PWC driver, traces are introduced in URB handler section. [1] https://www.spinics.net/lists/linux-usb/msg165735.html Signed-off-by: Matwey V. Kornilov --- drivers/media/usb/pwc/pwc-if.c | 7 + include/trace/events/pwc.h

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-10-10 Thread Matwey V. Kornilov
вт, 11 сент. 2018 г. в 21:58, Matwey V. Kornilov : > > вт, 28 авг. 2018 г. в 10:17, Matwey V. Kornilov : > > > > вт, 21 авг. 2018 г. в 20:06, Matwey V. Kornilov : > > > > > > DMA cocherency slows the transfer down on systems without hardware > > > co

Re: [PATCH 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-07-25 Thread Matwey V. Kornilov
2018-07-24 23:55 GMT+03:00 Alan Stern : > On Tue, 24 Jul 2018, Matwey V. Kornilov wrote: > >> 2018-07-23 21:57 GMT+03:00 Alan Stern : >> > On Mon, 23 Jul 2018, Matwey V. Kornilov wrote: >> > >> >> I've tried to strategies: >> >> >> &

Re: [BUG] musb: broken isochronous transfer at TI AM335x platform

2018-02-18 Thread Matwey V. Kornilov
2018-02-16 19:27 GMT+03:00 Tony Lindgren : > * Matwey V. Kornilov [180215 17:55]: >> [] 7.219456 d= 0.000997 [181.0 + 3.667] [ 3] IN : 4.5 >> [T ] 7.219459 d= 0.03 [181.0 + 7.083] [800] DATA0: 53 da >> ... >> []

[BUG] musb: broken isochronous transfer at TI AM335x platform

2018-02-15 Thread Matwey V. Kornilov
6.html [2] https://www.spinics.net/lists/linux-usb/msg145747.html [3] http://openvizsla.org/ [4] https://www.spinics.net/lists/linux-usb/msg156107.html [5] https://www.spinics.net/lists/linux-usb/msg156486.html [6] https://github.com/matwey/linux/commit/2b36e1add5aaf552923c8c1340e50bd7c2050fde -- With best regards, Matwey V. Kornilov. Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia 119234, Moscow, Universitetsky pr-k 13, +7 (495) 9392382

Re: musb: isoc pkt loss with pwc

2017-04-15 Thread Matwey V. Kornilov
187.0 + 3.667] [ 3] IN : 4.5 [] 7.225459 d= 0.03 [187.0 + 7.000] [ 3] DATA0: 00 00 Here, I believe that IN request is missed at 7.221 and this leads to the issues with missed data. 2016-08-28 13:13 GMT+03:00 Matwey V. Kornilov : > Hello Bin, > > I would like to start

Re: musb: isoc pkt loss with pwc

2017-01-27 Thread Matwey V. Kornilov
2016-11-01 23:33 GMT+03:00 Bin Liu : > On Sat, Oct 15, 2016 at 10:25:42PM +0300, Matwey V. Kornilov wrote: > > [snip] > >> >>> > Which means without this commit your camera has been working without >> >>> > issues, and this is a regression with

Re: musb: isoc pkt loss with pwc

2016-10-15 Thread Matwey V. Kornilov
2016-09-12 22:38 GMT+03:00 Matwey V. Kornilov : > 2016-09-12 21:57 GMT+03:00 Bin Liu : >> Hi, >> >> On Mon, Sep 12, 2016 at 11:52:46AM +0300, Matwey V. Kornilov wrote: >>> 2016-09-12 6:28 GMT+03:00 Bin Liu : >>> > Hi, >>> > >>> >

Re: musb: isoc pkt loss with pwc

2016-09-12 Thread Matwey V. Kornilov
2016-09-12 21:57 GMT+03:00 Bin Liu : > Hi, > > On Mon, Sep 12, 2016 at 11:52:46AM +0300, Matwey V. Kornilov wrote: >> 2016-09-12 6:28 GMT+03:00 Bin Liu : >> > Hi, >> > >> > On Tue, Aug 30, 2016 at 11:44:33PM +0300, Matwey V. Kornilov wrote: >> &g

Re: musb: isoc pkt loss with pwc

2016-09-12 Thread Matwey V. Kornilov
2016-09-12 6:28 GMT+03:00 Bin Liu : > Hi, > > On Tue, Aug 30, 2016 at 11:44:33PM +0300, Matwey V. Kornilov wrote: >> 2016-08-30 21:30 GMT+03:00 Bin Liu : >> > Hi, >> > >> > On Sun, Aug 28, 2016 at 01:13:55PM +0300, Matwey V. Kornilov wrote: >> >

Re: musb: isoc pkt loss with pwc

2016-08-30 Thread Matwey V. Kornilov
2016-08-30 21:30 GMT+03:00 Bin Liu : > Hi, > > On Sun, Aug 28, 2016 at 01:13:55PM +0300, Matwey V. Kornilov wrote: >> Hello Bin, >> >> I would like to start new thread on my issue. Let me recall where the issue >> is: >> There is 100% frame lost in pwc webc

musb: isoc pkt loss with pwc

2016-08-28 Thread Matwey V. Kornilov
ated every 1 ms by hardware and should be followed by IN immediately? If so, it is not clear to me how they should be aligned when the time difference between to subsequent INs is greater than 1ms. -- With best regards, Matwey V. Kornilov. Sternberg Astronomical Institute, Lomonosov Moscow S

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-24 Thread Matwey V. Kornilov
2016-08-22 11:32 GMT+03:00 Matwey V. Kornilov : > 2016-08-22 1:00 GMT+03:00 Alan Stern : >> On Sun, 21 Aug 2016, Matwey V. Kornilov wrote: >> >>> In both cases (with or without HCD_BH), usb_hcd_giveback_urb is called >>> every 0.01 sec. It is not clear why beh

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-22 Thread Matwey V. Kornilov
2016-08-22 1:00 GMT+03:00 Alan Stern : > On Sun, 21 Aug 2016, Matwey V. Kornilov wrote: > >> In both cases (with or without HCD_BH), usb_hcd_giveback_urb is called >> every 0.01 sec. It is not clear why behavior is so different. > > What behavior are you asking about?

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-21 Thread Matwey V. Kornilov
In both cases (with or without HCD_BH), usb_hcd_giveback_urb is called every 0.01 sec. It is not clear why behavior is so different. 2016-08-21 17:02 GMT+03:00 Matwey V. Kornilov : > I've just measured that > > it takes 150 us in average for pwc_isoc_handler t

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-21 Thread Matwey V. Kornilov
I've just measured that it takes 150 us in average for pwc_isoc_handler to run 350 us - __usb_hcd_giveback_urb So, it takes either 50 us (with HCD_BH) or 400 us (without) for usb_hcd_giveback_urb to run. 2016-08-20 21:09 GMT+03:00 Matwey V. Kornilov : > I've just checked 4

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-20 Thread Matwey V. Kornilov
I've just checked 4.8-rc2 - same behaviour. 2016-08-18 16:31 GMT+03:00 Matwey V. Kornilov : > Any ideas? > > 2016-08-04 23:08 GMT+03:00 Matwey V. Kornilov : >> When DMA is not used, I see the same behavior: lots of zero-length >> packages received. >> >>

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-18 Thread Matwey V. Kornilov
Any ideas? 2016-08-04 23:08 GMT+03:00 Matwey V. Kornilov : > When DMA is not used, I see the same behavior: lots of zero-length > packages received. > > Can It be related to some kind of USB overflow due to long input data > processing with disabled IRQ? > When HCD_BC is

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-04 Thread Matwey V. Kornilov
latency. 2016-08-04 22:58 GMT+03:00 Matwey V. Kornilov : > I've just found that in such cases, when DMA actual length is zero, > both cppi41_channel->prog_len and txstate.residue equal 960 at > musb_cppi41 line 225: > > http://git.kernel.org/cgit/linux/kernel/git/next/linu

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-04 Thread Matwey V. Kornilov
y ideas why? > > 2016-08-04 19:57 GMT+03:00 Matwey V. Kornilov : >> I've just found that many packages in URBs have zero actual_length (It >> is a question why). >> Then the following end of frame criteria leads to `frame underflow&

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-04 Thread Matwey V. Kornilov
xt_fill_buf(pdev); > if (pdev->fill_buf) { > pdev->fill_buf->filled = 0; > pdev->vsync = 1; > } > } > > 2016-08-01 21:16 GMT+03:00 Matwey V. Kornilov : &g

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-04 Thread Matwey V. Kornilov
if (pdev->fill_buf) { pdev->fill_buf->filled = 0; pdev->vsync = 1; } } 2016-08-01 21:16 GMT+03:00 Matwey V. Kornilov : > pwc module output with trace=511 is the following: > > [ 24.793109] usbcore:

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-01 Thread Matwey V. Kornilov
2016-08-01 20:06 GMT+03:00 Viresh Kumar : > On 01-08-16, 20:01, Matwey V. Kornilov wrote: >> With this patch, there is no cpufreq directory here. >> >> Without this patch, the output is the following: >> >> nohostname:~ # uname -a >> Linux nohostname 4.6.4-3.

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-01 Thread Matwey V. Kornilov
bytes); discarded. [ 31.874548] pwc: Frame buffer underflow (16252 bytes); discarded. [ 31.976533] pwc: Frame buffer underflow (18164 bytes); discarded. 2016-07-31 23:31 GMT+03:00 Matwey V. Kornilov : > Hello, > > I've also just found that the same commit breaks cpufreq on BeagleBon

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-01 Thread Matwey V. Kornilov
2016-08-01 19:50 GMT+03:00 Viresh Kumar : > On 31-07-16, 23:31, Matwey V. Kornilov wrote: >> Hello, >> >> I've also just found that the same commit breaks cpufreq on BeagleBone Black >> :) >> >> So, probably without HCD_BH flag musb works correctly only

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-31 Thread Matwey V. Kornilov
MT+03:00 Matwey V. Kornilov : > Hello, > > I've found that the following commit fixes the issue: > > commit 7694ca6e1d6f01122f05039b81f70f64b1ec4063 > Author: Viresh Kumar > Date: Fri Apr 22 16:58:42 2016 +0530 > > cpufreq: omap: Use generic platdev driver

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-29 Thread Matwey V. Kornilov
tform device now, reuse that and remove similar code from platform code. 2016-07-28 19:16 GMT+03:00 Matwey V. Kornilov : > Hello, > > I've just bisected commit, which fixed the issue in v4.7 > > commit 9fa64d6424adabf0e3a546ae24d01a62a927b342 > Merge: f55532a febce40 > Au

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-28 Thread Matwey V. Kornilov
ag to handle urb > return in bottom half" > > I have not checked yet, if it was intentionnaly fixed. > > 2016-07-23 22:24 GMT+03:00 Matwey V. Kornilov : >> 2016-07-20 21:56 GMT+03:00 Matwey V. Kornilov : >>> 2016-07-20 18:06 GMT+03:00 Bin Liu : >>>> Hi, &

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-27 Thread Matwey V. Kornilov
yet, if it was intentionnaly fixed. 2016-07-23 22:24 GMT+03:00 Matwey V. Kornilov : > 2016-07-20 21:56 GMT+03:00 Matwey V. Kornilov : >> 2016-07-20 18:06 GMT+03:00 Bin Liu : >>> Hi, >>> >>> On Wed, Jul 20, 2016 at 05:44:56PM +0300, Matwey V. Kornilov wrote:

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-23 Thread Matwey V. Kornilov
2016-07-20 21:56 GMT+03:00 Matwey V. Kornilov : > 2016-07-20 18:06 GMT+03:00 Bin Liu : >> Hi, >> >> On Wed, Jul 20, 2016 at 05:44:56PM +0300, Matwey V. Kornilov wrote: >>> 2016-07-20 17:13 GMT+03:00 Bin Liu : >>> > Hi, >>> > >>> >

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-20 Thread Matwey V. Kornilov
2016-07-20 18:06 GMT+03:00 Bin Liu : > Hi, > > On Wed, Jul 20, 2016 at 05:44:56PM +0300, Matwey V. Kornilov wrote: >> 2016-07-20 17:13 GMT+03:00 Bin Liu : >> > Hi, >> > >> > On Wed, Jul 20, 2016 at 09:09:42AM +0300, Matwey V. Kornilov wrote: >> &

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-20 Thread Matwey V. Kornilov
2016-07-20 17:13 GMT+03:00 Bin Liu : > Hi, > > On Wed, Jul 20, 2016 at 09:09:42AM +0300, Matwey V. Kornilov wrote: >> 2016-07-20 0:34 GMT+03:00 Bin Liu : >> > Hi, >> > >> > On Wed, Jul 20, 2016 at 12:25:44AM +0300, Matwey V. Kornilov wrote: >> &g

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-20 Thread Matwey V. Kornilov
2016-07-20 9:09 GMT+03:00 Matwey V. Kornilov : > 2016-07-20 0:34 GMT+03:00 Bin Liu : >> Hi, >> >> On Wed, Jul 20, 2016 at 12:25:44AM +0300, Matwey V. Kornilov wrote: >>> 2016-07-19 23:56 GMT+03:00 Bin Liu : >>> > Hi, >>> > >>> >

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-19 Thread Matwey V. Kornilov
2016-07-20 0:34 GMT+03:00 Bin Liu : > Hi, > > On Wed, Jul 20, 2016 at 12:25:44AM +0300, Matwey V. Kornilov wrote: >> 2016-07-19 23:56 GMT+03:00 Bin Liu : >> > Hi, >> > >> > On Tue, Jul 19, 2016 at 11:21:17PM +0300, mat...@sai.msu.ru wrote: >> >

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-07-19 Thread Matwey V. Kornilov
it, if you think that it could provide more information. I am >> also ready to perform additional tests (use usbmon maybe?). >> >> How could this issue be resolved? >> >> Thank you. > > Do you have CPPI DMA enabled? If so I think you might hit on a known > issu

v4l2 api: supported resolution negotiation

2015-10-04 Thread Matwey V. Kornilov
Hello, I learned from V2L2 API how to detect all supported formats using VIDIOC_ENUM_FMT. When I perform VIDIOC_S_FMT I don't know how to fill fmt.pix.width and fmt.pix.height, since I know only format. How should I negotiate device resolution? Could you point me? -- To unsubscribe from this list

Re: [PATCH RFC] drivers: parport: Ask user for irqreturn_t value

2014-09-28 Thread Matwey V. Kornilov
Forget it, I invented something strange. 2014-09-28 12:02 GMT+04:00 Matwey V. Kornilov : > Current parport_irq_handler behaviour is not correct when IRQ is shared. > LDDv3 on page 279 requires us: > > "Be sure to return IRQ_NONE whenever your handler is called and finds &g

[PATCH RFC] drivers: parport: Ask user for irqreturn_t value

2014-09-28 Thread Matwey V. Kornilov
bug.cgi?id=85221 Signed-off-by: Matwey V. Kornilov --- drivers/char/ppdev.c | 4 +++- drivers/i2c/busses/i2c-parport.c | 5 - drivers/input/joystick/walkera0701.c | 6 -- drivers/net/hamradio/baycom_par.c | 4 +++- drivers/net/p