Re: Kernel docs: muddying the waters a bit

2016-03-03 Thread Mauro Carvalho Chehab
Em Thu, 03 Mar 2016 07:13:05 -0700 Jonathan Corbet escreveu: > On Thu, 03 Mar 2016 16:03:14 +0200 > Jani Nikula wrote: > > > This stalled a bit, but the waters are still muddy... > > I've been dealing with real-world obnoxiousness, something which won't > come to an immediate end, unfortunat

Re: [git:media_tree/master] [media] media: rc: nuvoton: support reading / writing wakeup sequence via sysfs

2016-03-03 Thread Mauro Carvalho Chehab
Em Thu, 03 Mar 2016 19:18:17 +0100 Heiner Kallweit escreveu: > Am 03.03.2016 um 12:28 schrieb Mauro Carvalho Chehab: > > This is an automatic generated email to let you know that the following > > patch were queued at the > > http://git.linuxtv.org/cgit.cg

Re: [git:media_tree/master] [media] media: rc: nuvoton: support reading / writing wakeup sequence via sysfs

2016-03-03 Thread Mauro Carvalho Chehab
Em Thu, 03 Mar 2016 20:22:35 +0100 Heiner Kallweit escreveu: > Am 03.03.2016 um 19:52 schrieb Mauro Carvalho Chehab: > > Em Thu, 03 Mar 2016 19:18:17 +0100 > > Heiner Kallweit escreveu: > > > >> Am 03.03.2016 um 12:28 schrieb Mauro Carvalho Chehab: > &

Re: [GIT PULL FOR v4.6] Fixes, enhancement and move 3 soc-camera drivers to staging

2016-03-03 Thread Mauro Carvalho Chehab
Em Thu, 03 Mar 2016 12:25:00 +0100 Hans Verkuil escreveu: > On 03/03/16 11:40, Mauro Carvalho Chehab wrote: > > Em Fri, 26 Feb 2016 08:45:48 +0100 > > Hans Verkuil escreveu: > > > >> The following changes since commit > >> 3915d367932609f9c0bdc79c525b

Re: Kernel docs: muddying the waters a bit

2016-03-03 Thread Mauro Carvalho Chehab
Em Thu, 03 Mar 2016 15:23:23 -0800 Keith Packard escreveu: > Mauro Carvalho Chehab writes: > > > On my tests, Sphinix seemed too limited to format tables. Asciidoc > > produced an output that worked better. > > Yes, asciidoc has much more flexibility in table for

[PATCH] [media] media-device: map new functions into old types for legacy API

2016-03-04 Thread Mauro Carvalho Chehab
so ignore the entity when printing the graphviz diagram. As we're now adding devices outside the old range, the legacy ioctl needs to map the new entity functions into a type at the old range, or otherwise we'll have a regression. Reported-by: Laurent Pinchart Signed-off-by

Re: [PATCH] v4l2-mc.h: fix PM/pipeline stub definitions

2016-03-04 Thread Mauro Carvalho Chehab
Em Fri, 04 Mar 2016 11:13:36 +0100 Arnd Bergmann escreveu: > The newly added functions have an extra semicolon, which > prevents compilation, and they need to be marked inline: > > In file included from ../include/media/tuner.h:23:0, > from ../drivers/media/tuners/tuner-simple.c

Re: Kernel docs: muddying the waters a bit

2016-03-04 Thread Mauro Carvalho Chehab
Em Fri, 04 Mar 2016 10:29:08 +0200 Jani Nikula escreveu: > On Fri, 04 Mar 2016, Mauro Carvalho Chehab wrote: > > Em Thu, 03 Mar 2016 15:23:23 -0800 > > Keith Packard escreveu: > > > >> Mauro Carvalho Chehab writes: > >> > >> > On my

Re: [PATCH] [media] media-device: map new functions into old types for legacy API

2016-03-05 Thread Mauro Carvalho Chehab
Em Fri, 04 Mar 2016 22:34:04 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday 04 March 2016 07:43:37 Mauro Carvalho Chehab wrote: > > The media-ctl tool, on versions <= 1.10 relies on detecting the > > media_type to

Re: [PATCH v5 22/22] sound/usb: Use Media Controller API to share media resources

2016-03-05 Thread Mauro Carvalho Chehab
Em Wed, 2 Mar 2016 09:50:31 -0700 Shuah Khan escreveu: > Change ALSA driver to use Media Controller API to > share media resources with DVB and V4L2 drivers > on a AU0828 media device. Media Controller specific > initialization is done after sound card is registered. > ALSA creates Media interfa

Re: [TRIVIAL PATCH] treewide: Remove unnecessary 0x prefixes before %pa extension uses

2016-03-05 Thread Mauro Carvalho Chehab
; Signed-off-by: Joe Perches > --- > drivers/dma/at_hdmac_regs.h | 2 +- > drivers/media/platform/ti-vpe/cal.c | 2 +- Acked-by: Mauro Carvalho Chehab > drivers/nvdimm/pmem.c| 2 +- > drivers/rapidio/devices/rio_mport_cdev.c | 4 ++-- > drivers/rapi

[PATCH v2] [media] media-device: map new functions into old types for legacy API

2016-03-05 Thread Mauro Carvalho Chehab
Detected on all released media-ctl versions (e. g. versions <= 1.10). Fix this by deriving the type from the function to emulate the legacy API if the function isn't in the legacy functions range. Reported-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab ---

Re: [PATCH] [media] hide unused functions for !MEDIA_CONTROLLER

2016-03-05 Thread Mauro Carvalho Chehab
Em Fri, 4 Mar 2016 17:34:43 -0700 Shuah Khan escreveu: > On 03/04/2016 05:06 PM, Arnd Bergmann wrote: > > Some functions in the au0828 driver are only used when > > CONFIG_MEDIA_CONTROLLER > > is enabled, and otherwise defined as empty functions: > > > > media/usb/au0828/au0828-core.c:208:13: e

Re: [PATCH v4 3/4] media: Add type field to struct media_entity

2016-03-05 Thread Mauro Carvalho Chehab
Em Fri, 4 Mar 2016 22:18:50 +0200 Laurent Pinchart escreveu: > Code that processes media entities can require knowledge of the > structure type that embeds a particular media entity instance in order > to cast the entity to the proper object type. This needs is shown by the > presence of the is_

[GIT PULL for v4.5] media fixes

2016-03-05 Thread Mauro Carvalho Chehab
,v4.5] media.h: increase the spacing between function ranges [media] adv7604: fix tx 5v detect regression [media] media.h: use hex values for range offsets, move connectors base up. Mauro Carvalho Chehab (2): [media] media.h: get rid of MEDIA_ENT_F_CONN_TEST [media

Re: [RFC] Representing hardware connections via MC

2016-03-05 Thread Mauro Carvalho Chehab
On Wednesday 02 March 2016 12:40:29 Mauro Carvalho Chehab wrote: > > Em Wed, 02 Mar 2016 16:16:43 +0200 Sakari Ailus escreveu: > > > On Fri, Feb 26, 2016 at 09:13:17AM -0300, Mauro Carvalho Chehab wrote: > > >> We had some discussions on Feb, 12 about how to repr

Re: [RFC] Representing hardware connections via MC

2016-03-05 Thread Mauro Carvalho Chehab
Em Thu, 03 Mar 2016 01:18:46 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Wednesday 02 March 2016 16:31:54 Mauro Carvalho Chehab wrote: > > Em Wed, 02 Mar 2016 19:33:26 +0100 Hans Verkuil escreveu: > > > On 03/02/2016 01:08 PM, Mauro Carvalho Chehab wrote: &g

Re: [RFC] Representing hardware connections via MC

2016-03-05 Thread Mauro Carvalho Chehab
Em Thu, 03 Mar 2016 12:10:18 +0200 Laurent Pinchart escreveu: > > 4) The concept of splitting up multiplexed connectors has been in use in > > V4L2 since the beginning. Without, to my knowledge, causing any problems on > > either the driver or application side. It will have to be a hard sell to >

Linux Media Summit in April, 7 - San Diego - CA - USA

2016-03-05 Thread Mauro Carvalho Chehab
As discussed on our IRC #v4l channel at Freenode, we'll be running a 1-day Linux Media Summit in San Diego on Aug, 7, just after the Embedded Linux Conference. Feel free to submit relevant topics related to the Linux Kernel support for media, in order to help us to build the workshop's agenda and

Re: Linux Media Summit in April, 7 - San Diego - CA - USA

2016-03-05 Thread Mauro Carvalho Chehab
Em Sat, 05 Mar 2016 10:54:58 -0500 Michael Ira Krufky escreveu: > On Sat, Mar 5, 2016 at 10:08 AM, Mauro Carvalho Chehab > wrote: > > As discussed on our IRC #v4l channel at Freenode, we'll be running a 1-day > > Linux Media Summit in San Diego on Aug, 7, just after

Re: Kernel docs: muddying the waters a bit

2016-03-05 Thread Mauro Carvalho Chehab
Em Fri, 04 Mar 2016 15:09:09 +0100 Johannes Stezenbach escreveu: > On Fri, Mar 04, 2016 at 09:59:50AM -0300, Mauro Carvalho Chehab wrote: > > > > 3) I tried to use a .. cssclass, as Johannes suggested, but > > I was not able to include the CSS file. I suspect that this is &

[PATCH 6/6] [media] touptek: cast char types on %x printk

2016-03-06 Thread Mauro Carvalho Chehab
This fixes those two smatch warnings: drivers/media/usb/gspca/touptek.c:206 val_reply() warn: argument 3 to %02x specifier has type 'char' drivers/media/usb/gspca/touptek.c:222 reg_w() warn: argument 4 to %02x specifier has type 'char' Signed-off-by: M

[PATCH 3/6] [media] mceusb: use %*ph for small buffer dumps

2016-03-06 Thread Mauro Carvalho Chehab
cifier has type 'char' Signed-off-by: Mauro Carvalho Chehab --- drivers/media/rc/mceusb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index 2cdb740cde48..35155ae500c7 100644 --- a/drivers/media/rc/mceusb.c

[PATCH 5/6] [media] touptek: don't DMA at the stack

2016-03-06 Thread Mauro Carvalho Chehab
usb_buf instead. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/gspca/touptek.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/gspca/touptek.c b/drivers/media/usb/gspca/touptek.c index 7bac6bc96063..8063b8e45ee5 100644 --- a/drivers/media/usb

[PATCH 2/6] [media] ddcore: avoid endless loop if readl() fails

2016-03-06 Thread Mauro Carvalho Chehab
really bad happens and readl() fails. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/ddbridge/ddbridge-core.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/media/pci/ddbridge/ddbridge-core.c b/drivers/media/pci/ddbridge/ddbridge-core.c

[PATCH 1/6] [media] mantis: check for errors on readl inside loop

2016-03-06 Thread Mauro Carvalho Chehab
wrong is happening. While here, remove two defines that are only used once. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/mantis/mantis_common.h | 7 ++- drivers/media/pci/mantis/mantis_uart.c | 4 ++-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 4/6] [media] st-rc: prevent a endless loop

2016-03-06 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop depends on readl() succeeding as readl() might fail, with likely means some unrecovered error, let's loop only if it succeeds. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/rc/st_rc.

Re: Kernel docs: muddying the waters a bit

2016-03-07 Thread Mauro Carvalho Chehab
Em Mon, 7 Mar 2016 09:48:26 +0100 Johannes Stezenbach escreveu: > On Mon, Mar 07, 2016 at 12:29:08AM +0100, Johannes Stezenbach wrote: > > On Sat, Mar 05, 2016 at 11:29:37PM -0300, Mauro Carvalho Chehab wrote: > > > > > > I converted one of the big tables to CSV.

Re: Kernel docs: muddying the waters a bit

2016-03-07 Thread Mauro Carvalho Chehab
Em Mon, 7 Mar 2016 00:29:08 +0100 Johannes Stezenbach escreveu: > On Sat, Mar 05, 2016 at 11:29:37PM -0300, Mauro Carvalho Chehab wrote: > > > > I converted one of the big tables to CSV. At least now it recognized > > it as a table. Yet, the table was very badly formate

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Mauro Carvalho Chehab
Em Tue, 08 Mar 2016 11:49:35 +0200 Jani Nikula escreveu: > On Tue, 08 Mar 2016, Dan Allen wrote: > > One of the key goals of the Asciidoctor project is to be able to directly > > produce a wide variety of outputs from the same source (without DocBook). > > We've added flexibility and best practi

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Mauro Carvalho Chehab
Em Tue, 08 Mar 2016 05:09:40 -0700 Dan Allen escreveu: > Jani wrote: > > > there was no support for chunked, or split > > to chapters, HTML, and the single page result was simply way too big. > > > > That's not entirely true. First, you can pre-split at the source level > using includes and g

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Mauro Carvalho Chehab
Em Tue, 08 Mar 2016 05:13:13 -0700 Dan Allen escreveu: > On Tue, Mar 8, 2016 at 4:29 AM, Mauro Carvalho Chehab < > mche...@osg.samsung.com> wrote: > > > pandoc did a really crap job on the conversion. To convert this > > into something useful, we'll need to

Re: Kernel docs: muddying the waters a bit

2016-03-08 Thread Mauro Carvalho Chehab
Em Tue, 8 Mar 2016 10:39:22 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 08 Mar 2016 05:13:13 -0700 > Dan Allen escreveu: > > > On Tue, Mar 8, 2016 at 4:29 AM, Mauro Carvalho Chehab < > > mche...@osg.samsung.com> wrote: > > > > > pandoc d

Re: Kernel docs: muddying the waters a bit

2016-03-09 Thread Mauro Carvalho Chehab
Em Tue, 8 Mar 2016 12:39:21 -0300 Mauro Carvalho Chehab escreveu: > Pandoc failed to fully convert it, but at least it left all the texts, > with prevented rewriting it from scratch. This is the manual fix > I applied to it: > > https://git.linuxtv.org/mchehab/asciidoc-poc.

Re: Kernel docs: muddying the waters a bit

2016-03-10 Thread Mauro Carvalho Chehab
Em Thu, 10 Mar 2016 12:25:58 +0200 Jani Nikula escreveu: > TL;DR? Skip to the last paragraph. > > On Wed, 09 Mar 2016, Mauro Carvalho Chehab wrote: > > I guess the conversion to asciidoc format is now in good shape, > > at least to demonstrate that it is possible to us

Re: [PATCH] media: fix !CONFIG_MEDIA_CONTROLLER compile error for v4l_change_media_source()

2016-03-10 Thread Mauro Carvalho Chehab
Em Thu, 10 Mar 2016 07:50:22 -0700 Shuah Khan escreveu: > This error is a result of not defining v4l_change_media_source() stub > in include/media/v4l2-mc.h for !CONFIG_MEDIA_CONTROLLER case. > > Fix the following compile error: > > url: > https://github.com/0day-ci/linux/commits/Shuah-Khan

Re: [PATCH] Revert "[media] au0828: use v4l2_mc_create_media_graph()"

2016-03-10 Thread Mauro Carvalho Chehab
Em Thu, 10 Mar 2016 09:16:30 -0700 Shuah Khan escreveu: > On 03/08/2016 08:26 PM, Shuah Khan wrote: > > This reverts commit 9822f4173f84cb7c592edb5e1478b7903f69d018. > > This commit breaks au0828_enable_handler() logic to find the tuner. > > Audio, Video, and Digital applications are broken and f

[PATCH] [media] au0828: disable tuner->decoder on init

2016-03-10 Thread Mauro Carvalho Chehab
As au0828 assumes that all links to ATV decoder and DTV demod should be disabled, make sure this is the case. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/au0828/au0828-core.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/media

[PATCH 1/2] [media] au0828: disable tuner links and cache tuner/decoder

2016-03-11 Thread Mauro Carvalho Chehab
For au0828_enable_source() to work, the tuner links should be disabled and the tuner/decoder should be cached at au0828 struct. Fixes: 9822f4173f84 ('[media] au0828: use v4l2_mc_create_media_graph()') Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/au0828/au0828-c

[PATCH 2/2] [media] v4l2-mc: cleanup a warning

2016-03-11 Thread Mauro Carvalho Chehab
A previous patch removing dtv_demod needed to be rebased, but the hunk removing the data was not merged by mistake. Fixes: 840f5b0572ea ('media: au0828 disable tuner to demod link in au0828_media_device_register()'] Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l

Re: [PATCH] [media] au0828: disable tuner->decoder on init

2016-03-11 Thread Mauro Carvalho Chehab
Em Thu, 10 Mar 2016 14:56:30 -0700 Shuah Khan escreveu: > On 03/10/2016 12:57 PM, Mauro Carvalho Chehab wrote: > > As au0828 assumes that all links to ATV decoder and DTV demod > > should be disabled, make sure this is the case. > > > > Signed-off-by: Mauro Carvalho C

Re: [PATCH 1/2] [media] au0828: disable tuner links and cache tuner/decoder

2016-03-11 Thread Mauro Carvalho Chehab
Em Fri, 11 Mar 2016 09:27:40 -0700 Shuah Khan escreveu: > On 03/11/2016 08:55 AM, Mauro Carvalho Chehab wrote: > > For au0828_enable_source() to work, the tuner links should be > > disabled and the tuner/decoder should be cached at au0828 struct. > > hmm. are you sure a

[PATCH 1/2 v2] [media] au0828: disable tuner links and cache tuner/decoder

2016-03-11 Thread Mauro Carvalho Chehab
Fixes: 9822f4173f84 ('[media] au0828: use v4l2_mc_create_media_graph()') Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/au0828/au0828-cards.c | 4 drivers/media/usb/au0828/au0828-core.c | 42 + 2 files changed, 27 insertions(+), 19 deletions(

[GIT PULL for v4.4-rc8 or v4.5] media fixes

2016-03-11 Thread Mauro Carvalho Chehab
Mauro Carvalho Chehab (1): [media] media-device: map new functions into old types for legacy API drivers/media/media-device.c | 23 +++ include/uapi/linux/media.h | 6 +- 2 files changed, 28 insertions(+), 1

Re: Can you look at this daily build warning?

2016-03-13 Thread Mauro Carvalho Chehab
Em Sun, 13 Mar 2016 08:59:38 +0100 Hans Verkuil escreveu: > Hi Shuah, > > I am getting this warning since commit > 840f5b0572ea9ddaca2bf5540a171013e92c97bd > (media: au0828 disable tuner to demod link in au0828_media_device_register()). > > Can you take a look? > > I'm not sure whether the dt

Re: [PATCH] media: add dump_stack() if called in atomic context

2016-03-13 Thread Mauro Carvalho Chehab
Em Sat, 12 Mar 2016 17:37:05 -0700 Shuah Khan escreveu: > Change media_add_link() and media_devnode_create() to dump_stack when > called in atomic context. > > Signed-off-by: Shuah Khan > Suggested-by: Mauro Carvalho Chehab Just to be clear: my suggestion is to use this in or

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-13 Thread Mauro Carvalho Chehab
n. > > tree-wide driver changes for media_*() GFP flags change: > Change drivers to add gfpflags to interffaces, media_create_pad_link(), > media_create_intf_link() and media_devnode_create(). > > Signed-off-by: Shuah Khan > Suggested-by: Mauro Carvalho Chehab Patches

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Mauro Carvalho Chehab
link() and media_devnode_create(). > > > > Signed-off-by: Shuah Khan > > Suggested-by: Mauro Carvalho Chehab > > What's the use case for calling the above functions in an atomic context? > ALSA code seems to do a lot of stuff at atomic context. That

Re: Any reason why media_entity_pads_init() isn't void?

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 09:25:51 +0100 Hans Verkuil escreveu: > I was fixing a sparse warning in media_entity_pads_init() and I noticed that > that > function always returns 0. Any reason why this can't be changed to a void > function? > > That return value is checked a zillion times in the media

Re: Any reason why media_entity_pads_init() isn't void?

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 12:36:44 +0200 Sakari Ailus escreveu: > Hi Hans, > > On Mon, Mar 14, 2016 at 09:25:51AM +0100, Hans Verkuil wrote: > > I was fixing a sparse warning in media_entity_pads_init() and I noticed > > that that function always returns 0. Any reason why this can't be changed > > to

Re: [PATCH] media: v4l2-compat-ioctl32: fix missing reserved field copy in put_v4l2_create32

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 18:41:46 +0800 Tiffany Lin escreveu: > Change-Id: Idac449fae5059a3ce255340e6da491f8bd83af7a We don't need change-id at the Kernel, but we do need a proper patch description. Regards, Mauro > --- > drivers/media/v4l2-core/v4l2-compat-ioctl32.c |3 ++- > 1 file changed,

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 12:52:54 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Mar 14, 2016 at 07:13:58AM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 09:22:37 +0200 > > Sakari Ailus escreveu: > > > > > Hi Shuah, > > > > >

Re: Any reason why media_entity_pads_init() isn't void?

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 13:43:33 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Mar 14, 2016 at 08:27:38AM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 12:36:44 +0200 > > Sakari Ailus escreveu: > > > > > Hi Hans, > > > > &g

Re: Any reason why media_entity_pads_init() isn't void?

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 08:52:51 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 14 Mar 2016 13:43:33 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Mon, Mar 14, 2016 at 08:27:38AM -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 14 Mar 20

Re: [PATCH v3 2/9] [media] tvp5150: add userspace subdev API

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 16:23:30 +0100 Lucas Stach escreveu: > From: Philipp Zabel > > This patch adds userspace V4L2 subdevice API support. > > Signed-off-by: Philipp Zabel > Signed-off-by: Lucas Stach > --- > drivers/media/i2c/tvp5150.c | 282 > +++- >

Re: Any reason why media_entity_pads_init() isn't void?

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 10:05:01 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 14 Mar 2016 08:52:51 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Mon, 14 Mar 2016 13:43:33 +0200 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > > >

[PATCH] [media] media-device: Don't call notify callbacks holding a spinlock

2016-03-14 Thread Mauro Carvalho Chehab
evice_register_entity+0x3ab/0x700 [media] Tested with an HVR-950Q, under the following testcases: 1) load au0828 driver first, and then snd-usb-audio; 2) load snd-usb-audio driver first, and then au0828; 3) loading both drivers, and then connecting the device. Signed-off-by: Mauro Carvalho Cheha

[PATCH v2] [media] media-device: Don't call notify callbacks holding a spinlock

2016-03-14 Thread Mauro Carvalho Chehab
evice_register_entity+0x3ab/0x700 [media] Tested with an HVR-950Q, under the following testcases: 1) load au0828 driver first, and then snd-usb-audio; 2) load snd-usb-audio driver first, and then au0828; 3) loading both drivers, and then connecting the device. Signed-off-by: Mauro Carvalh

[GIT PULL for v4.6-rc1] media updates

2016-03-15 Thread Mauro Carvalho Chehab
T bandwidth auto mode Matthieu Rogez (3): [media] em28xx: add support for Terratec Grabby REC button [media] em28xx: add support for Terratec Grabby Record led [media] em28xx: fix Terratec Grabby AC97 codec detection Mauro Carvalho Chehab (95): Merge tag 'v4.5-rc1'

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-15 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 14:09:09 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Mon, Mar 14, 2016 at 08:46:33AM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 12:52:54 +0200 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > > >

Re: [PATCH] sound/usb: fix to release stream resources from media_snd_device_delete()

2016-03-18 Thread Mauro Carvalho Chehab
Em Fri, 18 Mar 2016 20:50:31 -0600 Shuah Khan escreveu: > Fix to release stream resources from media_snd_device_delete() before > media device is unregistered. Without this change, stream resource free > is attempted after the media device is unregistered which would result > in use-after-free er

[PATCH v2] [media] media-device: use kref for media_device instance

2016-03-18 Thread Mauro Carvalho Chehab
Now that the media_device can be used by multiple drivers, via devres, we need to be sure that it will be dropped only when all drivers stop using it. Signed-off-by: Mauro Carvalho Chehab --- v2: The kref is now used only when media_device is allocated via the media_device*_devress. This

Re: [PATCH 4/5] [media] media-device: use kref for media_device instance

2016-03-19 Thread Mauro Carvalho Chehab
Em Thu, 17 Mar 2016 13:50:53 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Wed, Mar 16, 2016 at 09:04:05AM -0300, Mauro Carvalho Chehab wrote: > > Now that the media_device can be used by multiple drivers, > > via devres, we need to be sure that it will be dropped only

[PATCH 2/2] [media] media-device: make topology_version u64

2016-03-19 Thread Mauro Carvalho Chehab
The uAPI defines it with 64 bits. Let's change the Kernel implementation too. Signed-off-by: Mauro Carvalho Chehab --- include/media/media-device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/media/media-device.h b/include/media/media-device.h index 9166bff

Re: [PATCH] [media] media: rename media unregister function

2016-03-19 Thread Mauro Carvalho Chehab
Em Fri, 18 Mar 2016 16:20:19 +0200 Sakari Ailus escreveu: > Shuah Khan wrote: > > On 03/18/2016 08:12 AM, Javier Martinez Canillas wrote: > >> Hello Shuah, > >> > >> On 03/18/2016 11:01 AM, Shuah Khan wrote: > >>> On 03/18/2016 07:05 AM

Re: [PATCH 4/5] [media] media-device: use kref for media_device instance

2016-03-19 Thread Mauro Carvalho Chehab
Em Wed, 16 Mar 2016 08:05:15 -0600 Shuah Khan escreveu: > On 03/16/2016 06:04 AM, Mauro Carvalho Chehab wrote: > > Now that the media_device can be used by multiple drivers, > > via devres, we need to be sure that it will be dropped only > > when all drivers stop using it. &

Re: [PATCH] media: fix media_device_unregister() to destroy media device device resource

2016-03-19 Thread Mauro Carvalho Chehab
Em Thu, 17 Mar 2016 16:46:36 -0600 Shuah Khan escreveu: > When all drivers except usb-core driver is unbound, destroy the media device > resource. Other wise, media device resource will persist in a defunct state. > This leads to use-after-free and bad access errors during a subsequent bind. > Fi

Re: [PATCH 1/5] [media] media-device: get rid of the spinlock

2016-03-19 Thread Mauro Carvalho Chehab
Em Wed, 16 Mar 2016 09:53:12 -0300 Javier Martinez Canillas escreveu: > Hello Mauro, > > On Wed, Mar 16, 2016 at 9:04 AM, Mauro Carvalho Chehab > wrote: > > Right now, the lock schema for media_device struct is messy, > > since sometimes, it is protected via a spin lo

Re: [PATCH] sound/usb: fix to release stream resources from media_snd_device_delete()

2016-03-19 Thread Mauro Carvalho Chehab
Em Fri, 18 Mar 2016 23:57:08 -0300 Mauro Carvalho Chehab escreveu: > Em Fri, 18 Mar 2016 20:50:31 -0600 > Shuah Khan escreveu: > > > Fix to release stream resources from media_snd_device_delete() before > > media device is unregistered. Without this change, stream

[PATCH 1/2] sound/usb/media: use core routine to initialize media_device

2016-03-19 Thread Mauro Carvalho Chehab
some other driver, like au0828. Signed-off-by: Mauro Carvalho Chehab --- sound/usb/media.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/sound/usb/media.c b/sound/usb/media.c index 93a50d01490c..44a5de91f748 100644 --- a/sound/usb/media.c +++ b/sound/usb

Re: [PATCH] sound/usb: fix to release stream resources from media_snd_device_delete()

2016-03-19 Thread Mauro Carvalho Chehab
nd/unbind, it seems to be working fine. Also for driver's rmmod, so: Tested-by: Mauro Carvalho Chehab PS.: === There are still some troubles if we run an infinite loop binding/unbinding au0828 and another one binding/unbinding snd-usb-audio, like this one: [ 91.556188] [ cut here ]

[PATCH 2/5] [media] media-device: Fix a comment

2016-03-19 Thread Mauro Carvalho Chehab
The comment is for the wrong function. Fix it. Signed-off-by: Mauro Carvalho Chehab --- include/media/media-device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/media/media-device.h b/include/media/media-device.h index 0c2de97181f3..ca3871b853ba 100644 --- a

[PATCH] [media] media: rename media unregister function

2016-03-19 Thread Mauro Carvalho Chehab
Now that media_device_unregister() also does a cleanup, rename it to media_device_unregister_cleanup(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/siano/smsdvb-main.c | 2 +- drivers/media/media-device.c | 4 ++-- drivers/media/pci/saa7134

[PATCH 1/5] [media] media-device: get rid of the spinlock

2016-03-19 Thread Mauro Carvalho Chehab
atomic context. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/media-device.c | 32 ++-- drivers/media/media-entity.c | 16 include/media/media-device.h | 6 +- 3 files changed, 23 insertions(+), 31 deletions(-) diff --git a/drivers

[PATCH 3/5] [media] au0828: Unregister notifiers

2016-03-19 Thread Mauro Carvalho Chehab
If au0828 gets removed, we need to remove the notifiers. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/au0828/au0828-core.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers

[PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-19 Thread Mauro Carvalho Chehab
that media_device_unregister() will do the right thing, if the media device is not fully initialized. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/siano/smsdvb-main.c | 1 - drivers/media/media-device.c | 13 ++--- drivers/media/pci/saa7134/saa7134-core.c

Re: [PATCH] [media] media-device: Don't call notify callbacks holding a spinlock

2016-03-19 Thread Mauro Carvalho Chehab
Em Thu, 17 Mar 2016 13:38:56 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Monday 14 March 2016 16:16:29 Mauro Carvalho Chehab wrote: > > The notify routines may sleep. So, they can't be called in spinlock > > context. Also, they may want to call other media

[PATCH 4/5] [media] media-device: use kref for media_device instance

2016-03-19 Thread Mauro Carvalho Chehab
Now that the media_device can be used by multiple drivers, via devres, we need to be sure that it will be dropped only when all drivers stop using it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/media-device.c | 48 +++- include/media/media

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-19 Thread Mauro Carvalho Chehab
Em Wed, 16 Mar 2016 10:28:35 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Mar 15, 2016 at 12:55:35PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 14:09:09 +0200 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > ...

Re: [PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-20 Thread Mauro Carvalho Chehab
Em Wed, 16 Mar 2016 11:03:38 -0300 Javier Martinez Canillas escreveu: > Hello Mauro, > > The patch looks mostly good to me, I just have a question below: > > On Wed, Mar 16, 2016 at 9:04 AM, Mauro Carvalho Chehab > wrote: > > [snip] > > > > > -void m

Re: cron job: media_tree daily build: OK

2016-03-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Mar 2016 05:05:07 +0100 "Hans Verkuil" escreveu: > This message is generated daily by a cron job that builds media_tree for > the kernels and architectures in the list below. > > Results of the daily build of media_tree: > > date: Mon Mar 21 04:00:22 CET 2016 > git branch:

Re: cron job: media_tree daily build: OK

2016-03-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Mar 2016 06:57:08 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 21 Mar 2016 05:05:07 +0100 > "Hans Verkuil" escreveu: > > > This message is generated daily by a cron job that builds media_tree for > > the kernels and architectures in the list below

Re: [PATCH v2] [media] media-device: use kref for media_device instance

2016-03-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Mar 2016 13:10:33 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday 18 Mar 2016 21:42:16 Mauro Carvalho Chehab wrote: > > Now that the media_device can be used by multiple drivers, > > via devres, we need to be sure t

Re: [PATCH] drivers/media/rc: postpone kfree(rc_dev)

2016-03-21 Thread Mauro Carvalho Chehab
Hi Max, Em Mon, 21 Mar 2016 12:33:05 +0100 Max Kellermann escreveu: > CONFIG_DEBUG_KOBJECT_RELEASE found this bug. Please, always send us your Signed-off-by on your patches, as described at: https://linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Developer.27s_Certificate_of

Re: [PATCH] drivers/media/media-devnode: add missing mutex lock in error handler

2016-03-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Mar 2016 12:33:12 +0100 Max Kellermann escreveu: Please, always send us your Signed-off-by on your patches, as described at: https://linuxtv.org/wiki/index.php/Development:_Submitting_Patches#Developer.27s_Certificate_of_Origin_1.1 Also, please add a description to the patch

Re: [RFC PATCH 1/3] [media] v4l2-mc.h: Add a S-Video C input PAD to demod enum

2016-03-21 Thread Mauro Carvalho Chehab
Add a DEMOD_PAD_C_INPUT that can be used for this case and the existing > >> DEMOD_PAD_IF_INPUT can be used for either Composite or the Y signal. > >> > >> Suggested-by: Mauro Carvalho Chehab > >> Signed-off-by: Javier Martinez Canillas > >> > >> --- >

Re: [RFC PATCH 1/3] [media] v4l2-mc.h: Add a S-Video C input PAD to demod enum

2016-03-21 Thread Mauro Carvalho Chehab
Hi Hans, Em Mon, 21 Mar 2016 17:01:43 +0100 Hans Verkuil escreveu: > > A reasonable solution to simplify converting legacy drivers without creating > > these global ugly pad indices is to add a new video (and probably audio) op > > 'g_pad_of_type(type)' where you ask the subdev entity to return

Re: [RFC PATCH 1/3] [media] v4l2-mc.h: Add a S-Video C input PAD to demod enum

2016-03-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Mar 2016 19:08:32 +0100 Hans Verkuil escreveu: > On 03/21/2016 06:50 PM, Mauro Carvalho Chehab wrote: > > Hi Hans, > > > > Em Mon, 21 Mar 2016 17:01:43 +0100 > > Hans Verkuil escreveu: > > > >>> A reasonable solution to simplify conv

Re: [RFC PATCH 1/3] [media] v4l2-mc.h: Add a S-Video C input PAD to demod enum

2016-03-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Mar 2016 15:24:00 -0300 Javier Martinez Canillas escreveu: > Hello Hans, > > On 03/21/2016 03:08 PM, Hans Verkuil wrote: > > On 03/21/2016 06:50 PM, Mauro Carvalho Chehab wrote: > >> Hi Hans, > >> > >> Em Mon, 21 Mar 2016 17:01:43 +0100

Re: [RFC PATCH 1/3] [media] v4l2-mc.h: Add a S-Video C input PAD to demod enum

2016-03-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Mar 2016 16:48:12 -0300 Javier Martinez Canillas escreveu: > Hello Hans, > > On 03/21/2016 04:30 PM, Hans Verkuil wrote: > > [snip] > > > Can you please provide an example of a media pipeline that user-space > should > use with this approach? AFAICT whatever PAD

Re: [RFC PATCH 1/3] [media] v4l2-mc.h: Add a S-Video C input PAD to demod enum

2016-03-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Mar 2016 16:20:09 -0300 Javier Martinez Canillas escreveu: > > BTW, if the tvp5150 needs to know which composite connector is connected > > to which hardware pin, then you still may need to be explicit w.r.t. the > > number of pads. I just thought of that. > > > > The tvp5150 doesn'

[PATCH] [media] au0828: Fix dev_state handling

2016-03-22 Thread Mauro Carvalho Chehab
The au0828 dev_state is actually a bit mask. It should not be checking with "==" but, instead, with a logic and. There are some places where it was doing it wrong. Fix that by replacing the dev_state set/clear/test with the bitops. Cc: sta...@vger.kernel.org Signed-off-by: Mauro Carva

Re: [PATCH] sound/usb: fix to release stream resources from media_snd_device_delete()

2016-03-22 Thread Mauro Carvalho Chehab
Em Tue, 22 Mar 2016 11:29:34 -0600 Shuah Khan escreveu: > On 03/22/2016 07:03 AM, Shuah Khan wrote: > > On 03/21/2016 10:01 PM, Shuah Khan wrote: > >> On 03/19/2016 07:31 AM, Shuah Khan wrote: > >>> On 03/19/2016 06:10 AM, Mauro Carvalho Chehab wrote: >

Re: [PATCH v5 1/2] media: Add obj_type field to struct media_entity

2016-03-23 Thread Mauro Carvalho Chehab
Em Wed, 23 Mar 2016 10:45:55 +0200 Laurent Pinchart escreveu: > Code that processes media entities can require knowledge of the > structure type that embeds a particular media entity instance in order > to cast the entity to the proper object type. This needs is shown by the > presence of the is_

Re: [PATCH v5 1/2] media: Add obj_type field to struct media_entity

2016-03-23 Thread Mauro Carvalho Chehab
Em Wed, 23 Mar 2016 15:05:41 +0100 Hans Verkuil escreveu: > On 03/23/2016 11:35 AM, Mauro Carvalho Chehab wrote: > > Em Wed, 23 Mar 2016 10:45:55 +0200 > > Laurent Pinchart escreveu: > > > >> Code that processes media entities can require knowledge of the >

Re: [PATCH v5 1/2] media: Add obj_type field to struct media_entity

2016-03-23 Thread Mauro Carvalho Chehab
Em Wed, 23 Mar 2016 15:57:10 +0100 Hans Verkuil escreveu: > On 03/23/2016 03:45 PM, Laurent Pinchart wrote: > > Hi Hans, > > > > On Wednesday 23 Mar 2016 15:05:41 Hans Verkuil wrote: > >> On 03/23/2016 11:35 AM, Mauro Carvalho Chehab wrote: > >>>

Re: [PATCH v5 1/2] media: Add obj_type field to struct media_entity

2016-03-23 Thread Mauro Carvalho Chehab
Em Wed, 23 Mar 2016 17:11:30 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Wednesday 23 Mar 2016 12:00:59 Mauro Carvalho Chehab wrote: > > Em Wed, 23 Mar 2016 15:05:41 +0100 Hans Verkuil escreveu: > > > On 03/23/2016 11:35 AM, Mauro Carvalho Chehab wrote: >

Re: [PATCH v5 1/2] media: Add obj_type field to struct media_entity

2016-03-23 Thread Mauro Carvalho Chehab
Em Wed, 23 Mar 2016 18:17:38 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Wed, Mar 23, 2016 at 12:00:59PM -0300, Mauro Carvalho Chehab wrote: > > Em Wed, 23 Mar 2016 15:05:41 +0100 > > Hans Verkuil escreveu: > > > > > On 03/23/2016 11:35 AM, Mauro Car

Re: [PATCH v5 1/2] media: Add obj_type field to struct media_entity

2016-03-23 Thread Mauro Carvalho Chehab
Em Wed, 23 Mar 2016 18:30:47 +0200 Laurent Pinchart escreveu: > On Wednesday 23 Mar 2016 12:24:38 Mauro Carvalho Chehab wrote: > > Em Wed, 23 Mar 2016 17:11:30 +0200 Laurent Pinchart escreveu: > > > On Wednesday 23 Mar 2016 12:00:59 Mauro Carvalho Chehab wrote: > > &g

Re: [PATCH v5 1/2] media: Add obj_type field to struct media_entity

2016-03-23 Thread Mauro Carvalho Chehab
Em Wed, 23 Mar 2016 17:41:44 +0200 Laurent Pinchart escreveu: > On Wednesday 23 Mar 2016 12:17:30 Mauro Carvalho Chehab wrote: > > Em Wed, 23 Mar 2016 15:57:10 +0100 Hans Verkuil escreveu: > > > On 03/23/2016 03:45 PM, Laurent Pinchart wrote: > > >> On Wedne

<    2   3   4   5   6   7   8   9   10   11   >