Hi Laurent,
Thanks for reviewing it.
Em Wed, 23 Mar 2016 18:57:50 +0200
Laurent Pinchart escreveu:
> On Friday 18 Mar 2016 21:42:16 Mauro Carvalho Chehab wrote:
> > Now that the media_device can be used by multiple drivers,
> > via devres, we need to be sure that it will
Only MEDIA_IOC_ENUM_LINKS32 require an special logic when
userspace is 32 bits and Kernel is 64 bits.
For the rest, media_device_ioctl() will do the right thing,
and will return -ENOIOCTLCMD if the ioctl is unknown.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/media-device.c | 8
The comment there is not pertinent.
Fixes: 44ff16d0b7cc ("media-device: use kref for media_device instance")
Signed-off-by: Mauro Carvalho Chehab
Suggested-by: Laurent Pinchart
---
drivers/media/media-device.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/media-
even GPF.
Fix this by dynamically allocating the struct media_devnode and only
freeing it when it is safe.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/media-device.c | 38 ++
drivers/media/media-devnode.c | 7 ++-
drivers/medi
with au0828 and snd-usb-audio and the issues I was noticing
before it disappeared.
Shuah,
Could you please test it also?
Thanks!
Mauro
Mauro Carvalho Chehab (4):
[media] media-device: Simplify compat32 logic
[media] media-devnode: fix namespace mess
[media] media-device: get rid of a
very confusing and may lead to development errors.
So, let's change all occurrences at media-devnode.[ch] to
also use "devnode" for such pointers.
This patch doesn't make any functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/media-devnode.c | 110 +
Em Thu, 24 Mar 2016 10:24:44 +0200
Laurent Pinchart escreveu:
> On Wednesday 23 Mar 2016 16:27:46 Mauro Carvalho Chehab wrote:
> > struct media_devnode is currently embedded at struct media_device.
> >
> > While this works fine during normal usage, it leads to a race
Em Thu, 24 Mar 2016 10:50:06 +0200
Laurent Pinchart escreveu:
> Hello,
>
> This patch series adds an obj_type field to the media entity structure. It
> is a resend of v5 with the MEDIA_ENTITY_TYPE_INVALID type replaced by
> MEDIA_ENTITY_TYPE_BASE to identify media entity instances not embedded i
Em Thu, 24 Mar 2016 13:54:57 +0200
Laurent Pinchart escreveu:
> On Thursday 24 Mar 2016 08:38:40 Mauro Carvalho Chehab wrote:
> > Em Thu, 24 Mar 2016 10:50:06 +0200 Laurent Pinchart escreveu:
> > > Hello,
> > >
> > > This patch series adds an obj_type fie
for cdev or to dynamically allocate it. Let's choose the last one,
as this is the same solution at v4l2 core, from where this code seems
to have originated.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/media-devnode.c | 39 ++-
include/media/
Em Fri, 25 Mar 2016 00:22:42 +0200
Laurent Pinchart escreveu:
> Commit c38077d39c7e ("[media] media-device: get rid of the spinlock")
> introduced a deadlock in the MEDIA_IOC_ENUM_LINKS ioctl handler.
>
> Revert the broken commit as well as another that has been merged on top, and
> let's implem
Add a note at the headers telling that the link setup
callbacks are called with the mutex hold. Also, removes a
double lock at the PM suspend callbacks.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/media-device.c | 1 -
drivers/media/v4l2-core/v4l2-mc.c | 4
include/media
octl+0x24/0x3c
[ 2760.180671] [] do_vfs_ioctl+0xac/0x758
[ 2760.184026] [] SyS_ioctl+0x84/0x98
[ 2760.187196] [] el0_svc_naked+0x24/0x28
That's because find_entity() holds the graph_mutex, but both
MEDIA_IOC_ENUM_LINKS and MEDIA_IOC_SETUP_LINK logic also take
the mutex.
Reported-by: Laurent Pincha
Hi Shuah,
Em Mon, 28 Mar 2016 11:08:09 -0600
Shuah Khan escreveu:
> Hi Mauro/Javier,
>
> I can't figure out when au0828_v4l2_device_register() was added. Must be in
> Linux 4.5 as I can't find this change in Linux 4.4 This used to be a call to
> v4l2_device_register() from au0828_usb_probe(). W
Em Fri, 25 Mar 2016 22:38:45 -0600
Shuah Khan escreveu:
> Change au0828, uvcvideo, snd-usb-audio to use Media Device Allocator and
> new Media Controller API media_device_unregister_put().
>
> Signed-off-by: Shuah Khan
> ---
> drivers/media/usb/au0828/au0828-core.c | 7 +--
> drivers/medi
Em Fri, 25 Mar 2016 22:38:44 -0600
Shuah Khan escreveu:
> Add refcount to keep track of media device registrations to avoid release
> of media device when one of the drivers does unregister when media device
> belongs to more than one driver. Also add a new interfaces to unregister
> a media devi
Em Fri, 25 Mar 2016 22:38:43 -0600
Shuah Khan escreveu:
> Add Media Device Allocator API documentation.
Please merge this with the previous patch.
>
> Signed-off-by: Shuah Khan
> ---
> include/media/media-dev-allocator.h | 32
> 1 file changed, 32 insertions(
Hi Shuah,
I reviewed the entire patch series, but I'm adding the comments only here,
as the other patches are coherent with this one.
Em Fri, 25 Mar 2016 22:38:42 -0600
Shuah Khan escreveu:
> Add Media Device Allocator API to manage Media Device life time problems.
> There are known problems wi
Em Thu, 24 Mar 2016 21:45:03 +0100
Hans Verkuil escreveu:
> On 03/24/2016 08:59 PM, Mauro Carvalho Chehab wrote:
> > Currently, cdev is embedded inside media_devnode. This causes
> > a problem with the fs core, as __fput() will try to release
> > its acces
Em Mon, 28 Mar 2016 22:29:50 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Monday 28 Mar 2016 15:09:48 Mauro Carvalho Chehab wrote:
> > Em Fri, 25 Mar 2016 00:22:42 +0200 Laurent Pinchart escreveu:
> > > Commit c38077d39c7e ("[media] media-de
Em Tue, 29 Mar 2016 00:58:37 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> Please see the comments below.
>
> On Mon, Mar 28, 2016 at 03:11:03PM -0300, Mauro Carvalho Chehab wrote:
> > Remove two nested mutex left-overs at find_entity and make sure
> > that the code w
Em Tue, 29 Mar 2016 01:06:42 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> Please see my comments below.
>
> On Mon, Mar 28, 2016 at 03:11:04PM -0300, Mauro Carvalho Chehab wrote:
> > Add a note at the headers telling that the link setup
> > callbacks are calle
Em Tue, 29 Mar 2016 06:17:34 -0300
Mauro Carvalho Chehab escreveu:
> > > diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
> > > index 6cfa890af7b4..6af5e6932271 100644
> > > --- a/drivers/media/media-device.c
> > > +++ b/drivers/media
octl+0x24/0x3c
[ 2760.180671] [] do_vfs_ioctl+0xac/0x758
[ 2760.184026] [] SyS_ioctl+0x84/0x98
[ 2760.187196] [] el0_svc_naked+0x24/0x28
That's because find_entity() holds the graph_mutex, but both
MEDIA_IOC_ENUM_LINKS and MEDIA_IOC_SETUP_LINK logic also take
the mutex.
Reported-by: Laurent Pincha
Those callbacks are called with the media_device.graph_mutex hold.
Add a note about that, as the code called by those notifiers should
not be touching in the mutex.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/media-device.h | 3 ++-
include/media/media-entity.h | 3 +++
2 files
data with other drivers.
So, better to revert the changes.
This reverts commit 182dde7c5d4c ("[media] media: au0828 change
to use Managed Media Controller API")
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/usb/au0828/au0828-core.c | 3 ++-
1 file changed, 2 insertions(+),
revert it and fix the core before reapplying this
change.
This reverts commit aebb2b89bff0 ("[media] sound/usb: Use Media
Controller API to share media resources")'
Signed-off-by: Mauro Carvalho Chehab
---
sound/usb/Kconfig| 4 -
sound/usb/Makefile | 2 -
s
Hi Helen,
This is just a quick look on it. See below.
Em Fri, 1 Apr 2016 14:18:13 -0300
Helen Mae Koike Fornazier escreveu:
> The test pattern generator will be used by other drivers as the virtual
> media controller (vimc)
>
> Signed-off-by: Helen Mae Koike Fornazier
> ---
>
> The patch is
9:04 -0300)
media fixes for v4.6-rc2
--------
Mauro Carvalho Chehab (5):
[media] au0828: disable tuner links and cache tuner/decoder
[media] v4l2-mc: cleanup a warning
[med
Em Mon, 28 Mar 2016 15:34:15 -0600
Shuah Khan escreveu:
> On 03/28/2016 12:28 PM, Mauro Carvalho Chehab wrote:
> > Hi Shuah,
> >
> > I reviewed the entire patch series, but I'm adding the comments only here,
> > as the other patches are coherent wi
Em Mon, 28 Mar 2016 15:37:43 -0600
Shuah Khan escreveu:
> On 03/28/2016 12:28 PM, Mauro Carvalho Chehab wrote:
> > Em Fri, 25 Mar 2016 22:38:44 -0600
> > Shuah Khan escreveu:
> >
> >> Add refcount to keep track of media device registrations to avoid release
&g
Em Wed, 6 Apr 2016 01:14:11 +0900
escreveu:
> From: Буди Романто, AreMa Inc
You should, instead, add the stuff you need to the existing drivers and not
remove them.
> Obsoleted & superseded, please read cover letter for details.
Cover letter is not stored at the git history. So, it should be
Em Wed, 6 Apr 2016 01:14:14 +0900
escreveu:
> From: Буди Романто, AreMa Inc
>
> Bridge driver for Earthsoft PT3, PLEX PX-Q3PE ISDB-S/T PCIE cards & PX-BCUD
> ISDB-S USB dongle.
> Including simplified Nagahama's patch for PLEX PX-BCUD (ISDB-S usb dongle)...
> Please read cover letter for detail
Em Tue, 5 Apr 2016 08:10:11 +0200
Takashi Iwai escreveu:
> On Tue, 05 Apr 2016 05:35:55 +0200,
> Shuah Khan wrote:
> >
> > There are known problems with media device life time management. When media
> > device is released while an media ioctl is in progress, ioctls fail with
> > use-after-free e
h_notify+0x173/0x360 [au0828]
[] ? media_gobj_create+0x1ba/0x480 [media]
[] media_device_register_entity+0x3ab/0x700 [media]
Reviewed-by: Javier Martinez Canillas
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/media-device.c | 39 +---
Those callbacks are called with the media_device.graph_mutex hold.
Add a note about that, as the code called by those notifiers should
not be touching in the mutex.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
---
include/media/media-device.h | 3 ++-
include/media/media
Hi Russel,
Em Sat, 26 Mar 2016 06:13:08 +
Russel Winder escreveu:
> I hadn't noticed previously, but it has been brought to my attention
> that libdvbv5 is licenced as GPLv2. This makes it impossible
> (effectively) for any non-GPL code to make use of libdvbv5. This seems
> to undermine the
ways false condition.
Fixes: c1ac057173ba "[media] exynos-gsc: remove non-device-tree init code"
Cc: Sylwester Nawrocki
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/exynos-gsc/gsc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/me
Em Mon, 21 Mar 2016 09:47:59 +0100
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Instead of a big if at the beginning, just check if g_selection == NULL
> and call the cropcap op immediately and return the result.
>
> No functional changes in this patch.
Hmm... not true. See below.
>
> Si
Instead of returning -1, return valid error codes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/usb/cx231xx/cx231xx-417.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c
b/drivers/media/usb/cx231xx
Instead of returning -1, return valid error codes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/usb/cx231xx/cx231xx-417.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c
b/drivers/media/usb/cx231xx
manager in the
WPF")
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/vsp1/vsp1_drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/vsp1_drm.c
b/drivers/media/platform/vsp1/vsp1_drm.c
index 22f67360b750..1f08da4b933b 100644
Em Wed, 13 Apr 2016 23:51:45 +0200
Hans Verkuil escreveu:
> On 04/13/2016 09:57 PM, Mauro Carvalho Chehab wrote:
> > Em Mon, 21 Mar 2016 09:47:59 +0100
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> Instead of a big if at
Em Thu, 14 Apr 2016 10:31:20 -0600
Shuah Khan escreveu:
> media_dev alloc error path does kfree when alloc fails. Fix it to not call
> kfree when media_dev alloc fails.
No need. kfree(NULL) is OK.
Adding a label inside a conditional block is ugly.
>
> Signed-off-by: Shuah Khan
> ---
> driv
Em Thu, 14 Apr 2016 16:18:17 -0600
Shuah Khan escreveu:
> On 04/14/2016 03:08 PM, Mauro Carvalho Chehab wrote:
> > Em Thu, 14 Apr 2016 10:31:20 -0600
> > Shuah Khan escreveu:
> >
> >> media_dev alloc error path does kfree when alloc fails. Fix it to not call
&
Em Mon, 18 Apr 2016 10:10:17 +0200
Markus Heiser escreveu:
> Hi Mauro, hi kernel-doc authors,
>
> Am 12.04.2016 um 15:58 schrieb Mauro Carvalho Chehab
> :
>
> > Em Fri, 8 Apr 2016 17:12:27 +0200
> > Markus Heiser escreveu:
> >
> >> Hi kernel-do
Em Wed, 13 Apr 2016 16:40:55 +0100
Russel Winder escreveu:
> On Tue, 2016-04-12 at 11:19 -0300, Mauro Carvalho Chehab wrote:
> […]
>
> > Yes. We had some discussions in the past to re-license it to LGPL,
> > if this is going to be used by some other OSS project that would
&
2016 – San Diego
===
Attendees list:
Mauro Carvalho Chehab (Samsung)
Lars-Peter Clausen (Analog Devices)
Magnus Damm (Renesas)
Shuah Khan (Samsung)
Guennadi Liakhovetski (Intel)
Kuninori Morimoto (Renesas)
Benoit Parrot (Texas Instruments)
Laurent Pin
Em Wed, 20 Apr 2016 07:33:17 -0300
Mauro Carvalho Chehab escreveu:
> This is the draft of the media summit report. I'll be soon posting an online
> version of it, with the group photo, at linuxtv.org.
>
> Please review. Also, for the ones that presented a slide deck there, ple
Em Wed, 20 Apr 2016 08:45:51 -0300
Mauro Carvalho Chehab escreveu:
> Em Wed, 20 Apr 2016 07:33:17 -0300
> Mauro Carvalho Chehab escreveu:
>
> > This is the draft of the media summit report. I'll be soon posting an online
> > version of it, with the group photo, at li
able]
u32 requests;
^
Use the cache instead, as it seems reading it needs to be done
with spin lock taken.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/tw686x-kh/tw686x-kh-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/tw686x-kh/
Em Thu, 21 Apr 2016 11:15:16 +0200
Ricardo Ribalda Delgado escreveu:
> When using a device is read/write mode, vb2 does not handle properly the
> first select/poll operation. It allways return POLLERR.
>
> The reason for this is that when this code has been refactored, some of
> the operations h
Em Fri, 22 Apr 2016 11:19:09 +0200
Hans Verkuil escreveu:
> Hi Ricardo,
>
> On 04/21/2016 11:15 AM, Ricardo Ribalda Delgado wrote:
> > When using a device is read/write mode, vb2 does not handle properly the
> > first select/poll operation. It allways return POLLERR.
> >
> > The reason for this
Em Wed, 20 Apr 2016 14:48:10 -0600
Shuah Khan escreveu:
> media_open() releases media_devnode_lock before open is complete. Hold
> the lock to call mdev->fops->open and release at the end.
This patch looks scary on my eyes, as it has potential of causing
dead locks, if the code, depending on the
Em Thu, 21 Apr 2016 03:40:26 +0300
Laurent Pinchart escreveu:
> The meta-data video device is used to transfer meta-data between
> userspace and kernelspace through a V4L2 buffers queue. It comes with a
> new meta-data capture capability, buffer type and format description.
Thanks for the patch.
Em Fri, 22 Apr 2016 09:46:04 +0200
Hans Verkuil escreveu:
> On 04/21/2016 09:15 PM, Laurent Pinchart wrote:
> > Hi Hans,
> >
> > Thank you for the review.
> >
> > On Thursday 21 Apr 2016 08:39:59 Hans Verkuil wrote:
> >> Hi Laurent,
> >>
> >> Thanks for the patch!
> >>
> >> Some, mostly small
Em Fri, 22 Apr 2016 14:37:07 +0200
Hans Verkuil escreveu:
> On 04/22/2016 02:31 PM, Mauro Carvalho Chehab wrote:
> > Em Fri, 22 Apr 2016 11:19:09 +0200
> > Hans Verkuil escreveu:
> >
> >> Hi Ricardo,
> >>
> >> On 04/21/2016 11:15 AM, Ricardo Ri
Em Fri, 22 Apr 2016 16:01:35 +0200
Hans Verkuil escreveu:
> > + * %VFL_TYPE_META - Meta-data (including statistics)
>
> I would drop the '(including statistics)' part. It feels weird that
> 'statistics' are singled out, it makes the reader wonder what is so
> spec
Em Fri, 22 Apr 2016 10:26:37 +0200
Hans Verkuil escreveu:
> Hi Nick,
>
> On 04/21/2016 11:31 AM, Nick Dyer wrote:
> > This is a series of patches to add diagnostic data support to the Atmel
> > maXTouch driver. It's a rewrite of the previous implementation which output
> > via
> > debugfs: it n
Em Fri, 22 Apr 2016 16:31:28 +0200
Hans Verkuil escreveu:
> On 04/22/2016 04:21 PM, Mauro Carvalho Chehab wrote:
> > Em Fri, 22 Apr 2016 14:37:07 +0200
> > Hans Verkuil escreveu:
> >
> >> On 04/22/2016 02:31 PM, Mauro Carvalho Chehab wrote:
> >&
Em Fri, 22 Apr 2016 16:56:00 +0200
Hans Verkuil escreveu:
> On 04/22/2016 04:48 PM, Mauro Carvalho Chehab wrote:
> > Em Fri, 22 Apr 2016 16:31:28 +0200
> > Hans Verkuil escreveu:
> >
> >> On 04/22/2016 04:21 PM, Mauro Carvalho Chehab wrote:
> >&
Em Fri, 22 Apr 2016 17:18:24 +0200
Hans Verkuil escreveu:
> On 04/22/2016 05:07 PM, Nick Dyer wrote:
> > On 22/04/2016 15:45, Mauro Carvalho Chehab wrote:
> >> Em Fri, 22 Apr 2016 10:26:37 +0200
> >> Hans Verkuil escreveu:
> >>> On 04/21/2016 11:31
Em Fri, 22 Apr 2016 18:45:41 +0200
Hans Verkuil escreveu:
> On 04/22/2016 05:21 PM, Mauro Carvalho Chehab wrote:
> > Em Fri, 22 Apr 2016 16:56:00 +0200
> > Hans Verkuil escreveu:
> >
> >> On 04/22/2016 04:48 PM, Mauro Carvalho Chehab wrote:
> >&
currently
hardcodes the framerate to 30 frames/sec, however a potential
use after the array size could happen when the driver adds support
for setting the framerate. So, fix it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/pci/tw686x/tw686x-video.c | 15 +--
1 file c
Em Mon, 25 Apr 2016 11:14:27 +0200
Hans Verkuil escreveu:
> Hi Mauro,
>
> Here are various fixes for 4.7.
>
> Note that I chose to go with my tw686x patches instead of yours
> (https://patchwork.linuxtv.org/patch/33991/).
Your patch caused this new smatch warning:
drivers/media/pci/tw6
Wunused-variable]
int status;
^
drivers/media/pci/sta2x11/sta2x11_vip.c:447:14: warning: unused variable
'oldstd' [-Wunused-variable]
v4l2_std_id oldstd = vip->std;
^
Remove them.
Fixes: 7b9f31f3b3ca ("[media] sta2x11_vip: fix s_std")
Signed-off-by:
entry_SYSCALL_64_fastpath+0x13/0x94
[2.790008] ---[ end trace c78a74e78baec6fc ]---
So, allocate the structure dynamically.
Cc: sta...@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab
---
The original patch failed to apply on Kernel 4.9, due to a trivial change
inside an error me
Hi Alan,
Em Fri, 17 Feb 2017 16:55:17 +
Alan Cox escreveu:
Thanks for the driver. Unfortunately, we missed the initial post at linux-media,
because VGER doesn't accept too big posts :-(
> This patch adds support for the Intel IPU v2 as found on Android and IoT
> Baytrail-T and Baytrail-CR p
Em Wed, 8 Mar 2017 14:55:44 +0100
Hans Verkuil escreveu:
> On 08/03/17 14:45, Hans Verkuil wrote:
> > On 08/03/17 14:39, Greg KH wrote:
> >> On Wed, Mar 08, 2017 at 01:49:23PM +0100, Hans Verkuil wrote:
> >>> OK, so I discovered that these patches are for a driver added to
> >>> linux-next
>
Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
tags/media/v4.11-2
For media regression fixes:
- serial_ir: fix a Kernel crash during boot on Kernel 4.11-rc1, due
to an IRQ code called too early;
- other IR regression fixes at lirc a
Now that we have an extension to handle images, use it.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/Makefile | 47 +-
Documentation/media/intro.rst | 6 +--
Documentation/media/uapi/dvb/intro.rst | 6
Currently, IMX_VDOA and VIDEO_CODA only builds on ARCH_MXC.
That prevented me to build-test the driver, causing a bad patch
to be applied, and to see other warnings on this driver.
Reported-by: Russell King
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/Kconfig | 2 +-
1 file
We can't constify struct platform_driver.
This reverts commit d2fe28feaee147e5e6e7bc68857f9bd7f6ad.
Reported-by: Russell King
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/coda/imx-vdoa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dr
ct vb2_queue *src_vq;
^~
drivers/media/platform/coda/coda-common.c: In function 'coda_buf_queue':
drivers/media/platform/coda/coda-common.c:1315:22: warning: variable 'q_data'
set but not used [-Wunused-but-set-variable]
struct coda_q_data *q_data;
2_err’
v4l2_err(&dev->v4l2_dev,
^~~~
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/coda/coda-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda/coda-common.c
b/drivers/media/platform/coda/coda-common.c
index cb76c96759b9.
Em Fri, 10 Mar 2017 13:54:28 +0100
Hans Verkuil escreveu:
> > Devices that have complex pipeline that do essentially require using the
> > Media controller interface to configure them are out of that scope.
> >
>
> Way too much of how the MC devices should be used is in the minds of
> develo
Hi Russell,
Em Fri, 10 Mar 2017 13:07:33 +
Russell King - ARM Linux escreveu:
> The idea that the v4l libraries should intercept the format negotiation
> between the application and kernel is a particularly painful one - the
> default gstreamer build detects the v4l libraries, and links agai
Em Fri, 10 Mar 2017 15:20:48 +0100
Hans Verkuil escreveu:
>
> > As I've already mentioned, from talking about this with Mauro, it seems
> > Mauro is in agreement with permitting the control inheritence... I wish
> > Mauro would comment for himself, as I can't quote our private discussion
> > on
Em Fri, 10 Mar 2017 15:57:09 +
Russell King - ARM Linux escreveu:
> On Fri, Mar 10, 2017 at 12:26:34PM -0300, Mauro Carvalho Chehab wrote:
> > Hi Russell,
> >
> > Em Fri, 10 Mar 2017 13:07:33 +
> > Russell King - ARM Linux escreveu:
> >
> > &
like V4L2_PIX_FMT_KONICA420,
V4L2_PIX_FMT_SPCA501, etc. So, let's offer only the emulated
variant for those weird stuff.
So, this patch changes the libv4lconvert behavior, for
all non-proprietary formats, including Bayer, to offer both
the original format and the emulated ones.
Signed-off-by: Maur
like V4L2_PIX_FMT_KONICA420,
V4L2_PIX_FMT_SPCA501, etc. So, let's offer only the emulated
variant for those weird stuff.
So, this patch changes the libv4lconvert default behavior to
show emulated formats, except for the explicit ones marked as
such.
Signed-off-by: Mauro Carvalho Chehab
Acked-
Currently, the bayer formats, if present, are not shown to the
applications, with prevents them to use more optimized code to
handle it.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
---
lib/libv4lconvert/libv4lconvert.c | 8
1 file changed, 4 insertions(+), 4 deletions
used with regards to exposing formats to userspace.
Suggested-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
lib/libv4lconvert/libv4lconvert.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/lib/libv4lconvert/libv4lconvert.c
b/lib/libv4lconvert
optimized code to
handle it. Change them to be shown to userspace.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
---
lib/libv4lconvert/libv4lconvert.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/libv4lconvert/libv4lconvert.c
b/lib/libv4lconvert
used with regards to exposing formats to userspace.
Suggested-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
lib/libv4lconvert/libv4lconvert.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/lib/libv4lconvert/libv4lconvert.c
b/lib/libv4lconvert
Em Fri, 10 Mar 2017 17:00:59 -0800
Troy Kisky escreveu:
> On 3/10/2017 12:53 PM, Mauro Carvalho Chehab wrote:
> > The libv4lconvert part of libv4l was meant to provide a common
> > place to handle weird proprietary formats. With time, we also
> > added support to other stand
Em Sat, 11 Mar 2017 06:21:40 -0300
Mauro Carvalho Chehab escreveu:
> The libv4lconvert part of libv4l was meant to provide a common
> place to handle weird proprietary formats. With time, we also
> added support to other standard formats, in order to help
> V4L2 applications
Em Sat, 11 Mar 2017 00:37:14 +0200
Sakari Ailus escreveu:
> Hi Mauro (and others),
>
> On Fri, Mar 10, 2017 at 12:53:42PM -0300, Mauro Carvalho Chehab wrote:
> > Em Fri, 10 Mar 2017 15:20:48 +0100
> > Hans Verkuil escreveu:
> >
> > >
> > > &g
Em Sat, 11 Mar 2017 12:32:43 +0100
Hans Verkuil escreveu:
> On 10/03/17 16:09, Mauro Carvalho Chehab wrote:
> > Em Fri, 10 Mar 2017 13:54:28 +0100
> > Hans Verkuil escreveu:
> >
> >>> Devices that have complex pipeline that do essentially require using the
&g
Em Sun, 12 Mar 2017 19:47:00 +
Russell King - ARM Linux escreveu:
> Another issue.
>
> The "reboot and the /dev/video* devices come up in a completely
> different order" problem seems to exist with this version.
>
> The dot graph I supplied previously had "ipu1_csi0 capture" on
> /dev/video
Em Sun, 12 Mar 2017 10:56:53 -0700
Steve Longerbeam escreveu:
> On 03/11/2017 11:37 PM, Russell King - ARM Linux wrote:
> > On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote:
> > Given what Mauro has said, I'm convinced that the media controller stuff
> > is a complete failure f
Em Sun, 12 Mar 2017 21:13:24 +
Russell King - ARM Linux escreveu:
> On Sun, Mar 12, 2017 at 05:59:28PM -0300, Mauro Carvalho Chehab wrote:
> > Yet, udev/systemd has some rules that provide an unique name for V4L
> > devices at /lib/udev/rules.d/60-persistent-v4l.rules. Basical
Em Sun, 12 Mar 2017 22:29:04 +0100
Pavel Machek escreveu:
> Mid-layer is difficult... there are _hundreds_ of possible
> pipeline setups. If it should live in kernel or in userspace is a
> question... but I don't think having it in kernel helps in any way.
Mid-layer is difficult, because we eith
Em Sun, 12 Mar 2017 14:16:56 +0100
Geert Uytterhoeven escreveu:
> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
>
> Signed-off-by: Geert Uytterhoeven
> Reviewed-by: Javier Martinez Canillas
> Cc: Mauro Carval
Em Mon, 13 Mar 2017 08:43:52 +0100
Geert Uytterhoeven escreveu:
> Hi Mauro,
>
> On Mon, Mar 13, 2017 at 2:02 AM, Mauro Carvalho Chehab
> wrote:
> > Em Sun, 12 Mar 2017 14:16:56 +0100
> > Geert Uytterhoeven escreveu:
> >
> >> Submitters of device tree
Em Mon, 13 Mar 2017 10:58:42 +
Russell King - ARM Linux escreveu:
> On Mon, Mar 13, 2017 at 11:44:50AM +0100, Hans Verkuil wrote:
> > On 03/12/2017 06:56 PM, Steve Longerbeam wrote:
> > > In summary, I do like the media framework, it's a good abstraction of
> > > hardware pipelines. It does
Hi Sakari,
I started preparing a long argument about it, but gave up in favor of a
simpler one.
Em Mon, 13 Mar 2017 14:46:22 +0200
Sakari Ailus escreveu:
> Drivers are written to support hardware, not particular use case.
No, it is just the reverse: drivers and hardware are developed to
supp
Em Tue, 14 Mar 2017 08:55:36 +0100
Hans Verkuil escreveu:
> On 03/14/2017 04:45 AM, Mauro Carvalho Chehab wrote:
> > Hi Sakari,
> >
> > I started preparing a long argument about it, but gave up in favor of a
> > simpler one.
> >
> > Em Mon, 13 Mar 2017 14
Em Tue, 14 Mar 2017 23:32:54 +0100
Pavel Machek escreveu:
> Hi!
>
> > > > Even if they were merged, if we keep the same mean time to develop a
> > > > libv4l plugin, that would mean that a plugin for i.MX6 could take 2-3
> > > > years to be developed.
> > > >
> > > > There's a clear message on
Em Fri, 27 Jan 2017 13:54:57 -0800
Eric Anholt escreveu:
> Here's my first pass at importing the camera driver. There's a bunch
> of TODO left to it, most of which is documented, and the rest being
> standard checkpatch fare.
>
> Unfortunately, when I try modprobing it on my pi3, the USB networ
701 - 800 of 1501 matches
Mail list logo
