[PATCH 14/30] media: cx23885: fix a warning

drivers/media/pci/cx23885/cx23885-alsa.c:92 cx23885_alsa_dma_init() warn: argument 3 to %08lx specifier is cast from pointer Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/pci/cx23885/cx23885-alsa.c | 5 ++--- 1 file changed, 2 insertions(+), 3 del

[PATCH] media: s5p_mfc_enc: get rid of new warnings

/media/platform/s5p-mfc/s5p_mfc_enc.c:1257 enc_post_frame_start() error: uninitialized symbol 'enc_c_addr'. Change the logic by initializing those constants to zero, with should hopefully do the right thing. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/pl

[PATCH] media: extended-controls.rst: don't use adjustbox

thy <smith...@samsung.com> Cc: Hans Verkuil <hans.verk...@cisco.com> Cc: Sylwester Nawrocki <s.nawro...@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- Documentation/media/uapi/v4l/extended-controls.rst | 42 +++--- 1 file changed, 21 in

[PATCH] media: v4l2-common: fix a compilation breakage

** *** WARNINGS *** compilation succeeded That was due to a change here to use of linux-log-diff script that provides a diffstat between the errors output. Somehow, the logic was missing some fatal errors. Fixes: 95ce9c28601a ("media: v4l: common: Add a function to obtain best

Re: [PATCHv2 6/7] cec-pin-error-inj.rst: document CEC Pin Error Injection

Em Mon, 5 Mar 2018 14:51:38 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > The CEC Pin framework adds support for Error Injection. > > Document all the error injections commands and how to use it. Please notice that all debugfs/sysfs

Re: [PATCH 0/5] SPDX license identifiers in all DD drivers

Em Tue, 20 Mar 2018 22:01:27 +0100 Daniel Scheller escreveu: > Ralph, Manfred, I'm Cc'ing you on these five patches aswell, so if there > are any concerns left regarding the changes proposed by these patches, > please raise them. It should be the reverse:

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Em Mon, 19 Mar 2018 13:48:55 +0100 Pavel Machek escreveu: > Hi! > > > >> I really want to work with you on this, but I am not looking for partial > > >> solutions. > > > > > > Well, expecting design to be done for opensource development is a bit > > > unusual :-). > > > >

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Em Mon, 19 Mar 2018 13:15:22 +0100 Hans Verkuil escreveu: > On 03/19/2018 01:00 PM, Pavel Machek wrote: > > Hi! > > > >>> Pavel, > >>> > >>> I appreciate your efforts of adding support for mc-based devices to > >>> libv4l. > > > > Thanks. > > > >>> I guess the main

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

Em Mon, 19 Mar 2018 11:23:54 +0100 Pavel Machek escreveu: > Hi! > > > I really don't want to add functions for this to libv4l2. That's just a > > quick hack. The real solution is to parse this from a config > > file. But > > No, this is not a quick hack. These are functions

Re: I2C media binding model

Em Fri, 16 Mar 2018 23:50:31 +0900 Akihiro TSUKADA escreveu: > Hi, > > As the new i2c binding helper was introduced, > I am now re-writing the following patches to use new helper functions. > > > 5. Jan,16 2015: [v2,1/2] dvb: tua6034: add a new driver for Infineon > >

Re: [PATCH 21/47] media: platform: remove m32r specific arv driver

Em Wed, 14 Mar 2018 16:35:34 +0100 Arnd Bergmann <a...@arndb.de> escreveu: > The m32r architecture is getting removed, so this one is no longer needed. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> >

Re: [PATCH 20/47] media: platform: remove blackfin capture driver

Em Wed, 14 Mar 2018 16:35:33 +0100 Arnd Bergmann <a...@arndb.de> escreveu: > The blackfin architecture is getting removed, so the video > capture driver is also obsolete. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Mauro Carvalho Chehab &

[PATCH v2] media: lgdt330x: add block error counts via DVBv5

with data, the maximum polling rate for those stats was set to 1 second. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c | 100 + 1 file changed, 76 insertions(+), 24 deletions(-) diff --git a/drivers/med

[PATCH 09/11] media: lgdt330x: provide DVBv5 Carrier S/N measurements

Change the logic at the driver to provide CNR stats via DVBv5 API. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c | 47 +- 1 file changed, 40 insertions(+), 7 deletions(-) diff --git a/drivers/med

[PATCH 08/11] media: lgdt330x: move *read_status functions

In preparation to implement DVBv5 stats on this driver, move the *read_status functions to happen after SNR and signal strength routines. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c | 255 +

[PATCH 03/11] media: lgdt330x: use pr_foo() macros

Cleanup the usecases of dprintk() by using pr_fmt() and replace printk by pr_foo(). Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c | 64 ++ 1 file changed, 34 insertions(+), 30 deletions(-) diff

[PATCH 04/11] media: lgdt330x: print info when device gets probed

It is useful to know if the driver load succeded. So, add a printk info there. While here, improve the .init debug printed message. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c | 5 - 1 file changed, 4 insertions(+), 1 de

[PATCH 05/11] media: lgdt330x: convert it to the new I2C binding way

Convert the driver to allow its usage with the new I2C binding way. Please notice that this patch doesn't convert the callers to bind to it using the new way. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/b2c2/flexcop-fe-tuner.c | 4 +- drivers

[PATCH 01/11] media: lgdt330x: use kernel-doc instead of inlined comments

Change the lgdt330x_config documentation to use kernel-doc style. No functional changes. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.h | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff

[PATCH 11/11] media: lgdt330x: add block error counts via DVBv5

with data, the maximum polling rate for those stats was set to 1 second. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c | 98 -- 1 file changed, 70 insertions(+), 28 deletions(-) diff --git a/drivers/med

[PATCH 02/11] media: lgdt330x: fix coding style issues

As we're about to convert this driver to use the new i2c binding way, let's first solve most coding style issues, in order to avoid mixing coding style changes with code changes. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c

[PATCH 07/11] media: lgdt330x: constify several register init arrays

67681a70 new/drivers/media/dvb-frontends/lgdt330x.o Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c | 43 ++ 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/drivers/media/dvb-fro

[PATCH 06/11] media: lgdt330x: do some cleanups at status logic

Simplify a few ifs there. While here, add debug messages for the 8-vsb and qam log status flags. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 10/11] media: lgdt330x: get rid of read_ber stub

This routine does nothing. Remove it. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/lgdt330x.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/media/dvb-frontends/lgdt330x.c b/drivers/media/dvb-frontends/lgdt330x.c

[PATCH] media: em28xx: fix a regression with HVR-950

ERROR DMX_SET_PES_FILTER failed (PID = 0x2000): 90 Message too long Tested with Hauppauge HVR-950 model A1C0. Cc: Brad Love <b...@nextdimension.cc> Fixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner functionality") Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensourc

[PATCH 2/2] media: v4l2-core: get rid of videobuf-dvb

Videobuf has been replaced by videobuf2. Now, no drivers use the videobuf-dvb helper module anymore. So, get rid of it. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/v4l2-core/Kconfig| 4 - drivers/media/v4l2-core/Makefile | 1 - d

[PATCH 1/2] media: cx231xx: get rid of videobuf-dvb dependency

This driver doesn't use videobuf-dvb. So, stop adding an unused struct and unused header on it. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/cx231xx/Kconfig | 1 - drivers/media/usb/cx231xx/cx231xx-dvb.c | 6 +- drivers/media/usb/c

Re: [PATCH] dvb: Save port number and provide sysfs attributes to pass values to udev

Em Thu, 08 Mar 2018 23:35:45 + David Howells <dhowe...@redhat.com> escreveu: > Mauro Carvalho Chehab <mche...@kernel.org> wrote: > > > > + dvb_class->dev_groups = dvb_class_groups, > > > dvb_class->dev_uevent = dvb_uevent; > > >

[PATCH] media: dvb-usb-v2: stop using coherent memory for URBs

There's no need to use coherent buffers there. So, let the DVB core do the allocation. That should give some performance gain outside x86. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/dvb-usb-v2/usb_urb.c | 17 - 1 file chan

[PATCH 1/2] media: dvbsky: use the new dvb_module_probe() API

-v2/dvbsky.o 58171108 1269371b19 new/drivers/media/usb/dvb-usb-v2/dvbsky.o Tested with a DVBSky S960C DVB-S2 tuner (0572:960c) Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 390 +++

[PATCH 2/2] media: dvbsky: fix driver unregister logic

Sky S960CI:2-2' successfully deinitialized and disconnected Fix it by letting the dvb-usb-v2 core to know that the frontend was already removed. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 +++ 1 file changed, 3 insertions

Re: Patch review

Em Wed, 28 Feb 2018 17:21:27 +0200 Laurent Pinchart escreveu: > Hi Guennadi, > > On Wednesday, 28 February 2018 17:07:00 EET Guennadi Liakhovetski wrote: > > Hi, > > > > I know the "development process and responsibilities" was the main topic > > during the

Re: [PATCH] media: ov5640: fix frame interval enumeration

Em Thu, 8 Mar 2018 07:39:09 -0300 Mauro Carvalho Chehab <mche...@kernel.org> escreveu: > Also, if this function starts returning NULL, I suspect that you also > need to change ov5640_s_frame_interval(), as currently it is called > at ov5640_s_frame_interval() as: > >

Re: [PATCH] media: ov5640: fix frame interval enumeration

Em Thu, 8 Mar 2018 10:01:59 +0100 Hugues Fruchet escreveu: > Driver must reject frame interval enumeration of unsupported resolution. > This was detected by v4l2-compliance format ioctl test: > v4l2-compliance Format ioctls: > info: found 2 frameintervals for pixel

Re: [PATCH 3/4] [media] ddbridge: use common DVB I2C client handling helpers

Em Wed, 7 Mar 2018 20:23:49 +0100 Daniel Scheller escreveu: > From: Daniel Scheller > > Instead of keeping duplicated I2C client handling construct, make use of > the newly introduced dvb_module_*() helpers. This not only keeps things > way

I2C media binding model

Hi Akihiro-san, There are a number of patches that you sent with a proposal for a new I2C binding model: 1. [v3,1/4] dvb: qm1d1c0042: use dvb-core i2c binding model template http://patchwork.linuxtv.org/patch/27923 2. dvb: mxl301rf: use dvb-core i2c binding model template

Re: [GIT PULL RESEND] SAA716x DVB driver

Hi Sören, Em Wed, 23 Aug 2017 11:56:50 +0200 Soeren Moch escreveu: > Resend this pull request. Apparently my explanation one month ago, > why we need the userspace API of this driver in the current form [1], > got lost. As discussed in priv, I'm ok to merge this at staging,

[PATCH] media: Kconfig: fix DVB dependencies

:972: undefined reference to `i2c_unregister_device' Reported-by: kbuild test robot <fengguang...@intel.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/Kconfig b/drivers/m

Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making the code match

Em Wed, 7 Mar 2018 15:23:52 +0200 Antti Palosaari <cr...@iki.fi> escreveu: > On 12/14/2017 04:48 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 19 Sep 2017 13:13:52 +0100 > > Nigel Kettlewell <nigel.kettlew...@googlemail.com> escreveu: > > > >>

Re: [PATCH] media: dvbdev: fix building on ia64

Em Wed, 7 Mar 2018 06:47:14 -0300 Fabio Estevam <feste...@gmail.com> escreveu: > Hi Mauro, > > On Wed, Mar 7, 2018 at 6:14 AM, Mauro Carvalho Chehab > <mche...@s-opensource.com> wrote: > > Not sure why, but, on ia64, with Linaro's gcc 7.3 compiler, > >

Re: [PATCH v5 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI interface

Em Thu, 18 Jan 2018 17:46:10 +0900 escreveu: > From: Yasunari Takiguchi > > This is the SPI adapter part of the driver for the > Sony CXD2880 DVB-T2/T tuner + demodulator. Thanks for the patches! The patch series look ok. Just a few

[PATCH] media: cxd2880: Fix location of DVB headers

Fix a trivial conflict, where the location of DVB headers got moved. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd.c | 2 +- drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd_dvbt.c | 2 +- drivers/med

[PATCH 1/3] media: cxd2880: Makefile: remove an include

It is not needed anymore to include the dvb-core directory, as all the public headers that used to be there was moved to include/media. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/cxd2880/Makefile | 1 - 1 file changed, 1 deletion(-)

[PATCH 3/3] media: cxd2880: remove unused vars

Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/cxd2880/cxd2880_top.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/media/dvb-frontends/cxd2880/cxd2880_top.c b/drivers/media/dvb-frontends/cxd2880/cxd2880_top.c index 05360a11bea9..d474dc1b05da

[PATCH 2/3] media: cxd2880: don't return unitialized values

:2985 cxd2880_tnrdmd_set_cfg() error: uninitialized symbol 'ret'. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/cxd2880/cxd2880_devio_spi.c | 4 ++-- drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd.c| 2 +- 2 files changed, 3 insertions

[PATCH] media: dvbdev: fix building on ia64

Not sure why, but, on ia64, with Linaro's gcc 7.3 compiler, using #ifdef (CONFIG_I2C) is not OK. So, replace it by IS_ENABLED(CONFIG_I2C), in order to fix the builds there. Reported-by: kbuild test robot <fengguang...@intel.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opens

Re: [PATCH] w1: fix w1_ds2438 documentation

Em Fri, 2 Mar 2018 08:55:24 +0100 Mariusz Bialonczyk escreveu: > Signed-off-by: Mariusz Bialonczyk > --- > Documentation/w1/slaves/w1_ds2438 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/w1/slaves/w1_ds2438 >

Re: [PATCH v2 01/11] media: tw9910: Re-order variables declaration

Em Tue, 6 Mar 2018 17:57:15 +0100 jacopo mondi <jac...@jmondi.org> escreveu: > Hi Mauro, > > On Tue, Mar 06, 2018 at 01:51:52PM -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 2 Mar 2018 15:46:33 +0100 > > Jacopo Mondi <jacopo+rene...@jmondi.org> escreve

Re: [PATCH v2 01/11] media: tw9910: Re-order variables declaration

Em Fri, 2 Mar 2018 15:46:33 +0100 Jacopo Mondi escreveu: > Re-order variables declaration to respect 'reverse christmas tree' > ordering whenever possible. To be frank, I don't like the idea of reverse christmas tree ordering myself... Perhaps due to the time I used

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

Em Tue, 06 Mar 2018 18:35:32 +0200 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote: > > Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu: > > &

Re: [PATCH] media: ov772x: constify ov772x_frame_intervals

Em Tue, 6 Mar 2018 17:05:26 +0100 jacopo mondi <jac...@jmondi.org> escreveu: > Hi Mauro, > > On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote: > > The values on this array never changes. Make it const. > > > > Signed-off-by: Mauro Carvalho

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu: > VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF. > As ARCH_RENESAS implies OF, the latter can be dropped. > > Signed-off-by: Geert Uytterhoeven > --- >

Re: [PATCH v2 11/12] [media] ngene: move the tsin_exchange() stripcopy block into a function

Em Sun, 25 Feb 2018 13:31:39 +0100 Daniel Scheller escreveu: > From: Daniel Scheller > > Move the copy logic that will skip previously inserted TS NULL frames when > moving data to the DVB ring buffers into an own function. This is done to > not

Re: [PATCH v2 08/12] [media] ngene: deduplicate I2C adapter evaluation

Em Tue, 6 Mar 2018 13:06:15 -0300 Mauro Carvalho Chehab <mche...@kernel.org> escreveu: > Em Sun, 25 Feb 2018 13:31:36 +0100 > Daniel Scheller <d.scheller@gmail.com> escreveu: > > > From: Daniel Scheller <d.schel...@gmx.net> > > > > The

Re: [PATCH v2 08/12] [media] ngene: deduplicate I2C adapter evaluation

Em Sun, 25 Feb 2018 13:31:36 +0100 Daniel Scheller escreveu: > From: Daniel Scheller > > The I2C adapter evaluation (based on chan->number) is duplicated at > several places (tuner_attach_() functions, demod_attach_stv0900() and > cineS2_probe()).

[PATCH] media: ov772x: constify ov772x_frame_intervals

The values on this array never changes. Make it const. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/ov772x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index 16665a

Re: [PATCH 1/2] media: ov5645: Fix write_reg return code

Em Thu, 8 Feb 2018 11:41:59 +0200 Todor Tomov escreveu: > I2C transfer functions return number of successful operations (on success). > > Do not return the received positive return code but instead return 0 on > success. The users of write_reg function already use this

Re: [PATCH v2 1/5] media: dvb_frontend: add FEC modes, S2X modulations and 64K transmission

Hi Daniel, Em Mon, 22 Jan 2018 18:13:42 +0100 Daniel Scheller escreveu: > From: Daniel Scheller > > Add 1/4 and 1/3 FEC ratios, 64/128/256-APSK S2X modulations and 64K > transmission mode. Update relevant doc items aswell. Please properly

Re: [PATCH 3/7] si2157: Add hybrid tuner support

Hi Brad, As patches 1 and 2 are independent of this one, and should be backward compatible, I'm applying them, but I have issues with this one too :-) Em Tue, 16 Jan 2018 14:48:35 -0600 Brad Love escreveu: > On 2018-01-15 23:05, Antti Palosaari wrote: > > Hello > > So

Re: [PATCH] dvb: Save port number and provide sysfs attributes to pass values to udev

Hi David, Em Wed, 10 Jan 2018 14:50:35 + David Howells escreveu: > Some devices, such as the DVBSky S952 and T982 cards, are dual port cards > that provide two cx23885 devices on the same PCI device, which means the > attributes available for writing udev rules are

[PATCH v2] media: s5h14*.h: fix typos for CONTINUOUS

,S5H1409_MPEGTIMING_CONTINUOUS_NONINVERTING_CLOCK,g -i $i done for i in $(git grep -l -i continous drivers/media); do sed s,CONTINOUS,CONTINUOUS,g -i $i; done Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/s5h1409.c | 8 drivers/media/dvb-frontends/s5h1409.h

Re: [PATCH V2 2/3] media: dvb-core: Added timers for dvb_ca_en50221_write_data

Em Wed, 14 Feb 2018 00:29:43 +0100 "Jasmin J." escreveu: > Hi! > > Please hold on in merging this series, because I have to investigate a hint > I got related to the buffer size handshake of the protocol driver: >

Re: [PULL] DVB-mmap Kconfig typo fix

Em Thu, 1 Mar 2018 07:55:20 -0500 Michael Ira Krufky escreveu: > Mauro, > > Please pull the following typo fix in the Kconfig for dvb-mmap: > > The following changes since commit 4df7ac5f42087dc9bcbed04b5cada0f025fbf9ef: > > drivers/media/Kconfig: typo: replace `with`

[PATCH 03/11] media: em28xx-reg.h: Fix coding style issues

implicitly truncated to unsigned type [-Woverflow] {EM2820_R08_GPIO_CTRL, 0x6d, ~EM_GPIO_4, 10}, ^ Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-reg.

[PATCH 02/11] em28xx.h: Fix most coding style issues

There used to have a lot of coding style issues there. The ones detected by checkpatch, in strict mode, got fixed. Still, we need to work more on it, in order to document all struct fields using kernel-doc macros, but this will be done on some future patch. Signed-off-by: Mauro Carvalho Chehab

[PATCH 10/11] media: em28xx-input: fix most coding style issues

There are a number of coding style issues at em28xx-input. Fix most of them, by using checkpatch in strict mode to point for it. Automatic fixes were made with --fix-inplace, but those were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- d

[PATCH 08/11] media: em28xx-core: fix most coding style issues

There are a number of coding style issues at em28xx-core. Fix most of them, by using checkpatch in strict mode to point for it. Automatic fixes were made with --fix-inplace, but those were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- d

[PATCH 01/11] em28xx: Add SPDX license tags where needed

Most of the files there are missing a SPDX license tag. Add. While here fix some DRIVER_LICENSE macro in order to reflect the source file license, as some of the headers are GPL v2 only. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-a

[PATCH 04/11] media: em28xx-audio: fix coding style issues

There are a number of coding style issues at em28xx-audio. Fix them, by using checkpatch in strict mode to point for it. Automatic fixes with --fix-inplace were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/

[PATCH 07/11] media: em28xx-cards: rework the em28xx probing code

There is a complex loop there with identifies the em28xx endpoints. It has lots of identations inside, and big names, making harder to understand. Simplify it by moving the main logic into a static function. While here, rename "interface" var to "intf". Signed-off-by: M

[PATCH 06/11] media: em28xx-cards: fix most coding style issues

There are a number of coding style issues, pointed by checkpatch on strict mode. Fix the ones that don't require code refactor here. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-cards.c | 305 +++- 1 file c

[PATCH 09/11] media: em28xx-i2c: fix most coding style issues

There are a number of coding style issues at em28xx-i2c. Fix most of them, by using checkpatch in strict mode to point for it. Automatic fixes were made with --fix-inplace, but those were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- d

[PATCH 11/11] media: em28xx-video: fix most coding style issues

There are a number of coding style issues at em28xx-video. Fix most of them, by using checkpatch in strict mode to point for it. Automatic fixes were made with --fix-inplace, but those were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- d

[PATCH 05/11] media: em28xx-camera: fix coding style issues

There are some coding style issues at em28xx-camera. Fix them, by using checkpatch in strict mode to point for it. Automatic fixes with --fix-inplace were complemented by manual work. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-ca

[PATCH 00/11] em28xx: coding style improvements

ges should be noticed after this patch series. Mauro Carvalho Chehab (11): em28xx: Add SPDX license tags where needed em28xx.h: Fix most coding style issues media: em28xx-reg.h: Fix coding style issues media: em28xx-audio: fix coding style issues media: em28xx-camera: fix coding style issu

Re: [PATCH 5/8] media: em28xx: adjust I2C timeout according with I2C speed

Em Fri, 2 Mar 2018 16:34:46 -0300 Mauro Carvalho Chehab <mche...@s-opensource.com> escreveu: > + switch (dev->i2c_speed & 0x03) { > + case EM28XX_I2C_FREQ_25_KHZ: > + return time += 4; /* Assume 4 ms for transfers */ > +

[PATCH 1/2] media: s5h1409: fix a typo on one of its enum values

-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/s5h1409.c | 2 +- drivers/media/dvb-frontends/s5h1409.h | 2 +- drivers/media/pci/cx18/cx18-dvb.c | 2 +- drivers/media/pci/cx23885/cx23885-dvb.c | 12 ++-- drivers/media/pci/cx88/cx88

[PATCH 2/2] media: em28xx-dvb: do some coding style improvements

As we're touching a lot on this file, let's solve several Coding Style issues there using checkpatch --fix-inline --strict, and manually adjusting the results. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-dvb.c

Re: [PATCH v2] media: siano: Fix coherent memory allocation failure on arm64

Hi Tomoki, Em Sat, 3 Mar 2018 21:20:17 +0900 tomoki.sekiy...@gmail.com escreveu: > From: Tomoki Sekiyama > > On some architectures such as arm64, siano chip based TV-tuner > USB devices are not recognized correctly due to coherent memory > allocation failure with

[GIT PULL for v4.16-rc4] media fixes

Mauro Carvalho Chehab (8): media: videobuf2: fix build issues with vb2-trace media: m88ds3103: don't call a non-initalized function media: dmxdev: fix error code for invalid ioctls media: dmxdev: Fix the logic that enables DMA mmap support media: dvb: add continuity error

[PATCH 4/8] media: em28xx: constify most static structs

hex filename 112345 32292 576 145213 2373d drivers/media/usb/em28xx/em28xx.o Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-cards.c | 106 drivers/media/usb/em28xx/em28xx-core.c | 2 +- drivers

[PATCH 6/8] media: em28xx: split up em28xx_dvb_init to reduce stack size

: Arnd Bergmann <a...@arndb.de> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-dvb.c | 947 ++ 1 file changed, 508 insertions(+), 439 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/driver

[PATCH 8/8] media: em28xx-dvb: simplify DVB module probing logic

filename 44743 14192 96 59031e697 drivers/media/usb/em28xx/em28xx-dvb.o Tested with a PCTV 461e device. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-dvb.c | 528 +- 1 file changed, 138 inse

[PATCH 5/8] media: em28xx: adjust I2C timeout according with I2C speed

If the I2C speed is too slow, it should wait more for an answer. While here, change disconnected type from char to unsigned int, just like all other bitmask fields there at em28xx struct. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-c

[PATCH 7/8] media: dvb-core: add helper functions for I2C binding

two new helper functions: - dvb_module_probe() - dvb_module_release() Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-core/dvbdev.c | 48 ++ include/media/dvbdev.h

[PATCH 0/8] em28xx: some improvements

his module! A side effect of patches 7 and 8 is that we don't to use noinline_for_stack "black" magic there anymore, with is a good thing. Arnd Bergmann (1): media: em28xx: split up em28xx_dvb_init to reduce stack size Mauro Carvalho Chehab (7): media: em28xx: don't use coherent buff

[PATCH 1/8] media: em28xx: don't use coherent buffer for DMA transfers

that it was not de-allocating memories if something gets wrong during memory block allocation. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-core.c | 51 +++--- drivers/media/usb/em28xx/em28xx.h | 2 +- 2

[PATCH 3/8] media: em28xx: stop rewriting device's struct

Writing at the device's struct is evil, as two em28xx devices may be using it. So, stop abusing it, storing the values inside struct em28xx_dev. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-cards.c | 12 +++- drivers/media/usb/

[PATCH 2/8] media: em28xx: improve the logic with sets Xclk and I2C speed

The logic there should be called on two places. Also, ideally, it should not be modifying the device struct. So, change the logic accordingly. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/usb/em28xx/em28xx-cards.c | 45 +-

Re: [PATCH RFC] media: em28xx: don't use coherent buffer for DMA transfers

Em Wed, 28 Feb 2018 09:49:12 -0500 Devin Heitmueller <dheitmuel...@kernellabs.com> escreveu: > On Tue, Feb 27, 2018 at 12:42 PM, Mauro Carvalho Chehab > <mche...@s-opensource.com> wrote: > > While coherent memory is cheap on x86, it has problems on > > arm. So, sto

[PATCH RFC] media: em28xx: don't use coherent buffer for DMA transfers

While coherent memory is cheap on x86, it has problems on arm. So, stop using it. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- I wrote this patch in order to check if this would make things better for ISOCH transfers on Raspberry Pi3. It didn't. Yet, keep using co

[PATCH] media: vb2: Makefile: place vb2-trace together with vb2-core

ed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/common/videobuf2/Makefile | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/media/common/videobuf2/Makefile b/drivers/media/common/videobuf2/Makefile index 067badb1aaa7..77bebe8

Re: [PATCHv4 06/15] subdev-formats.rst: fix incorrect types

Hi Hans, Em Wed, 21 Feb 2018 16:32:09 +0100 Hans Verkuil escreveu: > The ycbcr_enc, quantization and xfer_func fields are __u16 and not enums. > > Signed-off-by: Hans Verkuil > Acked-by: Sakari Ailus Thanks for your

[PATCH 2/2] media: tw9910: solve coding style issues

As we're adding this as a new driver, make checkpatch happier by solving several style issues, using --fix-inplace at strict mode. Some issues required manual work. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/tw9910.

[PATCH 1/2] media: ov772x: fix whitespace issues

As we're adding this as a new driver, make checkpatch happier by solving some whitespace issues, using --fix-inplace. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/ov772x.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-)

[PATCH 2/3] media: tvp541x: fix some kernel-doc parameters

/media/i2c/tvp514x.c: warning: Function parameter or member 'ival' not described in 'tvp514x_g_frame_interval': => 759 + drivers/media/i2c/tvp514x.c: warning: Function parameter or member 'ival' not described in 'tvp514x_s_frame_interval': => 784 Signed-off-by: Mauro Carvalho Cheha

[PATCH 3/3] media: imx: Don't initialize vars that won't be used

put_fi is not used, so just remove it. However, pinctrl should be used, as it devm_pinctrl_get_select_default() is declared with attribute warn_unused_result. What's missing there is an error handling code, in case it fails. Add it. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opens

[PATCH 1/3] media: ov7740: remove an unused var

Fix this warning regression: drivers/media/i2c/ov7740.c: warning: variable 'ret' set but not used [-Wunused-but-set-variable]: => 276:6 Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/ov7740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] media: ttpci/ttusb: add extra parameter to filter callbacks

Em Fri, 23 Feb 2018 19:52:48 +0200 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 23 February 2018 18:43:48 EET Mauro Carvalho Chehab wrote: > > The filter callbaks now have an optional extra a

[PATCH] media: ttpci/ttusb: add extra parameter to filter callbacks

t; 325:10 + drivers/media/pci/ttpci/av7110.c: error: too few arguments to function 'dvbdmxfilter->feed->cb.ts': => 332:11 + drivers/media/pci/ttpci/av7110_av.c: error: too few arguments to function 'feed->cb.ts': => 817:3 Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.

<    4   5   6   7   8   9   10   11   12   13   >