ICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
Do you mind using SPDX tags per [1] rather that this fine but long
legalese. (Here and in the whole patch series)
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
--
Cordially
Philippe Ombredanne
On Fri, Jan 12, 2018 at 2:38 PM, jacopo mondi wrote:
> Hi Philippe, Laurent, Geert,
>
> On Fri, Jan 12, 2018 at 11:36:31AM +0100, Philippe Ombredanne wrote:
>> On Tue, Jan 9, 2018 at 5:25 PM, Jacopo Mondi
>> wrote:
>> > Add driver for Renesas Capture Engine Unit
ur
> +// SPDX-License-Identifier: GPL-2.0
I know this can be confusing, but updating the MODULE_LICENSE tags
definitions in module.h to match SPDX tags is unlikely to happen as it
would create mayhem for everyone and every module loader relying on
this established convention.
--
Cordially
Philippe Ombredanne
you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
Do you mind using a simpler SPDX identifier instead of this long
legalese boilerplate?
This is documented in Thomas doc patches. This applies to your entire
patch set of course.
Thanks!
--
Cordially
Philippe Ombredanne
IN
> + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> + * SOFTWARE.
> + */
Do you mind using a simpler SPDX identifier instead of this long
legalese boilerplate?
This is documented in Thomas doc patches. This applies to your entire
patch set of course.
Thanks!
--
Cordially
Philippe Ombredanne
b-analog.c
> @@ -0,0 +1,1914 @@
> +// SPDX-License-Identifier: GPL-2.0+
Thanks! For the SPDX tags usage:
Acked-by: Philippe Ombredanne
re Foundation; either version 2
Since you are touching the copyright here, I wonder if you could reach
out to other copyright holders and switch to using an SPDX tag
instead?
--
Cordially
Philippe Ombredanne
is fine but longer legalese?
>> +MODULE_LICENSE("GPL v2");
Per module.h this means GPL2 only. This is not matching your top
license above which is GPL2 or later.
Please make sure your MODULE_LICENSE is consistent with the top level license.
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
; + * SOFTWARE.
>> + */
Have you considered using the new SPDX tags instead of this fine but
long legalese?
I know what you are about to say: everyone loves legalese so much that
it is hard to let go of so much of it and replace all this only with a
single SPDX tag line ;)
But then everyone loves code much more than legalese too! so you would
be making the world a service anyway.
And if other contributors in your team could follow suit and you could
spread the word that would be even better!
See Thomas doc patches [1] for details.
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
tware Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
Would you mind using the new SPDX tags documented in Thomas patch set
[1] rather than this fine but longer legalese? Thank you!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
ux-kernel-license-practices-revisited-spdx/
--
Cordially
Philippe Ombredanne
On Sun, Dec 17, 2017 at 7:46 PM, Maciej S. Szmigiero
wrote:
> This series adds support for analog part of Medion 95700 in the cxusb
> driver.
> Changes from v3:
> Add SPDX tag to a newly added "cxusb-analog.c" file.
Thank you.
--
Cordially
Philippe Ombredanne
on.
> + */
Would you mind using the new SPDX tags here. See Thomas patches [1]. Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
onsider using the new SPDX tags per Thomas doc patches [1]
Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne, your friendly kernel licensing scruffy
g the new SPDX tags instead of this fine but
long legalese? And if other Chromium contributors could follow suit
and you could spread the word that would be even better!
See Thomas doc patches [1] for details.
Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
to not pick those myself,
> except from people I trust.
Exactly, and this why --after the first batch that Greg pushed and
Linus pulled and that had been carefully reviewed--, I am trying to
gently nit the submitters of new patches, one at a time to use the new
SPDX tags. Eventually if I can find the time, I could also submit some
bigger patches to add SPDX tags to a bunch of files at once but that
would have to be organized in small batches by copyright holder and
these would be only RFCs until reviewed by and agreed to by the actual
copyright holders.
--
Cordially
Philippe Ombredanne
d
there is (or rather was before starting adding SPDX tags) 1000+
different license notices and over 700+ variations of "this file in
under the GPL"... This starts to diminish a bit with the addition of
SPDX tags and eventually most or all boilerplate could be removed over
time with reviews and discussions, IMHO for the better: I will then be
able to trash my tool and use a good ole grep instead ;)
--
Cordially
Philippe Ombredanne
el license scans). Net effect is that on a laptop on 8
threads it takes ~20 minutes to scan a whole kernel using this
diff-based approach and obtain a fairly accurate license detection.
--
Cordially
Philippe Ombredanne
may want to use the new SPDX ids as documented in Thomas doc
patches instead of the loner legalese?
--
Cordially
Philippe Ombredanne
Jose,
On 12/12/17 17:02, Jose Abreu wrote:
>>> Signed-off-by: Jose Abreu
>>> Cc: Joao Pinto
>>> Cc: Mauro Carvalho Chehab
>>> Cc: Hans Verkuil
>>> Cc: Sylwester Nawrocki
>>> Cc: Sakari Ailus
>>> Cc: Philippe Ombredanne
>&
y).
>
> Signed-off-by: Jose Abreu
> Cc: Joao Pinto
> Cc: Mauro Carvalho Chehab
> Cc: Hans Verkuil
> Cc: Sylwester Nawrocki
> Cc: Sakari Ailus
> Cc: Philippe Ombredanne
> ---
> Changes from v9:
> - Use SPDX License ID (Philippe)
Acked-by: Philippe Ombredanne
Joao Pinto
> Cc: Mauro Carvalho Chehab
> Cc: Hans Verkuil
> Cc: Sylwester Nawrocki
> Cc: Philippe Ombredanne
> ---
> Changes from v9:
> - Use SPDX License ID (Philippe)
Acked-by: Philippe Ombredanne
Thanks!
--
Cordially
Philippe Ombredanne
On Mon, Dec 11, 2017 at 2:31 AM, Wenyou Yang wrote:
> Add a Video4Linux2 sensor-level driver for the OmniVision OV7740
> VGA camera image sensor.
>
> Changes in v9:
> - Use the new SPDX ids.
Thank you for this
Acked-by: Philippe Ombredanne
--
Cordially
Philippe Ombredanne
e from a fellow Samsung colleague
[1]. And if you ever consider doing this for all Samsung's past,
present and future contributions, you will have my deep gratitude
[1] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/
--
Cordially
Philippe Ombredanne, your licensing helper elf
hes and Linus comments on
why he prefers the C++ comment style for these.
--
Cordially
Philippe Ombredanne
dy have tagged
~13K files with SPDX and they are now in Linus's tree. We still have
roughly 60K files to do... so every little help that would avoid
piling up more work for us with new and innovative legalese
boilerplate would really be much appreciated.
Extra bonus: you can also do this for all your past, present and
future contributions and spread the good word at your company so
that everyone does the same: with this small thing you will earn at
least 10 or more extra good karma points and my eternal gratitude.
Thank you for your kind consideration, your friendly kernel licensing janitor!
--
Cordially
Philippe Ombredanne
m.c
> index 821c78ed208c..caf50cd4bb77 100644
> --- a/drivers/media/platform/sti/hva/hva-mem.c
> +++ b/drivers/media/platform/sti/hva/hva-mem.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (C) STMicroelectronics SA 2015
> * Authors: Yannick Fertre
> * Hugues Fruchet
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #include "hva.h"
> diff --git a/drivers/media/platform/sti/hva/hva-mem.h
> b/drivers/media/platform/sti/hva/hva-mem.h
> index a95c728a45e6..fec549dff2b3 100644
> --- a/drivers/media/platform/sti/hva/hva-mem.h
> +++ b/drivers/media/platform/sti/hva/hva-mem.h
> @@ -1,8 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Copyright (C) STMicroelectronics SA 2015
> * Authors: Yannick Fertre
> * Hugues Fruchet
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #ifndef HVA_MEM_H
> diff --git a/drivers/media/platform/sti/hva/hva-v4l2.c
> b/drivers/media/platform/sti/hva/hva-v4l2.c
> index 1c4fc33cbcb5..2ab0b5cc5c22 100644
> --- a/drivers/media/platform/sti/hva/hva-v4l2.c
> +++ b/drivers/media/platform/sti/hva/hva-v4l2.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (C) STMicroelectronics SA 2015
> * Authors: Yannick Fertre
> * Hugues Fruchet
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #include
> diff --git a/drivers/media/platform/sti/hva/hva.h
> b/drivers/media/platform/sti/hva/hva.h
> index 0d749b257a21..8882d901d119 100644
> --- a/drivers/media/platform/sti/hva/hva.h
> +++ b/drivers/media/platform/sti/hva/hva.h
> @@ -1,8 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Copyright (C) STMicroelectronics SA 2015
> * Authors: Yannick Fertre
> * Hugues Fruchet
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #ifndef HVA_H
> --
> 2.15.0
>
Thank you for using the simpler SPDX license ids!
Acked-by: Philippe Ombredanne
--
Cordially
Philippe Ombredanne
Authors: Yannick Fertre
> * Hugues Fruchet
> * for STMicroelectronics.
> - * License terms: GNU General Public License (GPL), version 2
> *
> * This driver is based on atmel_isi.c
> *
> --
> 2.15.0
>
Thank you for using the simpler SPDX license ids!
Acked-by: Philippe Ombredanne
--
Cordially
Philippe Ombredanne
On Fri, Nov 17, 2017 at 6:01 PM, Mauro Carvalho Chehab
wrote:
> Em Fri, 17 Nov 2017 16:01:41 +0100
> Philippe Ombredanne escreveu:
>
>> On Fri, Nov 17, 2017 at 3:58 PM, Mauro Carvalho Chehab
>> wrote:
>> > Em Fri, 17 Nov 2017 15:18:26 +0100
>> > Greg
On Fri, Nov 17, 2017 at 4:01 PM, Mauro Carvalho Chehab
wrote:
> Em Fri, 17 Nov 2017 12:54:15 +0100
> Philippe Ombredanne escreveu:
>
>> On Fri, Nov 17, 2017 at 11:21 AM, Mauro Carvalho Chehab
>> wrote:
>> > As we're now using SPDX identifiers, on several
> This allows tools that check that the module license matches the source
>> code license to work properly, as there is no need to unwind the
>> unneeded dereference.
>>
>> Cc: Hans Verkuil
>> Cc: Mauro Carvalho Chehab
>> Cc: Johan Hovold
>> Cc
rk properly, as there is no need to unwind the
> unneeded dereference.
>
> Cc: Hans Verkuil
> Cc: Mauro Carvalho Chehab
> Cc: Johan Hovold
> Cc: Davidlohr Bueso
> Cc: Sakari Ailus
> Reported-by: Philippe Ombredanne
> Signed-off-by: Greg Kroah-Hartman
Revie
!
FWIW for this 6 patch series:
Reviewed-by: Philippe Ombredanne
CC: Thomas Gleixner
CC: Greg Kroah-Hartman
--
Cordially
Philippe Ombredanne
33 matches
Mail list logo
