/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
--
Cordially
Philippe Ombredanne
On Fri, Jan 12, 2018 at 2:38 PM, jacopo mondi <jac...@jmondi.org> wrote:
> Hi Philippe, Laurent, Geert,
>
> On Fri, Jan 12, 2018 at 11:36:31AM +0100, Philippe Ombredanne wrote:
>> On Tue, Jan 9, 2018 at 5:25 PM, Jacopo Mondi <jacopo+rene...@jmondi.org>
>> w
nstead:
> +MODULE_LICENSE("GPL v2");
... to match your
> +// SPDX-License-Identifier: GPL-2.0
I know this can be confusing, but updating the MODULE_LICENSE tags
definitions in module.h to match SPDX tags is unlikely to happen as it
would create mayhem for everyone and every module loader relying on
this established convention.
--
Cordially
Philippe Ombredanne
version 2 as
> + * published by the Free Software Foundation.
> + */
Do you mind using a simpler SPDX identifier instead of this long
legalese boilerplate?
This is documented in Thomas doc patches. This applies to your entire
patch set of course.
Thanks!
--
Cordially
Philippe Ombredanne
ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> + * SOFTWARE.
> + */
Do you mind using a simpler SPDX identifier instead of this long
legalese boilerplate?
This is documented in Thomas doc patches. This applies to your entire
patch set of course.
Thanks!
--
Cordially
Philippe Ombredanne
00..969d82b24f41
> --- /dev/null
> +++ b/drivers/media/usb/dvb-usb/cxusb-analog.c
> @@ -0,0 +1,1914 @@
> +// SPDX-License-Identifier: GPL-2.0+
Thanks! For the SPDX tags usage:
Acked-by: Philippe Ombredanne <pombreda...@nexb.com>
n redistribute it and/or
> * modify it under the terms of the GNU General Public License
> * as published by the Free Software Foundation; either version 2
Since you are touching the copyright here, I wonder if you could reach
out to other copyright holders and switch to using an SPDX tag
instead?
--
Cordially
Philippe Ombredanne
Would you mind using the new SPDX tags documented in Thomas patch set
[1] rather than this fine but longer legalese?
>> +MODULE_LICENSE("GPL v2");
Per module.h this means GPL2 only. This is not matching your top
license above which is GPL2 or later.
Please make sure your MODULE_LICENSE is consistent with the top level license.
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
so much of it and replace all this only with a
single SPDX tag line ;)
But then everyone loves code much more than legalese too! so you would
be making the world a service anyway.
And if other contributors in your team could follow suit and you could
spread the word that would be even better!
See Thomas doc patches [1] for details.
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
e terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
Would you mind using the new SPDX tags documented in Thomas patch set
[1] rather than this fine but longer legalese? Thank you!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
[2] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/
--
Cordially
Philippe Ombredanne
On Sun, Dec 17, 2017 at 7:46 PM, Maciej S. Szmigiero
<m...@maciej.szmigiero.name> wrote:
> This series adds support for analog part of Medion 95700 in the cxusb
> driver.
> Changes from v3:
> Add SPDX tag to a newly added "cxusb-analog.c" file.
Thank you.
--
Cordially
Philippe Ombredanne
r (at your option) any later version.
> + */
Would you mind using the new SPDX tags here. See Thomas patches [1]. Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
he Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */
Please consider using the new SPDX tags per Thomas doc patches [1]
Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne, your friendly kernel licensing scruffy
nse for more details.
> + */
Have you considered using the new SPDX tags instead of this fine but
long legalese? And if other Chromium contributors could follow suit
and you could spread the word that would be even better!
See Thomas doc patches [1] for details.
Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
by the copyright
> owners, or by LF legal counseling. So, I prefer to not pick those myself,
> except from people I trust.
Exactly, and this why --after the first batch that Greg pushed and
Linus pulled and that had been carefully reviewed--, I am trying to
gently nit the submitters of new patches, one at a time to use the new
SPDX tags. Eventually if I can find the time, I could also submit some
bigger patches to add SPDX tags to a bunch of files at once but that
would have to be organized in small batches by copyright holder and
these would be only RFCs until reviewed by and agreed to by the actual
copyright holders.
--
Cordially
Philippe Ombredanne
are over 80+ licenses in the kernel and
there is (or rather was before starting adding SPDX tags) 1000+
different license notices and over 700+ variations of "this file in
under the GPL"... This starts to diminish a bit with the addition of
SPDX tags and eventually most or all boilerplate could be removed over
time with reviews and discussions, IMHO for the better: I will then be
able to trash my tool and use a good ole grep instead ;)
--
Cordially
Philippe Ombredanne
lp Greg and
Thomas with kernel license scans). Net effect is that on a laptop on 8
threads it takes ~20 minutes to scan a whole kernel using this
diff-based approach and obtain a fairly accurate license detection.
--
Cordially
Philippe Ombredanne
bute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
You may want to use the new SPDX ids as documented in Thomas doc
patches instead of the loner legalese?
--
Cordially
Philippe Ombredanne
gt;
>>> Cc: Sylwester Nawrocki <snawro...@kernel.org>
>>> Cc: Sakari Ailus <sakari.ai...@iki.fi>
>>> Cc: Philippe Ombredanne <pombreda...@nexb.com>
>>> ---
>>> Changes from v9:
>>> - Use SPDX License ID (Philippe)
For the use of SPDX tags, thanks!
Acked-by: Philippe Ombredanne <pombreda...@nexb.com>
ct
> accordingly).
>
> Signed-off-by: Jose Abreu <joab...@synopsys.com>
> Cc: Joao Pinto <jpi...@synopsys.com>
> Cc: Mauro Carvalho Chehab <mche...@kernel.org>
> Cc: Hans Verkuil <hans.verk...@cisco.com>
> Cc: Sylwester Nawrocki <snawro...@kern
igned-off-by: Jose Abreu <joab...@synopsys.com>
> Cc: Joao Pinto <jpi...@synopsys.com>
> Cc: Mauro Carvalho Chehab <mche...@kernel.org>
> Cc: Hans Verkuil <hans.verk...@cisco.com>
> Cc: Sylwester Nawrocki <snawro...@kernel.org>
> Cc: Philippe Ombreda
On Mon, Dec 11, 2017 at 2:31 AM, Wenyou Yang <wenyou.y...@microchip.com> wrote:
> Add a Video4Linux2 sensor-level driver for the OmniVision OV7740
> VGA camera image sensor.
>
> Changes in v9:
> - Use the new SPDX ids.
Thank you for this
Acked-by: Philippe Ombredanne
ectronics Co., Ltd.
// Register definition file for Samsung MFC V10.x Interface (FIMV) driver
You can also read this fine article from a fellow Samsung colleague
[1]. And if you ever consider doing this for all Samsung's past,
present and future contributions, you will have my deep gratitude
[1] h
-2.0
// Copyright (c) 2017 Microchip Corporation.
Short and neat! Check also Thomas doc patches and Linus comments on
why he prefers the C++ comment style for these.
--
Cordially
Philippe Ombredanne
ode, you will have saved a tree or
two and be a good earth citizen.
And even better, you can now grep your code for licenses, unambiguously.
If you could do this that would be really nice: we already have tagged
~13K files with SPDX and they are now in Linus's tree. We still have
roughly 60K files to do... so every little help that would avoid
piling up more work for us with new and innovative legalese
boilerplate would really be much appreciated.
Extra bonus: you can also do this for all your past, present and
future contributions and spread the good word at your company so
that everyone does the same: with this small thing you will earn at
least 10 or more extra good karma points and my eternal gratitude.
Thank you for your kind consideration, your friendly kernel licensing janitor!
--
Cordially
Philippe Ombredanne
i/hva/hva-mem.c
> b/drivers/media/platform/sti/hva/hva-mem.c
> index 821c78ed208c..caf50cd4bb77 100644
> --- a/drivers/media/platform/sti/hva/hva-mem.c
> +++ b/drivers/media/platform/sti/hva/hva-mem.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
>
or STM32 Digital Camera Memory Interface
> *
> @@ -5,7 +6,6 @@
> * Authors: Yannick Fertre <yannick.fer...@st.com>
> * Hugues Fruchet <hugues.fruc...@st.com>
> * for STMicroelectronics.
> - * License terms: GNU General Public License (GPL), version 2
>
On Fri, Nov 17, 2017 at 6:01 PM, Mauro Carvalho Chehab
<mche...@s-opensource.com> wrote:
> Em Fri, 17 Nov 2017 16:01:41 +0100
> Philippe Ombredanne <pombreda...@nexb.com> escreveu:
>
>> On Fri, Nov 17, 2017 at 3:58 PM, Mauro Carvalho Chehab
>> <mche...@s-openso
On Fri, Nov 17, 2017 at 4:01 PM, Mauro Carvalho Chehab
<mche...@s-opensource.com> wrote:
> Em Fri, 17 Nov 2017 12:54:15 +0100
> Philippe Ombredanne <pombreda...@nexb.com> escreveu:
>
>> On Fri, Nov 17, 2017 at 11:21 AM, Mauro Carvalho Chehab
>> <mche...@s-open
s4all.nl>
>> Cc: Mauro Carvalho Chehab <mche...@kernel.org>
>> Cc: Johan Hovold <jo...@kernel.org>
>> Cc: Davidlohr Bueso <d...@stgolabs.net>
>> Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
>> Reported-by: Philippe Ombredanne <pombreda...@
r Bueso <d...@stgolabs.net>
> Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
> Reported-by: Philippe Ombredanne <pombreda...@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
c language of your notices in the
scancode-toolkit!
FWIW for this 6 patch series:
Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
CC: Thomas Gleixner <t...@linutronix.de>
CC: Greg Kroah-Hartman <gre...@linuxfoundation.org>
--
Cordially
Philippe Ombredanne
33 matches
Mail list logo
