[PATCH] [media] s5p-mfc: Fix checkpatch error in s5p_mfc_shm.h file

2012-06-11 Thread Sachin Kamat
Fixes the following error: ERROR: open brace '{' following enum go on the same line +enum MFC_SHM_OFS +{ Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-mfc/s5p_mfc_shm.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media

Re: [PATCH 1/1] [media] s5p-fimc: Add missing static storage class

2012-06-10 Thread Sachin Kamat
On 28/05/2012, Sylwester Nawrocki snj...@gmail.com wrote: On 05/26/2012 05:11 PM, Sachin Kamat wrote: Fixes the following sparse warnings: Hi Sachin. Thanks, in case somebody else applies this patch before I do: Acked-by: Sylwester Nawrocki s.nawro...@samsung.com Thanks Sylwester. I

Re: [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file

2012-05-26 Thread Sachin Kamat
Hi Sylwester, On 26 May 2012 14:09, Sylwester Nawrocki snj...@gmail.com wrote: Hi Sachin, On 05/25/2012 07:38 PM, Sachin Kamat wrote: Fixes the following sparse warning: drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol 'flite_hw_set_out_order' was not declared. Should

[PATCH 1/3] [media] s5p-fimc: Fix compiler warning in fimc-lite.c

2012-05-25 Thread Sachin Kamat
-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-lite.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s5p-fimc/fimc-lite.c b/drivers/media/video/s5p-fimc/fimc-lite.c index 400d701a..62faca5 100644 --- a/drivers/media/video

[PATCH 2/3] [media] s5p-fimc: Fix compiler warning in fimc-capture.c file

2012-05-25 Thread Sachin Kamat
drivers/media/video/s5p-fimc/fimc-capture.c: In function ‘fimc_cap_streamon’: drivers/media/video/s5p-fimc/fimc-capture.c:1053:29: warning: ignoring return value of ‘media_entity_pipeline_start’, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Sachin Kamat sachin.ka

[PATCH 3/3] [media] s5p-fimc: Stop media entity pipeline if fimc_pipeline_validate fails

2012-05-25 Thread Sachin Kamat
Stops the media entity pipeline which was started earlier if fimc_pipeline_validate fails. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-capture.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s5p-fimc

[PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file

2012-05-25 Thread Sachin Kamat
Fixes the following sparse warning: drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol 'flite_hw_set_out_order' was not declared. Should it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-lite-reg.c |2 +- 1 files changed

[PATCH 2/4] [media] s5p-fimc: Add missing static storage class in fimc-mdevice.c file

2012-05-25 Thread Sachin Kamat
? drivers/media/video/s5p-fimc/fimc-mdevice.c:1024:13: warning: symbol 'fimc_md_exit' was not declared. Should it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-mdevice.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 4/4] [media] s5p-fimc: Add missing static storage class in fimc-capture.c file

2012-05-25 Thread Sachin Kamat
Fixes the following sparse warning: drivers/media/video/s5p-fimc/fimc-capture.c:1163:5: warning: symbol 'enclosed_rectangle' was not declared. Should it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-capture.c |2 +- 1 files changed, 1

[PATCH] s5p-g2d: Use devm_* functions in g2d.c file

2012-05-14 Thread Sachin Kamat
devm_* functions are device managed functions and make error handling and cleanup simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d.c | 47 drivers/media/video/s5p-g2d/g2d.h |1 - 2 files changed, 11

[PATCH] s5p-jpeg: Use devm_* functions in jpeg-core.c file

2012-05-14 Thread Sachin Kamat
devm_* functions are used to replace kzalloc, request_mem_region, ioremap and request_irq functions in probe call. With the usage of devm_* functions explicit freeing and unmapping is not required. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-jpeg/jpeg-core.c

[PATCH] [media] s5p-mfc: Use devm_* functions in s5p_mfc.c file

2012-05-14 Thread Sachin Kamat
devm_* functions are device managed functions and make error handling and cleanup simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-mfc/s5p_mfc.c| 63 ++ drivers/media/video/s5p-mfc/s5p_mfc_common.h |2 - 2 files

[PATCH] [media] s5p-mfc: Add missing static storage class in s5p_mfc_enc.c file

2012-05-11 Thread Sachin Kamat
-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-mfc/s5p_mfc_enc.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_enc.c b/drivers/media/video/s5p-mfc/s5p_mfc_enc.c index dff9dc7..acedb20 100644 --- a/drivers/media

[PATCH 1/2] [media] s5p-mfc: Fix NULL pointer warnings

2012-05-10 Thread Sachin Kamat
Fixes the following type of warnings detected by sparse: warning: Using plain integer as NULL pointer. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-mfc/s5p_mfc.c | 10 +- drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c | 16 drivers

[PATCH 2/2] [media] s5p-mfc: Add missing static storage class to silence warnings

2012-05-10 Thread Sachin Kamat
it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-mfc/s5p_mfc.c |2 +- drivers/media/video/s5p-mfc/s5p_mfc_opr.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/drivers/media/video/s5p

[PATCH 1/2] [media] s5p-g2d: Fix NULL pointer warnings in g2d.c file

2012-05-10 Thread Sachin Kamat
Fixes the following warnings detected by sparse: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/s5p-g2d

[PATCH 2/2] [media] s5p-g2d: Add missing static storage class in g2d.c file

2012-05-10 Thread Sachin Kamat
: warning: symbol 'g2d_setup_ctrls' was not declared. Should it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/s5p-g2d/g2d.c b/drivers/media/video

[PATCH] [media] s5p-jpeg: Make s5p_jpeg_g_selection function static

2012-05-10 Thread Sachin Kamat
Makes the function s5p_jpeg_g_selection static (detected by sparse). Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-jpeg/jpeg-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s5p-jpeg/jpeg-core.c b/drivers

Re: [PATCH v3] [media] s5p-g2d: Add support for FIMG2D v4.1 H/W logic

2012-04-27 Thread Sachin Kamat
Hi Kamil, Any comments on the below patch? Regards Sachin On 24 April 2012 16:08, Sachin Kamat sachin.ka...@linaro.org wrote: From: Ajay Kumar ajaykumar...@samsung.com Modify the G2D driver(which initially supported only FIMG2D v3 style H/W) to support FIMG2D v4.1 style hardware present

[PATCH v3] [media] s5p-g2d: Add support for FIMG2D v4.1 H/W logic

2012-04-24 Thread Sachin Kamat
v4.1 H/W uses different logic for stretching(scaling). -- Use CACHECTL_REG only with FIMG2D v3. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d-hw.c | 17 + drivers/media/video/s5p

[PATCH] [media] s5p-tv: Fix compiler warning in mixer_video.c file

2012-04-03 Thread Sachin Kamat
Fixes the following warning: mixer_video.c:857:3: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘unsigned int’ [-Wformat] Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-tv/mixer_video.c |2 +- 1 files changed, 1

Re: [PATCH] [media] s5p-tv: Fix compiler warning in mixer_video.c file

2012-04-03 Thread Sachin Kamat
Ok. Please ignore my patch. Looks like this series has not yet made into mainline. On 03/04/2012, Tomasz Stanislawski t.stanisl...@samsung.com wrote: Hi Sachin Kamat, Thanks for the patch. However, the patch is already a duplicate of http://thread.gmane.org/gmane.linux.drivers.video-input

[PATCH] [media] s5p-jpeg: Make the output format setting conditional

2012-03-19 Thread Sachin Kamat
S5P-JPEG IP on Exynos4210 SoC supports YCbCr422 and YCbCr420 as decoded output formats. But the driver used to fix the output format as YCbCr422. This is now made conditional depending upon the requested output format. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video

Re: [PATCH] [media] s5p-jpeg: Make the output format setting conditional

2012-03-19 Thread Sachin Kamat
Hi Andrzej, On 19/03/2012, Andrzej Pietrasiewicz andrze...@samsung.com wrote: Hello, On March 19, 2012 12:35 PM Sachin Kamat wrote: Subject: [PATCH] [media] s5p-jpeg: Make the output format setting conditional S5P-JPEG IP on Exynos4210 SoC supports YCbCr422 and YCbCr420 as decoded

[PATCH] [media] s5p-tv: Fix section mismatch warning in mixer_video.c

2012-03-12 Thread Sachin Kamat
): Section mismatch in reference from the function mxr_probe() to the function .devexit.text:mxr_release_video() Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Tested on for-next branch of Kukjin Kim's tree git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git --- drivers/media

Re: V4L2 MFC video decoding example application

2012-03-06 Thread Sachin Kamat
Hi Kamil, Thank you for this really cool app. Tested on Origen board for MPEG4 and H.264 streams and they work fine. Regards, Sachin On 06/03/2012, Kamil Debski k.deb...@samsung.com wrote: Hi, I would like to inform you that the example application for the MFC driver has been prepared and

Re: [PATCH v3] [media] s5p-g2d: Add HFLIP and VFLIP support

2012-02-01 Thread Sachin Kamat
Hi Sylwester, On 1 February 2012 14:31, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Sachin, On 02/01/2012 06:09 AM, Sachin Kamat wrote: @@ -200,11 +206,7 @@ int g2d_setup_ctrls(struct g2d_ctx *ctx)  {       struct g2d_dev *dev = ctx-dev; -     v4l2_ctrl_handler_init(ctx

[PATCH v4] [media] s5p-g2d: Add HFLIP and VFLIP support

2012-02-01 Thread Sachin Kamat
Add support for flipping the image horizontally and vertically. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d-hw.c |5 + drivers/media/video/s5p-g2d/g2d.c| 27 --- drivers/media/video/s5p-g2d/g2d.h|4 3

Re: [PATCH v4] [media] s5p-g2d: Add HFLIP and VFLIP support

2012-02-01 Thread Sachin Kamat
Hi Sylwester, On 2 February 2012 01:16, Sylwester Nawrocki snj...@gmail.com wrote: Hi Sachin, On 02/01/2012 10:48 AM, Sachin Kamat wrote: Add support for flipping the image horizontally and vertically. Signed-off-by: Sachin Kamatsachin.ka...@linaro.org ---   drivers/media/video/s5p-g2d

Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-31 Thread Sachin Kamat
: On 30 January 2012 13:12 Laurent Pinchart wrote: On Monday 30 January 2012 10:58:43 Sachin Kamat wrote: This patch adds support for flipping the image horizontally and vertically. [snip] +       v4l2_ctrl_new_std(ctx-ctrl_handler, g2d_ctrl_ops

[PATCH v3] [media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-31 Thread Sachin Kamat
Add support for flipping the image horizontally and vertically. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d-hw.c |5 + drivers/media/video/s5p-g2d/g2d.c| 23 ++- drivers/media/video/s5p-g2d/g2d.h|4 3

[PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Sachin Kamat
This patch adds support for flipping the image horizontally and vertically. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d-hw.c |5 +++ drivers/media/video/s5p-g2d/g2d.c| 47 +++-- drivers/media/video/s5p-g2d/g2d.h

Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Sachin Kamat
, Kamil Debski k.deb...@samsung.com wrote: Hi Laurent and Sachin, Thanks for the patch and for your comments. From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: 30 January 2012 13:12 Hi Sashin, Thanks for the patch. On Monday 30 January 2012 10:58:43 Sachin Kamat wrote

[PATCH v2] [media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Sachin Kamat
This patch adds support for flipping the image horizontally and vertically. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d-hw.c |5 + drivers/media/video/s5p-g2d/g2d.c| 25 - drivers/media/video/s5p-g2d/g2d.h

[PATCH] [media] s5p-mfc: Remove linux/version.h include from s5p_mfc.c

2012-01-17 Thread Sachin Kamat
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-mfc/s5p_mfc.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/drivers/media/video/s5p-mfc/s5p_mfc.c index e43e128..ec7f000 100644 --- a/drivers/media

[PATCH] [media] s5p-fimc: Remove linux/version.h include from fimc-mdevice.c

2012-01-17 Thread Sachin Kamat
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-mdevice.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s5p-fimc/fimc-mdevice.c b/drivers/media/video/s5p-fimc/fimc-mdevice.c index 615c862..8ea4ee1 100644

[PATCH] [media] s5p-fimc: Fix incorrect control ID assignment

2012-01-10 Thread Sachin Kamat
This patch fixes the mismatch between control IDs (CID) and controls for hflip, vflip and rotate. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-core.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/s5p

[PATCH 1/1] [media] MFC: Change MFC firmware binary name

2011-09-30 Thread Sachin Kamat
This patches renames the MFC firmware binary to avoid SoC name in it. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c b

<    1   2   3   4