Re: [PATCH] [media] davinci/dm644x: work around ccdc_update_raw_params trainwreck

2017-06-27 Thread Sekhar Nori
On Tuesday 20 June 2017 06:36 PM, Lad, Prabhakar wrote: > Hi Arnd, > > Thanks for the patch. > > On Fri, Jun 9, 2017 at 10:36 PM, Arnd Bergmann wrote: >> Now that the davinci drivers can be enabled in compile tests on other >> architectures, I ran into this warning on a 64-bit build: >> >> drive

Re: [PATCH] davinci: vpif_capture: fix default pixel format for BT.656/BT.1120 video

2017-05-30 Thread Sekhar Nori
On Tuesday 30 May 2017 03:10 PM, Lad, Prabhakar wrote: > Hi Sekhar, > > Thanks for the patch. > > On Fri, May 26, 2017 at 11:55 AM, Sekhar Nori wrote: >> For both BT.656 and BT.1120 video, the pixel format >> used by VPIF is Y/CbCr 4:2:2 in semi-planar format >>

[PATCH] davinci: vpif_capture: fix default pixel format for BT.656/BT.1120 video

2017-05-26 Thread Sekhar Nori
incorrectly sets the default format to V4L2_PIX_FMT_YUV422P. Fix it. Reported-by: Alejandro Hernandez Signed-off-by: Sekhar Nori --- drivers/media/platform/davinci/vpif_capture.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

2017-02-13 Thread Sekhar Nori
On Tuesday 14 February 2017 02:31 AM, Kevin Hilman wrote: > Kevin Hilman writes: > >> Bartosz Golaszewski writes: >> >>> Signed-off-by: Bartosz Golaszewski >> >> I'll fold this one into the original since it's not yet merged. > > Oops, Sekhar has already merged this one to his v4.11/dt branch,

Re: [PATCH 00/10] ARM: davinci: add vpif display support

2017-02-13 Thread Sekhar Nori
Hi Bartosz, On Tuesday 07 February 2017 10:11 PM, Bartosz Golaszewski wrote: > The following series adds support for v4l2 display on da850-evm with > a UI board in device tree boot mode. > > Patches 1/10 - 5/10 deal with the device tree: we fix whitespace > errors in dts files and bindings, exten

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

2017-02-09 Thread Sekhar Nori
On Tuesday 07 February 2017 11:51 PM, Kevin Hilman wrote: > Bartosz Golaszewski writes: > >> When we enable vpif capture on the da850-evm we hit a BUG_ON() because >> the i2c adapter can't be found. The board file boot uses i2c adapter 1 >> but in the DT mode it's actually adapter 0. Drop the pro

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

2017-01-04 Thread Sekhar Nori
+ Mauro On Tuesday 03 January 2017 02:42 PM, Laurent Pinchart wrote: > Hi Sekhar, > > On Tuesday 03 Jan 2017 14:33:00 Sekhar Nori wrote: >> On Friday 16 December 2016 03:17 PM, Hans Verkuil wrote: >>> On 07/12/16 19:30, Kevin Hilman wrote: >>>> Prepare the

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

2017-01-03 Thread Sekhar Nori
Hi Hans, On Friday 16 December 2016 03:17 PM, Hans Verkuil wrote: > On 07/12/16 19:30, Kevin Hilman wrote: >> Prepare the groundwork for adding DT support for davinci VPIF drivers. >> This series does some fixups/cleanups and then adds the DT binding and >> DT compatible string matching for DT pro

Re: [PATCH] [media] staging/davinci_vfpe: allow modular build

2015-12-10 Thread Sekhar Nori
On Thursday 10 December 2015 08:10 PM, Mauro Carvalho Chehab wrote: > Em Thu, 10 Dec 2015 15:29:38 +0100 > Arnd Bergmann escreveu: > >> It has never been possible to actually build this driver as >> a loadable module, only built-in because the Makefile attempts >> to build each file into its own

Re: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h

2015-04-05 Thread Sekhar Nori
linux/clk.h. > > Signed-off-by: Russell King > --- > arch/arm/mach-davinci/da850.c| 1 + For the DaVinci change: Acked-by: Sekhar Nori Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger

Re: [PATCH v3 06/10] [media] platform: Make use of media_bus_format enum

2014-11-10 Thread Sekhar Nori
On Tuesday 11 November 2014 10:12 AM, Sekhar Nori wrote: > On Saturday 08 November 2014 02:48 PM, Prabhakar Lad wrote: >> Hi, >> >> Thanks for the patch, >> >> On Fri, Nov 7, 2014 at 2:07 PM, Boris Brezillon >> wrote: >>> In order to have subs

Re: [PATCH v3 06/10] [media] platform: Make use of media_bus_format enum

2014-11-10 Thread Sekhar Nori
On Saturday 08 November 2014 02:48 PM, Prabhakar Lad wrote: > Hi, > > Thanks for the patch, > > On Fri, Nov 7, 2014 at 2:07 PM, Boris Brezillon > wrote: >> In order to have subsytem agnostic media bus format definitions we've >> moved media bus definition to include/uapi/linux/media-bus-format.h

Re: [PATCH v3 1/2] media: i2c: adv7343: make the platform data members as array

2013-07-22 Thread Sekhar Nori
is patch also makes appropriate changes to board-da850-evm.c > > Signed-off-by: Lad, Prabhakar > Cc: Sekhar Nori > Cc: linux-arm-ker...@lists.infradead.org For the board-da850-evm.c change: Acked-by: Sekhar Nori Thanks, Sekhar -- To unsubscribe from this list: send the line

Re: [PATCH v2 1/4] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-06-06 Thread Sekhar Nori
On 6/6/2013 3:32 PM, Prabhakar Lad wrote: > Hi Sekhar, > > On Thu, Jun 6, 2013 at 10:06 AM, Sekhar Nori wrote: >> On 5/25/2013 11:09 PM, Prabhakar Lad wrote: >>> From: Lad, Prabhakar >>> >>> remove init_enable from ths7303 pdata as it is be

Re: [PATCH v2 1/4] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-06-05 Thread Sekhar Nori
On 5/25/2013 11:09 PM, Prabhakar Lad wrote: > From: Lad, Prabhakar > > remove init_enable from ths7303 pdata as it is being dropped > from ths7303_platform_data. > > Signed-off-by: Lad, Prabhakar > Cc: Sekhar Nori > Cc: Hans Verkuil > Cc: Laurent Pinchart > C

Re: [PATCH 0/6] Davinci fbdev driver and enable it for DMx platform

2013-05-03 Thread Sekhar Nori
On 4/26/2013 11:16 AM, Prabhakar Lad wrote: > Hi Laurent, > > On Thu, Apr 25, 2013 at 2:32 AM, Laurent Pinchart > wrote: >> Hi Prabhakar, >> >> Thank you for the patch. >> >> On Wednesday 24 April 2013 17:30:02 Prabhakar Lad wrote: >>> From: Lad, Prabhakar >>> >>> This patch series adds an fbdev

Re: [PATCH v3 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-04-09 Thread Sekhar Nori
On 4/8/2013 5:49 PM, Prabhakar lad wrote: > From: Lad, Prabhakar > > The vpss clocks were enabled by calling a exported function from a driver > in a machine code. calling driver code from platform code is incorrect way. > > This patch fixes this issue and calls the function from driver code i

Re: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Sekhar Nori
On 4/8/2013 5:08 PM, Prabhakar Lad wrote: > Sekhar, > > On Mon, Apr 8, 2013 at 3:56 PM, Sekhar Nori wrote: >> On 4/2/2013 5:14 PM, Prabhakar lad wrote: >>> From: Lad, Prabhakar >>> >>> By default the VPSS clocks were enabled in capture driver >&

Re: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks

2013-04-08 Thread Sekhar Nori
{ > > static struct pm_clk_notifier_block platform_bus_notifier = { > .pm_domain = &davinci_pm_domain, > - .con_ids = { "fck", NULL, }, > + .con_ids = { "fck", "master", "slave", NULL, }, NULL is sentinel so you can drop the ','

Re: [PATCH v3] media: davinci: kconfig: fix incorrect selects

2013-04-08 Thread Sekhar Nori
On 4/8/2013 1:39 PM, Prabhakar Lad wrote: > Hi Sekhar, >> config VIDEO_DAVINCI_VPBE_DISPLAY >> - tristate "DM644X/DM365/DM355 VPBE HW module" >> - depends on ARCH_DAVINCI_DM644x || ARCH_DAVINCI_DM355 || >> ARCH_DAVINCI_DM365 >> - select VIDEO_VPSS_SYSTEM >> + tristate "TI

Re: [PATCH] davinci: vpif: add pm_runtime support

2013-03-31 Thread Sekhar Nori
On 3/28/2013 3:50 PM, Prabhakar Lad wrote: > Hi Laurent, > > On Thu, Mar 28, 2013 at 3:40 PM, Laurent Pinchart > wrote: >> Hi Prabhakar, >> >> On Thursday 28 March 2013 15:36:11 Prabhakar Lad wrote: >>> On Thu, Mar 28, 2013 at 2:39 PM, Laurent Pinchart wrote: On Thursday 28 March 2013 14:20:

Re: [PATCH 2/2] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-03-25 Thread Sekhar Nori
On 3/25/2013 3:45 PM, Prabhakar Lad wrote: > Hi Sekhar, > > On Mon, Mar 25, 2013 at 11:09 AM, Sekhar Nori wrote: >> On 3/22/2013 1:23 PM, Prabhakar lad wrote: >>> From: Lad, Prabhakar >>> >>> The vpss clocks were enabled by calling a exported fu

Re: [PATCH 1/2] media: davinci: vpss: enable vpss clocks

2013-03-25 Thread Sekhar Nori
On 3/25/2013 3:44 PM, Prabhakar Lad wrote: > Hi Sekhar, > > Thanks for the review! > > On Mon, Mar 25, 2013 at 11:02 AM, Sekhar Nori wrote: >> On 3/22/2013 1:23 PM, Prabhakar lad wrote: >>> From: Lad, Prabhakar >>> >>> By default the VPSS c

Re: [PATCH 2/2] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

2013-03-24 Thread Sekhar Nori
On 3/22/2013 1:23 PM, Prabhakar lad wrote: > From: Lad, Prabhakar > > The vpss clocks were enabled by calling a exported function from a driver > in a machine code. calling driver code from platform code is incorrect way. > > This patch fixes this issue and calls the function from driver code it

Re: [PATCH 1/2] media: davinci: vpss: enable vpss clocks

2013-03-24 Thread Sekhar Nori
On 3/22/2013 1:23 PM, Prabhakar lad wrote: > From: Lad, Prabhakar > > By default the VPSS clocks are only enabled in capture driver > for davinci family which creates duplicates. This > patch adds support to enable the VPSS clocks in VPSS driver. > This avoids duplication of code and also adding

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-19 Thread Sekhar Nori
On 3/12/2013 1:46 PM, Sekhar Nori wrote: > On 3/12/2013 10:44 AM, Prabhakar Lad wrote: >> BTW this patch still is not present in media list. > Not sure what is happening there. Its an open list as far as I can see > and there is no message I am getting back from list. Mos

Re: [PATCH v3] media: davinci: kconfig: fix incorrect selects

2013-03-18 Thread Sekhar Nori
On 3/16/2013 2:06 PM, Prabhakar Lad wrote: > Hi Sekhar, > > Thanks for the patch! > > On Tue, Mar 12, 2013 at 2:44 PM, Sekhar Nori wrote: >> drivers/media/platform/davinci/Kconfig uses selects where >> it should be using 'depends on'. This results in warning

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-12 Thread Sekhar Nori
On 3/12/2013 10:44 AM, Prabhakar Lad wrote: > Hi Sekhar, > > Thanks for the patch! few nits below > > also version number for patch is missing as this should have been v2 :) Missed that, sorry. > BTW this patch still is not present in media list. Not sure what is happening there. Its an open

Re: [PATCH] davinci: vpbe: fix module build

2013-03-08 Thread Sekhar Nori
0x33 0x35 0x35 0x2c 0x76 0x70 0x62 0x65 0x2d 0x76 0x65 0x6e 0x63 > 0x00 0x00 0x00 0x00 0x00 0x03 0x00 0x00 0x00 > FATAL: drivers/media/platform/davinci/vpbe_venc: struct platform_device_id is > not terminated with a NULL entry! > make[1]: *** [__modpost] Error 1 > > Reported-by: Se

Error while building vpbe display as module

2013-03-08 Thread Sekhar Nori
Prabhakar, Building with CONFIG_VIDEO_DAVINCI_VPBE_DISPLAY=m in latest mainline gives the error: MODPOST 130 modules drivers/media/platform/davinci/vpbe_osd: struct platform_device_id is 24 bytes. The last of 3 is: 0x64 0x6d 0x33 0x35 0x35 0x2c 0x76 0x70 0x62 0x65 0x2d 0x6f 0x73 0x64 0x00 0x0

Re: [PATCH] davinci: vpif: Fix module build for capture and display

2013-03-08 Thread Sekhar Nori
_capture.ko] undefined! > ERROR: "vpif_ch_params_count" > [drivers/media/platform/davinci/vpif_capture.ko] undefined! > ERROR: "vpif_base" [drivers/media/platform/davinci/vpif_capture.ko] undefined! > make[1]: *** [__modpost] Error 1 > > Reported-by: Sekhar Nori

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-07 Thread Sekhar Nori
On 3/7/2013 12:47 PM, Prabhakar Lad wrote: > On Wed, Mar 6, 2013 at 7:51 PM, Sekhar Nori wrote: >> So instead of presenting a non-useful vpif selection to users, >> vpif.c dependency is better handled in makefile, no? >> > Agreed that’s a better fix. How about VIDEO_VPF

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-06 Thread Sekhar Nori
On 3/6/2013 4:05 PM, Prabhakar Lad wrote: > On Wed, Mar 6, 2013 at 3:53 PM, Sekhar Nori wrote: >> On 3/6/2013 3:46 PM, Prabhakar Lad wrote: >>> Sekhar, >>> >>> On Wed, Mar 6, 2013 at 3:37 PM, Sekhar Nori wrote: >>>> On 3/6/2013 2

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-06 Thread Sekhar Nori
On 3/6/2013 3:46 PM, Prabhakar Lad wrote: > Sekhar, > > On Wed, Mar 6, 2013 at 3:37 PM, Sekhar Nori wrote: >> On 3/6/2013 2:59 PM, Prabhakar Lad wrote: >> >>>> config VIDEO_DAVINCI_VPIF_DISPLAY >>>> tristate "DM646x/DA850/OMAPL138 EV

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-06 Thread Sekhar Nori
On 3/6/2013 2:59 PM, Prabhakar Lad wrote: >> config VIDEO_DAVINCI_VPIF_DISPLAY >> tristate "DM646x/DA850/OMAPL138 EVM Video Display" >> - depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || >> MACH_DAVINCI_DA850_EVM) >> + depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || >

Re: [RFC PATCH 06/18] davinci: replace V4L2_OUT_CAP_CUSTOM_TIMINGS by V4L2_OUT_CAP_DV_TIMINGS

2013-02-19 Thread Sekhar Nori
Hi Hans, On 2/17/2013 1:03 AM, Hans Verkuil wrote: > On Sat February 16 2013 20:23:39 Sekhar Nori wrote: >> On 2/16/2013 6:28 PM, Prabhakar Lad wrote: >>> Cc'ed Sekhar, DLOS, LAK. >>> >>> Sekhar Can you Ack this patch ? Or maybe you can take this patch thr

Re: [RFC PATCH 06/18] davinci: replace V4L2_OUT_CAP_CUSTOM_TIMINGS by V4L2_OUT_CAP_DV_TIMINGS

2013-02-16 Thread Sekhar Nori
accepted code. If you wish to take this through media tree for v3.9, feel free to add: Acked-by: Sekhar Nori Since this appears to be an ARM-only patch, its better to add an 'ARM:' prefix to the subject line as is the norm with all other ARM patches. Thanks, Sekhar -- To unsubscribe fr

Re: [RFC PATCH 05/18] davinci: remove VPBE_ENC_DV_PRESET and rename VPBE_ENC_CUSTOM_TIMINGS

2013-02-16 Thread Sekhar Nori
On 2/16/2013 6:20 PM, Prabhakar Lad wrote: > Cc'ed Sekhar, DLOS, LAK. > > Sekhar Can you Ack this patch for platform changes ? Acked-by: Sekhar Nori Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to m

Re: [PATCH RFC v2] media: tvp514x: add OF support

2013-02-03 Thread Sekhar Nori
On 2/3/2013 3:43 PM, Prabhakar Lad wrote: > Hi Sylwester, > > Thanks for the review. > > On Sat, Feb 2, 2013 at 4:07 AM, Sylwester Nawrocki > wrote: >> Hi Prabhakar, >> >> On 01/29/2013 02:07 PM, Prabhakar Lad wrote: >> [...] >> >>> diff --git a/Documentation/devicetree/bindings/media/i2c/tvp514

Re: [PATCH] davinci: vpbe: pass different platform names to handle different ip's

2012-11-20 Thread Sekhar Nori
rm_get_device_id() > and gets the appropriate driver data for that platform. > > Taking this approach will also make the DT transition easier. > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli Looks good to me except some comments below. After addressing those, ple

Re: [RESEND-PATCH] media:davinci: clk - {prepare/unprepare} for common clk

2012-10-27 Thread Sekhar Nori
Hi Murali, On 10/26/2012 9:22 PM, Murali Karicheri wrote: > On 10/25/2012 09:12 AM, Prabhakar Lad wrote: >> Hi Murali, >> >> Thanks for the patch. I'll queue this patch for 3.8. > Please check with Sekhar as well. This is a preparation patch for common > clk framework support. ALso fixes some bu

Re: [PATCH v2] ARM: dm365: replace V4L2_OUT_CAP_CUSTOM_TIMINGS with V4L2_OUT_CAP_DV_TIMINGS

2012-10-24 Thread Sekhar Nori
On 10/23/2012 6:47 PM, Prabhakar Lad wrote: > From: Lad, Prabhakar > > This patch replaces V4L2_OUT_CAP_CUSTOM_TIMINGS macro with > V4L2_OUT_CAP_DV_TIMINGS. As V4L2_OUT_CAP_CUSTOM_TIMINGS is being phased > out. > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manju

Re: [PATCH] davinci: vpbe: replace V4L2_OUT_CAP_CUSTOM_TIMINGS with V4L2_OUT_CAP_DV_TIMINGS

2012-10-03 Thread Sekhar Nori
On 10/3/2012 12:02 PM, Prabhakar wrote: > From: Lad, Prabhakar > > This patch replaces V4L2_OUT_CAP_CUSTOM_TIMINGS macro with > V4L2_OUT_CAP_DV_TIMINGS. As V4L2_OUT_CAP_CUSTOM_TIMINGS is being phased > out. > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath

Re: [RFCv2 PATCH 13/14] davinci: move struct vpif_interface to chan_cfg.

2012-10-03 Thread Sekhar Nori
On 9/20/2012 5:36 PM, Hans Verkuil wrote: > From: Hans Verkuil > > struct vpif_interface is channel specific, not subdev specific. > Move it to the channel config. > > Signed-off-by: Hans Verkuil For the DaVinci platform changes: Acked-by: Sekhar Nori Thanks, Sekhar -- T

Re: [RFCv2 PATCH 06/14] vpif_capture: move routing info from subdev to input.

2012-10-03 Thread Sekhar Nori
orm change: Acked-by: Sekhar Nori Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFCv2 PATCH 05/14] vpif_capture: remove unnecessary can_route flag.

2012-10-03 Thread Sekhar Nori
On 9/20/2012 5:36 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Calling a subdev op that isn't implemented will just return -ENOIOCTLCMD > No need to have a flag for that. > > Signed-off-by: Hans Verkuil For the DaVinci platform change: Acked-by: Sekhar Nori

Re: [PATCH v3] media: davinci: vpif: display: separate out subdev from output

2012-10-02 Thread Sekhar Nori
th Hadli > Cc: Hans Verkuil > Cc: Sekhar Nori For the DaVinci platform changes: Acked-by: Sekhar Nori Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] dm644x: replace the obsolete preset API by the timings API.

2012-10-01 Thread Sekhar Nori
On 8/8/2012 6:00 PM, Prabhakar Lad wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli Please have a patch description. For the DaVinci platform portion: Acked-by: Sekhar Nori Thanks, Sekhar -- To u

Re: [PATCH] media: davinci: vpif: add check for NULL handler

2012-08-17 Thread Sekhar Nori
On 8/17/2012 2:45 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Friday 17 August 2012 14:02:19 Prabhakar Lad wrote: >> On Friday 17 August 2012 11:07 AM, Sekhar Nori wrote: >>> On 8/17/2012 10:51 AM, Prabhakar Lad wrote: >>>> On Thursday 16 August 2

Re: [PATCH] media: davinci: vpif: add check for NULL handler

2012-08-16 Thread Sekhar Nori
On 8/17/2012 10:51 AM, Prabhakar Lad wrote: > Hi Laurent, > > Thanks for the review. > > On Thursday 16 August 2012 08:43 PM, Laurent Pinchart wrote: >> Hi Prabhakar, >> >> Thanks for the patch. >> >> On Thursday 16 August 2012 19:32:00 Prabhakar Lad wrote: >>> From: Lad, Prabhakar >>> >>> Signe

Re: [PATCH] davinci: vpss: enable vpss clocks

2012-07-23 Thread Sekhar Nori
Hi Prabhakar, On 7/20/2012 7:41 PM, Prabhakar Lad wrote: > From: Lad, Prabhakar > > By default the VPSS clocks are only enabled in capture driver. > and display wont work if the capture is not enabled. This > patch adds support to enable the VPSS clocks in VPSS driver. > This way we can enable/d