Hi Malathi,
On 11/13/18 9:28 AM, mgot...@codeaurora.org wrote:
> On 2018-11-12 18:04, Stanimir Varbanov wrote:
>> Hi Tomasz,
>>
>> On 10/23/2018 05:50 AM, Tomasz Figa wrote:
>>> Hi Malathi,
>>>
>>> On Tue, Oct 9, 2018 at 4:58 PM Malathi Gottam
>
Hi Tomasz,
On 11/13/18 11:13 AM, Tomasz Figa wrote:
> On Tue, Nov 13, 2018 at 5:12 PM Stanimir Varbanov
> wrote:
>>
>> Hi Malathi,
>>
>> On 11/13/18 9:28 AM, mgot...@codeaurora.org wrote:
>>> On 2018-11-12 18:04, Stanimir Varbanov wrote:
>>>>
a/platform/qcom/venus/venc_ctrls.c | 15 +++
> 1 file changed, 15 insertions(+)
Acked-by: Stanimir Varbanov
>
> diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c
> b/drivers/media/platform/qcom/venus/venc_ctrls.c
> index 45910172..f90a34e 100644
>
Hi Alex,
On 11/22/18 10:31 AM, Alexandre Courbot wrote:
> On Fri, Nov 16, 2018 at 1:49 AM Nicolas Dufresne wrote:
>>
>> Le mercredi 14 novembre 2018 à 13:12 +0900, Alexandre Courbot a écrit :
>>> On Wed, Nov 14, 2018 at 3:54 AM Nicolas Dufresne
>>> wrote:
Le mar. 13 nov. 2018 04
> const struct venus_format *fmt;
> + __u32 sizeimage;
please use u32 for kernel internal variables.
Otherwise looks good to me:
Acked-by: Stanimir Varbanov
>
> memset(pfmt[0].reserved, 0, sizeof(pfmt[0].reserved));
> memset(pixmp->reserved, 0, siz
e to believe that the buffer actually contains useful data. Fix
> this by passing the number of bytes reported used by the firmware.
>
> Signed-off-by: Alexandre Courbot
> ---
> drivers/media/platform/qcom/venus/vdec.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-
a/platform/qcom/venus/venc.c | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
Acked-by: Stanimir Varbanov
>
> diff --git a/drivers/media/platform/qcom/venus/venc.c
> b/drivers/media/platform/qcom/venus/venc.c
> index ce85962..e43dd3d 100644
> --- a/drivers/m
Hi Hans,
On 11/26/18 3:37 PM, Hans Verkuil wrote:
> On 11/26/2018 11:12 AM, Malathi Gottam wrote:
>> Accept the buffer size requested by client and compare it
>> against driver calculated size and set the maximum to
>> bitstream plane.
>>
>> Signed-off-by: Malathi Gottam
>
> Sorry, this isn't al
Hi Alex,
On 11/27/18 9:31 AM, Alexandre Courbot wrote:
> On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam wrote:
>>
>> This adds video nodes to sdm845 based on the examples
>> in the bindings.
>>
>> Signed-off-by: Malathi Gottam
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34
Hi Tomasz,
On 11/3/18 5:01 AM, Tomasz Figa wrote:
> Hi Malathi,
>
> On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam wrote:
>>
>> When client requests for a keyframe, set the property
>> to hardware to generate the sync frame.
>>
>> Signed-off-by: Malathi Gottam
>> ---
>> drivers/media/platform/q
Hi Hans,
On 11/29/18 9:40 PM, Tomasz Figa wrote:
> On Thu, Nov 29, 2018 at 3:10 AM wrote:
>>
>>
>> Hi Stan,
>>
>> On 2018-11-29 16:01, Stanimir Varbanov wrote:
>>> Hi Tomasz,
>>>
>>> On 11/3/18 5:01 AM, Tomasz Figa wrote:
>>>
egments.
> So, initialize the max segment size properly to weed out this warning.
>
> Based on a similar patch sent by Sean Paul for mdss:
> https://patchwork.kernel.org/patch/10671457/
>
> Signed-off-by: Vivek Gautam
> ---
> drivers/media/platform/qcom/venus/core.c | 8
> 1 file changed, 8 insertions(+)
Acked-by: Stanimir Varbanov
--
regards,
Stan
Hi Vikash,
On 07/04/2018 10:06 PM, Vikash Garodia wrote:
> Add routine to reset the ARM9 and brings it out of reset. Also
> abstract the Venus CPU state handling with a new function. This
> is in preparation to add PIL functionality in venus driver.
>
> Signed-off-by: Vikash Garodia
> ---
> dri
Hi Vikash,
On 07/04/2018 10:06 PM, Vikash Garodia wrote:
> Separate firmware loading part into a new function.
I cannot apply this patch in order to test the series.
>
> Signed-off-by: Vikash Garodia
> ---
> drivers/media/platform/qcom/venus/core.c | 4 +-
> drivers/media/platform/qcom/v
Hi Vikash,
On 07/04/2018 10:06 PM, Vikash Garodia wrote:
> Video hardware is mainly comprised of vcodec subsystem and video
> control subsystem. Video control has ARM9 which executes the video
> firmware instructions whereas vcodec does the video frame processing.
> This change adds support to loa
Hi,
On 07/04/2018 10:06 PM, Vikash Garodia wrote:
> Add routine to reset the ARM9 and brings it out of reset. Also
> abstract the Venus CPU state handling with a new function. This
> is in preparation to add PIL functionality in venus driver.
>
> Signed-off-by: Vikash Garodia
> ---
> drivers/me
This registers a firmware platform_device and associate it with
video-firmware DT subnode. Then calls dma configure to initialize
dma and iommu.
Signed-off-by: Stanimir Varbanov
---
.../devicetree/bindings/media/qcom,venus.txt | 13 +-
drivers/media/platform/qcom/venus/core.c
Hi Vikash,
Could you give a try below patch on your environment? You should keep
your 1/4 to 3/4 patches and replace your 4/4 with the below one.
You have to drop the compatible string in firmware DT subnode (keep only
iommus).
On 08/22/2018 03:34 PM, Stanimir Varbanov wrote:
> This register
Hi,
On 09/11/2018 03:46 PM, Johan Fjeldtvedt wrote:
> Warn and return error from the reqbufs ioctl when driver sets 0 number
> of planes or 0 as plane sizes, as these values don't make any sense.
typo: planes -> buffers
> Checking this here stops obviously wrong values from propagating
> further
Hi Alex,
On 10/11/2018 09:50 AM, Alexandre Courbot wrote:
> Please ignore this patch - I did not notice that a similar one has
> been sent before.
The difference is that you made it for decoder as well. Do you need
userptr for decoder?
--
regards,
Stan
Hi Hans,
On 08/15/2017 01:04 PM, Hans Verkuil wrote:
> On 08/14/17 10:41, Stanimir Varbanov wrote:
>> Hi,
>>
>> This RFC patch is intended to give to the drivers a choice to change
>> the default behavior of the v4l2-core DMA mapping direction from
>> DMA_TO/FRO
Hi Laurent,
On 08/16/2017 03:28 PM, Laurent Pinchart wrote:
> Hi Stan,
>
> On Wednesday 16 Aug 2017 14:46:50 Stanimir Varbanov wrote:
>> On 08/15/2017 01:04 PM, Hans Verkuil wrote:
>>> On 08/14/17 10:41, Stanimir Varbanov wrote:
>>>> Hi,
>>>>
Hi,
On 07/17/2017 02:18 PM, Smitha T Murthy wrote:
> On Fri, 2017-07-07 at 17:59 +0300, Stanimir Varbanov wrote:
>> Hi,
>>
>> On 06/19/2017 08:10 AM, Smitha T Murthy wrote:
>>> Added V4l2 controls for HEVC encoder
>>>
>>> Signed-off-by: Smitha T M
Hi Gustavo,
On 08/18/2017 02:12 AM, Gustavo A. R. Silva wrote:
> Refactor code in order to avoid identical code for different branches.
>
> This issue was detected with the help of Coccinelle.
>
> Addresses-Coverity-ID: 1415317
> Signed-off-by: Gustavo A. R. Silva
> ---
> This code was reported
No one of the supported Venus version has implemented VP9 codec
for enconding, so drop it from the list of codecs.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/venc.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/venc.c
b
Adds a helper function to runtime check supported encoder and
decoder codecs depending on venus version and platform.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 49 +
drivers/media/platform/qcom/venus/helpers.h | 1 +
2 files
Use the helper function in decoder and encoder find_format
to runtime check supported codecs.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/vdec.c | 24 +---
drivers/media/platform/qcom/venus/venc.c | 28 +++-
2 files changed
Without PM support gcc could warns about unused functions, thus
mark runtime_suspend/resume as __maybe_unused.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/vdec.c | 6 ++
drivers/media/platform/qcom/venus/venc.c | 6 ++
2 files changed, 4 insertions(+), 8
-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/venc.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/venc.c
b/drivers/media/platform/qcom/venus/venc.c
index 39748e7a08e4..01af1ac89edf 100644
--- a/drivers/media/platform
This fills missing (forgotten) video device name with
appropriate string so that udev can distinguishes between
decoder and encoder devices.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/vdec.c | 1 +
drivers/media/platform/qcom/venus/venc.c | 1 +
2 files changed, 2
type of buffers as
read/write.
Signed-off-by: Stanimir Varbanov
---
drivers/media/v4l2-core/videobuf2-core.c | 17 -
include/media/videobuf2-core.h | 13 +
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c
v4.14. For more info look in the patch descriptions.
Comments are welcome!
regards,
Stan
[1] https://lkml.org/lkml/2017/8/14/104
[2] https://patchwork.kernel.org/patch/9394145/
Stanimir Varbanov (7):
media: vb2: add bidirectional flag in vb2_queue
media: venus: venc: set correct resolution on
Hi Hans,
On 08/18/2017 05:30 PM, Hans Verkuil wrote:
> On 08/18/17 16:16, Stanimir Varbanov wrote:
>> This change is intended to give to the v4l2 drivers a choice to
>> change the default behavior of the v4l2-core DMA mapping direction
>> from DMA_TO/FROM_DEVICE (dependi
type of buffers as
read/write.
Signed-off-by: Stanimir Varbanov
---
v2: move dma_dir into private section.
drivers/media/v4l2-core/videobuf2-core.c | 17 -
include/media/videobuf2-core.h | 13 +
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git a
Thanks Gustavo!
On 08/18/2017 07:07 PM, Gustavo A. R. Silva wrote:
> Call function v4l2_m2m_dst_buf_remove_by_buf() instead of
> v4l2_m2m_src_buf_remove_by_buf()
>
> Addresses-Coverity-ID: 1415317
> Cc: Stanimir Varbanov
> Cc: Hans Verkuil
> Signed-off-by: Gustavo A. R. S
type of buffers as
read/write.
Signed-off-by: Stanimir Varbanov
---
v3: update V4L2 dma-sg/contig and vmalloc memory type ops with a
check for DMA_BIDIRECTIONAL.
v2: move dma_dir into private section.
drivers/media/v4l2-core/videobuf2-core.c | 17 -
drivers/media/v4l2
Hi,
On 08/21/2017 01:21 PM, Hans Verkuil wrote:
> On 08/21/2017 11:29 AM, Marek Szyprowski wrote:
>> Hi Stanimir,
>>
>> On 2017-08-21 11:09, Stanimir Varbanov wrote:
>>> This change is intended to give to the v4l2 drivers a choice to
>>> change the defaul
Hi Marek,
On 08/21/2017 03:21 PM, Marek Szyprowski wrote:
> Hi Stanimir,
>
> On 2017-08-21 13:34, Stanimir Varbanov wrote:
>> This change is intended to give to the v4l2 drivers a choice to
>> change the default behavior of the v4l2-core DMA mapping direction
>&
Gustavo,
could you resend the patch with the Acked-by and Cc stable kernel.
On 08/18/2017 07:07 PM, Gustavo A. R. Silva wrote:
> Call function v4l2_m2m_dst_buf_remove_by_buf() instead of
> v4l2_m2m_src_buf_remove_by_buf()
>
> Addresses-Coverity-ID: 1415317
> Cc: Stanimir Varba
On 08/23/2017 03:59 PM, Stanimir Varbanov wrote:
> Gustavo,
>
> could you resend the patch with the Acked-by and Cc stable kernel.
No need to resend, sorry for the noise.
--
regards,
Stan
: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/qcom/venus/helpers.c
b/drivers/media/platform/qcom/venus/helpers.c
index 68933d208063..9b2a401a4891 100644
--- a/drivers/media/platform/qcom/venus
-vmalloc, i.e. the pattern used in vmalloc has been
copied to dc and dma-sg.
Suggested-by: Marek Szyprowski
Signed-off-by: Stanimir Varbanov
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 6 --
drivers/media/v4l2-core/videobuf2-dma-sg.c | 7 +++
2 files changed, 7 insertions(+), 6
Hi Hans,
On 7.05.2018 13:39, Hans Verkuil wrote:
On 24/04/18 14:44, Stanimir Varbanov wrote:
This add HEVC codec support for venus versions 3xx and 4xx.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 3 +++
drivers/media/platform/qcom/venus/hfi.c
Hi Hans,
On 7.05.2018 13:41, Hans Verkuil wrote:
On 24/04/18 14:44, Stanimir Varbanov wrote:
Hello,
This patch set aims to:
* add initial support for Venus version 4xx (found on sdm845).
* introduce a common capability parser to enumerate better
supported uncompressed formats
Hi Vikash,
On 05/04/2018 02:09 PM, Vikash Garodia wrote:
> Hi Stanimir,
>
> On 2018-05-03 17:06, Stanimir Varbanov wrote:
>> Hi Vikash,
>>
>> Thanks for the comments!
>>
>> On 2.05.2018 09:26, Vikash Garodia wrote:
>>> Hello Stanimir,
>
Hi Vikash,
On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote:
> Hello Stanimir,
>
> On 2018-04-24 18:14, Stanimir Varbanov wrote:
>> This adds suspend (power collapse) function with slightly
>> different order of calls comparing with Venus 3xx.
>>
>>
Hi,
On 05/09/2018 05:14 PM, Vikash Garodia wrote:
> Hi Stanimir,
>
> On 2018-05-09 16:45, Stanimir Varbanov wrote:
>> Hi Vikash,
>>
>> On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote:
>>> Hello Stanimir,
>>>
>>> On 2018-04-24 18:14,
This adds suspend (power collapse) functionality by reusing
the suspend function for Venus 3xx and also enables idle indicator
property for Venus 4xx (where it is disabled by default).
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi_venus.c | 11 ++-
1 file
This is implementing a multi-stream decoder support. The multi
stream gives an option to use the secondary decoder output
with different raw format (or the same in case of crop).
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h| 1 +
drivers/media/platform
This add HEVC codec support for venus versions 3xx and 4xx.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h| 2 ++
drivers/media/platform/qcom/venus/helpers.c | 3 ++
drivers/media/platform/qcom/venus/hfi.c | 2 ++
drivers/media/platform/qcom/venus
This adds sdm845 DT compatible string with it's resource
data table.
Reviewed-by: Rob Herring
Signed-off-by: Stanimir Varbanov
---
.../devicetree/bindings/media/qcom,venus.txt | 1 +
drivers/media/platform/qcom/venus/core.c | 22 ++
2 files change
Make a new function vdec_output_conf() for decoder output
configuration. vdec_output_conf() will set properties via
HFI interface related to the output configuration, and
keep vdec_set_properties() which will set properties
related to decoding parameters.
Signed-off-by: Stanimir Varbanov
move calculations of raw and compressed in a common helper
and make it identical for encoder and decoder.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 98 +
drivers/media/platform/qcom/venus/helpers.h | 2 +
drivers/media
Add and use a helper function to set actual buffer size for
particular buffer type. This is also preparation to use
the second decoder output.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 12
drivers/media/platform/qcom/venus/helpers.h | 1
Rework and rename vdec_cap_num_buffers() to get the number of
input buffers too.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/vdec.c | 41 +++-
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git a/drivers/media/platform/qcom/venus
Add a helper function to return current output picture buffer size.
OPB sizes can vary depending on the selected decoder output(s).
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h| 10 ++
drivers/media/platform/qcom/venus/helpers.c | 15
Delete not used flag for capture buffer allocation mode.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.h
b/drivers/media/platform/qcom/venus/core.h
index fe2d2b9e8af8
These are new properties applicable to Venus version 4xx. Add the
helpers and call them from decoder and encoder drivers.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 28
drivers/media/platform/qcom/venus/helpers.h | 2
Extend venus_helper_set_num_bufs() helper function with one more
argument to set number of output buffers for the secondary decoder
output.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 16 ++--
drivers/media/platform/qcom/venus/helpers.h | 3
Adds a new helper function to set dynamic buffer mode if it is
supported by current HFI version.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 22 ++
drivers/media/platform/qcom/venus/helpers.h | 1 +
drivers/media/platform/qcom/venus
Rename is_reg_unreg_needed() to better name is_dynamic_bufmode() and
use buffer mode from enumerated per codec capabilities.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git
The new helper will has one more argument for buffer type, that
way the decoder can configure the format on it's secondary
output.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 52 ++---
drivers/media/platform/qcom/venus/help
Make common function which will enable power when enabling/disabling
clocks and also covers Venus 3xx/4xx versions.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 51 +
drivers/media/platform/qcom/venus/helpers.h | 2 ++
drivers
This adds common capability parser for all supported Venus
versions. Having it will help to enumerate better the supported
raw formars and codecs and also the capabilities for every
codec like max/min width/height, framerate, bitrate and so on.
Signed-off-by: Stanimir Varbanov
---
drivers/media
Delete no longer used flag cap_bufs_mode_dynamic from instance
structure.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h | 2 --
drivers/media/platform/qcom/venus/hfi_parser.c | 6 +-
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers
This adds one more function argument to pass buffer type to
set_output_resolution() helper function. That is a preparation
to support secondary decoder output.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 5 +++--
drivers/media/platform/qcom/venus/helpers.h
This extends the clocks number to support suspend and resume
on Venus version 4xx.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h | 4 +--
drivers/media/platform/qcom/venus/vdec.c | 42 ++--
drivers/media/platform/qcom/venus/venc.c
This fixes the suspend function for Venus 3xx versions by
add a check for WFI (wait for interrupt) bit. This bit
is on when the ARM9 is idle and entered in low power mode.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi_venus.c| 59
property early before
we enter into venus_suspend function where we need to check for
ARM9 WFI.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi_venus.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/qcom/venus
This makes possible to handle session_continue for 4xx as well.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/hfi.c
b/drivers/media/platform/qcom/venus/hfi.c
Add AXI halt support for version 4xx by using venus wrapper
registers.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi_venus.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c
b/drivers/media
Adds set_properties method to handle newer 4xx properties and
fall-back to 3xx for the rest.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi_cmds.c | 64 +++-
1 file changed, 63 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform
This adds handling of buffers of type OUTPUT2 which is needed to
support Venus 4xx version.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi.c | 3 ++-
drivers/media/platform/qcom/venus/hfi_msgs.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff
Data pointer should be incremented by size of the structure not
the size of a pointer, correct the mistake.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus
HFI version 4xx can pass more properties in the sequence change
event, extend the event structure with them.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi.h | 9 ++
drivers/media/platform/qcom/venus/hfi_msgs.c | 46
2 files
This covers the differences between 1xx,3xx and 4xx.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/core.h | 4 ++
drivers/media/platform/qcom/venus/helpers.c | 37 +++
drivers/media/platform/qcom/venus/hfi_helper.h | 84
.
* spelling typo in 15/28.
* added Reviewed-by for DT changes.
* extended 28/28 HEVC support for encoder, now the profile and
level are selected properly.
Comments are welcome!
regards,
Stan
Stanimir Varbanov (29):
venus: hfi_msgs: correct pointer increment
venus: hfi: preparation to
Hi Hans,
On 05/15/2018 11:17 AM, Hans Verkuil wrote:
> Hi Stanimir,
>
> On 05/15/18 09:58, Stanimir Varbanov wrote:
>> This is implementing a multi-stream decoder support. The multi
>> stream gives an option to use the secondary decoder output
>> with different raw for
Hi Tomasz,
Thanks for the review!
On 05/18/2018 11:33 AM, Tomasz Figa wrote:
> Hi Stanimir,
>
> Thanks for the series. I'll be gradually reviewing subsequent patches. Stay
> tuned. :)
>
Please consider that there is a v2 of this patchset. :)
>
> Reviewed-by: Tomasz Figa
>
Thanks!
--
reg
give them to the firmware.
The other decoder output (we called it OPB) format will be NV12
linear format and with the same resolution (or smaller in case
the user wants to downscale).
Signed-off-by: Stanimir Varbanov
---
Hi Hans, I have updated patch description a bit. Is it now clearer?
If you
Hi Tomasz,
On 05/18/2018 05:23 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:12 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> Add AXI halt support for version 4xx by using venus wrapper
>> registers.
>
>> Signed-off-by: Stanimir
Hi Tomasz,
On 05/18/2018 06:14 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:11 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> This fixes the suspend function for Venus 3xx versions by
>> add a check for WFI (wait for interrupt) bit. This bi
Hi Tomasz,
Thanks for the comments!
On 05/18/2018 12:44 PM, Tomasz Figa wrote:
> Hi Stanimir,
>
> On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> This covers the differences between 1xx,3xx and 4xx.
>
>&
Hi Tomasz,
On 05/18/2018 04:53 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> HFI version 4xx can pass more properties in the sequence change
>> event, extend the event structure with them.
&g
Hi Tomasz,
On 05/18/2018 05:16 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:13 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> Adds set_properties method to handle newer 4xx properties and
>> fall-back to 3xx for the rest.
>
>&
Hi Vikash,
On 05/17/2018 02:32 PM, Vikash Garodia wrote:
> This adds support to load the video firmware
> and bring ARM9 out of reset. This is useful
> for platforms which does not have trustzone
> to reset the ARM9.
>
> Signed-off-by: Vikash Garodia
> ---
> .../devicetree/bindings/media/qcom,v
Hi Vikash,
On 05/17/2018 02:32 PM, Vikash Garodia wrote:
> In order to invoke scm calls, ensure that the platform
> has the required support to invoke the scm calls in
> secure world. This code is in preparation to add PIL
> functionality in venus driver.
>
> Signed-off-by: Vikash Garodia
> ---
Hi,
On 05/22/2018 04:02 PM, Stanimir Varbanov wrote:
> Hi Vikash,
>
> On 05/17/2018 02:32 PM, Vikash Garodia wrote:
>> This adds support to load the video firmware
>> and bring ARM9 out of reset. This is useful
>> for platforms which does not have trustzone
>> to
Hi Jordan,
On 22.05.2018 22:50, Jordan Crouse wrote:
On Tue, May 22, 2018 at 04:04:51PM +0300, Stanimir Varbanov wrote:
Hi Vikash,
On 05/17/2018 02:32 PM, Vikash Garodia wrote:
In order to invoke scm calls, ensure that the platform
has the required support to invoke the scm calls in
secure
Hi Tomasz,
On 05/24/2018 09:11 AM, Tomasz Figa wrote:
> Hi Stanimir,
>
> On Tue, May 15, 2018 at 5:10 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> This extends the clocks number to support suspend and resume
>> on Venus version 4xx.
>
This adds suspend (power collapse) functionality by reusing
the suspend function for Venus 3xx and also enables idle indicator
property for Venus 4xx (where it is disabled by default).
Signed-off-by: Stanimir Varbanov
Reviewed-by: Tomasz Figa
---
drivers/media/platform/qcom/venus/hfi_venus.c
Hi Smitha,
Thanks for the patches!
On 12/08/2017 11:08 AM, Smitha T Murthy wrote:
Add v4l2 controls for HEVC encoder
Signed-off-by: Smitha T Murthy
Reviewed-by: Andrzej Hajda
---
drivers/media/v4l2-core/v4l2-ctrls.c | 118 +++
include/uapi/linux/v4l2-controls
Hi Alex,
Thanks for the patch!
On 13.03.2018 11:11, Alexandre Courbot wrote:
> find_format_by_index() stops enumerating formats as soon as the index
> matches, and returns NULL if venus_helper_check_codec() finds out that
> the format is not supported. This prevents formats to be properly
> enume
rted codecs
>
> Signed-off-by: Alexandre Courbot
> ---
> drivers/media/platform/qcom/venus/vdec.c | 13 +++--
> drivers/media/platform/qcom/venus/venc.c | 13 +++--
> 2 files changed, 14 insertions(+), 12 deletions(-)
Acked-by: Stanimir Varbanov
--
regards,
Stan
Hi Hans,
Could you take this patch it not too late.
On 20.03.2018 15:42, Stanimir Varbanov wrote:
Hi Alex,
Thanks!
On 03/19/2018 11:32 AM, Alexandre Courbot wrote:
find_format_by_index() stops enumerating formats as soon as the index
matches, and returns NULL if venus_helper_check_codec
are welcome!
regards,
Stan
Stanimir Varbanov (28):
venus: hfi_msgs: correct pointer increment
venus: hfi: preparation to support venus 4xx
venus: hfi: update sequence event to handle more properties
venus: hfi_cmds: add set_properties for 4xx version
venus: hfi: support session continue
Add and use a helper function to set actual buffer size for
particular buffer type. This is also preparation to use
the second decoder output.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 12
drivers/media/platform/qcom/venus/helpers.h | 1
This add HEVC codec support for venus versions 3xx and 4xx.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 3 +++
drivers/media/platform/qcom/venus/hfi.c | 2 ++
drivers/media/platform/qcom/venus/vdec.c| 4
drivers/media/platform/qcom/venus
move calculations of raw and compressed in a common helper
and make it identical for encoder and decoder.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/helpers.c | 98 +
drivers/media/platform/qcom/venus/helpers.h | 2 +
drivers/media
Make a new function vdec_output_conf() for decoder output
configuration. vdec_output_conf() will set properties via
HFI interface related to the output configuration, and
keep vdec_set_properties() which will set properties
related to decoding parameters.
Signed-off-by: Stanimir Varbanov
301 - 400 of 445 matches
Mail list logo