Re: [PATCH v2 53/58] firewire: don't break long lines

2016-10-19 Thread Stefan Richter
> Would the above be OK for you? ACK. -- Stefan Richter -==- =-=- =-=-- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 53/58] firewire: don't break long lines

2016-10-19 Thread Stefan Richter
ade to use dev_XYZ(). (On an unrelated note, this reminds me that I still need to take care of Mauro's patches "Add a keymap for FireDTV board" and "firedtv: Port it to use rc_core" from May 28, 2012.) -- Stefan Richter -==- =-=- =--== http://arcgraph.de/sr/ -- To unsubs

Re: [PATCH 03/57] [media] firewire: don't break long lines

2016-10-15 Thread Stefan Richter
strings at the source code. So, join those continuation > > lines. > > > > Signed-off-by: Mauro Carvalho Chehab > > I prefer this patch because of the same reason in patch comment. > > Reviewed-by: Takashi Sakamoto Acked-by: Stefan Richter > > --- &

Re: [PATCH 00/57] don't break long lines on strings

2016-10-15 Thread Stefan Richter
On Oct 14 Mauro Carvalho Chehab wrote: > There are lots of drivers on media that breaks long line strings in order to > fit into 80 columns. This was an usual practice to make checkpatch happy. This was practice even before checkpatch existed. -- Stefan Richter -==- =-=- -===

Re: [PATCH 18/26] [media] dvb: Get rid of typedev usage for enums

2015-06-08 Thread Stefan Richter
On Jun 08 Mauro Carvalho Chehab wrote: > The DVB API was originally defined using typedefs. This is against > Kernel CodingStyle, and there's no good usage here. While we can't > remove its usage on userspace, we can avoid its usage in Kernelspace. [...] Acked-by: Stefan Rich

Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca in firedtv-avc.c

2015-02-08 Thread Stefan Richter
On Feb 08 nick wrote: > On 2015-02-08 06:55 PM, Stefan Richter wrote: > > I still am missing research on the question whether or not the Common > > Interface serving part of the driver needs to send Host2CA commands. If > > yes, we implement it and use the function.

Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca in firedtv-avc.c

2015-02-08 Thread Stefan Richter
r_operands(c, 6, 8); > - > - fdtv->avc_data_length = 12; > - ret = avc_write(fdtv); > - > - /* FIXME: check response code? */ > - > - mutex_unlock(&fdtv->avc_mutex); > - > - return ret; > -} > -#endif > - > static int get_ca_object_pos(s

Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca

2015-02-08 Thread Stefan Richter
t; - > - mutex_unlock(&fdtv->avc_mutex); > - > - return ret; > -} > -#endif > - > static int get_ca_object_pos(struct avc_response_frame *r) > { > int length = 1; -- Stefan Richter -=-= --=- -=--- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] [media] firewire: Deletion of an unnecessary check before the function call "dvb_unregister_device"

2014-11-20 Thread Stefan Richter
detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Stefan Richter > --- > drivers/media/firewire/firedtv-ci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/firewire/firedtv-ci.c > b/driver

Re: [PATCH] [media] fix a warning on avr32 arch

2014-10-30 Thread Stefan Richter
gt; > In this particular case, the signal is desired, as the isochannel > var can be initalized with -1 inside the driver. > > So, change the type to s8, to avoid issues on archs where char > is unsigned. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Stefan Rich

Re: [patch] [media] firewire: firedtv-avc: potential buffer overflow

2014-09-08 Thread Stefan Richter
On Sep 08 Stefan Richter wrote: > On Sep 08 Dan Carpenter wrote: > > "program_info_length" is user controlled and can go up to 4095. The > > operand[] array has 509 bytes so we need to add a limit here to prevent > > buffer overflows. > > > > Sig

Re: [patch] [media] firewire: firedtv-avc: potential buffer overflow

2014-09-08 Thread Stefan Richter
On Sep 08 Dan Carpenter wrote: > "program_info_length" is user controlled and can go up to 4095. The > operand[] array has 509 bytes so we need to add a limit here to prevent > buffer overflows. > > Signed-off-by: Dan Carpenter Reviewed-by: Stefan Richter Than

Re: [PATCH 2/3] femon: Display SNR in dB

2013-11-25 Thread Stefan Richter
-T and DVB-S2 incarnations of FireDTV devices. Right now I don't remember how that application presents it (i.e. as percentage or dB or whatever...). When I looked at that application and at kaffeine some years ago, they displayed grossly different values. I did not research back then wh

Re: [PATCH 2/3] femon: Display SNR in dB

2013-11-25 Thread Stefan Richter
On Nov 25 Stefan Richter wrote: > On Nov 25 Jean Delvare wrote: > > Hi Manu, > > > > On Sun, 24 Nov 2013 22:51:33 +0530, Manu Abraham wrote: > > > Sorry, that I came upon this patch quite late. > > > > No problem, better late than never! :) > > &g

Re: [PATCH] driver: firewire: remove unnecessary #if 0 code

2013-09-24 Thread Stefan Richter
rand[7] & 0x7f); i++) { > - size <<= 8; > - size += r->operand[8 + i]; > - } > -#endif > return r->operand[7]; > } > Hi Henrik, get_ca_object_pos() is used in avc_ca_get_mmi() when the AVC response

Re: [PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread Stefan Richter
> > I anticipate adding some more users of this constant when > adding MPLS support to Open vSwtich. > > As suggested by Jesse Gross. > > Compile tested only. > > Cc: Jesse Gross > Cc: Stefan Richter > Cc: Karsten Keil > Cc: Mauro Carvalho Chehab > Cc

[PATCH] firedtv: add MAINTAINERS entry

2012-11-03 Thread Stefan Richter
an file path. The F: drivers/media/firewire/ pattern and the "FireWire media drivers" title are currently synonymous with firedtv. If more drivers get added there, this can be revisited. I don't have documentation or DVB-S2 devices to test, but I have DVB-C and DVB-T devices for testing

Re: [PATCH 2/2] [media] firedtv: Port it to use rc_core

2012-05-28 Thread Stefan Richter
On May 28 Stefan Richter wrote: > > + idev->phys = "/ir0";/* FIXME */ > > Something similar to drivers/media/dvb/dvb-usb/dvb-usb-remote.c:: > > usb_make_path(d->udev, d->rc_phys, sizeof(d->rc_phys)); > strlcat(d->rc_phy

Re: [PATCH 2/2] [media] firedtv: Port it to use rc_core

2012-05-28 Thread Stefan Richter
ceived; > struct work_struct remote_ctrl_work; > - struct input_dev*remote_ctrl_dev; > + struct rc_dev *remote_ctrl_dev; > > enum model_type type; > charsubunit; (Do you want to reroll it or should I resubmit it my

Re: [PATCH 1/2] [media] Add a keymap for FireDTV board

2012-05-28 Thread Stefan Richter
"rc-winfast" > #define RC_MAP_WINFAST_USBII_DELUXE "rc-winfast-usbii-deluxe" > +#define RC_MAP_FIREDTV"rc-firedtv" > > /* > * Please, do not just append newer Remote Controller names at the end. The comment says that

Re: [RFC PATCH 0/3] Improve Kconfig selection for media devices

2012-05-28 Thread Stefan Richter
On May 28 Mauro Carvalho Chehab wrote: > Em 28-05-2012 06:48, Stefan Richter escreveu: > > c) The RC_CORE_SUPP help text gives the impression that RC core is > > always needed if there is hardware with an IR feature. But the firedtv > > driver is a case where the driver dir

Re: [RFC PATCH 0/3] Improve Kconfig selection for media devices

2012-05-28 Thread Stefan Richter
and transmitters, whereas Kconfig options in the analog and digital TV categories silently do "select RC_CORE if INPUT" for combined tuner + IR/RF rx/tx hardware? -- Stefan Richter -=-===-- -=-= ===-- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscr

Re: [GIT PULL for v3.5-rc1] media updates for v3.5

2012-05-25 Thread Stefan Richter
s # CONFIG_DVB_FE_CUSTOMISE is not set # DVB-S (satellite) frontends # DVB-T (terrestrial) frontends # DVB-C (cable) frontends # SEC control devices for DVB-S # CONFIG_DVB_DUMMY_FE is not set -- Stefan Richter -=-===-- -=-= ==-=- http://arcgraph.de/sr/ -- To unsubscribe from this list: send

Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers

2011-12-31 Thread Stefan Richter
ncomplete element type etc. pp. -- Stefan Richter -=-==-== ==-- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 9/9] [media] firedtv: handle errors from dvb_net_init

2011-12-31 Thread Stefan Richter
: > fdtv->demux.dmx.close(&fdtv->demux.dmx); > fail_rem_frontend: > fdtv->demux.dmx.remove_frontend(&fdtv->demux.dmx, > &fdtv->frontend); -- Stefan Richter -=-==-== ==-- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 4/14] staging/media/as102: checkpatch fixes

2011-10-31 Thread Stefan Richter
e.google.com/p/git-core/source/detail?spec=svnbe3fa9125e708348c7baf04ebe9507a72a9d1800&r=0cfd112032017ab68ed576f6bb5258452084ebf1 This converts the "# User" and "# Date" lines of HG patches into RFC 2822 "From: " and "Date: " lines which are then used as auth

Re: [RESEND PATCH 1/14] staging/media/as102: initial import from Abilis

2011-10-30 Thread Stefan Richter
acter table) might not be such a bad idea to keep things simple. But since you are passing on a patch from somebody else, the right thing to do is IMO to keep the special characters that the author chose and only make sure that the file (and the patch mailing) are UTF-8 encoded. -- Stefan Richter

Re: [RESEND PATCH 11/14] staging/media/as102: fix compile warning about unused function

2011-10-30 Thread Stefan Richter
t AFAIU, this patch here does not have such a cleanup in its scope. If the compat removal isn't already included later on in Piotr's series, it will be done later before this driver can be moved out of staging. -- Stefan Richter -=-==-== =-=- - http://arcgraph.de/sr/ -- To unsubs

Re: [PATCH v3 4/14] staging/media/as102: checkpatch fixes

2011-10-30 Thread Stefan Richter
art of a file, it is very important to generate the patch like "diff --show-c-function [...]" a.k.a. "diff -p [...]" would do. While this information is ignored by any tool which applies the patch, it highly increases the human- readability of the diff. Of

Re: [PATCH 1/7] Staging submission: PCTV 74e driver (as102)

2011-10-16 Thread Stefan Richter
, but not many developers take the time to do so.) Again, thanks for the effort and also thanks to Devin for making it possible. -- Stefan Richter -=-==-== =-=- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFCv2 PATCH 2/7] V4L menu: move legacy drivers into their own submenu.

2011-09-30 Thread Stefan Richter
ipped and disabled. There are obviously several already existing menuconfigs in the video section which do not have these sentences; so maybe don't add the above, or add it separately across the board, or whatever. I find these sentences helpful when running "make ol

Re: Staging submission: PCTV 80e and PCTV 74e drivers (was Re: Problems cloning the git repostories)

2011-09-27 Thread Stefan Richter
On Sep 27 Greg KH wrote: > On Tue, Sep 27, 2011 at 09:44:09AM +0200, Stefan Richter wrote: > > Adding Cc: staging maintainer and mailinglist. > > > > On Sep 26 Devin Heitmueller wrote: > > > On Sun, Sep 25, 2011 at 11:25 PM, Mauro Carvalho Chehab > > >

Staging submission: PCTV 80e and PCTV 74e drivers (was Re: Problems cloning the git repostories)

2011-09-27 Thread Stefan Richter
No need to get angry that it hasn't happened yet. :-) It's just a matter of the right people joining the effort at the right time. Thanks Devin for the offer, -- Stefan Richter -=-==-== =--= ==-== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH resend] [media] firedtv: change some -EFAULT returns to more fitting error codes

2011-07-06 Thread Stefan Richter
Let's just pass through the error returns of lower level I/O code where applicable, and -EACCES (permission denied) when a seemingly valid but negative FCP response or an unknown-to-firedtv CA message is received. Signed-off-by: Stefan Richter Cc: Henrik Kurelid --- Resent, hopefully w

[PATCH] [media] firedtv: change some -EFAULT returns to more fitting error codes

2011-07-06 Thread Stefan Richter
Let's just pass through the error returns of lower level I/O code where applicable, and -EACCES (permission denied) when a seemingly valid but negative FCP response or an unknown-to-firedtv CA message is received. Signed-off-by: Stefan Richter Cc: Henrik Kurelid --- Only tested on FireD

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
On Jun 24 Devin Heitmueller wrote: > On Fri, Jun 24, 2011 at 5:20 PM, Stefan Richter > wrote: > > Easier: > >  "I run Ubuntu 10.4". > >  "I run kernel 2.6.32." > > One of these is usually already included in the first post or IRC message >

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
erating system distributor, or driver source code is not released within kernel source code. -- Stefan Richter -=-==-== -==- ==--- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
t. On the other hand, Mauro's solution is redundant to the uname(2) syscall. ¹) Yes, it is still an ABI version, nothing less. With all its backwards and forwards compatibility ramifications. -- Stefan Richter -=-==-== -==- ==--- http://arcgraph.de/sr/ -- To unsubscribe from this li

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
so because I had to learn it too; I certainly wasn't born with an instinct knowledge how to do it properly. (Disclaimer: I have no stake in drivers/media/ ABIs. But I am involved in maintaining a userspace ABI elsewhere in drivers/firewire/, and one of the userspace libraries that use this AB

[PATCH] firewire: octlet AT payloads can be stack-allocated

2011-04-22 Thread Stefan Richter
r 8-byte block write requests on the other hand needs to remain slab-allocated in order to keep the allocation around until end of AT DMA. Signed-off-by: Stefan Richter --- Tested with firedtv, snd-firewire-speakers, sind-isight, and Coriander on a kernel with CONFIG_DMA_API_DEBUG=y. The patch

Re: firedtv and removal of old IEEE1394 stack

2011-02-09 Thread Stefan Richter
On Feb 09 Stefan Richter wrote: > > https://bugs.launchpad.net/ubuntu/+source/linux-kernel-headers/+bug/134222 Correction: Bug 134222 has *nothing* to do with the removal of the older ieee1394 stack. The bug is about 1. a defect during assembling the linux-kernel-headers package.

Re: firedtv and removal of old IEEE1394 stack

2011-02-09 Thread Stefan Richter
.config having to match the kernel sources applies just as well and fully describes the problem and its solution. :-) -- Stefan Richter -=-==-== --=- -=--= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to m

[PATCH] firedtv: drop obsolete backend abstraction

2011-02-06 Thread Stefan Richter
removal are implemented. Signed-off-by: Stefan Richter --- Applies after Hans' "firedtv: remove dependency on the deleted ieee1394 stack.", http://git.linuxtv.org/hverkuil/media_tree.git?a=commitdiff;h=f02c316436eef3baf349c489545edc7ade419ff6 drivers/media/dvb/firewire/fired

Re: [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD

2011-02-06 Thread Stefan Richter
hing. If you rewrite the changelog, you can add Reviewed-by: Stefan Richter if you like. -- Stefan Richter -=-==-== --=- --==- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: firedtv and removal of old IEEE1394 stack

2011-02-05 Thread Stefan Richter
On Feb 05 Stefan Richter wrote: > On Feb 03 Hans Verkuil wrote: > > It would be nice to remove this since building the firedtv driver for older > > kernels > > always gives problems on ubuntu due to some missing ieee1394 headers. > > How so? Then there is somethin

Re: [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD

2011-02-05 Thread Stefan Richter
e}; controlled by whether CONFIG_{IEEE1394,FIREWIRE} are defined or not. I will have a look at your changes later. -- Stefan Richter -=-==-== --=- --=-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord

Re: firedtv and removal of old IEEE1394 stack

2011-02-05 Thread Stefan Richter
rs. How so? Then there is something wrong with the backported sources. If CONFIG_IEEE1394 is not defined, neither make nor gcc ever see anything that includes ieee1394 headers. Vice versa regarding CONFIG_FIREWIRE and the newer firewire headers. -- Stefan Richter -=-==-== --=- --=-= http://

[PATCH incremental update] firedtv: fix remote control - addendum

2011-01-17 Thread Stefan Richter
Dimitry notes that EV_SYN is also necessary between down and up, otherwise userspace could combine their state. Signed-off-by: Stefan Richter --- Hi Mauro, since you already pushed out the first version of "firedtv: fix remote control with newer Xorg evdev", here is the differential pa

[PATCH update] firedtv: fix remote control with newer Xorg evdev

2011-01-17 Thread Stefan Richter
The Linux console did not have an issue with the FireDTV's RC though. The fix is to insert EV_SYN events after the key-down/-up events. Dimitry notes that EV_SYN is also necessary between down and up, otherwise userspace could combine their state. Signed-off-by: Stefan Richter --- dr

[PATCH] firedtv: fix remote control with newer Xorg evdev

2011-01-16 Thread Stefan Richter
The Linux console did not have an issue with the FireDTV's RC though. The fix is to insert EV_SYN events after the key-down/-up events. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-rc.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: b/dr

drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

2010-10-31 Thread Stefan Richter
nction It is due to an actual bug but I don't know the fix. -- Stefan Richter -=-==-=- =-=- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[git pull] dvb/firewire update

2010-10-13 Thread Stefan Richter
tions(-) -- Stefan Richter -=-==-=- =-=- -==-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH update2] V4L/DVB: firedtv: support for PSK8 for S2 devices. To watch HD.

2010-10-04 Thread Stefan Richter
It adds support for tuning with PSK8 modulation, pilot and rolloff with the S2 versions of firedtv. Signed-off-by: Tommy Jonsson Signed-off-by: Stefan Richter (trivial simplification) --- Sorry, missed two space-before-tab. drivers/media/dvb/firewire/firedtv-avc.c | 30 +-

[PATCH update] V4L/DVB: firedtv: support for PSK8 for S2 devices. To watch HD.

2010-10-04 Thread Stefan Richter
It adds support for tuning with PSK8 modulation, pilot and rolloff with the S2 versions of firedtv. Signed-off-by: Tommy Jonsson Signed-off-by: Stefan Richter (trivial simplification) --- Update: resend with whitespace preserved, fe pointer does not have to be put into function parameter lis

Re: [PATCH] firedtv driver: support for PSK8 for S2 devices. To watch HD.

2010-09-15 Thread Stefan Richter
property = fdtv_get_property; > + ops->set_property = fdtv_set_property; > + > ops->read_status= fdtv_read_status; > ops->read_ber = fdtv_read_ber; > ops->read_signal_strength = fdtv_read_signal_strength; [...] (Hmm, note to self: Can't DVB core provide empty default methods?) -- Stefan Richter -=-==-=- =--= - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] firedtv driver: support for PSK8 for S2 devices. To watch HD.

2010-09-15 Thread Stefan Richter
he mail user agent, and there appear to be some whitespace issues in it. I will have a closer look at it later today and repost the patch so that Mauro can apply it without manual intervention. -- Stefan Richter -=-==-=- =--= - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the

Re: Handling of large keycodes

2010-07-31 Thread Stefan Richter
Stefan Richter wrote: > - I take it from your description that scan codes are fundamentally > variable-length data. How about defining it as __u8 scancode[0]? Forget this; that would make it difficult to extend the ABI later by adding more struct members. -- Stefan R

Re: Handling of large keycodes

2010-07-31 Thread Stefan Richter
ce-feedback stuff. How about calling struct keymap_entry perhaps struct input_keymap_entry instead, to keep namespaces tidy? - I take it from your description that scan codes are fundamentally variable-length data. How about defining it as __u8 scancode[0]? -- Stefan Richter -=

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Stefan Richter
ady, "git commit --amend [-a] [...]" lets you alter the very last commit of course. -- Stefan Richter -=-==-=- -==- - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] IR: add core lirc device interface

2010-06-05 Thread Stefan Richter
ft compilers define unsigned long always only as 32 bits wide AFAIK. -- Stefan Richter -=-==-=- -==- --=-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: post 2.6.34 bug: new code enabled by default

2010-05-26 Thread Stefan Richter
Mauro Carvalho Chehab wrote: > Stefan Richter wrote: [CONFIG_RC_MAP et al] >> Please leave the default of new options at N. >> >> (Unless this were a special case of new options that replaced older >> options and need to be migrated to 'on' per default in make

post 2.6.34 bug: new code enabled by default

2010-05-25 Thread Stefan Richter
options that replaced older options and need to be migrated to 'on' per default in make oldconfig. I think this is not the case here.) -- Stefan Richter -=-==-=- -=-= ==--= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in t

Re: ideal DVB-C PCI/e card? [linux-media]

2010-05-25 Thread Stefan Richter
Jed wrote: > On 24/05/10 4:18 AM, Stefan Richter wrote: >> Jed wrote: >>> Ideally it'd be dual DVB-C, the only one I've found is more than dual >>> DVB-C& is far too expensive. >> >> If you need two receivers but can only spare up to one

Re: ideal DVB-C PCI/e card? [linux-media]

2010-05-23 Thread Stefan Richter
roduction now though and weren't exactly on the cheap side. OTOH one can drive up to 3 DVB FireWire receivers on a single FireWire bus; and for those who need even more there are dual link FireWire PCI and PCIe cards readily available. -- Stefan Richter -=-==-=- -=-= =-=== http://arcgraph

Re: V4L-DVB drivers and BKL

2010-04-03 Thread Stefan Richter
e >> that to the DVB experts. > > The main issue is at dvbdev, since it is used by all devices. We need to get > rid > of it. Get rid of its lock_kernel in open and its locked ioctl, or of the dvbdev 'library' itself? > That's said, Stefan Richter sent a patch me

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Stefan Richter
I leave > that to the DVB experts. As a dvb/firewire/firedtv user, I started to mess around with dvbdev and firedtv: https://patchwork.kernel.org/patch/88778/ -- Stefan Richter -=-==-=- -=-- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubs

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Stefan Richter
Stefan Richter wrote: >> linux/drivers/media/dvb/dvb-core/dvbdev.c: lock_kernel(); >> linux/drivers/media/dvb/dvb-core/dvbdev.c: unlock_kernel(); >> linux/drivers/media/dvb/dvb-core/dvbdev.c: unlock_kernel(); > > This is from when the BKL was pushed

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Stefan Richter
there are also - remaining .ioctl that need to be checked for possible concurrency issues, then converted to .unlocked_ioctl, - remaining .llseek uses (all implicit) which need to be checked whether they should be no_llseek() (accompanied by nonseekable_open) or generic_file_llse

[PATCH RFC v2] DVB: add dvb_generic_nonseekable_open, dvb_generic_unlocked_ioctl, use in firedtv

2010-03-28 Thread Stefan Richter
_ioctl and remove .kernel_ioctl and the temporarily introduced dvbdev.c::legacy_usercopy(). Applies to: drivers/media/dvb/ttpci/av7110.c drivers/media/dvb/ttpci/av7110_av.c drivers/media/dvb/ttpci/av7110_ca.c drivers/media/dvb/dvb-core/dvb_frontend.c Signed-off-by: Stef

[PATCH RFC] DVB: add dvb_generic_nonseekable_open, dvb_generic_unlocked_ioctl, use in firedtv

2010-03-27 Thread Stefan Richter
/read_write.c::no_llseek. Signed-off-by: Stefan Richter --- This patch is motivated by Arnd's "bkl removal: make unlocked_ioctl mandatory" http://git.kernel.org/?p=linux/kernel/git/arnd/playground.git;a=blobdiff;f=drivers/media/dvb/firewire/firedtv-ci.c;h=7ab89035c101240

Re: [PATCH] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-06 Thread Stefan Richter
Stefan Richter wrote: > I already posted an updated version of the patch which correctly defines > num_fake_ca_system_ids as an unsigned long. err, unsigned int of course, as http://patchwork.kernel.org/patch/82912/. -- Stefan Richter -=-==-=- --== --==- http://arcgraph.de/sr/

Re: [PATCH] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-06 Thread Stefan Richter
Mauro Carvalho Chehab wrote: > Stefan Richter wrote: > >> The Digital Everywhere firmware have the shortcoming that ca_info_enq and >> ca_info are not supported. This means that we can never retrieve the correct >> ca_system_id to present in the CI message CA_INFO. C

[PATCH update] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-01 Thread Stefan Richter
ca_system_ids can be specified. This is needed for users with CAMs that have different manufacturer id and ca_system_id and that uses applications that take this into account, like MythTV. Signed-off-by: Henrik Kurelid Signed-off-by: Stefan Richter (rebased, type of num_fake_ca_system_ids, format

Re: [PATCH] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-01 Thread Stefan Richter
hich retries a kind of dummy operation with different system IDs until success, initially during fdtv_dvb_register/ fdtv_ca_register? (I don't know how CI works, and alas I don't have a CAM myself for testing and am not very keen on getting one...) -- Stefan Richter -=-==-=- --==

[PATCH] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-01 Thread Stefan Richter
specified. This is needed for users with CAMs that have different manufacturer id and ca_system_id and that uses applications that take this into account, like MythTV. Signed-off-by: Henrik Kurelid Signed-off-by: Stefan Richter (rebased, format of comment) --- Would be good to get into an .34-rc too

[PATCH] firedtv: correct version number and current/next in CA_PMT

2010-03-01 Thread Stefan Richter
. The version number is now copied from the original PMT. Signed-off-by: Henrik Kurelid Signed-off-by: Stefan Richter --- This patch got stuck somehow on the long way upstream. :-) Would be good to get into one of the next .34-rc releases. drivers/media/dvb/firewire/firedtv-avc.c |2 +- 1

How to add DVB-S2 support to firedtv?

2010-02-14 Thread Stefan Richter
current driver code enough to connect the dots? Is the transport stream different from DVB-C HD streams so that changes to the isochronous I/O part would be required? -- Stefan Richter -=-==-=- --=- -===- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe

Re: [hg:v4l-dvb] firedtv: do not DMA-map stack addresses

2010-02-01 Thread Stefan Richter
This way my worries are unfounded. :-) -- Stefan Richter -=-==-=- --=- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [hg:v4l-dvb] firedtv: do not DMA-map stack addresses

2010-02-01 Thread Stefan Richter
have been simpler if you had first inserted an hg:v4l-dvb only patch which simply reverts the divergence of firedtv in hg from mainline git. This divergence was introduced by some kind of hg->git export mistake. That's not a big issue but it may cause another mistake when the next hg->gi

Re: [PATCH v4l/dvb] firedtv: add forgotten __exit annotation

2010-01-10 Thread Stefan Richter
Stefan Richter wrote on 2009-12-26: > fdtv_fw_exit() is part of the firedtv driver's .exit.text section. ... > --- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c > +++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c > @@ -332,7 +332,7 @@ int __init

[PATCH v4l/dvb] firedtv: add missing NULL pointer check

2009-12-25 Thread Stefan Richter
. The firewire variant of firedtv's device probe is not affected. The fix makes sure that such an unexpected firmware is safely recognized by fdtv_alloc as an unknown firmware. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-1394.c | 10 +++--- 1 file chang

[PATCH v4l/dvb] firedtv: add forgotten __exit annotation

2009-12-25 Thread Stefan Richter
fdtv_fw_exit() is part of the firedtv driver's .exit.text section. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-fw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
Jon Smirl wrote: > On Sat, Nov 28, 2009 at 3:29 PM, Stefan Richter > wrote: >> Jon Smirl wrote: >>> We have one IR receiver device and multiple remotes. How does the >>> input system know how many devices to create corresponding to how many >>> remotes yo

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
Stefan Richter wrote: > Jon Smirl wrote: >> We have one IR receiver device and multiple remotes. How does the >> input system know how many devices to create corresponding to how many >> remotes you have? > > If several remotes are to be used on the same receiver, then

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
Jon Smirl wrote: > On Sat, Nov 28, 2009 at 2:45 PM, Stefan Richter > wrote: >> Jon Smirl wrote: >>> Also, how do you create the devices for each remote? You would need to >>> create these devices before being able to do EVIOCSKEYCODE to them. >> The input su

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
Jon Smirl wrote: > On Sat, Nov 28, 2009 at 2:30 PM, Stefan Richter > wrote: >> Jon Smirl wrote: >>> If these drivers are for specific USB devices it is straight forward >>> to turn them into kernel based drivers. If we are going for plug and >>> play this

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
Jon Smirl wrote: > On Sat, Nov 28, 2009 at 1:17 PM, Stefan Richter > wrote: >> Jon Smirl wrote: >>> There are two very basic things that we need to reach consensus on first. >>> >>> 1) Unification with mouse/keyboard in evdev - put IR on equal footing. >

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
machine), they /can/ be and are shipped everywhere, they /do/ auto-load when the device is inserted. And if there should be an issue with power management (is there any?), then improve the ABI and libusb can surely be improved. I don't see why a device with a userspace driver cannot be incl

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
an alternative --- but this does not affect LIRC and whether to merge it in any way. PS: Drop your "specific vs. generic tools" terminology already. Your configfs based proposal requires "specific" tools as well, it's just that they can be implemented

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-28 Thread Stefan Richter
he driver to clean the > current > keymap table and allocate a new one with the specified size. > This will avoid playing with memory allocation for every new key and will > provide a simple > way to say to the driver to discard the current keybable, since a new o

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-27 Thread Stefan Richter
us quo. - No regressions would be best. -- Stefan Richter -=-==--= =-== ==-== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [IR-RFC PATCH v4 0/6] In-kernel IR support using evdev

2009-11-26 Thread Stefan Richter
a new interface, just using an existing mechanism (sysfs). Not all of sysfs in itself is an interface really; rather there is a number of interfaces which are implemented by means of sysfs. sysfs is primarily meant for simple textual attributes though, not for I/O streams. -- Stefan Richter -=

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-23 Thread Stefan Richter
ndation for lirc. I have no idea whether a pulse/space -> scancode -> keycode translation would be practical there.) -- Stefan Richter -=-==--= =-== =-=== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

Re: [PATCH 0/6] DVB: firedtv: simplifications and a portability fix

2009-11-20 Thread Stefan Richter
On 18 Nov, Stefan Richter wrote: > The following three patches are applicable after "firedtv: port to new > firewire core" from 2009-11-08: ... > The rest of this patch set additionally requires the latest firedtv as > of 2.6.32-rc7: ... I updated the "firedtv" bra

[PATCH 6/6] firedtv: reduce memset()s

2009-11-18 Thread Stefan Richter
length response will be taken. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-avc.c | 146 ++- 1 file changed, 65 insertions(+), 81 deletions(-) Index: linux-2.6.32-rc7/drivers/media/dvb/firewire/firedtv-avc.c

[PATCH 5/6] firedtv: remove check for interrupting signal

2009-11-18 Thread Stefan Richter
time out, usually much shorter). Hence simplify the code to plain mutex_lock. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-avc.c | 51 --- 1 file changed, 17 insertions(+), 34 deletions(-) Index: linux-2.6.32-rc7/drivers/media/dvb/firewire/firedtv

[PATCH 4/6] firedtv: do not DMA-map stack addresses

2009-11-18 Thread Stefan Richter
FCP transactions, let it wait for an interim response. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-1394.c |9 + drivers/media/dvb/firewire/firedtv-avc.c | 437 +- drivers/media/dvb/firewire/firedtv-dvb.c |1 - drivers/media/dvb/firewire/fire

[PATCH 3/6] firedtv: remove an unnecessary function argument

2009-11-18 Thread Stefan Richter
All read transactions initiated by firedtv are only quadlet-sized, hence the backend->read call can be simplified a little. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-1394.c |4 ++-- drivers/media/dvb/firewire/firedtv-avc.c |8 drivers/media/

[PATCH 2/6] firedtv: packet requeuing is likely to succeed

2009-11-18 Thread Stefan Richter
which packet buffer to set the interrupt flag. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-fw.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) Index: linux-2.6.32-rc7/drivers/media/dvb/firewire/firedtv-fw.c

[PATCH 1/6] firedtv: shrink buffer pointer table

2009-11-18 Thread Stefan Richter
Cache only addresses of whole pages, not of each buffer chunk. Besides, page addresses can be obtained by page_address() instead of kmap() since they were allocated in lowmem. Signed-off-by: Stefan Richter --- drivers/media/dvb/firewire/firedtv-fw.c | 19 --- 1 file changed

  1   2   >