[PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-04-12 Thread Steve Longerbeam
this has not already been done. The exception is ic-prpencvf at the source pad, since the Image Converter outputs fixed quantization and Y`CbCr encoding. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prp.c | 5 ++- drivers/staging/media/imx/imx-ic-prpencvf.c | 25

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-12 Thread Steve Longerbeam
On 04/06/2017 08:25 AM, Philipp Zabel wrote: On Thu, 2017-04-06 at 16:10 +0100, Russell King - ARM Linux wrote: On Thu, Apr 06, 2017 at 05:01:52PM +0200, Philipp Zabel wrote: On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-04-11 Thread Steve Longerbeam
On 04/04/2017 05:47 AM, Sakari Ailus wrote: Hi Steve, Philipp and Pavel, On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: From: Philipp Zabel This driver can handle SoC internal and external video bus multiplexers, controlled either by register bit fields or by a GPIO. The

Re: [PATCH v6 19/39] media: Add i.MX media core driver

2017-04-06 Thread Steve Longerbeam
On 04/06/2017 02:43 AM, Philipp Zabel wrote: On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam [...] diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c new file

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-04 Thread Steve Longerbeam
On 04/04/2017 05:40 PM, Steve Longerbeam wrote: On 04/04/2017 04:10 PM, Russell King - ARM Linux wrote: On Thu, Mar 30, 2017 at 07:25:49PM +0200, Philipp Zabel wrote: The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-04 Thread Steve Longerbeam
On 04/04/2017 04:10 PM, Russell King - ARM Linux wrote: On Thu, Mar 30, 2017 at 07:25:49PM +0200, Philipp Zabel wrote: The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). Signed-off-by: Philipp Zabel --- I'm tryin

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-04 Thread Steve Longerbeam
On 03/30/2017 10:25 AM, Philipp Zabel wrote: The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). Signed-off-by: Philipp Zabel --- I'm trying to get this to work with a TVP5150 analog TV decoder, and the first probl

Re: [PATCH v6 00/39] i.MX Media Driver

2017-03-30 Thread Steve Longerbeam
On 03/30/2017 04:02 AM, Russell King - ARM Linux wrote: This fails at step 1. The removal of the frame interval support now means my setup script fails when trying to set the frame interval on the camera: Enumerating pads and links Setting up format SRGGB8_1X8 816x616 on pad imx219 0-0010/0 F

Re: [PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-03-28 Thread Steve Longerbeam
On 03/28/2017 05:21 PM, Rob Herring wrote: On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam wrote: Add bindings documentation for the i.MX media driver. + +mipi_csi2 node +-- + +This is the device node for the MIPI CSI-2 Receiver, required for MIPI +CSI-2 sensors. + +Required

[PATCH v6 04/39] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

2017-03-27 Thread Steve Longerbeam
Add to the MIPI CSI2 receiver node: compatible strings, interrupt sources, and clocks. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 6d7bf64

[PATCH v6 01/39] [media] dt-bindings: Add bindings for video-multiplexer device

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- .../bindings/media/video-multiplexer.txt | 59 ++ 1 file changed, 59 insertions

[PATCH v6 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-03-27 Thread Steve Longerbeam
Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 74 + 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx.txt diff --git a

[PATCH v6 00/39] i.MX Media Driver

2017-03-27 Thread Steve Longerbeam
dd support for bayer formats media: imx: csi: add support for bayer formats media: imx: csi/fim: add support for frame intervals media: imx-csi: add frame size/interval enumeration media: imx-media-capture: add frame sizes/interval enumeration Steve Longerbeam (26): [media] dt-bindings: Add bi

[PATCH v6 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-27 Thread Steve Longerbeam
oards that have the HW workaround for ERR006687") Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelit

[PATCH v6 10/39] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

2017-03-27 Thread Steve Longerbeam
X7310) are thus moved into i2cmux. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 65 +--- 1 file changed, 44 insertions(+), 21 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto

[PATCH v6 13/39] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

2017-03-27 Thread Steve Longerbeam
Enables the ADV7180 decoder sensor. The ADV7180 connects to the parallel-bus mux input on ipu1_csi0_mux. The ADV7180 power pin is via max7310_b port expander. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 58 1 file changed, 58

[PATCH v6 03/39] [media] dt/bindings: Add bindings for OV5640

2017-03-27 Thread Steve Longerbeam
Add device tree binding documentation for the OV5640 camera sensor. Signed-off-by: Steve Longerbeam --- .../devicetree/bindings/media/i2c/ov5640.txt | 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.txt

[PATCH v6 08/39] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-03-27 Thread Steve Longerbeam
-2 receiver on mipi_csi. The OV5642 node is disabled temporarily while the subdev driver is cleaned up and submitted later. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl-sabrelite.dts | 5 ++ arch/arm/boot/dts/imx6q-sabrelite.dts| 5 ++ arch/arm/boot/dts/imx6qdl

[PATCH v6 15/39] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-27 Thread Steve Longerbeam
v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam --- drivers/media/v4l2-core/v4l2-mc.c | 50 +++ include/media/v4l2-mc.h | 31

[PATCH v6 06/39] ARM: dts: imx6qdl: add capture-subsystem device

2017-03-27 Thread Steve Longerbeam
Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 8958c4a..a959c76 100644 --- a/arch/arm/boot/dts/imx6dl.dtsi

[PATCH v6 09/39] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-03-27 Thread Steve Longerbeam
available for testing, the ov5642 node is currently disabled. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl-sabresd.dts | 5 ++ arch/arm/boot/dts/imx6q-sabresd.dts| 5 ++ arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 114 - 3 files changed, 123

[PATCH v6 05/39] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

2017-03-27 Thread Steve Longerbeam
Zabel -- - Removed some dangling/unused endpoints (ipu2_csi0_from_csi2ipu) - Renamed the mipi virtual channel endpoint labels, from "mipi_csiX_..." to "mipi_vcX...". - Added input endpoint anchors to the video muxes for the connections from parallel sensors. Signed-off-

[PATCH v6 14/39] add mux and video interface bridge entity functions

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel Signed-off-by: Philipp Zabel - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam --- Documentation/media/uapi/mediactl/media-types.rst | 22 ++ include/uapi/linux/media.h| 6 ++ 2 files changed

[PATCH v6 28/39] media: imx: csi: fix crop rectangle changes in set_fmt

2017-03-27 Thread Steve Longerbeam
ff-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 35 --- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 37c68d8..730966b 100644 --- a/dr

[PATCH v6 18/39] media: Add userspace header file for i.MX

2017-03-27 Thread Steve Longerbeam
This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom events and v4l2 controls for the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam --- include/linux/imx-media.h | 27 +++ 1 file changed, 27

[PATCH v6 23/39] media: imx: Add IC subdev drivers

2017-03-27 Thread Steve Longerbeam
directly from the CSI or from the VDIC. Scaled output is limited to 1024x1024 resolution. Output frames are routed to the capture device. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx-ic-common.c | 113 +++ drivers

[PATCH v6 30/39] media: imx: csi/fim: add support for frame intervals

2017-03-27 Thread Steve Longerbeam
From: Russell King Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 46 +-- drivers

[PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-03-27 Thread Steve Longerbeam
prep patches for that). For now, I've removed the use of v4l2_of_subdev_registered() for the vidmux driver's registered callback. This doesn't affect the functionality of this driver, but allows for it to be merged now, before adding the chaining support. Signed-off-b

[PATCH v6 24/39] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-03-27 Thread Steve Longerbeam
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx6-mipi-csi2.c | 673 + 2 files changed, 674

[PATCH v6 19/39] media: Add i.MX media core driver

2017-03-27 Thread Steve Longerbeam
Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/media/v4l-drivers/imx.rst | 590 ++ drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile| 1 + drivers/staging/media/imx

[PATCH v6 11/39] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

2017-03-27 Thread Steve Longerbeam
max7310_b, that chip is needed by more functions (usb and adv7180). Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi ind

[PATCH v6 12/39] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-03-27 Thread Steve Longerbeam
Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi index

[PATCH v6 20/39] media: imx: Add Capture Device Interface

2017-03-27 Thread Steve Longerbeam
. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile| 1 + drivers/staging/media/imx/imx-media-capture.c | 663 ++ 2 files changed, 664 insertions(+) create mode 100644 drivers/staging/media/imx/imx-media-capture.c diff --git a/drivers

[PATCH v6 16/39] [media] add Omnivision OV5640 sensor driver

2017-03-27 Thread Steve Longerbeam
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov5640.c

[PATCH v6 32/39] media: imx: csi: add frame skipping support

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel The CSI can skip any out of up to 6 input frames, allowing to reduce the frame rate at the output pads by small fractions. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam Signed-off-by: Russell King --- drivers/staging/media/imx/imx-media-csi.c | 127

[PATCH v6 34/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 11 +-- 1 file

[PATCH v6 22/39] media: imx: Add VDIC subdev driver

2017-03-27 Thread Steve Longerbeam
gt;grp_id; + strncpy(priv->sd.name, pdata->sd_name, sizeof(priv->sd.name)); + + mutex_init(&priv->lock); + + ret = v4l2_async_register_subdev(&priv->sd); + if (ret) + goto free; + + return 0; +free: + mutex_destroy(&priv->lock); + return ret; +} + +static int imx_vdic_remove(struct platform_device *pdev) +{ + struct v4l2_subdev *sd = platform_get_drvdata(pdev); + struct vdic_priv *priv = v4l2_get_subdevdata(sd); + + v4l2_info(sd, "Removing\n"); + + v4l2_async_unregister_subdev(sd); + mutex_destroy(&priv->lock); + media_entity_cleanup(&sd->entity); + + return 0; +} + +static const struct platform_device_id imx_vdic_ids[] = { + { .name = "imx-ipuv3-vdic" }, + { }, +}; +MODULE_DEVICE_TABLE(platform, imx_vdic_ids); + +static struct platform_driver imx_vdic_driver = { + .probe = imx_vdic_probe, + .remove = imx_vdic_remove, + .id_table = imx_vdic_ids, + .driver = { + .name = "imx-ipuv3-vdic", + }, +}; +module_platform_driver(imx_vdic_driver); + +MODULE_DESCRIPTION("i.MX VDIC subdev driver"); +MODULE_AUTHOR("Steve Longerbeam "); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:imx-ipuv3-vdic"); -- 2.7.4

[PATCH v6 26/39] media: imx: add support for bayer formats

2017-03-27 Thread Steve Longerbeam
From: Russell King Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-utils.c

[PATCH v6 21/39] media: imx: Add CSI subdev driver

2017-03-27 Thread Steve Longerbeam
This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 14 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c | 1318

[PATCH v6 31/39] media: imx: redo pixel format enumeration and negotiation

2017-03-27 Thread Steve Longerbeam
ff-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prp.c| 77 -- drivers/staging/media/imx/imx-ic-prpencvf.c | 57 ++-- drivers/staging/media/imx/imx-media-capture.c | 85 -- drivers/staging/media/imx/imx-media-csi.c | 108 +--- drivers/staging/media/imx/imx-

[PATCH v6 29/39] media: imx: csi: add __csi_get_fmt

2017-03-27 Thread Steve Longerbeam
Add __csi_get_fmt() and use it to return the correct mbus format (active or try) in get_fmt. Use it in other places as well. Signed-off-by: Steve Longerbeam Suggested-by: Russell King --- drivers/staging/media/imx/imx-media-csi.c | 61 --- 1 file changed, 47

[PATCH v6 37/39] media: imx-csi: add frame size/interval enumeration

2017-03-27 Thread Steve Longerbeam
frames, resulting in frame rate reduction, so enumerate the resulting possible output frame rates. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 62 +++ 1 file changed, 62 insertions(+) diff --git a

[PATCH v6 36/39] media: imx: csi: add sink selection rectangles

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel Move the crop rectangle to the sink pad and add a sink compose rectangle to configure scaling. Also propagate rectangles from sink pad to crop rectangle, to compose rectangle, and to the source pads both in ACTIVE and TRY variants of set_fmt/selection, and initialize the defau

[PATCH v6 38/39] media: imx-ic-prpencvf: add frame size enumeration

2017-03-27 Thread Steve Longerbeam
Add frame size enumeration operation. The PRP ENC/VF subdevices are scalers, so they can output a continuous range of widths/ heights on their source pads. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prpencvf.c | 40 + 1 file changed, 40

[PATCH v6 27/39] media: imx: csi: add support for bayer formats

2017-03-27 Thread Steve Longerbeam
: bayer formats and 16-bit parallel buses. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 75 +++ 1 file changed, 57 insertions(+), 18 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx

[PATCH v6 39/39] media: imx-media-capture: add frame sizes/interval enumeration

2017-03-27 Thread Steve Longerbeam
From: Russell King Add support for enumerating frame sizes and frame intervals from the first subdev via the V4L2 interfaces. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-capture.c | 73 +++ 1 file changed, 73

[PATCH v6 33/39] media: imx: csi: Avoid faulty sensor frames at stream start

2017-03-27 Thread Steve Longerbeam
: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index d9c3a3b..8597d7e 100644 --- a/drivers/staging/media/imx/imx-media-csi.c

[PATCH v6 25/39] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

2017-03-27 Thread Steve Longerbeam
max zoneorder to allow larger video buffer allocations. Signed-off-by: Steve Longerbeam --- arch/arm/configs/imx_v6_v7_defconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index eaba3b1..5d8c94a

[PATCH v6 35/39] media: imx: propagate sink pad formats to source pads

2017-03-27 Thread Steve Longerbeam
propagation in this case was easy, just have only a single format shared by both pads. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prp.c| 39 ++--- drivers/staging/media/imx/imx-ic-prpencvf.c | 95 +++ drivers/staging/media/imx/imx-media-capture.c | 13

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-21 Thread Steve Longerbeam
On 03/21/2017 04:27 AM, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote: @@ -1173,15 +1196,8 @@ static void csi_try_fmt(struct csi_priv *priv, incc = imx_media_find_mbus_format(infmt->code,

Re: [PATCH 3/4] media: imx-csi: add frame size/interval enumeration

2017-03-21 Thread Steve Longerbeam
rop frames, resulting in frame rate reduction, so enumerate the resulting possible output frame rates. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 62 +++ 1 file changed, 62 insertions(+) diff --git a/driv

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-21 Thread Steve Longerbeam
Hi Philipp, Russell, On 03/20/2017 10:23 AM, Philipp Zabel wrote: Hi Steve, Russell, What do you think of this: --8<-- From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001 From: Philipp Zabel Date: Mon, 20 Mar 2017 17:10:21 +0100 Subject: [PATCH] media: im

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Steve Longerbeam
On 03/20/2017 10:23 AM, Philipp Zabel wrote: Hi Steve, Russell, On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: The same document says: Sca

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Steve Longerbeam
On 03/20/2017 07:00 AM, Philipp Zabel wrote: On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 12:55:26PM +0100, Philipp Zabel wrote: The above paragraph suggests we skip any rectangles that are not supported. In our case that would be 3. and 4., since

Re: [PATCH 4/4] media: imx-media-capture: add frame sizes/interval enumeration

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 03:49 AM, Russell King wrote: Add support for enumerating frame sizes and frame intervals from the first subdev via the V4L2 interfaces. Signed-off-by: Russell King --- drivers/staging/media/imx/imx-media-capture.c | 62 +++ 1 file changed, 62 insertio

Re: [PATCH 3/4] media: imx-csi: add frame size/interval enumeration

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 03:49 AM, Russell King wrote: Add frame size and frame interval enumeration to CSI. CSI can scale the image independently horizontally and vertically by a factor of two, which enumerates to four different frame sizes. CSI can also drop frames, resulting in frame rate reduction,

Re: [PATCH 2/4] media: imx: allow bayer pixel formats to be looked up

2017-03-19 Thread Steve Longerbeam
This is good too, but if it's all right with you I would prefer to squash this with the "redo pixel format enumeration and negotiation" patch, to keep the patch count down. Steve On 03/19/2017 03:48 AM, Russell King wrote: Allow imx_media_find_format() to look up bayer formats, which is requi

Re: [PATCH 1/4] media: imx-media-csi: fix v4l2-compliance check

2017-03-19 Thread Steve Longerbeam
Looks good to me. Steve On 03/19/2017 03:48 AM, Russell King wrote: v4l2-compliance was failing with: fail: v4l2-test-formats.cpp(1076): cap->timeperframe.numerator == 0 || cap->timeperframe.denominator == 0 test VIDIOC_G/S_PARM: FAIL Fix this. Signed-off-

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: 0:00:01.955927879 20954 0x15ffe90 INFOv4l2 gstv4l2object.c:3811:gst_v4l2_object_get_caps

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote: On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Are we

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 11:51 AM, Russell King - ARM Linux wrote: On Sun, Mar 19, 2017 at 11:37:15AM -0700, Steve Longerbeam wrote: On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: Right now, CSI doesn't do that - it only looks at the width, height, code, and field. Correct, there is curr

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: Right, imx-media-capture.c (the "standard" v4l2 user interface module) is not implementing VIDIOC_ENUM_FRAMESIZES. It should, but it can only return the single

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Steve Longerbeam
Hi Russell, On 03/14/2017 10:29 AM, Steve Longerbeam wrote: On 03/12/2017 02:09 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 08:40:37PM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote: But hold on, if my logic is

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Steve Longerbeam
On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: Hi Steve, I've just been trying to get gstreamer to capture and h264 encode video from my camera at various frame rates, and what I've discovered does not look good. 1) when setting frame rates, media-ctl _always_ calls VIDIOC_SUBDEV

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-15 Thread Steve Longerbeam
On 03/10/2017 11:17 AM, Fabio Estevam wrote: On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky wrote: On 3/9/2017 8:52 PM, Steve Longerbeam wrote: There is a pin conflict with GPIO_6. This pin functions as a power input pin to the OV5642 camera sensor, but ENET uses it as the h/w workaround for

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-14 Thread Steve Longerbeam
On 03/12/2017 02:09 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 08:40:37PM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote: But hold on, if my logic is correct, then why did the CSI power-off get reached in your case

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-14 Thread Steve Longerbeam
On 03/12/2017 03:10 PM, Mauro Carvalho Chehab wrote: Em Sun, 12 Mar 2017 21:13:24 + Russell King - ARM Linux escreveu: On Sun, Mar 12, 2017 at 05:59:28PM -0300, Mauro Carvalho Chehab wrote: Yet, udev/systemd has some rules that provide an unique name for V4L devices at /lib/udev/rules.d

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Steve Longerbeam
On 03/14/2017 09:47 AM, Russell King - ARM Linux wrote: On Tue, Mar 14, 2017 at 12:21:31PM -0400, Nicolas Dufresne wrote: My main concern here based on what I'm reading, is that this driver is not even able to notice immediately that a produced frame was corrupted (because it's out of sync). F

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Steve Longerbeam
On 03/14/2017 09:21 AM, Nicolas Dufresne wrote: Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: The event must be user visible, otherwise the user has no

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-13 Thread Steve Longerbeam
er, I meant I will integrate this patch. And verify/fix possible breakage for non-bayer passthrough. Steve On 03/13/2017 02:30 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 08:16:25AM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-13 Thread Steve Longerbeam
On 03/13/2017 01:16 AM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve Longerbeam wrote: On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote: What I had was this patch for your v3. I never got to testing your v4 because of the LP-11 problem. In v5

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Steve Longerbeam
On 03/13/2017 10:10 AM, Hans Verkuil wrote: On 03/13/2017 06:06 PM, Steve Longerbeam wrote: On 03/13/2017 03:53 AM, Hans Verkuil wrote: On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-03-13 Thread Steve Longerbeam
On 03/13/2017 06:55 AM, Philipp Zabel wrote: On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote: The vast majority of existing drivers do not implement them nor the user space expects having to set them. Making that

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Steve Longerbeam
On 03/13/2017 03:53 AM, Hans Verkuil wrote: On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: The event must be user visible, otherwise the user has no indication the error

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:05:06PM -0700, Steve Longerbeam wrote: On 03/12/2017 12:57 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote: If it's too difficult to get the imx219

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 01:36 PM, Steve Longerbeam wrote: On 03/12/2017 01:16 PM, Steve Longerbeam wrote: On 03/12/2017 12:44 PM, Steve Longerbeam wrote: On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's act

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 01:16 PM, Steve Longerbeam wrote: On 03/12/2017 12:44 PM, Steve Longerbeam wrote: On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually nothing preventing userland from disabling a

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 12:44 PM, Steve Longerbeam wrote: On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually nothing preventing userland from disabling a link multiple times, and imx_media_link_notify() com

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 12:57 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote: If it's too difficult to get the imx219 csi-2 transmitter into the LP-11 state on power on, perhaps the csi-2 receiver can be a little more lenient on the transmitte

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 12:47 PM, Russell King - ARM Linux wrote: Another issue. The "reboot and the /dev/video* devices come up in a completely different order" problem seems to exist with this version. The dot graph I supplied previously had "ipu1_csi0 capture" on /dev/video4. I've just rebooted, an

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually nothing preventing userland from disabling a link multiple times, and imx_media_link_notify() complies, and so csi_s_power(OFF) gets called multiple

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 10:51 AM, Russell King - ARM Linux wrote: I've just looked at my test system's dmesg, and spotted this in the log. It's been a while since these popped out of the kernel, so I don't know what caused them (other than the obvious, a media-ctl command.) My script which sets this up

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-12 Thread Steve Longerbeam
On 03/11/2017 11:37 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote: On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: I really don't think expecting the user to understand and configure the pipeline is a sane way forward.

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-11 Thread Steve Longerbeam
On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote: Version 5 gives me no v4l2 controls exposed through the video device interface. Just like with version 4, version 5 is completely useless with IMX219: imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200 ipu1_csi0: pipeline start failed

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 03:14 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 08:25:49AM -0300, Mauro Carvalho Chehab wrote: This situation is there since 2009. If I remember well, you tried to write such generic plugin in the past, but never finished it, apparently because it is too complex

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 12:26 PM, Pavel Machek wrote: Hi! I tend to agree with that. I agree as well. This is in line with how existing drivers behave, too. Well, sounds like there is consensus on this topic. I guess I'll go ahead and remove the control inheritance support. I suppose having a con

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 05:41 AM, Sakari Ailus wrote: Hi Steve, On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote: If the pads on both sides of a link specify a frame interval, then those frame intervals should match. Create the exported function v4l2_subdev_link_validate_frame_interval

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: I really don't think expecting the user to understand and configure the pipeline is a sane way forward.

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you nev

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you nev

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:08:23AM -0800, Steve Longerbeam wrote: On 03/11/2017 07:32 AM, Sakari Ailus wrote: Hi Mauro and Hans, On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote: Em Sat, 11 Mar 2017 12:32:43 +0100

Re: [PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 05:49 AM, Sakari Ailus wrote: Hi Steve, On Thu, Mar 09, 2017 at 08:53:01PM -0800, Steve Longerbeam wrote: Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam The existing V4L2 UAPI headers are under include/uapi/linux. Could you use that

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 03:39 AM, Hans Verkuil wrote: On 10/03/17 19:37, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 07:32 AM, Sakari Ailus wrote: Hi Mauro and Hans, On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote: Em Sat, 11 Mar 2017 12:32:43 +0100 Hans Verkuil escreveu: On 10/03/17 16:09, Mauro Carvalho Chehab wrote: Em Fri, 10 Mar 2017 13:54:28 +0100 Hans Verkuil

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Steve Longerbeam
On 03/10/2017 03:30 PM, Pavel Machek wrote: On Fri 2017-03-10 10:37:21, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-10 Thread Steve Longerbeam
On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote: Version 5 gives me no v4l2 controls exposed through the video device interface. Just like with version 4, version 5 is completely useless with IMX219: imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200 ipu1_csi0: pipeline start failed

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Steve Longerbeam
Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video that is

[PATCH v5 00/39] i.MX Media Driver

2017-03-09 Thread Steve Longerbeam
t media: imx: csi: add frame skipping support media: imx: csi: fix crop rectangle reset in sink set_fmt Russell King (4): media: imx: add support for bayer formats media: imx: csi: add support for bayer formats media: imx: mipi-csi2: enable setting and getting of frame rates media: im

[PATCH v5 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-03-09 Thread Steve Longerbeam
Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 74 + 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx.txt diff --git a

<    2   3   4   5   6   7   8   9   10   11   >