Re: [PATCH 2/3] omap3isp: Disable CCDC's VD0 and VD1 interrupts when stream is not enabled

2015-04-21 Thread Tim Nordell
Laurent - On 04/21/15 12:58, Laurent Pinchart wrote: Hi Tim, On Wednesday 18 March 2015 10:25:34 Tim Nordell wrote: I'll give that a shot and try add code into the adv7180 driver to turn on and off its output signals. However, it seems like if the driver can avoid a problem present

[PATCH] OMAP3 ISP: Support top and bottom fields

2015-03-20 Thread Tim Nordell
that the FLDMODE bit is set when we're doing this as we need to differentiate between the two frames. Signed-off-by: Tim Nordell --- drivers/media/platform/omap3isp/ispccdc.c | 29 +++-- drivers/media/platform/omap3isp/ispvideo.c | 4 ++-- 2 files changed, 29 insert

[PATCH v2] OMAP3 ISP: Set DMA segment size

2015-03-19 Thread Tim Nordell
buffers for the memory space from the OMAP3 ISP's vantage point, we need to configure the segments to be at least as large as the largest buffer we expect. Signed-off-by: Tim Nordell --- drivers/media/platform/omap3isp/isp.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/dr

[PATCH] OMAP3 ISP: Set DMA segment size

2015-03-18 Thread Tim Nordell
buffers for the memory space from the OMAP3 ISP's vantage point, we need to configure the segments to be at least as large as the largest buffer we expect. Signed-off-by: Tim Nordell --- drivers/media/platform/omap3isp/isp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
On 03/18/15 16:44, Sakari Ailus wrote: I don't think omap3isp has been using this very long. A few minor versions perhaps. Do you know if this common code is supposed to guarantee a physically contiguous memory region? The documentation for the function doesn't indicate that it should, and it

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
Laurent - On 03/18/15 14:49, Tim Nordell wrote: Digging through to find who is responsible for assigning the virtual addresses, I find that it's buried inside arch/arm/mm/dma-mapping.c:__alloc_iova(...). This call is called individually for each entry in the scatter-gather tabl

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
Laurent - On 03/18/15 10:21, Laurent Pinchart wrote: Correct. sg_dma_address() should contain the DMA virtual address when an IOMMU is used. I was assuming it was checking the physical memory layout to it without looking too closely to the code. Armed with that knowledge, I'll dig a little dee

Re: [PATCH 2/3] omap3isp: Disable CCDC's VD0 and VD1 interrupts when stream is not enabled

2015-03-18 Thread Tim Nordell
Laurent - On 03/18/15 10:19, Laurent Pinchart wrote: Hi Tim, Thank you for the patch. On Tuesday 10 March 2015 14:24:53 Tim Nordell wrote: During testing there appeared to be a race condition where the IRQs for VD0 and VD1 could be triggered while enabling the CCDC module before the pipeline

Re: [PATCH 1/3] omap3isp: Defer probing when subdev isn't available

2015-03-18 Thread Tim Nordell
On Tuesday 10 March 2015 14:24:52 Tim Nordell wrote: If the subdev isn't available just yet, defer probing of the system. This is useful if the omap3isp comes up before the I2C subsystem does. Signed-off-by: Tim Nordell --- drivers/media/platform/omap3isp/isp.c | 6 +- 1 file change

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
Laurent - On 03/18/15 09:59, Laurent Pinchart wrote: Hi Tim, The names might be a bit misleading, vb2-dma-contig requires contiguous memory in the device memory space, not in physical memory. The IOMMU, managed through dma_map_sg_attrs, should have mapped the userptr buffer contiguously in the I

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-18 Thread Tim Nordell
Laurent - On 03/18/15 07:39, Laurent Pinchart wrote: Hi Tim, On Tuesday 17 March 2015 17:57:30 Tim Nordell wrote: On 04/21/14 07:29, Laurent Pinchart wrote: Replace the custom buffers queue implementation with a videobuf2 queue. Signed-off-by: Laurent Pinchart I realize this is late (it&#

Re: [PATCH v2 25/26] omap3isp: Move to videobuf2

2015-03-17 Thread Tim Nordell
Hi - On 04/21/14 07:29, Laurent Pinchart wrote: Replace the custom buffers queue implementation with a videobuf2 queue. Signed-off-by: Laurent Pinchart I realize this is late (it's in the kernel now), but I'm noticing that this does not appear to properly support the scatter-gather buffers

[PATCH 0/3] *** Updates against OMAP3ISP and BT.656

2015-03-10 Thread Tim Nordell
on the VSYNC latching for the buffers in the CCDC. Tim Nordell (3): omap3isp: Defer probing when subdev isn't available omap3isp: Disable CCDC's VD0 and VD1 interrupts when stream is not enabled omap3isp: Add a delayed buffers for frame mode drivers/media/platform/omap3isp/isp

[PATCH 3/3] omap3isp: Add a delayed buffers for frame mode

2015-03-10 Thread Tim Nordell
simplifies this patch's integration with the rest of the system. Additionally, this patch is set to only occur when BT.656 is enabled in the system. Signed-off-by: Tim Nordell --- drivers/media/platform/omap3isp/ispccdc.c | 22 +++- drivers/media/platform/omap3

[PATCH 1/3] omap3isp: Defer probing when subdev isn't available

2015-03-10 Thread Tim Nordell
If the subdev isn't available just yet, defer probing of the system. This is useful if the omap3isp comes up before the I2C subsystem does. Signed-off-by: Tim Nordell --- drivers/media/platform/omap3isp/isp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH 2/3] omap3isp: Disable CCDC's VD0 and VD1 interrupts when stream is not enabled

2015-03-10 Thread Tim Nordell
this occurred during testing, the VD0 interrupt was occurring over and over again starving the rest of the system.) Signed-off-by: Tim Nordell --- drivers/media/platform/omap3isp/ispccdc.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/