[PATCH v3] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread Tomas Melin
Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir-raw.c |1 - drivers/media/rc/rc-main.c |2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c index e8fff2a..b732ac6 100644 --- a/drivers/media/rc/rc-ir-raw.

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread Tomas Melin
On Tue, Oct 28, 2014 at 10:42 AM, David Härdeman wrote: > On 2014-10-26 20:33, Tomas Melin wrote: >> >> Please let me know your preferences on which you prefer, and, if >> needed, I'll make a new patch version. > > > I'd prefer the above, minimal, approach.

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-26 Thread Tomas Melin
On Sat, Oct 25, 2014 at 12:03 PM, David Härdeman wrote: > Wouldn't something like this be a simpler way of achieving the same > result? (untested): The idea was to remove the empty change_protocol function that had been added in the breaking commit. IMHO, it would be better to not have functions

[PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-21 Thread Tomas Melin
col in ir-raw.c. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir-raw.c |7 --- drivers/media/rc/rc-main.c | 19 --- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git

[PATCH v2 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-21 Thread Tomas Melin
: Tomas Melin --- drivers/media/rc/rc-ir-raw.c |1 - drivers/media/rc/rc-main.c |6 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c index a118539..d3b1e76 100644 --- a/drivers/media/rc/rc-ir-raw.c +++ b

Re: [PATCH 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-21 Thread Tomas Melin
On Mon, Oct 20, 2014 at 5:12 PM, David Härdeman wrote: > On 2014-10-19 12:21, Tomas Melin wrote: >> >> Change default setting for enabled protocols. >> Instead of enabling all protocols, disable all except lirc during >> registration. >> Reduces overhead since all

[PATCH 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-19 Thread Tomas Melin
Change default setting for enabled protocols. Instead of enabling all protocols, disable all except lirc during registration. Reduces overhead since all protocols not handled by default. Protocol to use will be enabled when keycode table is written by userspace. Signed-off-by: Tomas Melin

[PATCH 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-19 Thread Tomas Melin
c. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir-raw.c |7 --- drivers/media/rc/rc-main.c | 19 --- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/drivers/media

Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-19 Thread Tomas Melin
On Sat, Oct 18, 2014 at 9:18 PM, Mauro Carvalho Chehab wrote: > > The right behavior here is to enable the protocol as soon as the > new keycode table is written by userspace. > > Except for LIRC and the protocol of the current table enabled is > not a good idea because: > > 1) It misread

Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-18 Thread Tomas Melin
On Thu, Oct 16, 2014 at 11:49 PM, David Härdeman wrote: > I think this is already addressed in this thread: > http://www.spinics.net/lists/linux-media/msg79865.html The patch in that thread would have broken things since the store_protocol function is not changed at the same time. The patch I sent

[PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-09 Thread Tomas Melin
driver, this disables all protocols but the one defined by the map. Changed back to original behaviour by removing empty function change_protocol in ir-raw.c. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir

[PATCH] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-06 Thread Tomas Melin
driver, this disables all protocols but the one defined by the map. Changed back to original behaviour by removing empty function change_protocol in ir-raw.c. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir

[PATCH] [media] rc-main: fix lockdep splash for rc-main

2014-09-30 Thread Tomas Melin
x1c21/0x1f2c [] ? show_initstate+0x44/0x44 [] SyS_init_module+0xa2/0xb1 [] system_call_fastpath+0x16/0x1b Signed-off-by: Tomas Melin --- drivers/media/rc/rc-main.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index a7991

regression nuvoton-cir: possible circular locking dependency

2014-08-30 Thread Tomas Melin
Hi, I get a lockdep splat with kernels 3.17-rc1 and newer for the nuvoton-cir driver on my Intel NUC D54250. The driver was working correctly with Linux 3.16, after upgrading it does not react to any input anymore although loading seems to be succesful. If you have any ideas on this issue I