Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-05 Thread Ulf Hansson
On 4 April 2018 at 21:56, Boris Brezillon <boris.brezil...@bootlin.com> wrote: > On Wed, 04 Apr 2018 21:49:26 +0200 > Robert Jarzmik <robert.jarz...@free.fr> wrote: > >> Ulf Hansson <ulf.hans...@linaro.org> writes: >> >> > On 2 April 2018 at 16:2

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-03 Thread Ulf Hansson
his tree > either > an Ack or "I want to take through my tree" will be spared in the next > iterations > of this serie. Perhaps an option is to send this hole series as PR for 3.17 rc1, that would removed some churns and make this faster/easier? Well, if you receive the needed ack

Re: [PATCH 04/12] exynos-gsc: Make runtime PM callbacks available for CONFIG_PM

2016-11-11 Thread Ulf Hansson
On 11 November 2016 at 10:47, Ulf Hansson <ulf.hans...@linaro.org> wrote: > On 10 November 2016 at 04:44, kbuild test robot <l...@intel.com> wrote: >> Hi Ulf, >> >> [auto build test ERROR on linuxtv-media/master] >> [also build test ERROR on v4.9-rc4 next

Re: [PATCH 04/12] exynos-gsc: Make runtime PM callbacks available for CONFIG_PM

2016-11-11 Thread Ulf Hansson
On 10 November 2016 at 04:44, kbuild test robot wrote: > Hi Ulf, > > [auto build test ERROR on linuxtv-media/master] > [also build test ERROR on v4.9-rc4 next-20161109] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url:

Re: [PATCH 09/12] exynos-gsc: Simplify system PM even more

2016-11-09 Thread Ulf Hansson
zyprow...@samsung.com> Reviewed-by: Ulf Hansson <ulf.hans...@linaro.org> Kind regards Uffe > --- > drivers/media/platform/exynos-gsc/gsc-core.c | 21 ++--- > 1 file changed, 2 insertions(+), 19 deletions(-) > > diff --git a/drivers/media/platform/exynos-gsc/gsc-

Re: [PATCH 04/13] mmc: omap_hsmmc: No need to check DMA channel validity at module remove

2015-05-28 Thread Ulf Hansson
On 26 May 2015 at 15:25, Peter Ujfalusi peter.ujfal...@ti.com wrote: The driver will not probe without valid DMA channels so no need to check if they are valid when the module is removed. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Ulf Hansson ulf.hans...@linaro.org Acked-by: Ulf

Re: [PATCH 05/13] mmc: omap_hsmmc: Support for deferred probing when requesting DMA channels

2015-05-28 Thread Ulf Hansson
-EPROBE_DEFER Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Ulf Hansson ulf.hans...@linaro.org With the minor change above. Acked-by: Ulf Hansson ulf.hans...@linaro.org Kind regards Uffe --- drivers/mmc/host/omap_hsmmc.c | 22 ++ 1 file changed, 10 insertions

Re: [PATCH 07/13] mmc: davinci_mmc: Support for deferred probing when requesting DMA channels

2015-05-28 Thread Ulf Hansson
-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Ulf Hansson ulf.hans...@linaro.org Acked-by: Ulf Hansson ulf.hans...@linaro.org Kind regards Uffe --- drivers/mmc/host/davinci_mmc.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/mmc

Re: [PATCH V2 0/8] [media] exynos-gsc: Fixup PM support

2015-03-02 Thread Ulf Hansson
On 19 January 2015 at 14:22, Ulf Hansson ulf.hans...@linaro.org wrote: Changes in v2: - Rebase patches. - Adapt to changes for the PM core. Especially, the Kconfig option for CONFIG_PM_RUNTIME has been removed and the runtime PM core is now build

[PATCH V2 2/8] [media] exynos-gsc: Convert gsc_m2m_resume() from int to void

2015-01-19 Thread Ulf Hansson
Since gsc_m2m_resume() always returns 0, convert it to a void instead. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b

[PATCH V2 5/8] [media] exynos-gsc: Fixup clock management at -remove()

2015-01-19 Thread Ulf Hansson
To make sure the clock is fully gated in -remove(), we first need to to bring the device into full power by invoking pm_runtime_get_sync(). Then, let's both unprepare and disable the clock. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 7

[PATCH V2 1/8] [media] exynos-gsc: Simplify clock management

2015-01-19 Thread Ulf Hansson
Instead of having separate functions that fecthes, prepares and unprepares the clock, let's encapsulate this code into -probe(). This makes error handling easier and decreases the lines of code. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c

[PATCH V2 3/8] [media] exynos-gsc: Make driver functional when CONFIG_PM is unset

2015-01-19 Thread Ulf Hansson
The driver depended on CONFIG_PM to be functional. Let's remove that dependency, by enable the runtime PM resourses during -probe() and update the device's runtime PM status to reflect this. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 19

[PATCH V2 0/8] [media] exynos-gsc: Fixup PM support

2015-01-19 Thread Ulf Hansson
to potentially save some more power at runtime PM suspend. Ulf Hansson (8): [media] exynos-gsc: Simplify clock management [media] exynos-gsc: Convert gsc_m2m_resume() from int to void [media] exynos-gsc: Make driver functional when CONFIG_PM is unset [media] exynos-gsc: Make runtime PM

[PATCH V2 4/8] [media] exynos-gsc: Make runtime PM callbacks available for CONFIG_PM

2015-01-19 Thread Ulf Hansson
There are no need to set up the runtime PM callbacks unless they are being used. It also causes compiler warnings about unused functions. Silence the warnings by making them available for CONFIG_PM. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc

[PATCH V2 7/8] [media] exynos-gsc: Make system PM callbacks available for CONFIG_PM_SLEEP

2015-01-19 Thread Ulf Hansson
There are no need to set up the system PM callbacks unless they are being used. It also causes compiler warnings about unused functions. Silence the warnings by making them available for CONFIG_PM_SLEEP. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc

[PATCH V2 8/8] [media] exynos-gsc: Simplify system PM

2015-01-19 Thread Ulf Hansson
It's not needed to keep a local flag about the current system PM state. Let's just remove that code and the corresponding debug print. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 21 - drivers/media/platform/exynos-gsc

[PATCH V2 6/8] [media] exynos-gsc: Do full clock gating at runtime PM suspend

2015-01-19 Thread Ulf Hansson
To potentially save more power in runtime PM suspend state, let's also prepare/unprepare the clock from the runtime PM callbacks. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH v2] [media] coda: Improve runtime PM support

2014-10-23 Thread Ulf Hansson
On 23 October 2014 13:57, Philipp Zabel p.za...@pengutronix.de wrote: Hi Ulf, Am Montag, den 22.09.2014, 20:44 +0200 schrieb Ulf Hansson: On 22 September 2014 18:05, Philipp Zabel p.za...@pengutronix.de wrote: From: Ulf Hansson ulf.hans...@linaro.org For several reasons it's good

[PATCH 0/7] [media] exynos-gsc: Fixup PM support

2014-10-14 Thread Ulf Hansson
The conserns from the above discussions are intended to be solved by a reworked approach for the generic PM domain, link below. http://marc.info/?l=linux-pmm=141320895122707w=2 Ulf Hansson (7): [media] exynos-gsc: Simplify clock management [media] exynos-gsc: Convert gsc_m2m_resume() from int

[PATCH 7/7] [media] exynos-gsc: Do full clock gating at runtime PM suspend

2014-10-14 Thread Ulf Hansson
To potentially save more power in runtime PM suspend state, let's also prepare/unprepare the clock from the runtime PM callbacks. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 4/7] [media] exynos-gsc: Make runtime PM callbacks available for CONFIG_PM

2014-10-14 Thread Ulf Hansson
There are no need to set up the runtime PM callbacks unless they are being used. Let's make them available for CONFIG_PM. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 2/7] [media] exynos-gsc: Convert gsc_m2m_resume() from int to void

2014-10-14 Thread Ulf Hansson
Since gsc_m2m_resume() always returns 0, convert it into void instead. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b

[PATCH 5/7] [media] exynos-gsc: Fixup system PM

2014-10-14 Thread Ulf Hansson
is not reflected properly. Solve all the above issues by using pm_runtime_force_suspend|resume() as the system PM callbacks. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 41 ++-- drivers/media/platform/exynos-gsc/gsc-core.h

[PATCH 3/7] [media] exynos-gsc: Make driver functional without CONFIG_PM_RUNTIME

2014-10-14 Thread Ulf Hansson
will be runtime PM suspended and thus we will still benefit from using CONFIG_PM_RUNTIME. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform

[PATCH 6/7] [media] exynos-gsc: Fixup clock management at -remove()

2014-10-14 Thread Ulf Hansson
We want to make sure that the clock is fully gated after -remove(). To do this, we need to bring the device into full power and not only unprepare the clock, but also disable it. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c | 7 +-- 1

[PATCH 1/7] [media] exynos-gsc: Simplify clock management

2014-10-14 Thread Ulf Hansson
Instead of having separate functions that fecthes, prepares and unprepares the clock, let's encapsulate this code into -probe(). This makes error handling easier and decreases the lines of code. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/media/platform/exynos-gsc/gsc-core.c

Re: [PATCH v2] [media] coda: Improve runtime PM support

2014-09-22 Thread Ulf Hansson
On 22 September 2014 18:05, Philipp Zabel p.za...@pengutronix.de wrote: From: Ulf Hansson ulf.hans...@linaro.org For several reasons it's good practice to leave devices in runtime PM active state while those have been probed. In this cases we also want to prevent the device from going