On 02/25/2014 01:10 PM, Phil Edworthy wrote:
Signed-off-by: Phil Edworthy
Acked-by: Vladimir Barinov
(Valentine can't do the review atm)
---
v2:
- Fix silly mistake with missing break.
drivers/media/platform/soc_camera/rcar_vin.c |9 +
1 file changed, 9 insertions(+)
Hi Matsubara-san,
On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote:
Hi Vladimir,
Thank you for the revised patch.
From: Sergei Shtylyov
Date: Sat, 20 Jul 2013 03:14:34 +0400
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy
Hi Guennadi,
Thank you for the v8 review.
On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote:
[snip]
+ /* output format */
+ switch (icd->current_fmt->host_fmt->fourcc) {
+ case V4L2_PIX_FMT_NV16:
+ iowrite32(ALIGN(cam->width * cam->height, 0x80),
+
Hi Guennadi,
Guennadi Liakhovetski wrote:
Hi Sergei
On Fri, 28 Jun 2013, Sergei Shtylyov wrote:
Hello.
On 06/28/2013 03:58 AM, Vladimir Barinov wrote:
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy
Hi Guennadi,
Vladimir Barinov wrote:
Hi Guennadi,
Guennadi Liakhovetski wrote:
Hi Sergei
On Sat, 22 Jun 2013, Sergei Shtylyov wrote:
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy .
Signed-off-by: Vladimir Barinov
[Sergei
Hi Guennadi,
Guennadi Liakhovetski wrote:
Hi Sergei
On Sat, 22 Jun 2013, Sergei Shtylyov wrote:
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy .
Signed-off-by: Vladimir Barinov
[Sergei: removed deprecated IRQF_DISABLED flag
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
Hi Vladimir,
From: Vladimir Barinov
Date: Fri, 21 Jun 2013 14:32:05 +0400
Katsuya MATSUBARA wrote:
Hi Vladimir,
From: Vladimir Barinov
Date: Fri, 21 Jun 2013 13:39:50 +0400
(snip)
I have not seen such i2c errors during
Katsuya MATSUBARA wrote:
Hi Vladimir,
From: Vladimir Barinov
Date: Fri, 21 Jun 2013 13:39:50 +0400
(snip)
I have not seen such i2c errors during capturing and booting.
But I have seen that querystd() in the ml86v7667 driver often
returns V4L2_STD_UNKNOWN, although the corresponding
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
Hi Vladimir,
From: Vladimir Barinov
Date: Fri, 21 Jun 2013 12:06:12 +0400
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
Hi Sergei and Valadmir,
From: Sergei Shtylyov
Date: Fri, 24 May 2013 02:11:28 +0400
(snip)
+/* Similar to
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
Hi Sergei and Valadmir,
From: Sergei Shtylyov
Date: Fri, 24 May 2013 02:11:28 +0400
(snip)
+/* Similar to set_crop multistage iterative algorithm */
+static int rcar_vin_set_fmt(struct soc_camera_device *icd,
+ struct v
Hi Guennadi,
Sorry for the response delay and thank you for new review.
Guennadi Liakhovetski wrote:
+ /* output format */
+ switch (icd->current_fmt->host_fmt->fourcc) {
+ case V4L2_PIX_FMT_NV16:
+ iowrite32(ALIGN(cam->width * cam->height, 0x80),
+
Hi Guennadi,
On 05/15/2013 08:44 AM, Guennadi Liakhovetski wrote:
Hi Sergei, Vladimir
On Wed, 15 May 2013, Sergei Shtylyov wrote:
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy.
Signed-off-by: Vladimir Barinov
[Sergei: removed
Hi, Guennadi,
Thank you for the review!
Sergei Shtylyov wrote:
I also strongly suspent some #include headers are
missing
above.
Hm, I wonder which. I'm certainly not V4L2 expert...
added following:
#include
#include
#include
#include
#include
+alloc_ctxs[0] = priv->alloc_ct
Vladimir Barinov wrote:
Hi Hans,
Hans Verkuil wrote:
+ */
+val = i2c_smbus_read_byte_data(client, STATUS_REG);
+if (val < 0)
+return val;
+
+priv->std = val & STATUS_NTSCPAL ? V4L2_STD_PAL : V4L2_STD_NTSC;
Shouldn't this be 50 Hz vs 60 Hz for
Hi Hans,
Hans Verkuil wrote:
+*/
+ val = i2c_smbus_read_byte_data(client, STATUS_REG);
+ if (val < 0)
+ return val;
+
+ priv->std = val & STATUS_NTSCPAL ? V4L2_STD_PAL : V4L2_STD_NTSC;
Shouldn't this be 50 Hz vs 60 Hz formats? There are 60 H
Hi Hans,
Thank you for the review.
Hans Verkuil wrote:
+#include
This include should be removed as well.
ok
+
+static int ml86v7667_querystd(struct v4l2_subdev *sd, v4l2_std_id *std)
+{
+ struct ml86v7667_priv *priv = to_ml86v7667(sd);
+
+ *std = priv->std;
Th
Hi Sylwester,
Thank you for the review.
Sylwester Nawrocki wrote
+static struct v4l2_subdev_video_ops ml86v7667_subdev_video_ops = {
+.querystd = ml86v7667_querystd,
+.g_input_status = ml86v7667_g_input_status,
+.enum_mbus_fmt = ml86v7667_enum_mbus_fmt,
+.try_mbus_fmt = ml86v7
17 matches
Mail list logo
