also
notice one detail, that we could improve:
On Tue, 10 Jan 2012, Josh Wu wrote:
Signed-off-by: Josh Wu josh...@atmel.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
Hi, Mauro
The first patch of this serie, [PATCH 1/2 v3] V4L: atmel-isi: add
code to enable/disable ISI_MCK
Hi, Guennadi
Would you acknowledge these two v3 patches and queue them for 3.3 merge
window? Thanks.
Best Regards,
Josh Wu
On Thursday, December 08, 2011 6:19 PM, Josh Wu wrote:
Signed-off-by: Josh Wu josh...@atmel.com
---
in v2 version, made the label name to be consistent
drivers/media
Hi, Russell King
On Wed, Dec 07, 2011 at 4:50 PM, Russell King wrote:
On Wed, Nov 30, 2011 at 06:06:43PM +0800, Josh Wu wrote:
+/* Get ISI_MCK, provided by programmable clock or external clock
*/
+isi-mck = clk_get(dev, isi_mck);
+if (IS_ERR_OR_NULL(isi-mck)) {
This should be
On Thursday, December 08, 2011 6:40AM, Russell King wrote:
On Wed, Dec 07, 2011 at 06:12:52PM +0800, Wu, Josh wrote:
Hi, Russell King
On Wed, Dec 07, 2011 at 4:50 PM, Russell King wrote:
On Wed, Nov 30, 2011 at 06:06:43PM +0800, Josh Wu wrote:
+ /* Get ISI_MCK, provided by programmable
in it,
that
I've fixed for you in the first patch in this series:
On Wed, 30 Nov 2011, Josh Wu wrote:
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/video/atmel-isi.c | 17 -
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/atmel
Hi, Guennadi
On Monday, October 17, 2011 11:04 PM, Guennadi Liakhovetski wrote:
From: Josh Wu josh...@atmel.com
This patch
- add ISI_MCK clock enable/disable code.
- change field name in isi_platform_data structure
Signed-off-by: Josh Wu josh...@atmel.com
[g.liakhovet...@gmx.de: fix
On Thu, 22 Sep 2011, Guennadi wrote:
On Thu, 22 Sep 2011, Josh Wu wrote:
This patch
1. add ISI_MCK parent setting code when add ISI device.
2. add ov2640 support on board file.
3. define isi_mck clock in sam9g45 chip file.
Signed-off-by: Josh Wu josh.wu@x
---
Hi, Nicolas
On Friday, September 09, 2011 6:05 PM, Nicolas Ferre wrote:
Le 06/09/2011 08:54, Guennadi Liakhovetski :
On Tue, 6 Sep 2011, Josh Wu wrote:
This patch enable the configuration for ISI_MCK, which is provided by
programmable clock.
Signed-off-by: Josh Wu josh...@atmel.com
On 09/03/2011 2:22 AM Jean-Christophe PLAGNIOL-VILLARD wrote:
#include asm/setup.h
#include asm/mach-types.h
@@ -194,6 +197,95 @@ static void __init ek_add_device_nand(void)
at91_add_device_nand(ek_nand_data);
}
+/*
+ * ISI
+ */
+#if defined(CONFIG_VIDEO_ATMEL_ISI) ||
Hi, Russell
On 09/05/2011 6:34 PM Russell King wrote:
On Mon, Sep 05, 2011 at 06:29:53PM +0800, Josh Wu wrote:
+static int initialize_mck(struct atmel_isi *isi,
+struct isi_platform_data *pdata)
+{
+int ret;
+struct clk *pck_parent;
+
+if
Hi, Thomas
On Thu, 1 Sep 2011, Thomas Petazzoni wrote:
Hello Josh,
I am currently looking at V4L2 and your atmel-isi driver for an AT91
based platform on which I would like the ISI interface to capture the
image from a camera and have this image directly output in RGB format
at a specific
: Josh Wu josh...@atmel.com
CC: Hans de Goede hdego...@redhat.com
CC: Paul Mundt let...@linux-sh.org
---
Hello,
This is yet another version of the patch that introduces significant
changes in the vb2 streamon operation. I've decided to remove the
additional parameter to buf_queue callback
format
- Tested on AT91SAM9M10G45-EK with OV2640
Signed-off-by: Josh Wu josh...@atmel.com
---
base on branch staging/for_v3.0
Modified in V3:
refined the interrupt handling code.
added a list to manage the allocated descriptors.
removed redundant code in isi_camera_set_bus_param().
return
- Tested on AT91SAM9M10G45-EK with OV2640
Signed-off-by: Josh Wu josh...@atmel.com
---
Modified in V2 patch:
[snip]
+
+#include linux/clk.h
+#include linux/completion.h
+#include linux/fs.h
+#include linux/init.h
+#include linux/interrupt.h
+#include linux/kernel.h
You had linux/module.h
Hi, Jean-Christophe
Thank you for the review.
Jean-Christophe PLAGNIOL-VILLARD wrote on Friday, May 27, 2011 8:06 PM:
+/* ISI interrupt service routine */
+static irqreturn_t isi_interrupt(int irq, void *dev_id) {
+struct atmel_isi *isi = dev_id;
+u32 status, mask, pending;
+
- Tested on AT91SAM9M10G45-EK with OV2640
Signed-off-by: Josh Wu josh...@atmel.com
Looks good to me now.
Acked-by: Arnd Bergmann a...@arndb.de
Thank you very much. I'll send a version 3 code.
Best Regards,
Josh Wu
--
To unsubscribe from this list: send the line unsubscribe linux-media
Hi, Guennadi
Sorry to answer the question so later,
From: Guennadi Liakhovetski Sent: Thursday, May 12, 2011 5:32 PM
On Thu, 12 May 2011, Wu, Josh wrote:
Hi, Russell
From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] Sent:
Thursday, May 12, 2011 3:47 PM
On Thu, May 12
Hi, JC
+struct atmel_isi;
do we really this here?
Not really. I'll remove this.
+
[snip]
if VIDEO_CAPTURE_DRIVERS VIDEO_V4L2
+config VIDEO_ATMEL_ISI
+tristate ATMEL Image Sensor Interface (ISI) support
+depends on VIDEO_DEV SOC_CAMERA
depends on AT91 if the drivers is at91
on AT91SAM9M10G45-EK with OV2640
Hi Josh,
Thansk for doing this. Overall the patch looks really good. A few
comments below.
Hi, Ryan
Thank you for the comments.
Signed-off-by: Josh Wu josh...@atmel.com
---
base on branch staging/for_v2.6.40
arch/arm/mach-at91/include/mach/at91_isi.h
Hi, Russell
From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] Sent: Thursday,
May 12, 2011 3:47 PM
On Thu, May 12, 2011 at 03:42:18PM +0800, Josh Wu wrote:
+err_alloc_isi:
+clk_disable(pclk);
clk_put() ?
Ok, will be fixed in V2 patch. Thanks.
Best Regards,
Josh Wu
--
To
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Thursday, May
12, 2011 5:32 PM
On Thu, 12 May 2011, Wu, Josh wrote:
Hi, Russell
From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] Sent:
Thursday, May 12, 2011 3:47 PM
On Thu, May 12, 2011 at 03:42:18PM +0800
On Thursday, May 12, 2011 5:35 PM, Russell King wrote:
A few more points...
+static int __init atmel_isi_probe(struct platform_device *pdev)
Should be __devinit otherwise you'll have section errors.
Ok, will be fixed in V2 patch.
+{
+unsigned int irq;
+struct atmel_isi *isi;
+
22 matches
Mail list logo
