RE: [PATCH v10 1/1] [media] i2c: add support for OV13858 sensor

2017-06-13 Thread Yang, Hyungwoo
Hi Sakari, I reverted v10 and just added a comparison to see if clock-frequency is 19.2Mhz https://patchwork.kernel.org/patch/9784827/ -Hyungwoo -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Tuesday, June 13, 2017 8:29 AM > To: Yang, Hyung

RE: [PATCH v10 1/1] [media] i2c: add support for OV13858 sensor

2017-06-13 Thread Yang, Hyungwoo
Here is the _DSD for 19.2Mhz i've inlined my comments. -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Tuesday, June 13, 2017 3:18 AM > To: Yang, Hyungwoo > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; Zheng

RE: [PATCH v7 1/1] [media] i2c: add support for OV13858 sensor

2017-06-02 Thread Yang, Hyungwoo
Hi Sakari, I have fixed runtime PM calls in .probe() and .remove(). I'll submit v8 Thanks, Hyungwoo -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Friday, June 2, 2017 12:54 AM > To: Yang, Hyungwoo > Cc: linux-media@vger.kern

RE: [PATCH v6 1/1] [media] i2c: add support for OV13858 sensor

2017-06-01 Thread Yang, Hyungwoo
Hi Sakari, I'm so sorry there was huge mistake in testing & submission in v6. I've submitted v7. Thanks, Hyungwoo -Original Message- From: Sakari Ailus [mailto:sakari.ai...@iki.fi] Sent: Thursday, June 1, 2017 1:39 AM To: Yang, Hyungwoo Cc: linux-media@vger.kernel.

RE: [PATCH v5 1/1] [media] i2c: add support for OV13858 sensor

2017-05-31 Thread Yang, Hyungwoo
Hi, Thank you so much. I'll submit v6. -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Wednesday, May 31, 2017 2:25 AM > To: Yang, Hyungwoo > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; Zheng, Jian Xu > ; tf.

RE: [PATCH v3 1/1] [media] i2c: add support for OV13858 sensor

2017-05-29 Thread Yang, Hyungwoo
Hi Sakari, Thank you for the reviews. I have addressed all of your comments and please review the "v4" I already submitted. -Hyungwoo -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Monday, May 29, 2017 12:30 AM > To: Yang, Hyungwoo

RE: [PATCH v3 1/1] [media] i2c: add support for OV13858 sensor

2017-05-29 Thread Yang, Hyungwoo
Hi Tomasz, I left my comments. Thanks, Hyungwoo -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Monday, May 29, 2017 12:35 AM > To: Yang, Hyungwoo > Cc: Sakari Ailus ; linux-media@vger.kernel.org; > sakari.ai...@linux.intel.com; Zheng

RE: [PATCH v3 1/1] [media] i2c: add support for OV13858 sensor

2017-05-28 Thread Yang, Hyungwoo
Hello Tomasz, Here's my comments. Thanks, Hyungwoo -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Sunday, May 28, 2017 7:56 PM > To: Yang, Hyungwoo > Cc: Sakari Ailus ; linux-media@vger.kernel.org; > sakari.ai...@linux.intel.com;

RE: [PATCH v3 1/1] [media] i2c: add support for OV13858 sensor

2017-05-28 Thread Yang, Hyungwoo
Hi Sakari, Here's my comments. -Hyungwoo -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Saturday, May 27, 2017 1:31 PM > To: Yang, Hyungwoo > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; Zheng, Jian Xu > ;

RE: [PATCH 1/1] [media] i2c: add support for OV13858 sensor

2017-05-27 Thread Yang, Hyungwoo
I dropped the changing bayer order support. -Hyungwoo -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Saturday, May 27, 2017 12:53 PM > To: Yang, Hyungwoo > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; Zheng, Jian Xu >

RE: [PATCH 1/1] [media] i2c: add support for OV13858 sensor

2017-05-26 Thread Yang, Hyungwoo
t; since it is not that meaningful. Should I ? For VBLANK, I realized I made wrong comments just after I send it. Yeas, it shouldn't be read-only. So you can see that VBLANK I added in V2 is NOT read-only. Thanks, Hyungwoo > Hi Hyungwoo, > > On Wed, May 24, 2017 at 11:13:50PM +0

RE: [PATCH 1/1] [media] i2c: add support for OV13858 sensor

2017-05-24 Thread Yang, Hyungwoo
Hi Sakari, Thank you for the review, I've left my comments below. I'll submit v2 soon. -Hyungwoo -Original Message- From: Sakari Ailus [mailto:sakari.ai...@iki.fi] Sent: Wednesday, May 24, 2017 5:51 AM To: Yang, Hyungwoo Cc: linux-media@vger.kernel.org; sakari.ai...@linux