RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-26 Thread Yeh, Andy
mail.com; linux-media me...@vger.kernel.org>; Yeh, Andy ; Lai, Jim >; grund...@chromium.org; Mani, Rajmohan > >Subject: Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver > >Hi Ping-chung, > >On Wed, Sep 26, 2018 at 02:27:01AM +, Chen, Ping-chung wrot

RE: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-10 Thread Yeh, Andy
Hi PC, Thanks for the patch. Cc in Grant, and Intel Jim/Jason > -Original Message- > From: Chen, Ping-chung > Sent: Tuesday, July 10, 2018 3:16 PM > To: linux-media@vger.kernel.org > Cc: sakari.ai...@linux.intel.com; Yeh, Andy ; > tf...@chromium.org; Chen, Ping-chung

RE: [v1, 2/2] dt-bindings: at24: Add address-width property

2018-06-22 Thread Yeh, Andy
; From: Chiang, AlanX > Sent: Friday, June 22, 2018 5:47 PM > To: linux-media@vger.kernel.org > Cc: Yeh, Andy ; sakari.ai...@linux.intel.com; > Shevchenko, Andriy ; Mani, Rajmohan > ; Chiang, AlanX > Subject: [v1, 2/2] dt-bindings: at24: Add address-width property > > From:

RE: [RESEND PATCH v9 2/2] media: dw9807: Add dw9807 vcm driver

2018-05-16 Thread Yeh, Andy
Hi Mauro, >-Original Message- >From: Mauro Carvalho Chehab [mailto:mchehab+sams...@kernel.org] >Sent: Thursday, May 10, 2018 3:04 AM >To: Yeh, Andy <andy@intel.com> >Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; >devicet...@vger.kernel.org;

RE: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Yeh, Andy
Hi Tomasz, -Original Message- From: Tomasz Figa [mailto:tf...@chromium.org] Sent: Thursday, May 10, 2018 3:04 PM To: Zheng, Jian Xu <jian.xu.zh...@intel.com> Cc: Chen, JasonX Z <jasonx.z.c...@intel.com>; Yeh, Andy <andy@intel.com>; Linux Media Mailing

RE: [RESEND PATCH v9 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-05-07 Thread Yeh, Andy
Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Thursday, May 3, 2018 5:37 AM To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org; devicet...@vger.kernel.org; tf...@chromium.org; jac...@jmondi.org; Chiang, AlanX <alanx.chi...@intel.com>

RE: [RESEND PATCH v9 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-05-03 Thread Yeh, Andy
To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org; devicet...@vger.kernel.org; tf...@chromium.org; jac...@jmondi.org; Chiang, AlanX <alanx.chi...@intel.com> Subject: Re: [RESEND PATCH v9 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil On Wed,

RE: [RESEND PATCH v8 2/2] media: dw9807: Add dw9807 vcm driver

2018-05-02 Thread Yeh, Andy
Thanks for your kindly review. Submitted v9 only with Reviewed/Acked-by. Regards, Andy -Original Message- From: jacopo mondi [mailto:jac...@jmondi.org] Sent: Wednesday, May 2, 2018 3:17 PM To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org; sakari.ai...@linux.int

RE: [RESEND PATCH v7 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-04-24 Thread Yeh, Andy
Hi Rob, Apologize missed your comment before sent out v8. I will definitely add acks/reviewed-bys in next version. Regards, Andy -Original Message- From: Rob Herring [mailto:r...@kernel.org] Sent: Friday, April 13, 2018 11:11 PM To: Yeh, Andy <andy@intel.com> Cc: linux

RE: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-24 Thread Yeh, Andy
ted. Regards, Andy -Original Message- From: jacopo mondi [mailto:jac...@jmondi.org] Sent: Thursday, April 12, 2018 4:57 PM To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; devicet...@vger.kernel.org; tf...@chromium.org; Chiang, AlanX <

RE: [PATCH v10] media: imx258: Add imx258 camera sensor driver

2018-04-16 Thread Yeh, Andy
We are re-implementing this patch. So obsolete this patch from list first. https://patchwork.linuxtv.org/patch/48722/ Permalink /patch/48722/ State Obsoleted Regards, Andy -Original Message- From: Yeh, Andy Sent: Monday, April 16, 2018 11:04 PM To: linux-media@vger.kernel.org Cc

RE: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-10 Thread Yeh, Andy
Message- From: jacopo mondi [mailto:jac...@jmondi.org] Sent: Tuesday, March 20, 2018 6:28 PM To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; devicet...@vger.kernel.org; Chiang, AlanX <alanx.chi...@intel.com> Subject: Re: RESEND[

RE: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-26 Thread Yeh, Andy
Got it. We shall reverse the order in the later submission on list. Regards, Andy -Original Message- From: sakari.ai...@linux.intel.com [mailto:sakari.ai...@linux.intel.com] Sent: Thursday, March 22, 2018 1:07 AM To: Yeh, Andy <andy@intel.com> Cc: jacopo mondi <jac...@j

RE: [PATCH v9.1] media: imx258: Add imx258 camera sensor driver

2018-03-25 Thread Yeh, Andy
it. Will complete and submit it after full internal verification. Regards, Andy -Original Message- From: Sakari Ailus [mailto:sakari.ai...@iki.fi] Sent: Friday, March 23, 2018 10:30 PM To: Tomasz Figa <tf...@chromium.org> Cc: Sakari Ailus <sakari.ai...@linux.intel.com>; Yeh, Andy <and

RE: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-21 Thread Yeh, Andy
Thanks for the comments. A quick question first. For the reset we need some time to address. -Original Message- From: jacopo mondi [mailto:jac...@jmondi.org] Sent: Tuesday, March 20, 2018 6:28 PM To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org; sak

RE: [v6 0/2] DW9807 DT binding and driver patches

2018-03-16 Thread Yeh, Andy
Done. Thanks Sakari. Regards, Andy -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Saturday, March 17, 2018 12:47 AM To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org Subject: Re: [v6 0/2] DW9807 DT binding and driver patches

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-16 Thread Yeh, Andy
al Message- From: lkp Sent: Friday, March 16, 2018 10:14 PM To: Yeh, Andy <andy@intel.com> Cc: kbuild-...@01.org; linux-media@vger.kernel.org; tf...@chromium.org; sakari.ai...@linux.intel.com; Yeh, Andy <andy@intel.com>; Chen, JasonX Z <jasonx.z.c...@intel.com>; Chiang, A

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-15 Thread Yeh, Andy
Both comments are OKAY. Thanks. -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Thursday, March 15, 2018 6:31 AM To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org; tf...@chromium.org; Chen, JasonX Z <jasonx.z.c...@intel.com

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-14 Thread Yeh, Andy
Sure will do. Thanks Sakari. -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Thursday, March 15, 2018 6:31 AM To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org; tf...@chromium.org; Chen, JasonX Z <jasonx.z.c...@intel.com>; C

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-14 Thread Yeh, Andy
Still wrong line break... Please check the list instead. Thanks. https://patchwork.linuxtv.org/patch/47936/ Regards, Andy -Original Message- From: Yeh, Andy Sent: Thursday, March 15, 2018 12:24 AM To: linux-media@vger.kernel.org; tf...@chromium.org Cc: sakari.ai...@linux.intel.com; Yeh

RE: [PATCH v7] media: imx258: Add imx258 camera sensor driver

2018-03-14 Thread Yeh, Andy
Hi Tomasz, Thanks for the comments. OKAY as inline. Please check the Patch V8. Regards, Andy -Original Message- From: Tomasz Figa [mailto:tf...@chromium.org] Sent: Monday, March 12, 2018 3:33 PM To: Yeh, Andy <andy@intel.com> Cc: Linux Media Mailing List <li

RE: [PATCH v7] media: imx258: Add imx258 camera sensor driver

2018-03-11 Thread Yeh, Andy
Andy -Original Message- From: Yeh, Andy Sent: Monday, March 12, 2018 12:02 AM To: linux-media@vger.kernel.org; tf...@chromium.org Cc: sakari.ai...@linux.intel.com; Yeh, Andy <andy@intel.com>; Chen, JasonX Z <jasonx.z.c...@intel.com>; Chiang, AlanX <alanx.chi...@intel

RE: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-11 Thread Yeh, Andy
Okay. All comments are addressed in v7. (https://patchwork.linuxtv.org/patch/47869/) Thanks for all the comments and suggestions. Regards, Andy -Original Message- From: Tomasz Figa [mailto:tf...@chromium.org] Sent: Friday, March 2, 2018 11:44 PM To: Yeh, Andy <andy@intel.com&

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-09 Thread Yeh, Andy
Understood. Thank you Tomasz too. -Original Message- From: Tomasz Figa [mailto:tf...@chromium.org] Sent: Friday, March 9, 2018 6:48 PM To: Yeh, Andy <andy@intel.com> Cc: Sakari Ailus <sakari.ai...@linux.intel.com>; Linux Media Mailing List <linux-media@vger.kernel.org

RE: [PATCH v8] media: imx258: Add imx258 camera sensor driver

2018-03-09 Thread Yeh, Andy
<sakari.ai...@linux.intel.com> Cc: Yeh, Andy <andy@intel.com>; Linux Media Mailing List <linux-media@vger.kernel.org>; Chen, JasonX Z <jasonx.z.c...@intel.com>; Chiang, AlanX <alanx.chi...@intel.com> Subject: Re: [PATCH v8] media: imx258: Add imx258 camera sensor dr

RE: [PATCH v4] media: dw9807: Add dw9807 vcm driver

2018-01-29 Thread Yeh, Andy
Please ignore this. This is the wrong patch which has been obsoleted. -Original Message- From: Yeh, Andy Sent: Tuesday, January 30, 2018 12:35 AM To: linux-media@vger.kernel.org Cc: Yeh, Andy <andy@intel.com>; sakari.ai...@linux.intel.com; tf...@chromium.org; Chiang,

RE: [PATCH v4] media: dw9807: Add dw9807 vcm driver

2018-01-29 Thread Yeh, Andy
This is the right one. Sorry for inconvenience. -Original Message- From: Yeh, Andy Sent: Tuesday, January 30, 2018 12:53 AM To: linux-media@vger.kernel.org Cc: Yeh, Andy <andy@intel.com>; sakari.ai...@linux.intel.com; tf...@chromium.org; Chiang, AlanX <alanx.chi...@

RE: [PATCH v3] media: dw9807: Add dw9807 vcm driver

2018-01-29 Thread Yeh, Andy
MSB and LSB" registers are written. During ringing control mode operation, VBUSY bit keep '1'. While VBUSY = '1', the I2C command for VCM is ignored. " Regards, Andy -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Friday, January 26, 2018 4:57

[PATCH v3 1/1] imx258: Fix sparse warnings

2018-01-27 Thread Yeh, Andy
Fix a few sparse warnings related to conversion between CPU and big endian. Also simplify the code in the process. Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Acked-by: Andy Yeh <andy@intel.com> --- since v2: - Count loop downwards, not up. drivers/media/i2c/i

RE: [PATCH v2 1/1] imx258: Fix sparse warnings

2018-01-22 Thread Yeh, Andy
(i2c_master_send(client, __buf, len + 2) != len + 2) Regards, Andy -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Monday, January 22, 2018 4:33 PM To: linux-media@vger.kernel.org Cc: Yeh, Andy <andy@intel.com> Subject: [PATCH v2 1/1] imx258: Fi

RE: [PATCH 1/1] imx258: Fix sparse warnings

2018-01-22 Thread Yeh, Andy
Hi Sakari, I verified the patch multiple times but the code cannot work. Regards, Andy -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Friday, January 19, 2018 5:23 PM To: linux-media@vger.kernel.org Cc: Yeh, Andy <andy@intel.com> Subject:

RE: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-22 Thread Yeh, Andy
...@linux.intel.com] Sent: Friday, January 19, 2018 5:18 PM To: Yeh, Andy <andy@intel.com> Cc: Tomasz Figa <tf...@chromium.org>; Linux Media Mailing List <linux-media@vger.kernel.org> Subject: Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver Hi Andy, On Fri, Jan 19, 2018 a

RE: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-18 Thread Yeh, Andy
break; } - pm_runtime_put(>dev); - return ret; } Regards, Andy -Original Message- From: Tomasz Figa [mailto:tf...@chromium.org] Sent: Friday, January 19, 2018 12:18 PM To: Yeh, Andy <andy@intel.com> Cc: Linux Media Mailing List <linux-media@vger.k

RE: [PATCH] media: imx258: Add imx258 camera sensor driver

2018-01-12 Thread Yeh, Andy
OK. I will set usleep_range(1000, 2000), which is enough for test on DUT. Regards, Andy -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Friday, January 12, 2018 4:46 PM To: Yeh, Andy <andy@intel.com> Cc: linux-media@vger.kernel.org; Chiang, Al

RE: [PATCH] media: imx258: Add imx258 camera sensor driver

2018-01-12 Thread Yeh, Andy
Thanks Sakari to remind. Since I would like to attach some snips from the datasheets. But blocked, I will re-edit to plain table and hope it could be understood. Regards, Andy From: Yeh, Andy Sent: Friday, January 12, 2018 3:31 PM To: 'Sakari Ailus' <sakari.ai...@linux.intel.com> Cc: