: of:N*T*Camlogic,meson6-irC*
alias: of:N*T*Camlogic,meson6-ir
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/rc/meson-ir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/rc/meson-ir.c b/drivers/media/rc/meson-ir.c
Hello Mauro,
I noticed that module autoload won't be working in a bunch of media
platform drivers because the module alias information is not filled
in the modules. This patch series contains the fixes for them.
Best regards,
Javier
Javier Martinez Canillas (5):
[media] v4l: vsp1: Fix module
: of:N*T*Crenesas,fcpf
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/rcar-fcp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/rcar-fcp.c
b/drivers/media/platform/rcar-fcp.c
index f3a3f31cdfa9..7146fc5ef168
: of:N*T*Crenesas,vsp1
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/vsp1/vsp1_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/vsp1/vsp1_drv.c
b/drivers/media/platform/vsp1/vsp1_drv.c
index 57c713a4e1df..aa237b
this by passing back to vb2 all the received buffers that were not
processed.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/exynos-gsc/gsc-m2m.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/media/platform/exynos-g
] [] (do_filp_open) from []
(do_sys_open+0x10c/0x1bc)
[ 36.830235] [] (do_sys_open) from []
(ret_fast_syscall+0x0/0x3c)
[ 36.837942] Code: 0a1c e1a04000 e3a1 ebfec92d (e5943000)
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/exynos-g
,
Javier
Javier Martinez Canillas (3):
[media] exynos-gsc: don't release a non-dynamically allocated
video_device
[media] exynos-gsc: unregister video device node on driver removal
[media] exynos-gsc: cleanup m2m src and dst vb2 queues on STREAMOFF
drivers/media/platform/exynos-gsc/gsc
error path. This is wrong since
the v4l2_device wasn't allocated directly and will be freed once its
parent struct gsc_dev is freed.
While being there, rename the remaining goto label in the error path
to something that better explains the error path cleanup.
Signed-off-by: Javier Martinez Canillas
different calls to REQBUFS before a call to STREAMON.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/exynos-gsc/gsc-m2m.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c
b/drivers
add a new line to the message.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/exynos-gsc/gsc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c
b/drivers/media/platform/exyn
=UYVY \
! v4l2video3convert ! video/x-raw,format=BGRx ! kmssink
This change is similar to commit 7f2816e51ea1 ("[media] s5p-fimc: Changed
RGB32 to BGR32") that fixed the same issue on a different Samsung driver.
Suggested-by: Nicolas Dufresne <nicolas.dufre...@collabora.com>
Signe
's support.
Suggested-by: Nicolas Dufresne <nicolas.dufre...@collabora.com>
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/exynos-gsc/gsc-core.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers
he support for most exposed formats.
Best regards,
Javier
Javier Martinez Canillas (4):
[media] exynos-gsc: change spamming try_fmt log message to debug
[media] exynos-gsc: don't clear format when freeing buffers with
REQBUFS(0)
[media] exynos-gsc: fix supported RGB pixel format
[med
Hello Marek,
On 09/16/2016 02:14 AM, Marek Szyprowski wrote:
> s5p_mfc_alloc_memdev() function lacks proper releasing of allocated device
> in case of reserved memory initialization failure. This results in NULL
> pointer
> dereference:
Patch looks good to me.
Reviewed-by: Jav
<p.za...@pengutronix.de>
> Cc: Hans Verkuil <hans.verk...@cisco.com>
> ---
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
I've also tested on an Exynos5 board to share DMA buffers between a
vivid capture device and the Exynos DRM drive
Allow the sub-device to be probed asynchronously so a bridge driver that's
waiting for the device can be notified and its .bound callback executed.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/i2c/ov9650.c | 7 ++-
1 file changed, 6 insertions
Hello Sakari,
Thanks a lot for your feedback.
On 08/17/2016 03:50 PM, Sakari Ailus wrote:
> Hi Javier,
>
> On Wed, Aug 17, 2016 at 02:28:56PM -0400, Javier Martinez Canillas wrote:
>> The vb2_buffer_done() function can be called from interrupt context but it
>> currently
sleep.
[0]: https://lkml.org/lkml/2016/8/13/36
Best regards,
Javier
Javier Martinez Canillas (2):
[media] vb2: defer sync buffers from vb2_buffer_done() with a
workqueue
[media] vb2: move dma-buf unmap from __vb2_dqbuf() to vb2_done_work()
drivers/media/v4l2-core/videobuf2-core.c | 114
the vb2_buffer_done() function as it was before.
Suggested-by: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/v4l2-core/videobuf2-core.c | 81 +---
include/media/videobuf2-core.h | 5 ++
2 f
processing.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/v4l2-core/videobuf2-core.c | 33
1 file changed, 21 insertions(+), 12 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c
b/drivers/media/v4l2-core/vid
The kernel-doc has the wrong function name and also the pindex
parameter is missing in the documentation.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
---
Changes in v2:
- Change pindex parameter kernel-do
Hello Sakari,
On 08/17/2016 05:01 AM, Sakari Ailus wrote:
> Hi Javier,
>
> On Tue, Aug 16, 2016 at 10:20:16AM -0400, Javier Martinez Canillas wrote:
>> The kernel-doc has the wrong function name and also the pindex
>> parameter is missing in the documentation.
>&g
Hello Sakari,
On 08/16/2016 05:13 PM, Sakari Ailus wrote:
> Hi Javier,
>
> Javier Martinez Canillas wrote:
>> Hello Sakari,
>>
>> On 08/16/2016 04:47 PM, Sakari Ailus wrote:
>>> Hi Javier,
>>>
>>> Javier Martinez Canillas wrote:
>
Hello Sakari,
On 08/16/2016 04:47 PM, Sakari Ailus wrote:
> Hi Javier,
>
> Javier Martinez Canillas wrote:
>> Hello Hans,
>>
>> Thanks a lot for your feedback.
>>
>> On 08/13/2016 09:47 AM, Hans Verkuil wrote:
>>> On 07/20/2016 08:22 PM, Javier Mar
The kernel-doc has the wrong function name and also the pindex
parameter is missing in the documentation.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
This patch was posted some weeks ago but I noticed that wasn't
picked by patchwork, so I'm resend it.
drivers
Hello Hans,
Thanks a lot for your feedback.
On 08/13/2016 09:47 AM, Hans Verkuil wrote:
> On 07/20/2016 08:22 PM, Javier Martinez Canillas wrote:
>> Currently the dma-buf is unmapped when the buffer is dequeued by userspace
>> but it's not used anymore after the driver fini
Hello Sakari,
On 08/11/2016 03:31 PM, Sakari Ailus wrote:
> Javier Martinez Canillas wrote:
>> Hello,
>>
>> Sakari pointed out in "[PATCH 2/8] [media] v4l2-async: call registered_async
>> after subdev registration" [0] that the added .registered_async callba
v4l2_subdev_internal_ops that's called after the entity has been
registered with the media device in v4l2_device_register_subdev().
Suggested-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/v4l2-core/
.ai...@linux.intel.com>
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/i2c/tvp5150.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 0b6d46c453bf..52e340c
when added the .registered_async callback,
sorry about that.
This small series convert the tvp5150 driver to use the proper .registered and
remove .registered_async since isn't needed.
[0]: https://lkml.org/lkml/2016/8/11/254
Best regards,
Javier
Javier Martinez Canillas (2):
[media] tvp5150: use s
u use these callbacks instead?
Yes, those can be used indeed. I'll post patches using that instead
and removing the .registered_async callback since as you said isn't
really needed.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Sakari,
On 07/20/2016 07:08 PM, Sakari Ailus wrote:
> Hi Javier,
>
> On Wed, Jul 20, 2016 at 06:56:52PM -0400, Javier Martinez Canillas wrote:
>> Hello Sakari,
>>
>> On 07/20/2016 03:52 PM, Sakari Ailus wrote:
>>> On Wed, Jul 20, 2016 at 12:07:55PM -
Hello Sakari,
On 07/20/2016 03:52 PM, Sakari Ailus wrote:
> On Wed, Jul 20, 2016 at 12:07:55PM -0400, Javier Martinez Canillas wrote:
>> If the VIDIOC_QBUF ioctl fails due a wrong dmabuf length, it's
>> useful to get the invalid and minimum lengths as a debug info.
>>
is done.
Decoupling the buffer dequeue from the dma-buf unmapping has also the side
effect of making possible to add dma-buf fence support in the future since
the buffer could be dequeued even before the driver has finished using it.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.
to recover, since it may had dropped the
buffer(s) already when it knows that the dma-buf mapping failed.
So remove the TODO instead and change the comment to explain this.
Suggested-by: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
, minimum
length 410880
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
Changes in v2:
- Use %u instead of %d (Sakari Ailus)
- Include min_length (Sakari Ailus)
drivers/media/v4l2-core/videobuf2-core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
Hello Hans,
On 07/20/2016 10:12 AM, Hans Verkuil wrote:
> On 07/20/2016 04:06 PM, Javier Martinez Canillas wrote:
>> Hello Sakari,
>>
>> On 07/20/2016 09:20 AM, Sakari Ailus wrote:
>>> Hi Javier,
>>>
>>> On Fri, Jul 15, 2016 at 12:26:06PM -0400,
Hello Sakari,
On 07/20/2016 09:20 AM, Sakari Ailus wrote:
> Hi Javier,
>
> On Fri, Jul 15, 2016 at 12:26:06PM -0400, Javier Martinez Canillas wrote:
>> The buffer planes' dma-buf are currently mapped when buffers are queued
>> from userspace but it's more appropriate t
Hello Sakari,
On 07/20/2016 09:03 AM, Sakari Ailus wrote:
> Hi Javier,
>
> Thanks for the patch!
>
Thanks for your feedback.
> On Thu, Jul 14, 2016 at 11:09:34AM -0400, Javier Martinez Canillas wrote:
>> If the the VIDIOC_QBUF ioctl fails due a wrong dmabuf length,
Hello Hans, Michael and Marek,
Thanks a lot for your feedback.
On 07/18/2016 04:34 AM, Hans Verkuil wrote:
> On 07/15/2016 06:26 PM, Javier Martinez Canillas wrote:
>> The buffer planes' dma-buf are currently mapped when buffers are queued
>> from userspace but it's more ap
Hello Shuah,
On 07/15/2016 03:42 PM, Shuah Khan wrote:
> On 07/15/2016 10:26 AM, Javier Martinez Canillas wrote:
>> The buffer planes' dma-buf are currently mapped when buffers are queued
>> from userspace but it's more appropriate to do the mapping when buffers
>> are queue
com>
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
Hello,
A side effect of this change is that if the dmabuf map fails for some
reasons (i.e: a driver using the DMA contig memory allocator but CMA
not being enabled), the fail will no longer happen on VIDIOC_QBUF bu
-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/v4l2-core/videobuf2-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c
b/drivers/media/v4l2-core/videobuf2-core.c
index ca8ffeb56d72..97d148
Hello Shuah,
On 07/14/2016 10:40 AM, Shuah Khan wrote:
> Removed unnecessary error message as appropriate error code is returned.
> Changed error message into a debug.
>
> Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
> ---
Reviewed-by: Javier Martinez Canillas &l
Hello Shuah,
On 07/14/2016 09:35 AM, Shuah Khan wrote:
> On 07/14/2016 06:46 AM, Javier Martinez Canillas wrote:
>> Hello Shuah,
>>
>> On 07/12/2016 08:33 PM, Shuah Khan wrote:
>>> Removing unnecessary error messages as appropriate error code is returned.
>>&
if (ctx->num >= MFC_NUM_CONTEXTS) {
> - mfc_err("Too many open contexts\n");
But I think this error message shouldn't be removed since explains why
the open failed, even when an error code is returned.
> ret = -EBUSY;
>
Hello Jean Christophe,
On Wed, Jul 13, 2016 at 9:49 AM, Jean Christophe TROTIN
<jean-christophe.tro...@st.com> wrote:
>
>
> On 07/11/2016 08:57 PM, Javier Martinez Canillas wrote:
>> On Mon, Jul 11, 2016 at 1:48 PM, Nicolas Dufresne
>> <nicolas.dufre...@gmail.com&g
Hello Shuah,
On 07/12/2016 11:07 AM, Shuah Khan wrote:
> On 07/12/2016 09:03 AM, Javier Martinez Canillas wrote:
>> Hello Shuah,
>>
>> On 07/11/2016 06:39 PM, Shuah Khan wrote:
>>> Fix misspelled error message and existing checkpatch errors in the
>>> err
ev *dev,
> s5p_mfc_hw_call(dev->mfc_ops, clear_int_flags, dev);
> s5p_mfc_clock_off();
> wake_up_dev(dev, reason, err);
> - return;
> }
>
> /* Header parsing interrupt handling */
>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
FCINST_HEAD_PARSED &&
> [...]
> + mfc_err("Can not get crop information\n");
>
> Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
> ---
Patch looks good to me. Maybe is better to split the message and checkpatch
changes in two different patches. But I don't have a stron
ard type. The VIDIOC_QUERYCAP ioctl documentation
explains what information these fields should contain:
https://linuxtv.org/downloads/v4l-dvb-apis/vidioc-querycap.html
For example
https://git.linuxtv.org/media_tree.git/commit/?id=e0d80c8acca0f221b9dedb2eab7a5184848b99b7
Best regards,
Javier
--
To unsu
T markup, we need to keep it in sync
> with the change.
>
> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
> ---
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsub
ry types. We need to keep the ReST
> doc updated to such change.
>
> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
> ---
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best regards,
Javier
--
To unsubscribe from
* @mfc_regs:structure holding MFC registers
> * @fw_ver: loaded firmware sub-version
> + * risc_on: flag indicates RISC is on or off
> *
> */
> struct s5p_mfc_dev {
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <jav.
-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 3 ++-
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
b/drivers
, Card type and Bus info.
Best regards,
Javier
Javier Martinez Canillas (6):
[media] s5p-mfc: set capablity bus_info as required by VIDIOC_QUERYCAP
[media] s5p-mfc: improve v4l2_capability driver and card fields
[media] s5p-jpeg: set capablity bus_info as required by
VIDIOC_QUERYCAP
-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/s5p-jpeg/jpeg-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c
b/drivers/media/platform/s5p-jpeg/jpeg-core.c
index 17bc94092864..e3ff3d
this patch:
Driver Info (not using libv4l2):
Driver name : exynos-gsc
Card type : exynos-gsc gscaler
Bus info : platform:13e0.video-scaler
Driver version: 4.7.0
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers
is in the card
type field anyways.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/s5p-jpeg/jpeg-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c
b/drivers/media/platform/s5p-jpe
fixes this by filling also the device besides the bus.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/exynos-gsc/gsc-m2m.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c
b/d
: s5p-mfc-dec
Bus info : platform:1100.codec
Driver version: 4.7.0
Driver Info (not using libv4l2):
Driver name : s5p-mfc
Card type : s5p-mfc-enc
Bus info : platform:1100.codec
Driver version: 4.7.0
Signed-off-by: Javier Martinez
Hello Hans,
On 06/15/2016 02:09 AM, Hans Verkuil wrote:
> On 06/14/2016 10:18 PM, Javier Martinez Canillas wrote:
>> Commit 95dd7b7e30f3 ("[media] v4l2-ioctl.c: improve cropcap compatibility
>> code") tried to check if both .vidioc_cropcap and .vidioc_g_selection
3c)
Fixes: 95dd7b7e30f3 ("[media] v4l2-ioctl.c: improve cropcap compatibility code")
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l
ir
counterparts? IOW to do the release for both encoder and decoder after
their unregistration.
After that change:
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
> ---
Thanks for the patch but Shuah already posted the same fix before:
https://lkml.org/lkml/2016/6/8/1210
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of
(dev->vfd_enc) get called twice if encoder
> register fails.
>
> Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
> ---
Right, thanks for the fix.
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best regards,
Javier
--
To unsubscribe from this list: send t
The streaming field in struct vb2_queue is meant to be private and should
not be used by drivers directly, instead the vb2_is_streaming() function
should be used to check the videobuf2 queue streaming status.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers
The function comment has an obvious typo error, so fix it.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_de
V4L2_MEMORY_MMAP is supported
[ 178.704666] vidioc_reqbufs:575: Only V4L2_MEMORY_MMAP is supported
[ 178.714956] vidioc_reqbufs:575: Only V4L2_MEMORY_MMAP is supported
[ 178.715229] vidioc_reqbufs:575: Only V4L2_MEMORY_MMAP is supported
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.
> device for Exynos3250, Exynos4 and Exynos542x platforms. Board can still
> include exynos-mfc-reserved-memory.dtsi to enable using this device
> without IOMMU being enabled.
>
> Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
> ---
Reviewed-by: Javier Martinez Canill
row...@samsung.com>
> ---
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line &
-
The patch looks good to me and I've also tested it on an Exynos5800 Peach
Pi Chromebook and an Exynos5420 Odroid XU4 board.
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best regards,
--
Javier Marti
Hello Krzysztof,
On 06/02/2016 12:31 PM, Krzysztof Kozlowski wrote:
> On 06/02/2016 05:20 PM, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> On 05/30/2016 03:28 AM, Krzysztof Kozlowski wrote:
>>> On 05/24/2016 03:31 PM, Marek Szyprowski wrote:
>>&
om
memory regions reservation will break with the current s5p-mfc driver.
> What is your final decision for DTS patches? Which approach for MFC
> reserved memory node?
>
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research Ameri
Commit 4b9c1cb641c46 ("[media] Documentation: media: description of DMABUF
importing in V4L2") documented the V4L2 dma-buf importing support but did
not update the VIDIOC_REQBUFS description, so only the Memory Mapping and
User Pointer I/O methods are mentioned.
Signed-off-by: Javie
to explicitly mention in the documentation, and also makes all sections
about streaming I/O methods more consistent.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
Documentation/DocBook/media/v4l/io.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Hello Marek,
On 05/27/2016 07:32 AM, Marek Szyprowski wrote:
> Hello,
>
>
> On 2016-05-25 19:11, Javier Martinez Canillas wrote:
>> Hello Marek,
>>
>> On 05/24/2016 09:31 AM, Marek Szyprowski wrote:
>>> This patch replaces custom properties for defining r
Hello Marek,
On 05/27/2016 02:37 AM, Marek Szyprowski wrote:
> Hello,
>
>
> On 2016-05-25 19:36, Rob Herring wrote:
>> On Wed, May 25, 2016 at 11:18:59AM -0400, Javier Martinez Canillas wrote:
>>> Hello Marek,
>>>
>>> On 05/24/2016 09:31 AM, Mare
Hello Marek,
On 05/24/2016 09:31 AM, Marek Szyprowski wrote:
> Enable support for Multimedia Codec (MFC) device for all Exynos4412-based
> Odroid boards.
>
> Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
> ---
Reviewed-by: Javier Martinez Canillas <jav..
{
> - samsung,mfc-r = <0x4300 0x80>;
> - samsung,mfc-l = <0x5100 0x80>;
> + memory-region = <_left>, <_right>;
> status = "okay";
I wonder if shouldn't be better to include the exynos-mfc-reserved-memory.dtsi
on e
Hello Marek,
On 05/25/2016 11:42 AM, Javier Martinez Canillas wrote:
[snip]
>
> I couldn't test this exact patch because my Odroid XU4 died but I've tested
> the previous version and the only difference is that the memory reserve is
> made by index now instead of name, so I think
Hello Marek,
On 05/24/2016 09:31 AM, Marek Szyprowski wrote:
> Once MFC driver has been converted to generic reserved memory bindings,
> there is no need for custom memory reservation code.
>
> Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
> ---
Reviewe
timal, but besides limiting
> total address space available has no other drawbacks (MFC firmware
> supports 256M of address space per each channel).
>
> Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com>
> ---
Reviewed-by: Javier Martinez Canillas <jav...@osg.sa
than for patch #2, shouldn't we include the in-kernel DTS
changes with this patch to keep bisectability? Otherwise the mfc-{l,r} mem
allocation will fail after this patch.
The patch looks good to me though:
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
I couldn't test this ex
>
I wonder if we should maintain backward compatibility for this driver
since s5p-mfc memory allocation won't work with an old FDT if support
for the old properties are removed.
Although I'm not a big fan of keeping backward compatibility just to
add dead code that will never be used and I don't k
git://linuxtv.org/media_tree.git
> S: Maintained
> +F: Documentation/devicetree/bindings/media/
> F: Documentation/dvb/
> F: Documentation/video4linux/
> F: Documentation/DocBook/media/
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best re
- }
+ if (ret < 0)
+ goto err_subdev_call;
}
return 0;
+
+err_subdev_call:
+ v4l2_device_unregister_subdev(sd);
+err_subdev_register:
+ if (notifier->unbind)
+ notifier->unbind(notifier, sd, as
ix this save the asd before calling v4l2_async_cleanup().
>
> Signed-off-by: Alban Bedel <alban.be...@avionic-design.de>
> ---
Patch looks good to me. So after fixing the issues pointed out by Sakari:
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Best regards,
great if you can provide
your Reviewed or Acked by tags.
> cheers,
> Nicolas
>
> Le vendredi 06 mai 2016 à 18:11 -0400, Javier Martinez Canillas a écrit :
>> From: ayaka <ay...@soulik.info>
>>
>> User-space applications can use the VIDIOC_REQBUFS ioctl to det
won't be set to MFCINST_INIT again and VIDIOC_REQBUFS will fail.
To avoid this issue, only free the buffers on VIDIOC_REQBUFS(0) but don't
close the MFC instance to allow future VIDIOC_REQBUFS(n) calls to succeed.
Signed-off-by: ayaka <ay...@soulik.info>
[javier: Rewrote changelog to explain
Fix kernel warning on memory init")
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c
b/drivers/media/platform/s5p-mfc/s5p_mf
and must be
fixed.
Also, the declared DMA memory using dma_declare_coherent_memory() isn't
relased so add a dev .release that calls dma_release_declared_memory().
Cc: <sta...@vger.kernel.org>
Fixes: 6e83e6e25eb4 ("[media] s5p-mfc: Fix kernel warning on memory init")
Signed-off-by:
reservation [0]. But the fixes are trivial
so we can fix the current code until his rework patch lands.
[0]: https://patchwork.linuxtv.org/patch/32287/
Best regards,
Javier
Javier Martinez Canillas (3):
[media] s5p-mfc: Set device name for reserved memory region devs
[media] s5p-mfc: Add
)
[ 45.766655] Code: eae3 e3a1 e28dd008 e8bd81f0 (e7f001f2)
Fix it by registering the video devs as the last step in s5p_mfc_probe().
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 39 +---
1 file c
Hello Krzysztof,
On 05/03/2016 06:15 AM, Krzysztof Kozlowski wrote:
> On Mon, May 02, 2016 at 03:14:22PM -0400, Javier Martinez Canillas wrote:
>> Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the
>> clock field can have a errno pointer value. But s5p_mfc_
+0x174/0x1b8)
[] (SyS_delete_module) from [] (ret_fast_syscall+0x0/0x3c)
Assign the pointer to NULL in case of a lookup failure to fix the issue.
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
Changes in v2:
- Set the clock pointer to NULL instead of ch
Hello Arnd,
Thanks for your feedback.
On 05/02/2016 02:41 PM, Arnd Bergmann wrote:
> On Monday 02 May 2016 13:27:54 Javier Martinez Canillas wrote:
>> Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the
>> clock field can have a errno pointer value. But s
+0x174/0x1b8)
[] (SyS_delete_module) from [] (ret_fast_syscall+0x0/0x3c)
So check if the pointer is not an errno value before calling clk_put().
Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 2 +-
1 file changed, 1 ins
Hello Laurent,
Thanks a lot for your feedback.
On 04/27/2016 10:29 AM, Laurent Pinchart wrote:
> Hi Javier,
>
> Thank you for the patch.
>
> On Tuesday 12 Apr 2016 18:42:52 Javier Martinez Canillas wrote:
>> The tvp5150 and tvp5151 decoders support different video input
On 04/12/2016 06:42 PM, Javier Martinez Canillas wrote:
> Hello,
>
> This is a second version of an RFC patch series that adds MC input connector
> support to the tvp5150 driver. The first RFC version was [0].
>
> The patches are RFC because a previous version was merged
101 - 200 of 896 matches
Mail list logo
