Hello Arnd,
Thanks for your feedback.
On 05/02/2016 02:41 PM, Arnd Bergmann wrote:
> On Monday 02 May 2016 13:27:54 Javier Martinez Canillas wrote:
>> Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the
>> clock field can have a errno pointer value. But s
+0x174/0x1b8)
[] (SyS_delete_module) from [] (ret_fast_syscall+0x0/0x3c)
So check if the pointer is not an errno value before calling clk_put().
Signed-off-by: Javier Martinez Canillas
---
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Hello Laurent,
Thanks a lot for your feedback.
On 04/27/2016 10:29 AM, Laurent Pinchart wrote:
> Hi Javier,
>
> Thank you for the patch.
>
> On Tuesday 12 Apr 2016 18:42:52 Javier Martinez Canillas wrote:
>> The tvp5150 and tvp5151 decoders support different video input
On 04/12/2016 06:42 PM, Javier Martinez Canillas wrote:
> Hello,
>
> This is a second version of an RFC patch series that adds MC input connector
> support to the tvp5150 driver. The first RFC version was [0].
>
> The patches are RFC because a previous version was merged
Hello Sylwester,
On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote:
> The same struct device_node * is used for looking up the I2C sensor, OF
> graph endpoint and port. So the reference count is incremented but not
> decremented for the endpoint and port nodes.
>
> Fix
external pull down resistor.
>
Yes, I got that from your previous email but as I mentioned, the lines
in the board don't have external pull resistors.
> Regards,
>
> Tony
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The tvp5150_write() function can fail so don't return 0 unconditionally
in tvp5150_s_register() but propagate what's returned by tvp5150_write().
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
di
makes the kernel image size to be much bigger (~16 KiB).
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index e5003d94f262..4a2e851b6a3b 10
Hello Tony,
On 04/14/2016 11:12 AM, Tony Lindgren wrote:
> Hi,
>
> * Javier Martinez Canillas [160414 07:28]:
>> Hello Wofram,
>>
>> On 04/14/2016 10:19 AM, Wolfram Sang wrote:
>>>
>>>> Yes, I also wonder why I'm the only one facing this
sing I2C registers.
Maybe runtime pm has an effect on this and the chip is not reset correctly?
[0]:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/media/i2c/tvp5150.c#n1311
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
T
> http://patchwork.ozlabs.org/patch/609280/
>
Unfortunately it doesn't help, I just tried today's -next (next-20160414)
that already has the mentioned patch but the issue is still present.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe
pm_runtime_disable(&adap->dev);
+
dev_info(omap->dev, "bus %d rev%d.%d at %d kHz\n", adap->nr,
major, minor, omap->speed);
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this l
-off-by: Javier Martinez Canillas
---
Hello,
The DT binding assumes that there is a 1:1 map between physical connectors
and connections, so there will be a connector described in the DT for each
connection.
There is also the question about how the DT bindings will be extended to
support other
using the dot tool is at [2].
I tested these patches on an IGEPv2 by capturing using both Composite inputs.
[0]: https://www.mail-archive.com/linux-media@vger.kernel.org/msg95389.html
[1]: http://hastebin.com/yiduhonome.tex
[2]: http://i.imgur.com/EyFtVtJ.png?1
Best regards,
Javier
Changes in v2
inding doc.
The DT binding only describes the type of the input connectors and not
how the signals are routed to the chip, that information is inferred
by the driver that knows what are the possible input configurations.
Signed-off-by: Javier Martinez Canillas
---
Changes in v2:
- Use a single si
vice_for_each_entity(entity, mdev) {
> if (((media_entity_id(entity) == id) && !next) ||
> ((media_entity_id(entity) > id) && next)) {
> - mutex_unlock(&mdev->graph_mutex);
This change belongs to patch 1/2.
After this
about
> 20k interactions of mc_nextgen_test[1], and tested wit both uvcvideo
> and au0828+snd-usb-audio drivers.
>
> [1] It looks like getting the entire topology calling G_TOPOLOGY
> twice is two times faster than using the legacy ioctls (even
> retrieving more information - i
The same struct device_node * is used for looking up the I2C sensor, OF
graph endpoint and port. So the reference count is incremented but not
decremented for the endpoint and port nodes.
Fix this by having separate pointers for each node looked up.
Signed-off-by: Javier Martinez Canillas
Hello Andreas,
Thanks for your feedback.
On 03/23/2016 07:33 PM, Andreas Färber wrote:
> Hi Javier,
>
> Am 23.03.2016 um 17:15 schrieb Javier Martinez Canillas:
>> The same struct device_node * is used for looking up the I2C sensor, OF
>> graph endpoint and port. So t
The same struct device_node * is used for looking up the I2C sensor, OF
graph endpoint and port. So the reference count is incremented but not
decremented for the endpoint and port nodes.
Fix this by having separate pointers for each node looked up.
Signed-off-by: Javier Martinez Canillas
The path mentioned in the driver's Makefile is not correct, fix it.
Signed-off-by: Javier Martinez Canillas
---
drivers/media/platform/s5p-tv/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-tv/Makefile
b/drivers/media/platform/s
Hello Sylwester,
On 03/11/2016 10:03 AM, Sylwester Nawrocki wrote:
> On 03/04/2016 09:20 PM, Javier Martinez Canillas wrote:
>> The fimc_md_parse_port_node() function return 0 if an endpoint node is
>> not found but according to Documentation/devicetree/bindings/graph.txt,
>&g
Hello Mauro,
On 03/21/2016 06:15 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 21 Mar 2016 16:48:12 -0300
> Javier Martinez Canillas escreveu:
>
>> Hello Hans,
>>
>> On 03/21/2016 04:30 PM, Hans Verkuil wrote:
>>
>> [snip]
>>
>>>>>>
&g
Hello Mauro,
On 03/21/2016 06:20 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 21 Mar 2016 16:20:09 -0300
> Javier Martinez Canillas escreveu:
>
>>> BTW, if the tvp5150 needs to know which composite connector is connected
>>> to which hardware pin, then you still may nee
Hello Mauro,
On 03/21/2016 03:34 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 21 Mar 2016 15:24:00 -0300
> Javier Martinez Canillas escreveu:
>
>> Hello Hans,
>>
>> On 03/21/2016 03:08 PM, Hans Verkuil wrote:
>>> On 03/21/2016 06:50 PM, Mauro Carvalho Chehab w
andardize.
>
> Not all devices have VBI. Some devices may have *only* VBI (although the last
> driver of that kind was removed from the kernel a long time ago), there may
> be multiple video source pads, and when we add HDMI I can think of a lot more
> complex scenarios. So source pads shouldn
Hello Hans,
On 03/21/2016 04:06 PM, Hans Verkuil wrote:
> On 03/21/2016 07:24 PM, Javier Martinez Canillas wrote:
>> Hello Hans,
>>
>> On 03/21/2016 03:08 PM, Hans Verkuil wrote:
>>> On 03/21/2016 06:50 PM, Mauro Carvalho Chehab wrote:
>>>> Hi Hans,
&g
wholly inside the kernel so we can
>>> modify it at will later without impacting userspace.
>>
>> I prepared a long answer to your email, but I guess we're not at the
>> same page.
>>
>> Let be clear on my view. Please let me know where you disagree:
>
Hello,
On 03/09/2016 04:09 PM, Javier Martinez Canillas wrote:
>
> I was waiting for the MC input connector support discussion to settle before
> attempting to propose another patch series for the tvp5150 video decoder but
> IIUC you are going to continue the discussion at ELC so I
or parameter
> 'active_list'
>
> Thanks :)
> Luis
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ia_entity *new,
> + void *notify_data);
> +#endif
> +
I would rather move the au0828_media_graph_notify() function
definition before au0828_unregister_media_device() instead of adding
this function forward declaration. Specially since requires ifdef
gua
up in this function will make very clear
that a single function is the counter part of the previous two operations.
> thanks,
> -- Shuah
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line &quo
r()
and while being there, you can also fix the "Unegisters" typo.
After those changes:
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Mauro,
On Wed, Mar 16, 2016 at 11:36 AM, Mauro Carvalho Chehab
wrote:
> Em Wed, 16 Mar 2016 11:03:38 -0300
> Javier Martinez Canillas escreveu:
>
>> Hello Mauro,
>>
>> The patch looks mostly good to me, I just have a question below:
>>
>> On Wed,
de);
Why are you adding this? If media_devnode_register() failed then the
device node won't be registered so is not correct to call
media_devnode_unregister(). Or maybe I'm missing something.
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The patch looks good and I agree that makes things more clear.
Reviewed-by: Javier Martinez Canillas
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body
always using a mutex.
>
> As a side effect, this prevents a bug where the media notifiers
> were called at atomic context.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
I agree with the patch.
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscr
in
media_device_init() so I believe the destroy should be kept here.
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
6 mode.
>
> For devices that are not instantiated through DT the current behavior
> is preserved.
>
> Signed-off-by: Philipp Zabel
> Signed-off-by: Lucas Stach
> ---
Similar to Mauro's comment on patch 2/9, the current driver already
supports configuring the interface outp
Hello Sylwester,
On Fri, Mar 11, 2016 at 10:03 AM, Sylwester Nawrocki
wrote:
> On 03/04/2016 09:20 PM, Javier Martinez Canillas wrote:
>> The fimc_md_parse_port_node() function return 0 if an endpoint node is
>> not found but according to Documentation/devicetree/bindings/graph
Hello Sylwester,
On Fri, Mar 11, 2016 at 10:09 AM, Sylwester Nawrocki
wrote:
> On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote:
>> Thanks, I just noticed another similar issue in the driver now and is
>> that fimc_is_parse_sensor_config() uses the same struct device_node *
.imgur.com/6y7d7AS.png
[4]: http://hastebin.com/dijowanuki.tex
[5]: http://i.imgur.com/Qr1F9dL.png
[6]: http://hastebin.com/zegiwisoli.tex
[7]: http://i.imgur.com/TdrVJ0R.png
Best regards,
Javier
Javier Martinez Canillas (3):
[media] v4l2-mc.h: Add a S-Video C input PAD to demod enum
[media] tvp5150:
C signal.
Add a DEMOD_PAD_C_INPUT that can be used for this case and the existing
DEMOD_PAD_IF_INPUT can be used for either Composite or the Y signal.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Javier Martinez Canillas
---
Hello,
This change was suggested by Mauro in [0] although is
used for either Composite or a S-Video signal (Y or C). But from
the tvp5150 point of view, there are three different "connections", so
the DT binding models the hardware as three separate connectors instead.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
Hel
both the two Composite and a single S-Video input.
The DT binding only describes the type of the input connection and not
how the signals are routed to the chip, that information is inferred
by the driver that knows what are the possible input configurations.
Signed-off-by: Javier Martinez Canillas
Hello Sylwester,
On 03/07/2016 06:24 AM, Sylwester Nawrocki wrote:
> Hi Javier, Krzysztof,
>
> On 03/05/2016 05:35 AM, Krzysztof Kozlowski wrote:
>> 2016-03-05 5:20 GMT+09:00 Javier Martinez Canillas :
>>>> Hello,
>>>>
>>>> This series hav
of_node_put(rem);
> return -EINVAL;
> + }
>
> fmd->sensor[index].asd.match_type = V4L2_ASYNC_MATCH_OF;
> fmd->sensor[index].asd.match.of.node = rem;
>
Reviewed-by: Javier Martinez Canillas
Best regards,
--
Javier Martinez Canillas
Open Source Group
Sam
ut(ep);
> return -EINVAL;
> + }
>
> pd->mux_id = (endpoint.base.port - 1) & 0x1;
>
>
Reviewed-by: Javier Martinez Canillas
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list:
Instead of just returning, go to the error path that already does it.
Signed-off-by: Javier Martinez Canillas
---
drivers/media/platform/exynos4-is/mipi-csis.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c
b/drivers/media/plat
invalid Device Tree description.
Signed-off-by: Javier Martinez Canillas
---
drivers/media/platform/exynos4-is/media-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos4-is/media-dev.c
b/drivers/media/platform/exynos4-is/media-dev.c
index
s are very simple.
Best regards,
Javier
Javier Martinez Canillas (2):
[media] exynos4-is: Put node before s5pcsis_parse_dt() return error
[media] exynos4-is: FIMC port parse should fail if there's no endpoint
drivers/media/platform/exynos4-is/media-dev.c | 2 +-
drivers/media/platform/
inance and luminance information (Y+C).
MEDIA_ENT_F_CAM_SENSOR
Reviewed-by: Javier Martinez Canillas
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-med
From: Laurent Pinchart
This patch enables the tvp5150 decoder driver to be used with the media
controller framework by adding pad-level subdev operations and init the
media entity pad.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
Changes in v2: None
drivers
From: Laurent Pinchart
This patch adds the .g_mbus_config subdev operation to the driver.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
Changes in v2: None
drivers/media/i2c/tvp5150.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers
uard Gavin
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Laurent Pinchart
---
Changes in v2:
- Add Reviewed-by tag from Laurent Pinchart to patch 8/10.
drivers/media/i2c/tvp5150.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c
From: Laurent Pinchart
This patch adds the .s_stream subdev operation to the driver.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
Changes in v2: None
drivers/media/i2c/tvp5150.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers
Add a Device Tree binding document for the TVP5150 video decoder.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Laurent Pinchart
---
Changes in v2:
- Fix indentation of the DTS example. Suggested by Rob Herring.
- Rename powerdown-gpios to pdn-gpios to match the pin name in
the
From: Laurent Pinchart
Move the version detection code to a separate function and restructure
it to prepare for TVP5151 support.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
Changes in v2: None
drivers/media/i2c/tvp5150.c | 79
720x480 -n 1 --field interlaced-tb --capture=1 -F /dev/video2
$ raw2rgbpnm -f UYVY -s 720x480 frame-00.bin frame-00.pnm
The patches are on top of [0] not because is a depedency but just to avoid
merge conflicts and I don't expect them to be picked before that anyways.
Best
he V4L2_MBUS_DATA_ACTIVE_HIGH flags set returned by
>>> tvp5150_g_mbus_config() when pdata is NULL is never set by
>>> v4l2_of_parse_endpoint(), should you add it unconditionally ?
>>
>> But v4l2_of_parse_endpoint() calls v4l2_of_parse_parallel_bus() which does
>>
Hello Laurent,
On 01/06/2016 07:59 AM, Laurent Pinchart wrote:
> Hi Javier,
>
> Thankk you for the patch.
>
Thanks a lot for your feedback.
> On Monday 04 January 2016 09:25:31 Javier Martinez Canillas wrote:
>> After power-up, the tvp5150 decoder is in a unknown state un
Hello Laurent,
Thanks a lot for your feedback.
On 01/06/2016 07:56 AM, Laurent Pinchart wrote:
> Hi Javier,
>
> Thank you for the patch.
>
> On Monday 04 January 2016 09:25:32 Javier Martinez Canillas wrote:
>> The video decoder supports either 8-bit 4:2:2 YUV with discr
Hello Laurent,
On 01/06/2016 07:39 AM, Laurent Pinchart wrote:
> Hi Javier,
>
> Thank you for the patch.
>
Thanks a lot for your feedback.
[snip]
>> +
>> +Optional Properties:
>> +- powerdown-gpios: phandle for the GPIO connected to the PDN pin, if any.
>
Hello Rob,
Thanks a lot for your feedback.
On 01/04/2016 11:07 AM, Rob Herring wrote:
> On Mon, Jan 04, 2016 at 09:25:29AM -0300, Javier Martinez Canillas wrote:
>> Add a Device Tree binding document for the TVP5150 video decoder.
>>
>> Signed-off-by: Jav
Hello,
On 01/04/2016 09:40 AM, kbuild test robot wrote:
> Hi Javier,
>
> [auto build test ERROR on linuxtv-media/master]
> [also build test ERROR on v4.4-rc8 next-20151231]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving th
From: Laurent Pinchart
Move the version detection code to a separate function and restructure
it to prepare for TVP5151 support.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c | 79 ++---
1 file
From: Laurent Pinchart
This patch adds support for the V4L2_CID_PIXEL_RATE control.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/tvp5150.c b
From: Laurent Pinchart
This patch enables the tvp5150 decoder driver to be used with the media
controller framework by adding pad-level subdev operations and init the
media entity pad.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c
e on top of [0] not because is a depedency but just to avoid
merge conflicts and I don't expect them to be picked before that anyways.
Best regards,
Javier
[0]:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/367109.html
[1]: http://git.linuxtv.org/pinchartl/media.git
From: Laurent Pinchart
Expand the version detection code to identity the tvp5151.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c
From: Laurent Pinchart
This patch adds the .g_mbus_config subdev operation to the driver.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/media/i2c/tvp5150.c b
From: Laurent Pinchart
This patch adds the .s_stream subdev operation to the driver.
Signed-off-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/media/i2c/tvp5150.c b
Add a Device Tree binding document for the TVP5150 video decoder.
Signed-off-by: Javier Martinez Canillas
---
.../devicetree/bindings/media/i2c/tvp5150.txt | 35 ++
1 file changed, 35 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/tvp5150
uard Gavin
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 105bd1c6b17f..caac96a577f8 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c
The video decoder supports either 8-bit 4:2:2 YUV with discrete syncs
or 8-bit ITU-R BT.656 with embedded syncs output format but currently
BT.656 it's always reported. Allow to configure the format to use via
either platform data or a device tree definition.
Signed-off-by: Javier Mar
reset.
This patch used as a reference the logic in the IGEPv2 board file from
the ISEE 2.6.37 vendor tree.
Signed-off-by: Javier Martinez Canillas
---
drivers/media/i2c/tvp5150.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/media/i2c/tvp515
selected.
>
> Fixes: 1590ad7b5271 ("[media] media-device: split media initialization and
> registration")
> Cc: Javier Martinez Canillas
> Cc: Mauro Carvalho Chehab
> Signed-off-by: Thierry Reding
> ---
Thanks for the patch but I've already posted the same
ime due holidays season to finish
the discussion about the struct media_v2_topology layout.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message
:
>>>> This is the third version of the unrestricted media entity ID range
>>>> support set. I've taken Mauro's comments into account and fixed a number
>>>> of bugs as well (omap3isp memory leak and omap4iss stream start).
>>>
>>> Javi
Hello Okash,
On 12/22/2015 10:00 AM, Okash Khawaja wrote:
[snip]
>
> Cool. There was another similar compile error
>
> https://lkml.org/lkml/2015/12/22/196
>
Yes and you can see in that thread that I also mention
that was fixed already :)
> Thanks,
> Okash
>
edia_dev);
> +#endif
>
> done:
> if (retval < 0)
>
Thanks for your patch, I've posted the same fix already:
https://lkml.org/lkml/2015/12/21/270
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list:
.o' failed
>
> 'git blame' points at that line being added in:
>
> commit 1590ad7b52714fddc958189103c95541b49b1dae
> Author: Javier Martinez Canillas
> Date: Fri Dec 11 20:57:08 2015 -0200
>
> [media] media-device: split media initialization and registration
>
> Not sure what w
[media] media-device: split media initialization and
registration")
Reported-by: Fengguang Wu
Signed-off-by: Javier Martinez Canillas
---
drivers/media/usb/cx231xx/cx231xx-cards.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c
b/drivers
by: Mauro Carvalho Chehab
> ---
I agree with your patch, in fact the first version of the media
split patch did exactly this and later media_device_init() was
converted to void and the BUG_ON() introduced to address some
feedback I got during the patches review.
Reviewed-by: Javier Martinez Cani
d Sakari [0] but
he had a strong opinion about it and I didn't mind too much so I decided at
the end to just change it to a BUG_ON() so I could get his ack for this set.
> For sure, this is not the case here. Also, all drivers have already
> a logic that checks if the device init happened
On 12/16/2015 02:39 PM, Mauro Carvalho Chehab wrote:
> Em Wed, 16 Dec 2015 16:03:01 +0200
> Sakari Ailus escreveu:
>
>> Hi Javier,
>>
>> On Wed, Dec 16, 2015 at 03:32:15PM +0200, Sakari Ailus wrote:
>>> This is the third version of the unrestricted media e
; Signed-off-by: Mauro Carvalho Chehab
Looks good to me, sorry for forgetting to test with !CONFIG_MEDIA_CONTROLLER
and missing this...
Reviewed-by: Javier Martinez Canillas
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send t
: 1590ad7b5271 ("[media] media-device: split media initialization and
registration")
Reported-by: Fengguang Wu
Signed-off-by: Javier Martinez Canillas
---
drivers/media/usb/uvc/uvc_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/
he function, in order
> to prevent such race condition.
>
> Reported-by: Shuah Khan
> Signed-off-by: Mauro Carvalho Chehab
> ---
The patch looks good and I also tested it on an OMAP3 IGEPv2 board:
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Bes
7;t
> want to add a function prototype without needing it.
>
> No functional changes.
>
> Signed-off-by: Mauro Carvalho Chehab
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
T
Hello Mauro,
On 12/15/2015 07:41 AM, Mauro Carvalho Chehab wrote:
> Em Fri, 11 Dec 2015 16:36:27 -0700
> Shuah Khan escreveu:
>
>> On 12/11/2015 03:57 PM, Javier Martinez Canillas wrote:
>>> Most media functions that unregister, check if the corresponding register
>
Hello Mauro,
On 12/12/2015 10:50 AM, Mauro Carvalho Chehab wrote:
> Em Fri, 11 Dec 2015 19:57:06 -0300
> Javier Martinez Canillas escreveu:
>
>> Hello,
>>
>> This series fixes the issue of media device nodes being registered before
>> all the media entities and
h updates after
the media device was registered).
Best regards,
Javier
Changes in v5:
- Add kernel-doc for media_device_init() and media_device_register().
Changes in v4:
- Remove the model check from BUG_ON() since shold not be fatal.
Suggested by Sakari Ailus.
Changes in v3:
- Replace t
media_device_init().
Suggested-by: Sakari Ailus
Signed-off-by: Javier Martinez Canillas
Acked-by: Sakari Ailus
---
Changes in v5:
- Add kernel-doc for media_device_init() and media_device_register().
Changes in v4:
- Remove the model check from BUG_ON() since shold not be fatal.
Suggested by
.
This will also allow to split the media_device_register() function in an
initialization and registration functions without the need to change the
generic cleanup functions and error code paths for all the media drivers.
Suggested-by: Sakari Ailus
Signed-off-by: Javier Martinez Canillas
Acked-by
().
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Javier Martinez Canillas
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/media/media-device.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/media-device.c b/drivers/media
0]: https://www.mail-archive.com/linux-media@vger.kernel.org/msg94222.html
[1]: http://git.linuxtv.org/media_tree.git/log/?h=media-controller
[2]: http://git.linuxtv.org/mchehab/experimental.git/log/?h=media-controller-rc3
Best regards,
Javier
Javier Martinez Canillas (10):
[media] omap3isp: remove
c since is not using
a proper format.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
This patch addresses 2 remaining issues Laurent pointed in patch [0]:
1- Rename isp_create_pads_links() to isp_create_links().
2- Fix kernel-doc for the same f
to rename the label to just "error" in thi case.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
This patch addresses the last remaining issue Laurent pointed in patch [0]:
1- Rename label to just "error" if there is a single error label.
[0]:
Also, since the only possible failure for the link creation is a memory
allocation, there is no need for error messages since the core already
reports a very verbose message in that case.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
---
This patch addresses 3 of the i
201 - 300 of 917 matches
Mail list logo
