Re: drivers/staging/media/ipu3/ipu3-css.c:1831: bad compare ?

2019-01-07 Thread sakari.ai...@linux.intel.com
turn value from function first, then if it is ok, > assign it to an unsigned variable. Thanks for reporting this. There have been a few patches to address it so far, the one going in is here: https://patchwork.linuxtv.org/patch/53633/> -- Sakari Ailus sakari.ai...@linux.intel.com

Re: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI

2018-10-04 Thread sakari.ai...@linux.intel.com
t; The ux.y notation is more common in the context of software but I couldn't find any decent document to refer to. -- Regards, Sakari Ailus sakari.ai...@linux.intel.com

Re: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI

2018-09-13 Thread sakari.ai...@linux.intel.com
stitution and where not to. That seems unaddressable in the kernel-doc script; most of the time you want the definitions as-is while this is likely the only case where something else might be appropriate. Making IPU3_ALIGN a special case probably wouldn't really fly either. In this particular case I'd just write open the alignment requirement so kernel-doc can correctly parse it. -- Kind regards, Sakari Ailus sakari.ai...@linux.intel.com

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-16 Thread sakari.ai...@linux.intel.com
; > There is no limitation on using GRBG bayer order now. You can refer to imx355 > driver as well. It seems the rest of the driver uses RGGB. The enumeration should only contain what is possible using the current flipping configuration. -- Sakari Ailus sakari.ai...@linux.intel.com

Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-03-21 Thread sakari.ai...@linux.intel.com
6:28 PM > To: Yeh, Andy > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; > devicet...@vger.kernel.org; Chiang, AlanX > Subject: Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver > > Hi Andy, >a few comments on you patch below... > > O

Re: [PATCH v4 04/12] intel-ipu3: Add user space ABI definitions

2017-11-21 Thread sakari.ai...@linux.intel.com
Zhi, Yong > > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; Zheng, Jian > > Xu > > ; Mani, Rajmohan ; > > Toivonen, Tuukka ; Hu, Jerry W > > > > Subject: Re: [PATCH v4 04/12] intel-ipu3: Add user space ABI definitions > > > &

Re: [PATCH v2 08/12] intel-ipu3: params: compute and program ccs

2017-10-11 Thread sakari.ai...@linux.intel.com
t; > To: Zhi, Yong > > Cc: Linux Media Mailing List ; > > sakari.ai...@linux.intel.com; Zheng, Jian Xu ; > > tf...@chromium.org; Mani, Rajmohan ; > > Toivonen, Tuukka > > Subject: Re: [PATCH v2 08/12] intel-ipu3: params: compute and program ccs > > >