[PATCH v6 16/39] [media] add Omnivision OV5640 sensor driver

2017-03-27 Thread Steve Longerbeam
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile

[PATCH v6 12/39] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-03-27 Thread Steve Longerbeam
Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/bo

[PATCH v6 20/39] media: imx: Add Capture Device Interface

2017-03-27 Thread Steve Longerbeam
. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/Makefile| 1 + drivers/staging/media/imx/imx-media-capture.c | 663 ++ 2 files changed, 664 insertions(+) create mode 100644 drivers/staging/media/imx/imx

[PATCH v6 32/39] media: imx: csi: add frame skipping support

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel <p.za...@pengutronix.de> The CSI can skip any out of up to 6 input frames, allowing to reduce the frame rate at the output pads by small fractions. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.

[PATCH v6 34/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel <p.za...@pengutronix.de> The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam &l

[PATCH v6 22/39] media: imx: Add VDIC subdev driver

2017-03-27 Thread Steve Longerbeam
This is a media entity subdevice driver for the i.MX Video De-Interlacing or Combining Block. So far this entity does not implement the Combining function but only motion compensated deinterlacing. Video frames are received from the CSI and are routed to the IC PRPVF entity. Signed-off-by: Steve

[PATCH v6 26/39] media: imx: add support for bayer formats

2017-03-27 Thread Steve Longerbeam
From: Russell King <rmk+ker...@armlinux.org.uk> Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam &l

[PATCH v6 21/39] media: imx: Add CSI subdev driver

2017-03-27 Thread Steve Longerbeam
This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/Kconfig | 14 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c

[PATCH v6 31/39] media: imx: redo pixel format enumeration and negotiation

2017-03-27 Thread Steve Longerbeam
-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-ic-prp.c| 77 -- drivers/staging/media/imx/imx-ic-prpencvf.c | 57 ++-- drivers/staging/media/imx/imx-media-capture.c | 85 -- drivers/staging/media/imx/imx-media-csi.c | 108 +--- d

[PATCH v6 29/39] media: imx: csi: add __csi_get_fmt

2017-03-27 Thread Steve Longerbeam
Add __csi_get_fmt() and use it to return the correct mbus format (active or try) in get_fmt. Use it in other places as well. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Suggested-by: Russell King <li...@armlinux.org.uk> --- drivers/staging/media/imx/imx-medi

[PATCH v6 37/39] media: imx-csi: add frame size/interval enumeration

2017-03-27 Thread Steve Longerbeam
range of frame sizes. CSI can also drop frames, resulting in frame rate reduction, so enumerate the resulting possible output frame rates. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/im

[PATCH v6 36/39] media: imx: csi: add sink selection rectangles

2017-03-27 Thread Steve Longerbeam
From: Philipp Zabel Move the crop rectangle to the sink pad and add a sink compose rectangle to configure scaling. Also propagate rectangles from sink pad to crop rectangle, to compose rectangle, and to the source pads both in ACTIVE and TRY variants of set_fmt/selection,

[PATCH v6 38/39] media: imx-ic-prpencvf: add frame size enumeration

2017-03-27 Thread Steve Longerbeam
Add frame size enumeration operation. The PRP ENC/VF subdevices are scalers, so they can output a continuous range of widths/ heights on their source pads. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-ic-prpencvf.

[PATCH v6 27/39] media: imx: csi: add support for bayer formats

2017-03-27 Thread Steve Longerbeam
destination is IDMAC output pad when passthrough conditions exist: bayer formats and 16-bit parallel buses. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-media-csi.c | 75 +++ 1 file changed, 57 insertions(+), 18

[PATCH v6 39/39] media: imx-media-capture: add frame sizes/interval enumeration

2017-03-27 Thread Steve Longerbeam
From: Russell King <rmk+ker...@armlinux.org.uk> Add support for enumerating frame sizes and frame intervals from the first subdev via the V4L2 interfaces. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --

[PATCH v6 33/39] media: imx: csi: Avoid faulty sensor frames at stream start

2017-03-27 Thread Steve Longerbeam
-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-media-csi.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index d9c3a3b..8597d7e 100644 --- a/d

[PATCH v6 25/39] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

2017-03-27 Thread Steve Longerbeam
max zoneorder to allow larger video buffer allocations. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/configs/imx_v6_v7_defconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/c

[PATCH v6 35/39] media: imx: propagate sink pad formats to source pads

2017-03-27 Thread Steve Longerbeam
propagation in this case was easy, just have only a single format shared by both pads. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-ic-prp.c| 39 ++--- drivers/staging/media/imx/imx-ic-prpencvf.c | 95 +++ drivers/staging/media/i

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-21 Thread Steve Longerbeam
related to the sink formats, so so much would have to be modified after copying the sink format that it would be rather pointless, except to forward the colorimetry params. Steve What if the format structure gains a new member? diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/

Re: [PATCH 3/4] media: imx-csi: add frame size/interval enumeration

2017-03-21 Thread Steve Longerbeam
, not on the format at the source pads, due to the crop/compose re-org patch from Philipp. The updated patch is attached. Steve >From ce1772dfe9e0381b2749102e760ed7c49fda5ae2 Mon Sep 17 00:00:00 2001 From: Russell King <rmk+ker...@armlinux.org.uk> Date: Sun, 19 Mar 2017 10:49:02 + Subject: [PATCH 36/

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-21 Thread Steve Longerbeam
Hi Philipp, Russell, On 03/20/2017 10:23 AM, Philipp Zabel wrote: Hi Steve, Russell, What do you think of this: --8<-- From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001 From: Philipp Zabel <p.za...@pengutronix.de> Date: Mon, 20 Mar 2017 17:10

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Steve Longerbeam
On 03/20/2017 10:23 AM, Philipp Zabel wrote: Hi Steve, Russell, On Mon, 2017-03-20 at 14:17 +, Russell King - ARM Linux wrote: On Mon, Mar 20, 2017 at 03:00:51PM +0100, Philipp Zabel wrote: On Mon, 2017-03-20 at 12:08 +, Russell King - ARM Linux wrote: The same document says

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-20 Thread Steve Longerbeam
pad crop selection. - the CSI hardware /2 downscaler should be specified via the sink pad compose selection. - the final source pad rectangle is the same as the sink pad compose rectangle. So that leaves only step 4 (source pad crop selection) as unsupported. Steve I have previously set

Re: [PATCH 4/4] media: imx-media-capture: add frame sizes/interval enumeration

2017-03-19 Thread Steve Longerbeam
>stepwise.min_width = fse.min_width; fsize->stepwise.max_width = fse.max_width; fsize->stepwise.min_height = fse.min_height; fsize->stepwise.max_height = fse.max_height; fsize->stepwise.step_width = 1; fsize->stepwise.step_height = 1; } ...

Re: [PATCH 3/4] media: imx-csi: add frame size/interval enumeration

2017-03-19 Thread Steve Longerbeam
e sinks rather than only the last set/tried values. So the sink enumeration should return a continuous range. The source enumeration should behave the same as you have it above however, i.e. a discrete set of 4 possibilities since the CSI is limited to only /2 downsizing in bot

Re: [PATCH 2/4] media: imx: allow bayer pixel formats to be looked up

2017-03-19 Thread Steve Longerbeam
This is good too, but if it's all right with you I would prefer to squash this with the "redo pixel format enumeration and negotiation" patch, to keep the patch count down. Steve On 03/19/2017 03:48 AM, Russell King wrote: Allow imx_media_find_format() to look up bayer form

Re: [PATCH 1/4] media: imx-media-csi: fix v4l2-compliance check

2017-03-19 Thread Steve Longerbeam
Looks good to me. Steve On 03/19/2017 03:48 AM, Russell King wrote: v4l2-compliance was failing with: fail: v4l2-test-formats.cpp(1076): cap->timeperframe.numerator == 0 || cap->timeperframe.denominator == 0 test VIDIOC_G/S_PARM: FAIL Fix this. Sign

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: 0:00:01.955927879 20954 0x15ffe90 INFOv4l2 gstv4l2object.c:3811:gst_v4l2_object_get_caps

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote: On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: From: Philipp Zabel <p.za...@pengutronix.de> The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the pr

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 11:51 AM, Russell King - ARM Linux wrote: On Sun, Mar 19, 2017 at 11:37:15AM -0700, Steve Longerbeam wrote: On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: Right now, CSI doesn't do that - it only looks at the width, height, code, and field. Correct, there is currently

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: Right, imx-media-capture.c (the "standard" v4l2 user interface module) is not implementing VIDIOC_ENUM_FRAMESIZES. It should, but it can only return the single

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Steve Longerbeam
Hi Russell, On 03/14/2017 10:29 AM, Steve Longerbeam wrote: On 03/12/2017 02:09 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 08:40:37PM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote: But hold on, if my logic

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Steve Longerbeam
On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: Hi Steve, I've just been trying to get gstreamer to capture and h264 encode video from my camera at various frame rates, and what I've discovered does not look good. 1) when setting frame rates, media-ctl _always_ calls

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-15 Thread Steve Longerbeam
On 03/10/2017 11:17 AM, Fabio Estevam wrote: On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky <troy.ki...@boundarydevices.com> wrote: On 3/9/2017 8:52 PM, Steve Longerbeam wrote: There is a pin conflict with GPIO_6. This pin functions as a power input pin to the OV5642 camera sensor, bu

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-14 Thread Steve Longerbeam
On 03/12/2017 02:09 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 08:40:37PM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote: But hold on, if my logic is correct, then why did the CSI power-off get reached in your case

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-14 Thread Steve Longerbeam
;); for some devices. imx6 is setting bus_info string on all capture devices as: snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", dev_name(priv->dev)); dev_name(priv->dev) is the device name of the attached subdev. So the bus_info string, at l

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Steve Longerbeam
input capture support. Steve

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Steve Longerbeam
On 03/14/2017 09:21 AM, Nicolas Dufresne wrote: Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: The event must be user visible, otherwise the user has

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-13 Thread Steve Longerbeam
er, I meant I will integrate this patch. And verify/fix possible breakage for non-bayer passthrough. Steve On 03/13/2017 02:30 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 08:16:25AM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-13 Thread Steve Longerbeam
On 03/13/2017 01:16 AM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve Longerbeam wrote: On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote: What I had was this patch for your v3. I never got to testing your v4 because of the LP-11 problem. In v5

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Steve Longerbeam
On 03/13/2017 10:10 AM, Hans Verkuil wrote: On 03/13/2017 06:06 PM, Steve Longerbeam wrote: On 03/13/2017 03:53 AM, Hans Verkuil wrote: On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-03-13 Thread Steve Longerbeam
on: either the subdevs have to walk the graph to find the source of frame rate, or s_frame_interval would have to be mandatory and validated between pads, same as set_fmt. Steve

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-13 Thread Steve Longerbeam
On 03/13/2017 03:53 AM, Hans Verkuil wrote: On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: The event must be user visible, otherwise the user has no indication the error

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:05:06PM -0700, Steve Longerbeam wrote: On 03/12/2017 12:57 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote: If it's too difficult to get the imx219 csi-2

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 01:36 PM, Steve Longerbeam wrote: On 03/12/2017 01:16 PM, Steve Longerbeam wrote: On 03/12/2017 12:44 PM, Steve Longerbeam wrote: On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 01:16 PM, Steve Longerbeam wrote: On 03/12/2017 12:44 PM, Steve Longerbeam wrote: On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually nothing preventing userland from disabling a link

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 12:44 PM, Steve Longerbeam wrote: On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually nothing preventing userland from disabling a link multiple times, and imx_media_link_notify() complies

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 12:57 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote: If it's too difficult to get the imx219 csi-2 transmitter into the LP-11 state on power on, perhaps the csi-2 receiver can be a little more lenient on the transmitter

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
I've just rebooted, and now I find it's on /dev/video2 instead. Yes, that's still an issue I haven't had the chance to get to yet. It could be as simple as passing a fixed device node # to video_register_device(), but something tells me it won't be that easy. But I'll get to this in next versi

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually nothing preventing userland from disabling a link multiple times, and imx_media_link_notify() complies, and so csi_s_power(OFF) gets called multiple times

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-12 Thread Steve Longerbeam
called multiple times, and so that WARN_ON() in there is silly, I borrowed this from other MC driver examples, but it makes no sense to me, I'll remove it and prevent the power count from going negative. Steve [ cut here ] WARNING: CPU: 1 PID: 1889 at drivers/staging/media

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-12 Thread Steve Longerbeam
On 03/11/2017 11:37 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote: On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: I really don't think expecting the user to understand and configure the pipeline is a sane way forward. Think

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-11 Thread Steve Longerbeam
on, perhaps the csi-2 receiver can be a little more lenient on the transmitter and make the LP-11 timeout a warning instead of error-out. Can you try the attached change on top of the version 5 patchset? If that doesn't work then you're just going to have to fix the bug in imx219. Steve diff --git

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
elevant: the iMX6 board I have here has a RPi compatible connector for a MIPI CSI2 camera. In fact, the IMX219 module I'm using _is_ a RPi camera, it's the RPi NoIR Camera V2.) The iMX6 problem is way larger than just "which subdev do I need to configure for control X" - if you look at t

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
a control appear in two places (subdev and video nodes) can be confusing. I guess that's way to go. It is impossible to change userland APIs once the patch is merged... Ok, not including myself, it's now 4 in favor of removing, 1 against... Steve

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 05:41 AM, Sakari Ailus wrote: Hi Steve, On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote: If the pads on both sides of a link specify a frame interval, then those frame intervals should match. Create the exported function v4l2_subdev_link_validate_frame_interval

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: I really don't think expecting the user to understand and configure the pipeline is a sane way forward. Think

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you never capture

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you never capture

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:08:23AM -0800, Steve Longerbeam wrote: On 03/11/2017 07:32 AM, Sakari Ailus wrote: Hi Mauro and Hans, On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote: Em Sat, 11 Mar 2017 12:32:43 +0100

Re: [PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 05:49 AM, Sakari Ailus wrote: Hi Steve, On Thu, Mar 09, 2017 at 08:53:01PM -0800, Steve Longerbeam wrote: Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> The existing V4L2 UAPI headers are under includ

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-11 Thread Steve Longerbeam
On 03/11/2017 03:39 AM, Hans Verkuil wrote: On 10/03/17 19:37, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Steve Longerbeam
driver users should decide if it either makes sense or not, based on the expected use cases. My understanding of the i.MX6 case is the hardware is configurable enough to warrant the use of the Media controller API. Some patches indicate there are choices to be made in data routing. Steve: coul

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Steve Longerbeam
On 03/10/2017 03:30 PM, Pavel Machek wrote: On Fri 2017-03-10 10:37:21, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-10 Thread Steve Longerbeam
state on exit from s_power(ON)? I realize that probably means bringing the chip up to a completely operational state and then setting it to stream OFF in the s_power() op. The same had to be done for the OV5640. Steve

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Steve Longerbeam
Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video

[PATCH v5 00/39] i.MX Media Driver

2017-03-09 Thread Steve Longerbeam
frame skipping support media: imx: csi: fix crop rectangle reset in sink set_fmt Russell King (4): media: imx: add support for bayer formats media: imx: csi: add support for bayer formats media: imx: mipi-csi2: enable setting and getting of frame rates media: imx: csi/fim: add support f

[PATCH v5 02/39] [media] dt-bindings: Add bindings for i.MX media driver

2017-03-09 Thread Steve Longerbeam
Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Documentation/devicetree/bindings/media/imx.txt | 74 + 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v5 01/39] [media] dt-bindings: Add bindings for video-multiplexer device

2017-03-09 Thread Steve Longerbeam
From: Philipp Zabel <p.za...@pengutronix.de> Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.c

[PATCH v5 04/39] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

2017-03-09 Thread Steve Longerbeam
Add to the MIPI CSI2 receiver node: compatible strings, interrupt sources, and clocks. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/bo

[PATCH v5 08/39] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-03-09 Thread Steve Longerbeam
-2 receiver on mipi_csi. The OV5642 node is disabled temporarily while the subdev driver is cleaned up and submitted later. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6dl-sabrelite.dts | 5 ++ arch/arm/boot/dts/imx6q-sabrelite.dts| 5 ++

[PATCH v5 06/39] ARM: dts: imx6qdl: add capture-subsystem device

2017-03-09 Thread Steve Longerbeam
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 8958c4a..a959c76

[PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-09 Thread Steve Longerbeam
oards that have the HW workaround for ERR006687") Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b

[PATCH v5 03/39] [media] dt/bindings: Add bindings for OV5640

2017-03-09 Thread Steve Longerbeam
Add device tree binding documentation for the OV5640 camera sensor. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- .../devicetree/bindings/media/i2c/ov5640.txt | 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devi

[PATCH v5 05/39] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

2017-03-09 Thread Steve Longerbeam
muxes for the connections from parallel sensors. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6dl.dtsi | 180 + arch/arm/boot/dts/imx6q.dtsi | 116 ++ arch/arm/boot/dts/imx6qd

[PATCH v5 12/39] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-03-09 Thread Steve Longerbeam
Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/bo

[PATCH v5 09/39] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-03-09 Thread Steve Longerbeam
available for testing, the ov5642 node is currently disabled. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6dl-sabresd.dts | 5 ++ arch/arm/boot/dts/imx6q-sabresd.dts| 5 ++ arch/arm/boot/dts/imx6qdl-sabresd.dtsi

[PATCH v5 11/39] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

2017-03-09 Thread Steve Longerbeam
, that chip is needed by more functions (usb and adv7180). Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/i

[PATCH v5 13/39] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

2017-03-09 Thread Steve Longerbeam
Enables the ADV7180 decoder sensor. The ADV7180 connects to the parallel-bus mux input on ipu1_csi0_mux. The ADV7180 power pin is via max7310_b port expander. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabreauto.dts

[PATCH v5 14/39] add mux and video interface bridge entity functions

2017-03-09 Thread Steve Longerbeam
From: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Documentation/media/uapi/mediactl/me

[PATCH v5 16/39] [media] v4l2: add a new-frame before end-of-frame event

2017-03-09 Thread Steve Longerbeam
Add a NEW_FRAME_BEFORE_EOF event to signal that a video capture or output device has signaled a new frame is ready before a previous frame has completed reception or transmission. This usually indicates a DMA read/write channel is having trouble gaining bus access. Signed-off-by: Steve Longerbeam

[PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

2017-03-09 Thread Steve Longerbeam
callbacks. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/media/v4l2-core/v4l2-subdev.c | 50 +++ include/media/v4l2-subdev.h | 10 +++ 2 files changed, 60 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-subde

[PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-09 Thread Steve Longerbeam
Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video that is outside the nominal frame interval by some tolerance value. Signed-off-by: Steve Longerbeam

[PATCH v5 19/39] [media] add Omnivision OV5640 sensor driver

2017-03-09 Thread Steve Longerbeam
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile

[PATCH v5 17/39] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-09 Thread Steve Longerbeam
v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/media/v4l2-core/v4l2-mc.c | 48 +++ include/media/v4l

[PATCH v5 20/39] platform: add video-multiplexer subdevice driver

2017-03-09 Thread Steve Longerbeam
tionality of this driver, but allows for it to be merged now, before adding the chaining support. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/media/platform/Kconfig | 8 + drivers/media/platform/Makefile| 2 + drivers/media/plat

[PATCH v5 23/39] media: Add i.MX media core driver

2017-03-09 Thread Steve Longerbeam
Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Documentation/media/v4l-drivers/imx.rst | 560 drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile

[PATCH v5 25/39] media: imx: Add CSI subdev driver

2017-03-09 Thread Steve Longerbeam
This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/Kconfig | 14 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c

[PATCH v5 24/39] media: imx: Add Capture Device Interface

2017-03-09 Thread Steve Longerbeam
. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/Makefile| 1 + drivers/staging/media/imx/imx-media-capture.c | 655 ++ 2 files changed, 656 insertions(+) create mode 100644 drivers/staging/media/imx/imx

[PATCH v5 29/39] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

2017-03-09 Thread Steve Longerbeam
max zoneorder to allow larger video buffer allocations. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/configs/imx_v6_v7_defconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/c

[PATCH v5 22/39] media: Add userspace header file for i.MX

2017-03-09 Thread Steve Longerbeam
This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom v4l2 controls for the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- include/uapi/media/Kbuild | 1 + include/uapi/media/imx.h

[PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

2017-03-09 Thread Steve Longerbeam
Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- include/uapi/Kbuild | 1 + include/uapi/media/Kbuild | 1 + 2 files changed, 2 insertions(+) create mode 100644 include/uapi/media/Kbuild diff --git a/includ

[PATCH v5 28/39] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-03-09 Thread Steve Longerbeam
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx6-mipi-csi2.c

[PATCH v5 26/39] media: imx: Add VDIC subdev driver

2017-03-09 Thread Steve Longerbeam
This is a media entity subdevice driver for the i.MX Video De-Interlacing or Combining Block. So far this entity does not implement the Combining function but only motion compensated deinterlacing. Video frames are received from the CSI and are routed to the IC PRPVF entity. Signed-off-by: Steve

[PATCH v5 31/39] media: imx: csi: add support for bayer formats

2017-03-09 Thread Steve Longerbeam
destination is IDMAC output pad when passthrough conditions exist: bayer formats and 16-bit parallel buses. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-media-csi.c | 52 +-- 1 file changed, 43 insertions(+), 9

[PATCH v5 30/39] media: imx: add support for bayer formats

2017-03-09 Thread Steve Longerbeam
From: Russell King <rmk+ker...@armlinux.org.uk> Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam &l

[PATCH v5 33/39] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-03-09 Thread Steve Longerbeam
s part of the negotiation. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx6-mipi-csi2.c | 36 ++ 1 file changed, 36 insertions(+) diff --git a/drivers/stag

[PATCH v5 32/39] media: imx: csi: fix crop rectangle changes in set_fmt

2017-03-09 Thread Steve Longerbeam
ed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-media-csi.c | 35 --- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/imx/imx-medi

[PATCH v5 35/39] media: imx: csi/fim: add support for frame intervals

2017-03-09 Thread Steve Longerbeam
From: Russell King <rmk+ker...@armlinux.org.uk> Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> Signed-off-by: Steve Longerbeam <steve_longer

<    1   2   3   4   5   6   7   8   9   10   >