[PATCH v4 19/36] media: imx: Add Capture Device Interface

2017-02-15 Thread Steve Longerbeam
. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile| 2 +- drivers/staging/media/imx/imx-media-capture.c | 654 ++ 2 files changed, 655 insertions(+), 1 deletion(-) create mode 100644 drivers/staging/media/imx/imx-media-capture.c diff

[PATCH v4 26/36] media: imx: add support for bayer formats

2017-02-15 Thread Steve Longerbeam
From: Russell King Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-utils.c

[PATCH v4 20/36] media: imx: Add CSI subdev driver

2017-02-15 Thread Steve Longerbeam
This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 13 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c | 1220

[PATCH v4 24/36] [media] add Omnivision OV5640 sensor driver

2017-02-15 Thread Steve Longerbeam
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam --- .../devicetree/bindings/media/i2c/ov5640.txt | 43 + drivers/media/i2c/Kconfig

[PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-15 Thread Steve Longerbeam
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx6-mipi-csi2.c | 573 + 2 files changed, 574

[PATCH v4 27/36] media: imx: csi: add support for bayer formats

2017-02-15 Thread Steve Longerbeam
: bayer formats and 16-bit parallel buses. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 50 ++- 1 file changed, 42 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx

[PATCH v4 25/36] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

2017-02-15 Thread Steve Longerbeam
max zoneorder to allow larger video buffer allocations. Signed-off-by: Steve Longerbeam --- arch/arm/configs/imx_v6_v7_defconfig | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index

[PATCH v4 32/36] media: imx: csi/fim: add support for frame intervals

2017-02-15 Thread Steve Longerbeam
Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 36 --- drivers/staging/media/imx/imx

[PATCH v4 28/36] media: imx: csi: fix crop rectangle changes in set_fmt

2017-02-15 Thread Steve Longerbeam
ff-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 35 --- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index ae24b42..3cb97e2 100644 --- a/dr

[PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-15 Thread Steve Longerbeam
d-off-by: Russell King Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx6-mipi-csi2.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c index 23dca80..c62f14e 1

[PATCH v4 31/36] media: imx: csi: add __csi_get_fmt

2017-02-15 Thread Steve Longerbeam
Add __csi_get_fmt() and use it to return the correct mbus format (active or try) in get_fmt. Use it in other places as well. Signed-off-by: Steve Longerbeam Suggested-by: Russell King --- drivers/staging/media/imx/imx-media-csi.c | 52 --- 1 file changed, 40

[PATCH v4 35/36] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-02-15 Thread Steve Longerbeam
From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 11 +-- 1 file

[PATCH v4 34/36] media: imx: csi: add frame skipping support

2017-02-15 Thread Steve Longerbeam
From: Philipp Zabel The CSI can skip any out of up to 6 input frames, allowing to reduce the frame rate at the output pads by small fractions. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-csi.c | 119 +- 1

[PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

2017-02-15 Thread Steve Longerbeam
(u32 *code, u32 index, enum codespace_sel cs_sel); The tables have been split into separate tables for YUV and RGB formats to support the implementation of the above. The subdev's .enum_mbus_code() and .set_fmt() operations have been rewritten using the above APIs. Signed-off-by: Steve Longe

[PATCH v4 30/36] media: imx: update capture dev format on IDMAC output pad set_fmt

2017-02-15 Thread Steve Longerbeam
When configuring the IDMAC output pad formats (in ipu_csi, ipu_ic_prpenc, and ipu_ic_prpvf subdevs), the attached capture device format must also be updated. Signed-off-by: Steve Longerbeam Suggested-by: Philipp Zabel --- drivers/staging/media/imx/imx-ic-prpencvf.c | 9 + drivers

[PATCH v4 36/36] media: imx: propagate sink pad formats to source pads

2017-02-15 Thread Steve Longerbeam
Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prp.c | 11 ++- drivers/staging/media/imx/imx-ic-prpencvf.c | 22 ++ drivers/staging/media/imx/imx-media-csi.c | 26 +- drivers/staging/media/imx/imx-media-vdic.c | 15

[PATCH v4 22/36] media: imx: Add IC subdev drivers

2017-02-15 Thread Steve Longerbeam
directly from the CSI or from the VDIC. Scaled output is limited to 1024x1024 resolution. Output frames are routed to the capture device. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx-ic-common.c | 113 +++ drivers

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-14 Thread Steve Longerbeam
e below. On 01/31/2017 05:54 AM, Philipp Zabel wrote: Hi Steve, I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some observations: # Link pipeline media-ctl -l "'tc358743 1-000f':0->

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-13 Thread Steve Longerbeam
(#!##* Thunderbird! resending text only) Hi Philipp, On 02/13/2017 01:20 AM, Philipp Zabel wrote: Hi Steve, On Thu, 2017-02-09 at 15:51 -0800, Steve Longerbeam wrote: On 02/09/2017 03:49 PM, Steve Longerbeam wrote: On 02/08/2017 03:42 PM, Russell King - ARM Linux wrote: On Wed, Feb 08

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-02-12 Thread Steve Longerbeam
(resending text only) On 02/02/2017 02:36 AM, Laurent Pinchart wrote: Hi Steve, Thank you for the patch. Many of the comments below apply to the ov5642 driver too, please take them into account when reworking patch 23/24. On Friday 06 Jan 2017 18:11:40 Steve Longerbeam wrote: This driver is

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-09 Thread Steve Longerbeam
On 02/09/2017 03:49 PM, Steve Longerbeam wrote: On 02/08/2017 03:42 PM, Russell King - ARM Linux wrote: On Wed, Feb 08, 2017 at 03:23:53PM -0800, Steve Longerbeam wrote: Actually, this exact function already exists as dw_mipi_dsi_phy_write in drivers/gpu/drm/rockchip/dw-mipi-dsi.c, and it

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-09 Thread Steve Longerbeam
On 02/08/2017 03:42 PM, Russell King - ARM Linux wrote: On Wed, Feb 08, 2017 at 03:23:53PM -0800, Steve Longerbeam wrote: Actually, this exact function already exists as dw_mipi_dsi_phy_write in drivers/gpu/drm/rockchip/dw-mipi-dsi.c, and it looks like the D-PHY register 0x44 might contain a

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-08 Thread Steve Longerbeam
;format_mbus; The output formats are different from the input formats, see the media bus format discussion in the other thread. The input pad is the MIPI CSI-2 bus, but the four output pads are connected to the muxes / CSIs via a 16-bit parallel bus. So if the input format is UYVY8_1X16,

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-02-06 Thread Steve Longerbeam
On 02/02/2017 02:50 PM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:34PM -0800, Steve Longerbeam wrote: +/* register an internal subdev as a platform device */ +static struct imx_media_subdev * +add_internal_subdev(struct imx_media_dev *imxmd, + const

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

2017-02-06 Thread Steve Longerbeam
for tracking this down. I remember doing this when I was reviewing the code for opportunities to "optimize" :-/, and carelessly caused this bug by not reviewing how video_device is freed. Fixed. Steve -- To unsubscribe from this list: send the line "unsubscribe linux-media"

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-06 Thread Steve Longerbeam
On 02/06/2017 02:33 PM, Laurent Pinchart wrote: Hi Hans, (CC'ing Sakari) On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote: On 02/05/2017 04:48 PM, Laurent Pinchart wrote: On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote: On 01/24/2017 04:02 AM, Philipp Zabel wrote: On Fri, 20

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-03 Thread Steve Longerbeam
On 02/02/2017 02:29 PM, Russell King - ARM Linux wrote: On Thu, Feb 02, 2017 at 11:12:41AM -0800, Steve Longerbeam wrote: Here is the current .queue_setup() op in imx-media-capture.c: static int capture_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-03 Thread Steve Longerbeam
On 02/03/2017 06:41 AM, Laurent Pinchart wrote: Hello, On Wednesday 01 Feb 2017 16:19:27 Steve Longerbeam wrote: On 02/01/2017 01:30 AM, Philipp Zabel wrote: media-ctl propagates the output pad format to all remote subdevices' input pads for all enabled links: https://git.linuxtv.or

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Steve Longerbeam
On 02/02/2017 10:58 AM, Russell King - ARM Linux wrote: On Thu, Feb 02, 2017 at 10:26:55AM -0800, Steve Longerbeam wrote: On 02/02/2017 09:56 AM, Russell King - ARM Linux wrote: and for whatever reason we end up falling out through free_ring. This is VERY bad news, because it means that the

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Steve Longerbeam
the ring should not have been freed, it should have only returned the error. And further bad stuff happens from that point on. But all of this is gone in version 4. Steve It doesn't matter if you later reallocate it, it could very well end up with a different pointer from kmalloc(). S

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Steve Longerbeam
Hi Russell, I don't recommend spending too much time debugging this OOPS. The dma buffer ring has been removed completely in version 4 (which I'm trying to get ready to post hopefully by end of this week). Steve On 02/02/2017 09:22 AM, Russell King - ARM Linux wrote: I seem to

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-01 Thread Steve Longerbeam
On 02/01/2017 01:30 AM, Philipp Zabel wrote: On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: [...] # Set pad formats media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY/1920x1080]" media-ctl --set-v4l2 "'imx6-mipi-csi2':1[fmt:UYVY2X8/1920x1080]&qu

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-01 Thread Steve Longerbeam
On 02/01/2017 03:44 PM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:39PM -0800, Steve Longerbeam wrote: +static int imxcsi2_get_fmt(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg, + struct v4l2_subdev_format

Re: [PATCH v3 18/24] media: imx: Add SMFC subdev driver

2017-02-01 Thread Steve Longerbeam
On 02/01/2017 10:39 AM, Russell King - ARM Linux wrote: Hi Steve, On Fri, Jan 06, 2017 at 06:11:36PM -0800, Steve Longerbeam wrote: +/* + * Min/Max supported width and heights. + * + * We allow planar output from the SMFC, so we have to align + * output width by 16 pixels to meet IDMAC

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Steve Longerbeam
On 01/31/2017 04:23 PM, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 03:43:22PM -0800, Steve Longerbeam wrote: On 01/31/2017 03:00 AM, Russell King - ARM Linux wrote: Just like smiapp, the camera sensor block (which is the very far end of the pipeline) is marked with

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-31 Thread Steve Longerbeam
On 01/31/2017 08:48 AM, Philipp Zabel wrote: On Tue, 2017-01-31 at 16:51 +0100, Philipp Zabel wrote: On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: [...] +static int csi_set_fmt(struct v4l2_subdev *sd, + struct v4l2_subdev_pad_config *cfg

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Steve Longerbeam
On 01/31/2017 05:54 AM, Philipp Zabel wrote: Hi Steve, I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some observations: # Link pipeline media-ctl -l "'tc358743 1-000f':0->'imx6

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-01-31 Thread Steve Longerbeam
IPI sensors that s_power(ON) should only place the D_PHY in LP-11, and _not_ start the clock lane. But perhaps that is correct behavior anyway. Steve With Philipp's driver, this is easy, because there is a prepare_stream callback which gives the sensor an opportunity to get everythi

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-31 Thread Steve Longerbeam
On 01/31/2017 03:20 AM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:35PM -0800, Steve Longerbeam wrote: +static int csi_link_validate(struct v4l2_subdev *sd, +struct media_link *link, +struct v4l2_subdev_format

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Steve Longerbeam
On 01/31/2017 03:00 AM, Russell King - ARM Linux wrote: On Mon, Jan 30, 2017 at 05:22:01PM -0800, Steve Longerbeam wrote: I'm also having trouble finding a datasheet for it, but from what I've read, it has a MIPI CSI-2 interface. It should work fine as long as it presents a single

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

2017-01-31 Thread Steve Longerbeam
On 01/31/2017 03:30 PM, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 02:36:53PM -0800, Steve Longerbeam wrote: On 01/31/2017 02:04 PM, Russell King - ARM Linux wrote: I don't want master though, I want v4.10-rc1, and if I ask for that it tells me it knows nothing about v4.1

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

2017-01-31 Thread Steve Longerbeam
On 01/31/2017 02:04 PM, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 09:55:29PM +, Ian Arkver wrote: On 31/01/17 20:33, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 10:21:26AM -0800, Steve Longerbeam wrote: On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

2017-01-31 Thread Steve Longerbeam
imx_media_enum_format(). All the others now (the non-device node pads), request only RGB or packed YUV, or the IPU internal formats for IPU internal connections, and these are the first entries in the table. The planar formats all are at the end, which can only be enumerated by the capture devic

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-01-30 Thread Steve Longerbeam
On 01/30/2017 03:29 PM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:40PM -0800, Steve Longerbeam wrote: +config IMX_OV5640_MIPI + tristate "OmniVision OV5640 MIPI CSI-2 camera support" + depends on GPIOLIB && VIDEO_IMX_CAMERA + se

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-01-30 Thread Steve Longerbeam
On 01/30/2017 04:31 PM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:39PM -0800, Steve Longerbeam wrote: +++ b/drivers/staging/media/imx/imx-mipi-csi2.c ... +#define DEVICE_NAME "imx6-mipi-csi2" Why is the device/driver named imx6-mipi-csi2, but the module name

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-30 Thread Steve Longerbeam
dic 6909 2 imx_mipi_csi2 6293 1 ov5640_mipi25988 1 imx_media 15532 0 imx_media_common 16093 6 imx_media_ic,imx_media,imx_media_csi,imx_mipi_cs i2,imx_media_capture,imx_media_vdic Steve Philipp's driver can do this (once the unload bugs are fi

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-30 Thread Steve Longerbeam
the v3 driver and I'll try to find what's missing. Edit: I see a subdev that is missing: the video mux. Did you enable CONFIG_VIDEO_MULTIPLEXER? Finally, what platform does this IMX219 sensor module plug into? Steve -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-28 Thread Steve Longerbeam
On 01/24/2017 03:27 AM, Philipp Zabel wrote: Hi Steve, Hans, [added Laurent to Cc: who I believe might have an opinion on the media bus formats, too. Sorry for the wall of text, I have put a marker where the MEDIA_BUS argument starts] The central issue seems to be that I think media pad

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-25 Thread Steve Longerbeam
On 01/24/2017 04:44 AM, Javier Martinez Canillas wrote: Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: From: Philipp Zabel [snip] +config VIDEO_MULTIPLEXER + tristate "Video Multiplexer" + depends on VIDEO_V4L2_SUBDEV_API && MED

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-01-25 Thread Steve Longerbeam
On 01/20/2017 06:48 AM, Hans Verkuil wrote: On 01/07/2017 03:11 AM, Steve Longerbeam wrote: + + /* cached control settings */ + int ctrl_cache[OV5640_MAX_CONTROLS]; This is just duplicating the cached value in the control framework. I think this can be dropped. done, see below

Re: [PATCH v3 19/24] media: imx: Add IC subdev drivers

2017-01-24 Thread Steve Longerbeam
On 01/20/2017 06:29 AM, Hans Verkuil wrote: On 01/07/2017 03:11 AM, Steve Longerbeam wrote: + +static const struct v4l2_ctrl_config prpenc_std_ctrl[] = { + { + .id = V4L2_CID_HFLIP, + .name = "Horizontal Flip", + .type = V4L2_CTRL_TY

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-24 Thread Steve Longerbeam
d by the CSI's, at least the virtual channel number is ignored. For example, if the sensor is transmitting on vc 1, the gasket routes the sensor data to the parallel bus to CSI1. But if CSI_MIPI_DI on CSI1 is written with vc 1, no data is received. Steve Currently we let g_mbus_config pret

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

2017-01-23 Thread Steve Longerbeam
On 01/20/2017 06:38 AM, Hans Verkuil wrote: On 01/07/2017 03:11 AM, Steve Longerbeam wrote: +static int vidioc_querycap(struct file *file, void *fh, + struct v4l2_capability *cap) +{ + strncpy(cap->driver, "imx-media-camif", sizeof(cap

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-23 Thread Steve Longerbeam
On 01/23/2017 05:38 PM, Steve Longerbeam wrote: Second, ignoring the above locking issue for a moment, v4l2_pipeline_pm_use() will call s_power on the sensor _first_, then the mipi csi-2 s_power, when executing media-ctl -l '"ov5640 1-003c":0 -> "imx6-mipi-csi2&quo

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-23 Thread Steve Longerbeam
On 01/23/2017 03:13 AM, Philipp Zabel wrote: Hi Steve, On Sun, 2017-01-22 at 18:31 -0800, Steve Longerbeam wrote: On 01/16/2017 05:47 AM, Philipp Zabel wrote: On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: [...] +Unprocessed Video Capture: +-- + +Send

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-23 Thread Steve Longerbeam
interface is wrong, and I am afraid that even though in staging, it might become established. I don't believe there is anything wrong with the userspace interface, In fact it hasn't even changed. The fact two pads are passing memory buffers is "under the hood".

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-22 Thread Steve Longerbeam
On 01/16/2017 05:47 AM, Philipp Zabel wrote: On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: [...] +Unprocessed Video Capture: +-- + +Send frames directly from sensor to camera interface, with no +conversions: + +-> ipu_smfc -> camif I'd call t

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-20 Thread Steve Longerbeam
Hi Hans, Philipp, On 01/20/2017 08:31 AM, Philipp Zabel wrote: Hi Hans, On Fri, 2017-01-20 at 14:52 +0100, Hans Verkuil wrote: Hi Steve, Philipp, On 01/07/2017 03:11 AM, Steve Longerbeam wrote: In version 3: Changes suggested by Rob Herring : - prepended FIM node properties with

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-18 Thread Steve Longerbeam
On 01/14/2017 02:42 PM, Steve Longerbeam wrote: +/* parse inputs property from a sensor node */ +static void of_parse_sensor_inputs(struct imx_media_dev *imxmd, + struct imx_media_subdev *sensor, + struct device_node

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-16 Thread Steve Longerbeam
On 01/16/2017 07:03 AM, Philipp Zabel wrote: On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: This is a media entity subdevice for the i.MX Camera Serial Interface module. s/Serial/Sensor/ done. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 13

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-16 Thread Steve Longerbeam
On 01/16/2017 04:55 AM, Philipp Zabel wrote: On Fri, 2017-01-13 at 15:04 -0800, Steve Longerbeam wrote: @@ -299,6 +326,52 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_i2c2>; status = "okay"; + + ov5640: camera@40 { +

Re: [PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver

2017-01-16 Thread Steve Longerbeam
On 01/16/2017 04:09 AM, Philipp Zabel wrote: On Fri, 2017-01-13 at 11:03 -0800, Steve Longerbeam wrote: On 01/13/2017 03:55 AM, Philipp Zabel wrote: Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: Add bindings documentation for the i.MX media driver. Signed-off-by: Steve

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-14 Thread Steve Longerbeam
(sorry sending again w/o html) On 01/13/2017 07:20 AM, Philipp Zabel wrote: Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: +For image capture, the IPU contains the following internal subunits: + +- Image DMA Controller (IDMAC) +- Camera Serial Interface (CSI) +- Image

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2017-01-14 Thread Steve Longerbeam
On 01/13/2017 03:05 AM, Philipp Zabel wrote: Hi Steve, Am Donnerstag, den 12.01.2017, 15:22 -0800 schrieb Steve Longerbeam: Hi Philipp, JM, First, let me say that you both have convinced me that we need a VDIC entity. I've implemented that in the branch imx-media-staging-md-vdic. At

Re: [PATCH v3 15/24] media: Add userspace header file for i.MX

2017-01-13 Thread Steve Longerbeam
On 01/13/2017 04:05 AM, Philipp Zabel wrote: Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom v4l2 controls and events generated by the i.MX v4l2 subdevices

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-13 Thread Steve Longerbeam
On 01/13/2017 04:03 AM, Philipp Zabel wrote: Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. Both hang off the same i2c2 bus, so they require different (and non- default) i2c slave addresses. The

Re: [PATCH v3 02/24] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

2017-01-13 Thread Steve Longerbeam
On 01/13/2017 03:57 AM, Philipp Zabel wrote: Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: Add to the MIPI CSI2 receiver node: compatible string, interrupt sources, clocks. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed

Re: [PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver

2017-01-13 Thread Steve Longerbeam
On 01/13/2017 03:55 AM, Philipp Zabel wrote: Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 57 + 1 file

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2017-01-12 Thread Steve Longerbeam
On 01/12/2017 03:43 PM, Steve Longerbeam wrote: On 01/12/2017 03:22 PM, Steve Longerbeam wrote: and since my PRPVF entity roles up the VDIC internally, it is actually receiving from the VDIC channel. So unless you think we should have a distinct VDIC entity, I would like to keep this

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2017-01-12 Thread Steve Longerbeam
On 01/12/2017 03:22 PM, Steve Longerbeam wrote: and since my PRPVF entity roles up the VDIC internally, it is actually receiving from the VDIC channel. So unless you think we should have a distinct VDIC entity, I would like to keep this the way it is. Yes, I think VDIC should be separated

Re: [PATCH v3 10/24] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-01-12 Thread Steve Longerbeam
On 01/12/2017 11:37 AM, Tim Harvey wrote: On Fri, Jan 6, 2017 at 6:11 PM, Steve Longerbeam wrote: Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2017-01-12 Thread Steve Longerbeam
ad. I would imagine it will need two additional inputs and another output to support the Combiner (two pads for each plane to be combined, and a combiner output pad). More below... On 01/11/2017 04:10 AM, Philipp Zabel wrote: Hi Steve, Am Dienstag, den 10.01.2017, 15:52 -0800 schrieb Steve Longe

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-12 Thread Steve Longerbeam
D/Q? Well, same number of virtual channels on quad vs S/DL. It's just that the video mux on S/DL can select from all 4 virtual channels, whereas quad's mux'es only select either vc0 or vc3. I get the same results on the S/DL as I do on D/Q as long as I adjust the links to compensat

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-11 Thread Steve Longerbeam
Hi Tim, On 01/11/2017 03:14 PM, Tim Harvey wrote: Hi Steve, I took a stab at testing this today on a gw51xx which has an adv7180 hooked up as follows: - i2c3@0x20 - 8bit data bus from DAT12 to DAT19, HSYNC, VSYNC, PIXCLK on CSI0 pads (CSI0_IPU1) - PWRDWN# on

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2017-01-10 Thread Steve Longerbeam
On 01/09/2017 04:15 PM, Steve Longerbeam wrote: Hi Philipp, On 01/09/2017 11:43 AM, Philipp Zabel wrote: One is the amount and organization of subdevices/media entities visible to userspace. The SMFCs should not be user controllable subdevices, but can be implicitly enabled when a CSI is

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2017-01-09 Thread Steve Longerbeam
Hi Philipp, On 01/09/2017 11:43 AM, Philipp Zabel wrote: Hi Steve, Am Freitag, den 30.12.2016, 12:26 -0800 schrieb Steve Longerbeam: On 12/30/2016 11:06 AM, Marek Vasut wrote: On 12/29/2016 09:51 PM, Robert Schwebel wrote: Hi Jean-Michel, Hi, On Thu, Dec 29, 2016 at 04:08:33PM +0100

[PATCH v3 11/24] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

2017-01-06 Thread Steve Longerbeam
ADV7180 power pin is via max7310_b port expander. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 61 1 file changed, 61 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi

[PATCH v3 00/24] i.MX Media Driver

2017-01-06 Thread Steve Longerbeam
s into imx-media.h. Philipp Zabel (3): ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections add mux and video interface bridge entity functions platform: add video-multiplexer subdevice driver Steve Longerbeam (21): [media] dt-bindings: Add bindings for i

[PATCH v3 12/24] add mux and video interface bridge entity functions

2017-01-06 Thread Steve Longerbeam
From: Philipp Zabel Signed-off-by: Philipp Zabel --- Documentation/media/uapi/mediactl/media-types.rst | 22 ++ include/uapi/linux/media.h| 6 ++ 2 files changed, 28 insertions(+) diff --git a/Documentation/media/uapi/mediactl/media-types.rst b

[PATCH v3 03/24] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

2017-01-06 Thread Steve Longerbeam
endpoint anchors to the mipi_csi for the connections from mipi csi-2 sensors. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl.dtsi | 187 + arch/arm/boot/dts/imx6q.dtsi | 123 +++ arch/arm/boot/dts/imx6qdl.dts

[PATCH v3 02/24] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

2017-01-06 Thread Steve Longerbeam
Add to the MIPI CSI2 receiver node: compatible string, interrupt sources, clocks. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 53e6e63..42926e9

[PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-06 Thread Steve Longerbeam
ered() and the prep patches for that). For now, I've removed the use of v4l2_of_subdev_registered() for the vidmux driver's registered callback. This doesn't affect the functionality of this driver, but allows for it to be merged now, before adding the chaining support. S

[PATCH v3 19/24] media: imx: Add IC subdev drivers

2017-01-06 Thread Steve Longerbeam
re-process encode. However this entity sends frames to the i.MX IPU image converter which supports image tiling, which allows scaled output up to 4096x4096 resolution. Output frames can be routed to the camera interfaces. Signed-off-by: Steve Longerbeam --- drivers/staging/media/im

[PATCH v3 14/24] UAPI: Add media UAPI Kbuild file

2017-01-06 Thread Steve Longerbeam
Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam --- include/uapi/Kbuild | 1 + include/uapi/media/Kbuild | 1 + 2 files changed, 2 insertions(+) create mode 100644 include/uapi/media/Kbuild diff --git a/include/uapi/Kbuild b/include/uapi/Kbuild

[PATCH v3 16/24] media: Add i.MX media core driver

2017-01-06 Thread Steve Longerbeam
Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/media/v4l-drivers/imx.rst | 443 ++ drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile| 1 + drivers/staging/media/imx/Kconfig

[PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-01-06 Thread Steve Longerbeam
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile| 1 + drivers/staging/media/imx/imx-mipi-csi2.c | 501 ++ 2 files changed, 502

[PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-06 Thread Steve Longerbeam
This is a media entity subdevice for the i.MX Camera Serial Interface module. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 13 + drivers/staging/media/imx/Makefile | 2 + drivers/staging/media/imx/imx-csi.c | 644 3 files

[PATCH v3 15/24] media: Add userspace header file for i.MX

2017-01-06 Thread Steve Longerbeam
This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom v4l2 controls and events generated by the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam --- include/uapi/media/Kbuild | 1 + include/uapi/media/imx.h | 30

[PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-06 Thread Steve Longerbeam
CSI-2 receiver on mipi_csi. It is set to transmit over MIPI virtual channel 1. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl-sabrelite.dts | 5 ++ arch/arm/boot/dts/imx6q-sabrelite.dts| 6 ++ arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 118

[PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

2017-01-06 Thread Steve Longerbeam
the IC post-process task. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile|2 +- drivers/staging/media/imx/imx-camif.c | 1000 + 2 files changed, 1001 insertions(+), 1 deletion(-) create mode 100644 drivers/staging/media/imx/imx

[PATCH v3 18/24] media: imx: Add SMFC subdev driver

2017-01-06 Thread Steve Longerbeam
-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx-smfc.c | 737 +++ 2 files changed, 738 insertions(+) create mode 100644 drivers/staging/media/imx/imx-smfc.c diff --git a/drivers/staging/media/imx/Makefile b

[PATCH v3 24/24] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

2017-01-06 Thread Steve Longerbeam
. Signed-off-by: Steve Longerbeam --- arch/arm/configs/imx_v6_v7_defconfig | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index cbe7faf..b67b99f 100644 --- a/arch/arm/configs

[PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-01-06 Thread Steve Longerbeam
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig |8 + drivers/staging/media/imx/Makefile |2

[PATCH v3 05/24] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-01-06 Thread Steve Longerbeam
oards that have the HW workaround for ERR006687") Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelit

[PATCH v3 10/24] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-01-06 Thread Steve Longerbeam
Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi index

[PATCH v3 08/24] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

2017-01-06 Thread Steve Longerbeam
X7310) are thus moved into i2cmux. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 65 +--- 1 file changed, 44 insertions(+), 21 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto

[PATCH v3 07/24] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

2017-01-06 Thread Steve Longerbeam
sensor module compatible with the SabreSD becomes available for testing, the ov5642 node is currently disabled. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl-sabresd.dts | 5 ++ arch/arm/boot/dts/imx6q-sabresd.dts| 5 ++ arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 114

[PATCH v3 09/24] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

2017-01-06 Thread Steve Longerbeam
max7310_b, that chip is needed by more functions (usb and adv7180). Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi ind

[PATCH v3 04/24] ARM: dts: imx6qdl: add media device

2017-01-06 Thread Steve Longerbeam
Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6q.dtsi | 4 arch/arm/boot/dts/imx6qdl.dtsi | 8 2 files changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi index 9b2ca32..8867e78 100644 --- a/arch/arm/boot/dts/imx6q.dtsi

[PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver

2017-01-06 Thread Steve Longerbeam
Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 57 + 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx.txt diff --git a

<    4   5   6   7   8   9   10   11   12   13   >