Re: [PATCH v4 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-18 Thread Y Song
On Fri, May 18, 2018 at 1:17 PM, Y Song wrote: > On Fri, May 18, 2018 at 7:07 AM, Sean Young wrote: >> This is simple test over rc-loopback. >> >> Signed-off-by: Sean Young > > Acked-by: Yonghong Song Just one minor thing. You need to add "test_lirc_mode2_user

Re: [PATCH v4 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-18 Thread Y Song
sample as passed into > + * the program. > + * > + * The *protocol* is the decoded protocol number (see > + * **enum rc_proto** for some predefined values). > + * > + * This helper is only available is the kernel was compiled with >

Re: [PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-18 Thread Y Song
e lirc daemon. > > +config BPF_LIRC_MODE2 > + bool "Support for eBPF programs attached to lirc devices" > + depends on BPF_SYSCALL > + depends on RC_CORE=y > + depends on LIRC > + help > + Allow attaching eBPF progra

Re: [PATCH v4 1/3] bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found

2018-05-18 Thread Y Song
On Fri, May 18, 2018 at 7:07 AM, Sean Young wrote: > This makes is it possible for bpf prog detach to return -ENOENT. > > Signed-off-by: Sean Young Acked-by: Yonghong Song

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Y Song
On Thu, May 17, 2018 at 2:45 PM, Sean Young wrote: > Hi, > > Again thanks for a thoughtful review. This will definitely will improve > the code. > > On Thu, May 17, 2018 at 10:02:52AM -0700, Y Song wrote: >> On Wed, May 16, 2018 at 2:04 PM, Sean Young wro

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-17 Thread Y Song
t; +} > + > +char _license[] SEC("license") = "GPL"; > diff --git a/tools/testing/selftests/bpf/test_rawir_event_user.c > b/tools/testing/selftests/bpf/test_rawir_event_user.c > new file mode 100644 > index ..c3d7f2c68033 > --- /dev/null > +++ b/tools/testing/selftests/bpf/test_rawir_event_user.c > @@ -0,0 +1,130 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// test ir decoder > +// > +// Copyright (C) 2018 Sean Young > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "bpf_util.h" > +#include > +#include > + > +int main(int argc, char **argv) > +{ > + struct bpf_object *obj; > + int ret, lircfd, progfd, mode; > + int testir = 0x1dead; > + u32 prog_ids[10], prog_flags[10], prog_cnt; > + > + if (argc != 2) { > + printf("Usage: %s /dev/lircN\n", argv[0]); Most people probably not really familiar with lircN device. It would be good to provide more information about how to enable this, e.g., CONFIG_RC_CORE=y CONFIG_BPF_RAWIR_EVENT=y CONFIG_RC_LOOPBACK=y .. Thanks!

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Y Song
lirc daemon. > > +config BPF_RAWIR_EVENT > + bool "Support for eBPF programs attached to lirc devices" > + depends on BPF_SYSCALL > + depends on RC_CORE=y > + depends on LIRC > + help > + Allow attaching eBPF progra

Re: [PATCH v1 4/4] samples/bpf: an example of a raw IR decoder

2018-05-14 Thread Y Song
Makefile > +++ b/samples/bpf/Makefile > @@ -44,6 +44,7 @@ hostprogs-y += xdp_monitor > hostprogs-y += xdp_rxq_info > hostprogs-y += syscall_tp > hostprogs-y += cpustat > +hostprogs-y += grundig_decoder > > # Libbpf dependencies > LIBBPF := ../../tools/lib/bpf/bpf.o ../../t

Re: [PATCH v1 3/4] media: rc bpf: move ir_raw_event to uapi

2018-05-14 Thread Y Song
On Mon, May 14, 2018 at 2:11 PM, Sean Young wrote: > The context provided to a BPF_PROG_RAWIR_DECODER is a struct ir_raw_event; > ensure user space has a a definition. > > Signed-off-by: Sean Young > --- > include/media/rc-core.h| 19 +-- > include/uapi/linux/bpf_rcdev.h

Re: [PATCH v1 2/4] media: bpf: allow raw IR decoder bpf programs to be used

2018-05-14 Thread Y Song
On Mon, May 14, 2018 at 2:10 PM, Sean Young wrote: > This implements attaching, detaching, querying and execution. The target > fd has to be the /dev/lircN device. > > Signed-off-by: Sean Young > --- > drivers/media/rc/ir-bpf-decoder.c | 191 ++ > drivers/media/rc/lir

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-14 Thread Y Song
@@ config IR_IMON_DECODER >remote control and you would like to use it with a raw IR >receiver, or if you wish to use an encoder to transmit this IR. > > +config IR_BPF_DECODER > + bool "Enable IR raw decoder using BPF" > + depends

[PATCH] Documentation: add support for V4L touch devices

2016-07-18 Thread y
is composed of an array of +horizontal and vertical conductors (alternatively called rows/columns, X/Y +lines, or tx/rx). Mutual Capacitance measured is at the nodes where the +conductors cross. Alternatively, Self Capacitance measures the signal from each +column and row independently. + +A touch

[PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl

2015-08-12 Thread Shah, Yash (Y.)
From: Yash Shah Fix line over 80 characters warning as detected by checkpatch.pl Signed-off-by: Yash Shah --- drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/med

RE: [PATCH] V4L2: clear buf when vrfb buf not allocated

2009-11-20 Thread Y, Kishore
> -Original Message- > From: Hiremath, Vaibhav > Sent: Wednesday, November 18, 2009 8:44 PM > To: Y, Kishore; linux-media@vger.kernel.org > Cc: linux-o...@vger.kernel.org > Subject: RE: [PATCH] V4L2: clear buf when vrfb buf not allocated > > > > -Origina

[PATCH] V4L2: clear buf when vrfb buf not allocated

2009-11-18 Thread Y, Kishore
>From 15246e4dfa6853d9aef48a4b8633f93efe40ed81 Mon Sep 17 00:00:00 2001 From: Kishore Y Date: Thu, 12 Nov 2009 20:47:58 +0530 Subject: [PATCH] V4L2: clear buf when vrfb buf not allocated buffer memory is set to 0 only for the first time before the vrfb buffer is allocated Signed-off

[RFC] [PATCH] V4L2: Allow rotation between stream off-on

2009-11-17 Thread Y, Kishore
This patch is dependent on the patch [PATCH 4/4] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2 >From cda5b97d02784318d89a029a2fde97903610d2b2 Mon Sep 17 00:00:00 2001 From: Kishore Y Date: Wed, 11 Nov 2009 19:22:46 +0530 Subject: [PATCH] V4L2: Allow rotation between stream

[RFC] [PATCH] omap_vout: Change allocated buffer to only needed size

2009-11-17 Thread Y, Kishore
This patch is dependent on the patch [PATCH 4/4] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2 >From eb4302232f15e0af075604a9cf24fcaa9688e8a5 Mon Sep 17 00:00:00 2001 From: Kishore Y Date: Tue, 10 Nov 2009 21:44:10 +0530 Subject: [PATCH] omap_vout: Change allocated buffer

[RFC] [PATCH] omap_vout: default colorspace for RGB565 set to SRGB

2009-11-17 Thread Y, Kishore
This patch is dependent on the patch [PATCH 4/4] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2 >From 41b85f02f441771ace6c42ee08475ab7be04eb90 Mon Sep 17 00:00:00 2001 From: Kishore Y Date: Wed, 11 Nov 2009 19:47:14 +0530 Subject: [PATCH] omap_vout: default colorspace