Re: [PATCH/RFC v2 3/4] gspca: sonixj: Add V4L2_CID_JPEG_COMPRESSION_QUALITY control support

2012-01-14 Thread Jean-Francois Moine
On Fri, 6 Jan 2012 19:14:41 +0100 Sylwester Nawrocki snj...@gmail.com wrote: The JPEG compression quality value can currently be read using the VIDIOC_G_JPEGCOMP ioctl. As the quality field of struct v4l2_jpgecomp is being deprecated, we add the V4L2_CID_JPEG_COMPRESSION_QUALITY control, so

Re: [PATCH/RFC v2 3/4] gspca: sonixj: Add V4L2_CID_JPEG_COMPRESSION_QUALITY control support

2012-01-14 Thread Sylwester Nawrocki
On 01/14/2012 09:47 AM, Jean-Francois Moine wrote: On Fri, 6 Jan 2012 19:14:41 +0100 Sylwester Nawrockisnj...@gmail.com wrote: The JPEG compression quality value can currently be read using the VIDIOC_G_JPEGCOMP ioctl. As the quality field of struct v4l2_jpgecomp is being deprecated, we

Re: [PATCH/RFC v2 3/4] gspca: sonixj: Add V4L2_CID_JPEG_COMPRESSION_QUALITY control support

2012-01-14 Thread Jean-Francois Moine
On Sat, 14 Jan 2012 18:42:20 +0100 Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Thank you for reviewing the patches. I wasn't sure I fully understood the locking, hence I left the 'quality' field in 'struct sd' not removed. I've modified both subdrivers according to your

Re: [PATCH/RFC v2 3/4] gspca: sonixj: Add V4L2_CID_JPEG_COMPRESSION_QUALITY control support

2012-01-14 Thread Sylwester Nawrocki
On 01/14/2012 07:24 PM, Jean-Francois Moine wrote: Setting the JPEG quality in sonixj has been removed when automatic quality adjustment has been added (git commit b96cfc33e7). At this time, I let the JPEG get function, but it could have been removed as well: I don't think the users are

[PATCH/RFC v2 3/4] gspca: sonixj: Add V4L2_CID_JPEG_COMPRESSION_QUALITY control support

2012-01-06 Thread Sylwester Nawrocki
The JPEG compression quality value can currently be read using the VIDIOC_G_JPEGCOMP ioctl. As the quality field of struct v4l2_jpgecomp is being deprecated, we add the V4L2_CID_JPEG_COMPRESSION_QUALITY control, so after the deprecation period VIDIOC_G_JPEGCOMP ioctl handler can be removed,