Re: [PATCH] [Patch v2] usbtv: Fix refcounting mixup

2018-05-16 Thread Hans Verkuil
On 05/16/18 11:23, Oliver Neukum wrote: > Am Dienstag, den 15.05.2018, 18:01 +0200 schrieb Hans Verkuil: >> On 05/15/2018 05:46 PM, Oliver Neukum wrote: >>> Am Dienstag, den 15.05.2018, 16:28 +0200 schrieb Hans Verkuil: On 05/15/18 15:07, Oliver Neukum wrote: > > usbtv_audio_fail: >

Re: [PATCH] [Patch v2] usbtv: Fix refcounting mixup

2018-05-16 Thread Oliver Neukum
Am Dienstag, den 15.05.2018, 18:01 +0200 schrieb Hans Verkuil: > On 05/15/2018 05:46 PM, Oliver Neukum wrote: > > Am Dienstag, den 15.05.2018, 16:28 +0200 schrieb Hans Verkuil: > > > On 05/15/18 15:07, Oliver Neukum wrote: > > > > usbtv_audio_fail: > > > > /* we must not free at this

Re: [PATCH] [Patch v2] usbtv: Fix refcounting mixup

2018-05-15 Thread Hans Verkuil
On 05/15/2018 05:46 PM, Oliver Neukum wrote: > Am Dienstag, den 15.05.2018, 16:28 +0200 schrieb Hans Verkuil: >> On 05/15/18 15:07, Oliver Neukum wrote: >>> The premature free in the error path is blocked by V4L >>> refcounting, not USB refcounting. Thanks to >>> Ben Hutchings for review. >>> >>>

Re: [PATCH] [Patch v2] usbtv: Fix refcounting mixup

2018-05-15 Thread Oliver Neukum
Am Dienstag, den 15.05.2018, 16:28 +0200 schrieb Hans Verkuil: > On 05/15/18 15:07, Oliver Neukum wrote: > > The premature free in the error path is blocked by V4L > > refcounting, not USB refcounting. Thanks to > > Ben Hutchings for review. > > > > [v2] corrected attributions > > > >

Re: [PATCH] [Patch v2] usbtv: Fix refcounting mixup

2018-05-15 Thread Hans Verkuil
On 05/15/18 15:07, Oliver Neukum wrote: > The premature free in the error path is blocked by V4L > refcounting, not USB refcounting. Thanks to > Ben Hutchings for review. > > [v2] corrected attributions > > Signed-off-by: Oliver Neukum > Fixes: 50e704453553 ("media: usbtv:

[PATCH] [Patch v2] usbtv: Fix refcounting mixup

2018-05-15 Thread Oliver Neukum
The premature free in the error path is blocked by V4L refcounting, not USB refcounting. Thanks to Ben Hutchings for review. [v2] corrected attributions Signed-off-by: Oliver Neukum Fixes: 50e704453553 ("media: usbtv: prevent double free in error case") CC: