Re: [PATCH] [V2] stv090x: variable 'no_signal' set but not used

2012-06-28 Thread Peter Senna Tschudin
On Thu, Jun 28, 2012 at 10:41 AM, Ezequiel Garcia wrote: > On Thu, Jun 28, 2012 at 10:17 AM, Peter Senna Tschudin > wrote: >> Hey Ezequiel, >> >> On Thu, Jun 28, 2012 at 1:02 AM, Ezequiel Garcia >> wrote: >>> Hey Peter, >>> >>> On Wed, Jun 27, 2012 at 7:18 PM, Peter Senna Tschudin >>> wrote: >

Re: [PATCH] [V2] stv090x: variable 'no_signal' set but not used

2012-06-28 Thread Ezequiel Garcia
On Thu, Jun 28, 2012 at 10:17 AM, Peter Senna Tschudin wrote: > Hey Ezequiel, > > On Thu, Jun 28, 2012 at 1:02 AM, Ezequiel Garcia > wrote: >> Hey Peter, >> >> On Wed, Jun 27, 2012 at 7:18 PM, Peter Senna Tschudin >> wrote: >>> -                       no_signal = stv090x_chk_signal(state); >>>

Re: [PATCH] [V2] stv090x: variable 'no_signal' set but not used

2012-06-28 Thread Peter Senna Tschudin
On Thu, Jun 28, 2012 at 10:17 AM, Peter Senna Tschudin wrote: > Hey Ezequiel, > > On Thu, Jun 28, 2012 at 1:02 AM, Ezequiel Garcia > wrote: >> Hey Peter, >> >> On Wed, Jun 27, 2012 at 7:18 PM, Peter Senna Tschudin >> wrote: >>> -                       no_signal = stv090x_chk_signal(state); >>>

Re: [PATCH] [V2] stv090x: variable 'no_signal' set but not used

2012-06-28 Thread Peter Senna Tschudin
Hey Ezequiel, On Thu, Jun 28, 2012 at 1:02 AM, Ezequiel Garcia wrote: > Hey Peter, > > On Wed, Jun 27, 2012 at 7:18 PM, Peter Senna Tschudin > wrote: >> -                       no_signal = stv090x_chk_signal(state); >> +                       (void) stv090x_chk_signal(state); > > Why are you cas

Re: [PATCH] [V2] stv090x: variable 'no_signal' set but not used

2012-06-27 Thread Ezequiel Garcia
Hey Peter, On Wed, Jun 27, 2012 at 7:18 PM, Peter Senna Tschudin wrote: > -                       no_signal = stv090x_chk_signal(state); > +                       (void) stv090x_chk_signal(state); Why are you casting return to void? I can't see there is a reason to it. Regards, Ezequiel. -- To

[PATCH] [V2] stv090x: variable 'no_signal' set but not used

2012-06-27 Thread Peter Senna Tschudin
Remove variable and ignore return value of stv090x_chk_signal(). Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- drivers/media/dvb/frontends/stv090x.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/