[PATCH] [media] coda: add missing header dependencies

2016-09-23 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/media/platform/coda/coda-h264.c:21:5: warning: no previous prototype for 'coda_h264_padding' [-Wmissing-prototypes] In fact, this function is declared in drivers/media/platform/coda/coda.h, so this patch adds missing header dependencies. Si

Re: [PATCH] [media] coda: add missing header dependencies

2016-09-06 Thread Philipp Zabel
Am Dienstag, den 06.09.2016, 11:21 +0200 schrieb Arnd Bergmann: > On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote: > > #include > > #include > > +#include > > > > by convention, we tend to write this as > > #include "coda.h" > > otherwise the patch looks good to me, > > Ack

Re: [PATCH] [media] coda: add missing header dependencies

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote: > #include > #include > +#include > by convention, we tend to write this as #include "coda.h" otherwise the patch looks good to me, Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-m

[PATCH] [media] coda: add missing header dependencies

2016-09-06 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/media/platform/coda/coda-h264.c:22:5: warning: no previous prototype for 'coda_h264_padding' [-Wmissing-prototypes] In fact, this function is declared in coda.h, so this patch add missing header dependencies. Signed-off-by: Baoyou Xie ---