[PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-10-20 Thread Taylor Ralph
I've attached a patch that correctly sets the max/min/default values for the hdpvr picture controls. The reason the current values didn't cause a problem until now is because any firmware <= 0.15 didn't support them. The latest firmware releases properly support picture controls and the values in t

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2012-01-31 Thread Taylor Ralph
On Wed, Dec 21, 2011 at 5:14 PM, Taylor Ralph wrote: > On Mon, Nov 7, 2011 at 7:54 PM, Taylor Ralph wrote: >> On Mon, Nov 7, 2011 at 7:21 AM, Mauro Carvalho Chehab >> wrote: >>> Em 21-10-2011 01:33, Taylor Ralph escreveu: On Thu, Oct 20, 2011 at 3:26 PM, Taylor Ralph wrote: > On

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2012-02-14 Thread Jarod Wilson
On Mon, Nov 7, 2011 at 7:54 PM, Taylor Ralph wrote: > On Mon, Nov 7, 2011 at 7:21 AM, Mauro Carvalho Chehab > wrote: >> Em 21-10-2011 01:33, Taylor Ralph escreveu: >>> On Thu, Oct 20, 2011 at 3:26 PM, Taylor Ralph >>> wrote: On Thu, Oct 20, 2011 at 2:14 PM, Devin Heitmueller wrote: >

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2012-02-14 Thread Devin Heitmueller
On Tue, Feb 14, 2012 at 3:43 PM, Jarod Wilson wrote: > Looks sane to me, and really needs to get in ASAP. I'd even suggest we > get it sent to stable, as these newer firmware HDPVR are pretty wonky > with any current kernel. > > Acked-by: Jarod Wilson > Reviewed-by: Jarod Wilson > CC: sta...@vge

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2012-02-14 Thread Jarod Wilson
On Tue, Feb 14, 2012 at 4:32 PM, Devin Heitmueller wrote: > On Tue, Feb 14, 2012 at 3:43 PM, Jarod Wilson wrote: >> Looks sane to me, and really needs to get in ASAP. I'd even suggest we >> get it sent to stable, as these newer firmware HDPVR are pretty wonky >> with any current kernel. >> >> Ack

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-10-20 Thread Devin Heitmueller
On Thu, Oct 20, 2011 at 11:24 AM, Taylor Ralph wrote: > I've attached a patch that correctly sets the max/min/default values > for the hdpvr picture controls. The reason the current values didn't > cause a problem until now is because any firmware <= 0.15 didn't > support them. The latest firmware

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-10-20 Thread Taylor Ralph
On Thu, Oct 20, 2011 at 11:30 AM, Devin Heitmueller wrote: > On Thu, Oct 20, 2011 at 11:24 AM, Taylor Ralph wrote: >> I've attached a patch that correctly sets the max/min/default values >> for the hdpvr picture controls. The reason the current values didn't >> cause a problem until now is becaus

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-10-20 Thread Janne Grunau
On Thu, Oct 20, 2011 at 11:30:11AM -0400, Devin Heitmueller wrote: > On Thu, Oct 20, 2011 at 11:24 AM, Taylor Ralph wrote: > > I've attached a patch that correctly sets the max/min/default values > > for the hdpvr picture controls. The reason the current values didn't > > cause a problem until now

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-10-20 Thread Devin Heitmueller
On Thu, Oct 20, 2011 at 12:23 PM, Janne Grunau wrote: > On Thu, Oct 20, 2011 at 11:30:11AM -0400, Devin Heitmueller wrote: >> On Thu, Oct 20, 2011 at 11:24 AM, Taylor Ralph >> wrote: >> > I've attached a patch that correctly sets the max/min/default values >> > for the hdpvr picture controls. Th

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-10-20 Thread Janne Grunau
On Thu, Oct 20, 2011 at 12:35:40PM -0400, Devin Heitmueller wrote: > On Thu, Oct 20, 2011 at 12:23 PM, Janne Grunau wrote: > > > > I've looked at them only at very beginning and if I recall correctly > > they had no visible effects. The values in the linux driver were taken > > from sniffing the w

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-10-20 Thread Devin Heitmueller
On Thu, Oct 20, 2011 at 1:08 PM, Janne Grunau wrote: > I think such scenario is unlikely but I don't know it for sure and > I don't want to force anyone to test every firmware version. > Ignoring them for firmware version < 16 should be safe since we assume > they had no effect. Returning -EINVAL

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-10-20 Thread Taylor Ralph
On Thu, Oct 20, 2011 at 2:14 PM, Devin Heitmueller wrote: > On Thu, Oct 20, 2011 at 1:08 PM, Janne Grunau wrote: >> I think such scenario is unlikely but I don't know it for sure and >> I don't want to force anyone to test every firmware version. >> Ignoring them for firmware version < 16 should

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-10-20 Thread Taylor Ralph
On Thu, Oct 20, 2011 at 3:26 PM, Taylor Ralph wrote: > On Thu, Oct 20, 2011 at 2:14 PM, Devin Heitmueller > wrote: >> On Thu, Oct 20, 2011 at 1:08 PM, Janne Grunau wrote: >>> I think such scenario is unlikely but I don't know it for sure and >>> I don't want to force anyone to test every firmwar

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-11-07 Thread Mauro Carvalho Chehab
Em 21-10-2011 01:33, Taylor Ralph escreveu: > On Thu, Oct 20, 2011 at 3:26 PM, Taylor Ralph wrote: >> On Thu, Oct 20, 2011 at 2:14 PM, Devin Heitmueller >> wrote: >>> On Thu, Oct 20, 2011 at 1:08 PM, Janne Grunau wrote: I think such scenario is unlikely but I don't know it for sure and

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-11-07 Thread Taylor Ralph
On Mon, Nov 7, 2011 at 7:21 AM, Mauro Carvalho Chehab wrote: > Em 21-10-2011 01:33, Taylor Ralph escreveu: >> On Thu, Oct 20, 2011 at 3:26 PM, Taylor Ralph wrote: >>> On Thu, Oct 20, 2011 at 2:14 PM, Devin Heitmueller >>> wrote: On Thu, Oct 20, 2011 at 1:08 PM, Janne Grunau wrote: > I

Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15

2011-12-21 Thread Taylor Ralph
On Mon, Nov 7, 2011 at 7:54 PM, Taylor Ralph wrote: > On Mon, Nov 7, 2011 at 7:21 AM, Mauro Carvalho Chehab > wrote: >> Em 21-10-2011 01:33, Taylor Ralph escreveu: >>> On Thu, Oct 20, 2011 at 3:26 PM, Taylor Ralph >>> wrote: On Thu, Oct 20, 2011 at 2:14 PM, Devin Heitmueller wrote: >

missing patches in patchwork (was Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15)

2012-02-15 Thread Janne Grunau
On 2012-02-14 17:09:55 -0500, Jarod Wilson wrote: > On Tue, Feb 14, 2012 at 4:32 PM, Devin Heitmueller > wrote: > > On Tue, Feb 14, 2012 at 3:43 PM, Jarod Wilson wrote: > >> Looks sane to me, and really needs to get in ASAP. I'd even suggest we > >> get it sent to stable, as these newer firmware

Re: missing patches in patchwork (was Re: [PATCH] [media] hdpvr: update picture controls to support firmware versions > 0.15)

2012-02-15 Thread Mauro Carvalho Chehab
Em 15-02-2012 09:46, Janne Grunau escreveu: > On 2012-02-14 17:09:55 -0500, Jarod Wilson wrote: >> On Tue, Feb 14, 2012 at 4:32 PM, Devin Heitmueller >> wrote: >>> On Tue, Feb 14, 2012 at 3:43 PM, Jarod Wilson wrote: Looks sane to me, and really needs to get in ASAP. I'd even suggest we