Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

2014-03-05 Thread Seung-Woo Kim
Hello Sachin, On 2014년 03월 06일 12:28, Sachin Kamat wrote: > Hi Seung-Woo, > > On 6 March 2014 07:43, Seung-Woo Kim wrote: >> Hello Sachin, >> >> On 2014년 03월 05일 20:42, Sachin Kamat wrote: >>> On 5 March 2014 16:38, Seung-Woo Kim wrote: >> >> (...) >> - dev->bank1 = dev->bank1; >>> >

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

2014-03-05 Thread Sachin Kamat
Hi Seung-Woo, On 6 March 2014 07:43, Seung-Woo Kim wrote: > Hello Sachin, > > On 2014년 03월 05일 20:42, Sachin Kamat wrote: >> On 5 March 2014 16:38, Seung-Woo Kim wrote: > > (...) > >>> - dev->bank1 = dev->bank1; >> >> Are you sure this isn't some kind of typo? If not then your commit >> de

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

2014-03-05 Thread Seung-Woo Kim
Hello Sachin, On 2014년 03월 05일 20:42, Sachin Kamat wrote: > On 5 March 2014 16:38, Seung-Woo Kim wrote: (...) >> - dev->bank1 = dev->bank1; > > Are you sure this isn't some kind of typo? If not then your commit > description is too verbose > to actually say that the code is redundant and

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

2014-03-05 Thread Sachin Kamat
On 5 March 2014 16:38, Seung-Woo Kim wrote: > There was assignment of memory bank with dma address converted > from physical address. But allocation has been changed with dma > function, so the assignment is not necessary. > > Signed-off-by: Seung-Woo Kim > --- > change from v1 > - fixes subject

[PATCH] [media] s5-mfc: remove meaningless memory bank assignment

2014-03-05 Thread Seung-Woo Kim
There was assignment of memory bank with dma address converted from physical address. But allocation has been changed with dma function, so the assignment is not necessary. Signed-off-by: Seung-Woo Kim --- change from v1 - fixes subject and adds proper description --- drivers/media/platform/s5p-