Re: [PATCH] [media] sta2x11_vip: fix error return code in sta2x11_vip_init_one()

2013-05-13 Thread Federico Vaga
On Monday 13 May 2013 20:40:33 Wei Yongjun wrote: > On 05/13/2013 08:19 PM, Federico Vaga wrote: > > Hello, > > > > I agree with the content of the patch, but I disagree with the commit > > message.> > > >From the commit message it seems that you fixed a bug about the error > > >code, > > > > bu

Re: [PATCH] [media] sta2x11_vip: fix error return code in sta2x11_vip_init_one()

2013-05-13 Thread Wei Yongjun
On 05/13/2013 08:19 PM, Federico Vaga wrote: > Hello, > > I agree with the content of the patch, but I disagree with the commit > message. > >From the commit message it seems that you fixed a bug about the error code, > but the aim of this patch is to uniform the code style. I suggest something

Re: [PATCH] [media] sta2x11_vip: fix error return code in sta2x11_vip_init_one()

2013-05-13 Thread Federico Vaga
Hello, I agree with the content of the patch, but I disagree with the commit message. >From the commit message it seems that you fixed a bug about the error code, but the aim of this patch is to uniform the code style. I suggest something like: "uniform code style in sta2x11_vip_init_one()" On

[PATCH] [media] sta2x11_vip: fix error return code in sta2x11_vip_init_one()

2013-05-12 Thread Wei Yongjun
From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/media/pci/sta2x11/sta2x11_vip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/st