Re: [PATCH] [media] uvcvideo: Retry usb_submit_urb on -EPERM return

2013-05-07 Thread Laurent Pinchart
Hi Shawn, On Friday 03 May 2013 16:00:24 Shawn Nematbakhsh wrote: Hi Laurent, Thanks for the changes! I agree that your synchronization logic is correct. Just two small comments: On Mon, Apr 29, 2013 at 1:34 PM, Laurent Pinchart wrote: On Tuesday 23 April 2013 17:42:32 Shawn Nematbakhsh

Re: [PATCH] [media] uvcvideo: Retry usb_submit_urb on -EPERM return

2013-05-03 Thread Shawn Nematbakhsh
Hi Laurent, Thanks for the changes! I agree that your synchronization logic is correct. Just two small comments: On Mon, Apr 29, 2013 at 1:34 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Shawn, Thank you for the patch. On Tuesday 23 April 2013 17:42:32 Shawn Nematbakhsh

Re: [PATCH] [media] uvcvideo: Retry usb_submit_urb on -EPERM return

2013-04-29 Thread Laurent Pinchart
Hi Shawn, Thank you for the patch. On Tuesday 23 April 2013 17:42:32 Shawn Nematbakhsh wrote: While usb_kill_urb is in progress, calls to usb_submit_urb will fail with -EPERM (documented in Documentation/usb/URB.txt). The UVC driver does not correctly handle this case -- there is no

[PATCH] [media] uvcvideo: Retry usb_submit_urb on -EPERM return

2013-04-23 Thread Shawn Nematbakhsh
From: Shawn Nematbakhsh sha...@chromium.org While usb_kill_urb is in progress, calls to usb_submit_urb will fail with -EPERM (documented in Documentation/usb/URB.txt). The UVC driver does not correctly handle this case -- there is no synchronization between uvc_v4l2_open / uvc_status_start and

[PATCH] [media] uvcvideo: Retry usb_submit_urb on -EPERM return

2013-04-23 Thread Shawn Nematbakhsh
While usb_kill_urb is in progress, calls to usb_submit_urb will fail with -EPERM (documented in Documentation/usb/URB.txt). The UVC driver does not correctly handle this case -- there is no synchronization between uvc_v4l2_open / uvc_status_start and uvc_v4l2_release / uvc_status_stop. This patch