Re: [PATCH] [media] v4l2-async: Always unregister the subdev on failure

2016-08-24 Thread Alban Bedel
On Fri, 1 Jul 2016 13:55:44 +0200 Hans Verkuil wrote: > On 05/11/2016 06:32 PM, Alban Bedel wrote: > > On Wed, 11 May 2016 12:22:44 -0400 > > Javier Martinez Canillas wrote: > > > >> Hello Alban, > >> > >> On 05/11/2016 11:40 AM, Alban Bedel wrote: > >>> In v4l2_async_test_notify() if the r

Re: [PATCH] [media] v4l2-async: Always unregister the subdev on failure

2016-07-01 Thread Hans Verkuil
On 05/11/2016 06:32 PM, Alban Bedel wrote: > On Wed, 11 May 2016 12:22:44 -0400 > Javier Martinez Canillas wrote: > >> Hello Alban, >> >> On 05/11/2016 11:40 AM, Alban Bedel wrote: >>> In v4l2_async_test_notify() if the registered_async callback or the >>> complete notifier returns an error the s

Re: [PATCH] [media] v4l2-async: Always unregister the subdev on failure

2016-05-11 Thread Alban Bedel
On Wed, 11 May 2016 12:22:44 -0400 Javier Martinez Canillas wrote: > Hello Alban, > > On 05/11/2016 11:40 AM, Alban Bedel wrote: > > In v4l2_async_test_notify() if the registered_async callback or the > > complete notifier returns an error the subdev is not unregistered. > > This leave paths whe

Re: [PATCH] [media] v4l2-async: Always unregister the subdev on failure

2016-05-11 Thread Javier Martinez Canillas
Hello Alban, On 05/11/2016 11:40 AM, Alban Bedel wrote: > In v4l2_async_test_notify() if the registered_async callback or the > complete notifier returns an error the subdev is not unregistered. > This leave paths where v4l2_async_register_subdev() can fail but > leave the subdev still registered.

[PATCH] [media] v4l2-async: Always unregister the subdev on failure

2016-05-11 Thread Alban Bedel
In v4l2_async_test_notify() if the registered_async callback or the complete notifier returns an error the subdev is not unregistered. This leave paths where v4l2_async_register_subdev() can fail but leave the subdev still registered. Add the required calls to v4l2_device_unregister_subdev() to pl