Re: [PATCH] FE_GET_PROPERTY should be _IOW, because the associated structure is transferred from userspace to kernelspace. Keep the old ioctl around for compatibility so that existing code is not brok

2011-06-03 Thread Andreas Oberritter
On 06/01/2011 11:15 PM, Mauro Carvalho Chehab wrote: The dvb_usercopy will do the right thing, if we use _IOR or _IORW. It only works, because _IOC_READ triggers a copy_from_user, as a workaround for wrongly marked ioctls like this, according to a code comment. It does not really do the right

Re: [PATCH] FE_GET_PROPERTY should be _IOW, because the associated structure is transferred from userspace to kernelspace. Keep the old ioctl around for compatibility so that existing code is not brok

2011-06-03 Thread Mauro Carvalho Chehab
Em 03-06-2011 09:44, Andreas Oberritter escreveu: On 06/01/2011 11:15 PM, Mauro Carvalho Chehab wrote: The dvb_usercopy will do the right thing, if we use _IOR or _IORW. It only works, because _IOC_READ triggers a copy_from_user, as a workaround for wrongly marked ioctls like this, according

Re: [PATCH] FE_GET_PROPERTY should be _IOW, because the associated structure is transferred from userspace to kernelspace. Keep the old ioctl around for compatibility so that existing code is not brok

2011-06-01 Thread Mauro Carvalho Chehab
Em 23-05-2011 12:32, Andreas Oberritter escreveu: On 05/23/2011 04:51 PM, Hans Petter Selasky wrote: On Monday 23 May 2011 16:37:18 Andreas Oberritter wrote: On 05/23/2011 03:58 PM, Hans Petter Selasky wrote: From be7d0f72ebf4d945cfb2a5c9cc871707f72e1e3c Mon Sep 17 00:00:00 2001 From: Hans

Re: [PATCH] FE_GET_PROPERTY should be _IOW, because the associated structure is transferred from userspace to kernelspace. Keep the old ioctl around for compatibility so that existing code is not brok

2011-05-23 Thread Andreas Oberritter
On 05/23/2011 03:58 PM, Hans Petter Selasky wrote: From be7d0f72ebf4d945cfb2a5c9cc871707f72e1e3c Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky hsela...@c2i.net Date: Mon, 23 May 2011 15:56:31 +0200 Subject: [PATCH] FE_GET_PROPERTY should be _IOW, because the associated structure is

Re: [PATCH] FE_GET_PROPERTY should be _IOW, because the associated structure is transferred from userspace to kernelspace. Keep the old ioctl around for compatibility so that existing code is not brok

2011-05-23 Thread Hans Petter Selasky
On Monday 23 May 2011 16:37:18 Andreas Oberritter wrote: On 05/23/2011 03:58 PM, Hans Petter Selasky wrote: From be7d0f72ebf4d945cfb2a5c9cc871707f72e1e3c Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky hsela...@c2i.net Date: Mon, 23 May 2011 15:56:31 +0200 Subject: [PATCH]

Re: [PATCH] FE_GET_PROPERTY should be _IOW, because the associated structure is transferred from userspace to kernelspace. Keep the old ioctl around for compatibility so that existing code is not brok

2011-05-23 Thread Andreas Oberritter
On 05/23/2011 04:51 PM, Hans Petter Selasky wrote: On Monday 23 May 2011 16:37:18 Andreas Oberritter wrote: On 05/23/2011 03:58 PM, Hans Petter Selasky wrote: From be7d0f72ebf4d945cfb2a5c9cc871707f72e1e3c Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky hsela...@c2i.net Date: Mon, 23 May