[PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-23 Thread Ralf Baechle
A build with ISA && ISA_DMA && !ISA_DMA_API results in: CC sound/isa/es18xx.o sound/isa/es18xx.c: In function ‘snd_es18xx_playback1_prepare’: sound/isa/es18xx.c:501:9: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration] sound/isa/es18xx.c: In f

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Takashi Iwai
At Thu, 23 Jun 2011 15:47:50 +0100, Ralf Baechle wrote: > > A build with ISA && ISA_DMA && !ISA_DMA_API results in: > > CC sound/isa/es18xx.o > sound/isa/es18xx.c: In function ‘snd_es18xx_playback1_prepare’: > sound/isa/es18xx.c:501:9: error: implicit declaration of function > ‘snd_dma_pr

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Ralf Baechle
On Fri, Jun 24, 2011 at 10:26:13AM +0200, Takashi Iwai wrote: > Hrm... I still don't understand why ES18XX or others were selected at > the first place. Isn't it covered by the conditional in > sound/isa/Kconfig like below? > > >

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Mauro Carvalho Chehab
Em 24-06-2011 08:16, Ralf Baechle escreveu: > On Fri, Jun 24, 2011 at 10:26:13AM +0200, Takashi Iwai wrote: > >> Hrm... I still don't understand why ES18XX or others were selected at >> the first place. Isn't it covered by the conditional in >> sound/isa/Kconfig like below? >> >> ===

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Ralf Baechle
On Fri, Jun 24, 2011 at 08:35:22AM -0300, Mauro Carvalho Chehab wrote: > Em 24-06-2011 08:16, Ralf Baechle escreveu: > > tristate "miroSOUND PCM20 radio" > > depends on ISA && VIDEO_V4L2 && SND > > select SND_ISA > > select SND_MIRO > > > > So SND_ISA gets forced o

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Takashi Iwai
At Fri, 24 Jun 2011 12:16:08 +0100, Ralf Baechle wrote: > > On Fri, Jun 24, 2011 at 10:26:13AM +0200, Takashi Iwai wrote: > > > Hrm... I still don't understand why ES18XX or others were selected at > > the first place. Isn't it covered by the conditional in > > sound/isa/Kconfig like below? > >

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Ralf Baechle
On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote: > > o The drivers/media/radio/Kconfig part should be applied for 3.0 and > >maybe -stable. > > Yes, this will be good. I just tested that segment only and it works as expected. Will repost in a minute. > > o The sound/isa/Kcon

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Takashi Iwai
At Fri, 24 Jun 2011 14:08:18 +0100, Ralf Baechle wrote: > > On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote: > > > > o The drivers/media/radio/Kconfig part should be applied for 3.0 and > > >maybe -stable. > > > > Yes, this will be good. > > I just tested that segment only and

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Arnd Bergmann
On Thursday 23 June 2011 16:47:50 Ralf Baechle wrote: > Fixed by adding an explicit dependency on ISA_DMA_API for all of the > config statment that either result in the direction inclusion of code that > calls the ISA DMA API or selects something which in turn would use the ISA > DMA API. > > The

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Ralf Baechle
On Fri, Jun 24, 2011 at 03:19:44PM +0200, Arnd Bergmann wrote: > > The sole ISA sound driver that does not use the ISA DMA API is the Adlib > > driver so replaced the dependency of SND_ISA on ISA_DMA_API and add it to > > each of the drivers individually. > > Do we really care all that much about