Re: [PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Malcolm Priestley
Hi Devin On 31/08/15 19:07, Devin Heitmueller wrote: Hi Malcolm, The capabilities call interacting with the oneshot setting is rather weird and maybe unexpected. No, because in normal mode it can do auto inversion. ... If the goal was for the software-emulated auto inversion to be trans

Re: [PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Devin Heitmueller
Hi Malcolm, >> The capabilities call interacting with the oneshot setting is rather weird >> and maybe unexpected. >> >> > > No, because in normal mode it can do auto inversion. This isn't my area of expertise, but I suspect this is going to cause some pretty confusing behavior. Generally speaki

Re: [PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Malcolm Priestley
On 31/08/15 18:03, Johann Klammer wrote: Why not just remove the line? info->caps |= FE_CAN_INVERSION_AUTO; The capabilities call interacting with the oneshot setting is rather weird and maybe unexpected. No, because in normal mode it can do auto inversion. -- To unsubscribe from

Re: [PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Johann Klammer
Why not just remove the line? info->caps |= FE_CAN_INVERSION_AUTO; The capabilities call interacting with the oneshot setting is rather weird and maybe unexpected. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kerne

[PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Malcolm Priestley
When in FE_TUNE_MODE_ONESHOT the frontend must report the actual capabilities so user can take appropriate action. With frontends that can't do auto inversion this is done by dvb-core automatically so CAN_INVERSION_AUTO is valid. However, when in FE_TUNE_MODE_ONESHOT this is not true. So only se