Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-22 Thread Guennadi Liakhovetski
On Wed, 22 Feb 2012, javier Martin wrote: > >>> @@ -1087,6 +1298,18 @@ static int mx2_camera_set_fmt(struct > >>> soc_camera_device *icd, > >>>       if (ret < 0 && ret != -ENOIOCTLCMD) > >>>               return ret; > >>> > >>> +     /* Store width and height returned by the sensor for resizing

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-22 Thread javier Martin
>>> @@ -1087,6 +1298,18 @@ static int mx2_camera_set_fmt(struct >>> soc_camera_device *icd, >>>       if (ret < 0 && ret != -ENOIOCTLCMD) >>>               return ret; >>> >>> +     /* Store width and height returned by the sensor for resizing */ >>> +     pcdev->s_width = mf.width; >>> +     pcde

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread javier Martin
On 21 February 2012 10:24, Guennadi Liakhovetski wrote: > On Tue, 21 Feb 2012, javier Martin wrote: > >> On 21 February 2012 09:39, Guennadi Liakhovetski >> wrote: >> > Hi Javier >> > >> > One more thing occurred to me: I don't see anywhere in your patch checking >> > for supported pixel (fourcc

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread Guennadi Liakhovetski
On Tue, 21 Feb 2012, javier Martin wrote: > On 21 February 2012 09:39, Guennadi Liakhovetski > wrote: > > Hi Javier > > > > One more thing occurred to me: I don't see anywhere in your patch checking > > for supported pixel (fourcc) formats. I don't think the PRP can resize > > arbitrary formats?

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread javier Martin
On 21 February 2012 09:39, Guennadi Liakhovetski wrote: > Hi Javier > > One more thing occurred to me: I don't see anywhere in your patch checking > for supported pixel (fourcc) formats. I don't think the PRP can resize > arbitrary formats? Most likely these would be limited to some YUV, and, > po

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread Guennadi Liakhovetski
Hi Javier One more thing occurred to me: I don't see anywhere in your patch checking for supported pixel (fourcc) formats. I don't think the PRP can resize arbitrary formats? Most likely these would be limited to some YUV, and, possibly, some RGB formats? Thanks Guennadi On Tue, 21 Feb 2012,

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread javier Martin
Hi Guennadi, thank you for your review. On 20 February 2012 15:13, Guennadi Liakhovetski wrote: >> @@ -707,6 +732,74 @@ static void mx27_camera_emma_buf_init(struct >> soc_camera_device *icd, >>       writel(prp->cfg.irq_flags, pcdev->base_emma + PRP_INTR_CNTL); >>  } >> >> +static void mx2_prp_

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-20 Thread Guennadi Liakhovetski
On Tue, 14 Feb 2012, Javier Martin wrote: > If the attached video sensor cannot provide the > requested image size, try to use resizing engine > included in the eMMa-PrP IP. > > This patch supports both averaging and bilinear > algorithms. > > Signed-off-by: Javier Martin > --- > drivers/media

[PATCH] media: i.MX27 camera: Add resizing support.

2012-02-14 Thread Javier Martin
If the attached video sensor cannot provide the requested image size, try to use resizing engine included in the eMMa-PrP IP. This patch supports both averaging and bilinear algorithms. Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 251