Re: [PATCH] media: initial driver for ov5642 CMOS sensor

2011-07-06 Thread Guennadi Liakhovetski
Hi Angela On Tue, 5 Jul 2011, Angela Wan wrote: > Hi, Guennadi > The solution you said is right. We could use parameters to > distinguish different power managerment, gain, etc. > So ov5642_default_regs_init and ov5642_default_regs_finalise in the > patch could be removed in the final versio

Re: [PATCH] media: initial driver for ov5642 CMOS sensor

2011-07-05 Thread Angela Wan
Hi, Guennadi The solution you said is right. We could use parameters to distinguish different power managerment, gain, etc. So ov5642_default_regs_init and ov5642_default_regs_finalise in the patch could be removed in the final version, right? Since it's not common for all boards. What I think

Re: [PATCH] media: initial driver for ov5642 CMOS sensor

2011-07-04 Thread Guennadi Liakhovetski
Hi Angela On Sun, 3 Jul 2011, angela wan wrote: > Hi, Bastian, > >Could the setting in ov5642.c like ov5642_default_regs_init and > ov5642_default_regs_finalise adapt to different board? From my experience, > ov5642 may have difference settings for differnt boards. So could we put the > sett

Re: [PATCH] media: initial driver for ov5642 CMOS sensor

2011-07-03 Thread Angela Wan
> > Hi, Bastian, > >    Could the setting in ov5642.c like ov5642_default_regs_init and > ov5642_default_regs_finalise adapt to different board? From my experience, > ov5642 may have difference settings for differnt boards. So could we put the > setting in another file instead of in the common d

Re: [PATCH] media: initial driver for ov5642 CMOS sensor

2011-06-28 Thread Bastian Hecht
2011/6/27 Laurent Pinchart : > Hi Bastian, > > Thanks for the patch. > > On Friday 24 June 2011 12:57:36 Bastian Hecht wrote: >> This is an initial driver release for the Omnivision 5642 CMOS sensor. >> >> Signed-off-by: Bastian Hecht >> --- >> >> diff --git a/drivers/media/video/ov5642.c b/driver

Re: [PATCH] media: initial driver for ov5642 CMOS sensor

2011-06-27 Thread Laurent Pinchart
Hi Bastian, Thanks for the patch. On Friday 24 June 2011 12:57:36 Bastian Hecht wrote: > This is an initial driver release for the Omnivision 5642 CMOS sensor. > > Signed-off-by: Bastian Hecht > --- > > diff --git a/drivers/media/video/ov5642.c b/drivers/media/video/ov5642.c > new file mode 10

[PATCH] media: initial driver for ov5642 CMOS sensor

2011-06-24 Thread Bastian Hecht
This is an initial driver release for the Omnivision 5642 CMOS sensor. Signed-off-by: Bastian Hecht --- diff --git a/drivers/media/video/ov5642.c b/drivers/media/video/ov5642.c new file mode 100644 index 000..3cdae97 --- /dev/null +++ b/drivers/media/video/ov5642.c @@ -0,0 +1,1011 @@ +/* + *