Re: [PATCH] media: stk1160: Avoid stack-allocated buffer for control URBs

2014-04-15 Thread Alan Stern
On Mon, 14 Apr 2014, Ezequiel Garcia wrote: On Apr 14, Alan Stern wrote: On Mon, 14 Apr 2014, Ezequiel Garcia wrote: Currently stk1160_read_reg() uses a stack-allocated char to get the read control value. This is wrong because usb_control_msg() requires a kmalloc-ed buffer, and a

[PATCH] media: stk1160: Avoid stack-allocated buffer for control URBs

2014-04-14 Thread Ezequiel Garcia
Currently stk1160_read_reg() uses a stack-allocated char to get the read control value. This is wrong because usb_control_msg() requires a kmalloc-ed buffer, and a DMA-API warning is produced: WARNING: CPU: 0 PID: 1376 at lib/dma-debug.c:1153 check_for_stack+0xa0/0x100() ehci-pci :00:0a.0:

Re: [PATCH] media: stk1160: Avoid stack-allocated buffer for control URBs

2014-04-14 Thread Sander Eikelenboom
Monday, April 14, 2014, 6:41:05 PM, you wrote: Currently stk1160_read_reg() uses a stack-allocated char to get the read control value. This is wrong because usb_control_msg() requires a kmalloc-ed buffer, and a DMA-API warning is produced: WARNING: CPU: 0 PID: 1376 at lib/dma-debug.c:1153

Re: [PATCH] media: stk1160: Avoid stack-allocated buffer for control URBs

2014-04-14 Thread Alan Stern
On Mon, 14 Apr 2014, Ezequiel Garcia wrote: Currently stk1160_read_reg() uses a stack-allocated char to get the read control value. This is wrong because usb_control_msg() requires a kmalloc-ed buffer, and a DMA-API warning is produced: WARNING: CPU: 0 PID: 1376 at lib/dma-debug.c:1153

Re: [PATCH] media: stk1160: Avoid stack-allocated buffer for control URBs

2014-04-14 Thread Ezequiel Garcia
On Apr 14, Alan Stern wrote: On Mon, 14 Apr 2014, Ezequiel Garcia wrote: Currently stk1160_read_reg() uses a stack-allocated char to get the read control value. This is wrong because usb_control_msg() requires a kmalloc-ed buffer, and a DMA-API warning is produced: WARNING: CPU: 0