Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca in firedtv-avc.c

2015-02-08 Thread Stefan Richter
On Feb 08 nick wrote: > On 2015-02-08 06:55 PM, Stefan Richter wrote: > > I still am missing research on the question whether or not the Common > > Interface serving part of the driver needs to send Host2CA commands. If > > yes, we implement it and use the function. If not, we remove the > > func

Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca in firedtv-avc.c

2015-02-08 Thread Stefan Richter
On Feb 08 Nicholas Krause wrote: > Removes the unneeded function defintion,avc_tuner_host2ca in the file, > firedtv-avc. This > function should have been removed during the refactoring of the firetv code > base during > commit id,154907957f939 due to us removing unneeded definitions of functions

Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca

2015-02-08 Thread Stefan Richter
On Feb 08 Nicholas Krause wrote: > Removes the function,avc_tuner_host2ca and the ifdef marco statements > around this function as there are no more callers of this function > and therefor no need for it's definition anymore. > > Signed-off-by: Nicholas Krause Your changelog is incorrect. If yo