Re: [PATCH] ov10635: Add OmniVision ov10635 SoC camera driver

2013-06-03 Thread Hans Verkuil
On Mon June 3 2013 15:31:55 phil.edwor...@renesas.com wrote: > Hi Hans, > > > Subject: Re: [PATCH] ov10635: Add OmniVision ov10635 SoC camera driver > > > > +#include > > > > Don't implement chip_ident or use this header: it's going to be > >

Re: [PATCH] ov10635: Add OmniVision ov10635 SoC camera driver

2013-06-03 Thread phil . edworthy
Hi Hans, > Subject: Re: [PATCH] ov10635: Add OmniVision ov10635 SoC camera driver > > +#include > > Don't implement chip_ident or use this header: it's going to be > removed in 3.11. > > +/* Set status of additional camera capabilities */ > > +st

Re: [PATCH] ov10635: Add OmniVision ov10635 SoC camera driver

2013-06-03 Thread Hans Verkuil
Hi Phil, Some quick review notes: On Mon June 3 2013 11:35:35 Phil Edworthy wrote: > Signed-off-by: Phil Edworthy > --- > drivers/media/i2c/soc_camera/Kconfig |6 + > drivers/media/i2c/soc_camera/Makefile |1 + > drivers/media/i2c/soc_camera/ov10635.c | 1169 > ++

[PATCH] ov10635: Add OmniVision ov10635 SoC camera driver

2013-06-03 Thread Phil Edworthy
Signed-off-by: Phil Edworthy --- drivers/media/i2c/soc_camera/Kconfig |6 + drivers/media/i2c/soc_camera/Makefile |1 + drivers/media/i2c/soc_camera/ov10635.c | 1169 include/media/v4l2-chip-ident.h|1 + 4 files changed, 1177 insertions(+)