Re: [PATCH] pwc: add support for webcam snapshot button (2)

2009-01-12 Thread Pham Thanh Nam
Hi all Maybe Linux Media team has not received my patch. I also CC'ed my former email to linux-media mailing list, but it has been filtered out by Linux Media mail server's policy for some reason, so I resend the patch. *** PATCH BEGINS FROM HERE *** This patch adds support for Philips webcam snaps

Re: [PATCH] pwc: add support for webcam snapshot button (2)

2009-01-11 Thread Pham Thanh Nam
Hi, Please review and consider to apply my patch, for following reasons: 1. Nobody complains anymore about it :) 2. Tested to guarantee working with 2 kinds of Logitech webcam. 3. It's quite clearly to see that event input support won't break anything existing (and you still have option to disable

Re: [PATCH] pwc: add support for webcam snapshot button

2009-01-08 Thread Mauro Carvalho Chehab
On Thu, 8 Jan 2009 12:31:48 +0700 "Nam Phạm Thành" wrote: > OK, resent. Hope it's OK now. Unfortunately, it is not 100% ok. See the comments bellow. You shouldn't add any comment before the patch (like the above). Otherwise, it will be committed by the scripts also, or I need to double check

[PATCH] pwc: add support for webcam snapshot button

2009-01-07 Thread Nam Phạm Thành
OK, resent. Hope it's OK now. This patch adds support for Philips webcam snapshot button as an event input device, for consistency with other webcam drivers. Signed-off-by: Pham Thanh Nam diff -uNr a/linux/drivers/media/video/pwc/pwc.h b/linux/drivers/media/video/pwc/pwc.h --- a/linux/drivers/med

Re: [PATCH] pwc: add support for webcam snapshot button

2009-01-07 Thread Mauro Carvalho Chehab
Hi Nam, On Thu, 8 Jan 2009 11:07:20 +0700 "Nam Phạm Thành" wrote: > Hi all, > I read somewhere that official support for pwc driver has been stopped :( > This patch adds support for Philips webcam snapshot button as an event input > device, for consistency with other webcam drivers (uvc, quickca