Re: [linux-media] Re: [PATCH] stb0899: fix the limits for signal strength values

2012-01-24 Thread Mauro Carvalho Chehab
Em 24-01-2012 07:33, Klaus Schmidinger escreveu: > On 23.01.2012 20:43, Mauro Carvalho Chehab wrote: >> Hi Klaus, >> >> The patch didn't apply. It seems to be due to your emailer that mangled the >> whitespaces. > > Sorry about that. Here it is again as an attachment. Thanks! >> The patch looks

Re: [linux-media] Re: [PATCH] stb0899: fix the limits for signal strength values

2012-01-24 Thread Klaus Schmidinger
n logic. Well, as long as there are no negative values for strength... However, I don't quite see why the range is 750 - 950 for DVB-S and 750 - 999 for DVB-S2. Shouldn't this be the same maximum value in both cases? Klaus [PATCH] stb0899: fix the limits for signal strength valu

Re: [PATCH] stb0899: fix the limits for signal strength values

2012-01-23 Thread Mauro Carvalho Chehab
h (state->delsys) { > case SYS_DVBS: PS.: Another alternative for it would be the enclosed patch, wich will be a little simpler, and will also preserve the slope on the boundary values, used at the stb0899_table_lookup() interpolation logic. Regards, Mauro - [PATCH] stb0899: fix

[PATCH] stb0899: fix the limits for signal strength values

2012-01-19 Thread Klaus Schmidinger
stb0899_read_signal_strength() adds an offset to the result of the table lookup. That offset must correspond to the lowest value in the lookup table, to make sure the result doesn't get below 0, which would mean a "very high" value since the parameter is unsigned. 'strength' and 'snr' need to be