Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-03 Thread Ezequiel Garcia
Hi Arvydas, On Sat, Nov 3, 2012 at 12:48 AM, Arvydas Sidorenko wrote: >> If you have the time to test it and stamp a "Tested-by" on it, I would >> appreciate it. >> >> Thanks, >> >> Ezequiel > > I applied and tested on 3.7.0-rc3 - everything is ok. Thanks! Ezequiel -- To unsubscribe fro

Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-02 Thread Arvydas Sidorenko
> If you have the time to test it and stamp a "Tested-by" on it, I would > appreciate it. > > Thanks, > > Ezequiel I applied and tested on 3.7.0-rc3 - everything is ok. Signed patch is bellow. Signed-off-by: Ezequiel Garcia Tested-by: Arvydas Sidorenko --- drivers/media/usb/stkwebcam/stk-

Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-02 Thread Ezequiel Garcia
Hi Arvydas, On Fri, Nov 2, 2012 at 4:35 AM, Arvydas Sidorenko wrote: >> why the heck do we need this first_init? > > first_init was introduced in 7b1c8f58fcdbed75 for turning off LED when > the cam finishes > the capture. > Andrea Anacleto claimed that the change > broke his webcam > on the same

Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-02 Thread Arvydas Sidorenko
> why the heck do we need this first_init? first_init was introduced in 7b1c8f58fcdbed75 for turning off LED when the cam finishes the capture. Andrea Anacleto claimed that the change broke his webcam on the same laptop, so he introduced that variable to fix the issue. It didn't have any impact t

[PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-01 Thread Ezequiel Garcia
The sparse warning is: "drivers/media/usb/stkwebcam/stk-webcam.c:59:5: warning: symbol 'first_init' was not declared. Should it be static?" Declare variable 'first_init' as static and local to the function. Found by Hans Verkuil's daily build. Tested by compilation only. Cc: Andrea Anacleto Cc: