Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Kieran Bingham
Hi Hans, Niklas, Sakari, Thank you for the very prompt reviews! I fired the patch - disappeared to teach code club, and came back to the answers :-D - very streamlined! On 08/01/18 15:48, Hans Verkuil wrote: > On 01/08/2018 04:32 PM, Niklas Söderlund wrote: >> Hi, >> >> Thanks for your patch.

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Hans Verkuil
On 01/08/2018 05:11 PM, Niklas Söderlund wrote: > On 2018-01-08 16:48:35 +0100, Hans Verkuil wrote: >> On 01/08/2018 04:32 PM, Niklas Söderlund wrote: >>> Hi, >>> >>> Thanks for your patch. >>> >>> On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: Hi Kieran, On Mon, Jan 08, 2018 at

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Niklas Söderlund
On 2018-01-08 16:48:35 +0100, Hans Verkuil wrote: > On 01/08/2018 04:32 PM, Niklas Söderlund wrote: > > Hi, > > > > Thanks for your patch. > > > > On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: > >> Hi Kieran, > >> > >> On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: > >>> The

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Hans Verkuil
On 01/08/2018 04:32 PM, Niklas Söderlund wrote: > Hi, > > Thanks for your patch. > > On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: >> Hi Kieran, >> >> On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: >>> The v4l2_mbus_fmt width and height corresponds directly with the >>>

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Niklas Söderlund
Hi, Thanks for your patch. On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: > Hi Kieran, > > On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: > > The v4l2_mbus_fmt width and height corresponds directly with the > > v4l2_pix_format definitions, yet the differences in

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Sakari Ailus
Hi Kieran, On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: > The v4l2_mbus_fmt width and height corresponds directly with the > v4l2_pix_format definitions, yet the differences in documentation make > it ambiguous what to do in the event of field heights. > > Clarify this by

[PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

2018-01-08 Thread Kieran Bingham
The v4l2_mbus_fmt width and height corresponds directly with the v4l2_pix_format definitions, yet the differences in documentation make it ambiguous what to do in the event of field heights. Clarify this by referencing the v4l2_pix_format which is explicit on the matter, and by matching the