Re: [PATCH] videobuf2-core: check for q->error in vb2_core_qbuf()

2018-07-18 Thread Hans Verkuil
On 18/07/18 12:06, Sakari Ailus wrote: > On Wed, Jul 18, 2018 at 11:29:01AM +0200, Hans Verkuil wrote: >> On 16/07/18 14:49, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Thu, Jul 05, 2018 at 10:25:19AM +0200, Hans Verkuil wrote: The vb2_core_qbuf() function didn't check if q->error was set. It

Re: [PATCH] videobuf2-core: check for q->error in vb2_core_qbuf()

2018-07-18 Thread Sakari Ailus
On Wed, Jul 18, 2018 at 11:29:01AM +0200, Hans Verkuil wrote: > On 16/07/18 14:49, Sakari Ailus wrote: > > Hi Hans, > > > > On Thu, Jul 05, 2018 at 10:25:19AM +0200, Hans Verkuil wrote: > >> The vb2_core_qbuf() function didn't check if q->error was set. It is > >> checked in > >> __buf_prepare(),

Re: [PATCH] videobuf2-core: check for q->error in vb2_core_qbuf()

2018-07-18 Thread Hans Verkuil
On 16/07/18 14:49, Sakari Ailus wrote: > Hi Hans, > > On Thu, Jul 05, 2018 at 10:25:19AM +0200, Hans Verkuil wrote: >> The vb2_core_qbuf() function didn't check if q->error was set. It is checked >> in >> __buf_prepare(), but that function isn't called if the buffer was already >> prepared before

Re: [PATCH] videobuf2-core: check for q->error in vb2_core_qbuf()

2018-07-16 Thread Sakari Ailus
Hi Hans, On Thu, Jul 05, 2018 at 10:25:19AM +0200, Hans Verkuil wrote: > The vb2_core_qbuf() function didn't check if q->error was set. It is checked > in > __buf_prepare(), but that function isn't called if the buffer was already > prepared before with VIDIOC_PREPARE_BUF. > > So check it at the

[PATCH] videobuf2-core: check for q->error in vb2_core_qbuf()

2018-07-05 Thread Hans Verkuil
The vb2_core_qbuf() function didn't check if q->error was set. It is checked in __buf_prepare(), but that function isn't called if the buffer was already prepared before with VIDIOC_PREPARE_BUF. So check it at the start of vb2_core_qbuf() as well. Signed-off-by: Hans Verkuil --- diff --git a/dri