Re: [PATCH] vivi: remove pointless video_nr++

2012-07-20 Thread Hans Verkuil
On Thu July 19 2012 23:15:42 Ezequiel Garcia wrote: On Thu, Jul 19, 2012 at 6:05 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On Thu, Jul 19, 2012 at 5:45 PM, Hans Verkuil hverk...@xs4all.nl wrote: Remove the pointless video_nr++. It doesn't do anything useful and it has the

[PATCH] vivi: remove pointless video_nr++

2012-07-19 Thread Hans Verkuil
Remove the pointless video_nr++. It doesn't do anything useful and it has the unexpected side-effect of changing the video_nr module option, so cat /sys/module/vivi/parameters/video_nr gives a different value back then what was specified with modprobe. Signed-off-by: Hans Verkuil

Re: [PATCH] vivi: remove pointless video_nr++

2012-07-19 Thread Ezequiel Garcia
On Thu, Jul 19, 2012 at 5:45 PM, Hans Verkuil hverk...@xs4all.nl wrote: Remove the pointless video_nr++. It doesn't do anything useful and it has the unexpected side-effect of changing the video_nr module option, so cat /sys/module/vivi/parameters/video_nr gives a different value back then

Re: [PATCH] vivi: remove pointless video_nr++

2012-07-19 Thread Ezequiel Garcia
On Thu, Jul 19, 2012 at 6:05 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On Thu, Jul 19, 2012 at 5:45 PM, Hans Verkuil hverk...@xs4all.nl wrote: Remove the pointless video_nr++. It doesn't do anything useful and it has the unexpected side-effect of changing the video_nr module option, so