Re: [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode.

2011-12-30 Thread Javier S. Pedro
(Fri, 02 Sep 2011 10:19:05 +0200) Thierry Reding: > So you are saying that the card was previously working for you, but > when you apply the xc2028 patches from my series on top the tuning is > off by 2.7 MHz? I observed the 2.75Mhz offset nearly a year ago [1], but since I got silence on this ML

Re: [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode.

2011-09-02 Thread Thierry Reding
* Andrew Goff wrote: > Hi Thierry, > > I have been having problems with the radio tuner in my leadtek 1800h > card. This card has the xc2028 tuner. Using fmtools i would get an > error message similar to - frequency out of range 0.0 - 0.0. > > After seeing you patches at the beginning of last mon

Re: [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode.

2011-09-01 Thread Mauro Carvalho Chehab
Em 01-09-2011 09:45, Andrew Goff escreveu: > Hi Thierry, > > I have been having problems with the radio tuner in my leadtek 1800h card. > This card has the xc2028 tuner. Using fmtools i would get an error message > similar to - frequency out of range 0.0 - 0.0. This is due to a bug at the tuner

Re: [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode.

2011-09-01 Thread Andrew Goff
Hi Thierry, I have been having problems with the radio tuner in my leadtek 1800h card. This card has the xc2028 tuner. Using fmtools i would get an error message similar to - frequency out of range 0.0 - 0.0. After seeing you patches at the beginning of last month I installed the recent driv

Re: [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode.

2011-08-31 Thread Thierry Reding
* Mauro Carvalho Chehab wrote: > Em 04-08-2011 04:14, Thierry Reding escreveu: > > In radio mode, no frequency offset is needed. While at it, split off the > > frequency offset computation for digital TV into a separate function. > > Nah, it is better to keep the offset calculation there. there is

Re: [PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode.

2011-08-31 Thread Mauro Carvalho Chehab
Em 04-08-2011 04:14, Thierry Reding escreveu: > In radio mode, no frequency offset is needed. While at it, split off the > frequency offset computation for digital TV into a separate function. Nah, it is better to keep the offset calculation there. there is already a set_freq for DVB. breaking the

[PATCH 02/21] [media] tuner/xc2028: Fix frequency offset for radio mode.

2011-08-04 Thread Thierry Reding
In radio mode, no frequency offset is needed. While at it, split off the frequency offset computation for digital TV into a separate function. --- drivers/media/common/tuners/tuner-xc2028.c | 137 +++- 1 files changed, 75 insertions(+), 62 deletions(-) diff --git a/driver