Re: [PATCH 04/11] mm: compaction: export some of the functions

2011-12-12 Thread Arnd Bergmann
On Monday 12 December 2011, Mel Gorman wrote: > The bloat exists either way. I don't believe the linker strips it out so > overall it would make more sense to depend on compaction to keep the > vmstat counters for debugging reasons if nothing else. It's not > something I feel very strongly about th

Re: [PATCH 04/11] mm: compaction: export some of the functions

2011-12-12 Thread Michal Nazarewicz
On Mon, 12 Dec 2011 15:29:07 +0100, Mel Gorman wrote: Overall, this patch implies that CMA is always compiled in. On Mon, Dec 12, 2011 at 03:41:04PM +0100, Michal Nazarewicz wrote: Not really. But yes, it produces some bloat when neither CMA nor compaction are compiled. I assume that linke

Re: [PATCH 04/11] mm: compaction: export some of the functions

2011-12-12 Thread Mel Gorman
On Mon, Dec 12, 2011 at 03:41:04PM +0100, Michal Nazarewicz wrote: > On Mon, 12 Dec 2011 15:29:07 +0100, Mel Gorman wrote: > > >On Fri, Nov 18, 2011 at 05:43:11PM +0100, Marek Szyprowski wrote: > >>From: Michal Nazarewicz > >> > >>This commit exports some of the functions from compaction.c file

Re: [PATCH 04/11] mm: compaction: export some of the functions

2011-12-12 Thread Michal Nazarewicz
On Mon, 12 Dec 2011 15:29:07 +0100, Mel Gorman wrote: On Fri, Nov 18, 2011 at 05:43:11PM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz This commit exports some of the functions from compaction.c file outside of it adding their declaration into internal.h header file so that other mm

Re: [PATCH 04/11] mm: compaction: export some of the functions

2011-12-12 Thread Mel Gorman
On Fri, Nov 18, 2011 at 05:43:11PM +0100, Marek Szyprowski wrote: > From: Michal Nazarewicz > > This commit exports some of the functions from compaction.c file > outside of it adding their declaration into internal.h header > file so that other mm related code can use them. > > This forced comp

[PATCH 04/11] mm: compaction: export some of the functions

2011-11-18 Thread Marek Szyprowski
From: Michal Nazarewicz This commit exports some of the functions from compaction.c file outside of it adding their declaration into internal.h header file so that other mm related code can use them. This forced compaction.c to always be compiled (as opposed to being compiled only if CONFIG_COMP